| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
chromedriver_unittests is a duplicate target that will eventually replace chromedriver2_unittests.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/119753011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242899 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is beneficial since there are occasional false positives, so it is nicer not to trigger them when you are just touching a file that contains them.
BUG=none
Review URL: https://codereview.chromium.org/123203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
PRESUBMIT.py _CheckForString16().
R=brettw@chromium.org, maruel@chromium.org
TBR=sky@chromium.org, tsepez@chromium.org
BUG=329295
Review URL: https://codereview.chromium.org/93903011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=joi@chromium.org
BUG=329295
NOTRY=true
Review URL: https://codereview.chromium.org/119933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The reasons for the move are:
- it's actually a blink embedder, so it can't use blink/wtf types
- it can't use base either
- we want to replace CppBoundClass with gin::Wrappable, not possible in blink
In the first step, this is mostly a 1:1 copy (except for include paths).
Follow-up CLs will move the test plugin and layout tests helpers and
clean up the coding style
BUG=324658
R=abarth@chromium.org, maruel@chromium.org, torne@chromium.org, jam@chromium.org
TBR=torne@chromium.org
Review URL: https://codereview.chromium.org/110533009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=joi@chromium.org
BUG=329295
NOTRY=true
Review URL: https://codereview.chromium.org/119763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=joi@chromium.org
BUG=329295
NOTRY=true
Review URL: https://codereview.chromium.org/119523003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
directories.
TBR=joi@chromium.org
BUG=329295
NOTRY=true
Review URL: https://codereview.chromium.org/112463007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was inadvertently added in https://chromiumcodereview.appspot.com/116673003/ when the win7_aura builder had already been removed.
BUG=278554
TBR=maruel@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/118963002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a reland of https://codereview.chromium.org/58803002 which was reverted in https://codereview.chromium.org/64473002. It has been updated to reflect the latest projects.py changes.
BUG=278554
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/116673003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
for future Finch integration.
In order to do tests and a safe, controlled roll-out of Chrome's new profile management, we're going to enable it using a Finch experiment. The current tests of the existing command-line flags all need to be routed through common functions in order to override these settings if a Finch experiment is set.
Affected flags are:
--new-profile-management
--enable-inline-signin
--google-profile-info
Note that there existed a function to test for NewProfileManagement but it was not in a good place for general testing and definitely not for other flags so it has been extracted as well.
BUG=324046
Review URL: https://codereview.chromium.org/108803007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
BUG=329295
NOTRY=true
Review URL: https://codereview.chromium.org/114603007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
BUG=329295
NOTRY=true
Review URL: https://codereview.chromium.org/102073009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
BUG=329295
TEST=PRESUBMIT_test.py
NOTRY=true
Review URL: https://codereview.chromium.org/98143005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also excluded remoting/host from the _checkSpamLogging PRESUBMIT check.
BUG=
TBR=joi@chromium.org
Review URL: https://codereview.chromium.org/103053006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241100 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes all uses of blink::WebGraphicsContext3D as the context type
from ui/compositor/ and dependent code, excluding some test harness setup.
The compositor implementation uses gpu::gles2::GLES2Interface*, defined in
gpu/command_buffer/client/, as the context type to avoid dependencies on
the blink repository.
BUG=181120
Review URL: https://codereview.chromium.org/107513008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=320711
Review URL: https://codereview.chromium.org/110773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> [breakpad] remove dependency on content_switches.cc
>
> https://codereview.chromium.org/104593008/
R=noms@chromium.org
TBR=joi@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/110113002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reason for revert: Failed on the waterfall ([ FAILED ] nacl_newlib.run_breakpad_crash_in_syscall_test (250 ms). This error also happened on the trybot.
TBR=scottmg@chromium.org,joi@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/101623005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239219 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=joi@chromium.org, scottmg@chromium.org
BUG=none
Review URL: https://codereview.chromium.org/104593008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These types are all scoped locks and should never be in an anonymous
variable. A presubmit check is not watertight, but should go a long way
towards avoiding this class of bugs.
I ran this check over Chromium and there were no false positives in the
codebase.
This CL is meant as an alternative to the macro and extra parentheses
approach described in https://codereview.chromium.org/71713004/
BUG=none
Review URL: https://codereview.chromium.org/100743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238618 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If multi-install Chrome Frame is present when a multi-install install or
update is processed, CF is uninstalled prior to ordinary processing. The
binaries will be removed if they are not in use. Otherwise, they will
stick around until the next update for which they are not in use.
BUG=316496
R=robertshield@chromium.org
Review URL: https://codereview.chromium.org/96193003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
The printf in that file is legitimate, so it shouldn't
trigger the warning.
BUG=none
NOTRY=true
Review URL: https://codereview.chromium.org/103133002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is
generally undefined on Mac, but as of r223369, it is incorrect in Chrome on
Mac.
To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not
used with close, and that IGNORE_EINTR is only used with close. Unnecessary
#includes of eintr_wrapper.h are also removed.
base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc
contain non-mechanical changes. Variable naming within the latter is updated
per r178174. Missing #includes for <errno.h> in
content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were
manually added. Mechanical changes were generated by running:
sed -E -i '' \
-e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \
-e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \
-e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \
$(git grep -El 'HANDLE_EINTR.*close')
sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \
$(grep -EL '(HANDLE|IGNORE)_EINTR' \
$(git grep -El '#include.*eintr_wrapper\.h"'))
BUG=269623
R=agl@chromium.org, jln@chromium.org
TBR=OWNERS
Review URL: https://codereview.chromium.org/100253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/99653004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=324225
R=joi@chromium.org, marja@chromium.org
Review URL: https://codereview.chromium.org/98543004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
build/common.gypi now has the default set to 0, avoid using 1 or
introducing more uses of manual setting to 0. Only checks the
diff, not the full file, so shouldn't be annoying.
R=maruel@chromium.org
BUG=123026
Review URL: https://codereview.chromium.org/93543002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was missed in https://codereview.chromium.org/79173008/ (or
really in the original implementation of these checks for cc/).
R=ben@chromium.org, thakis
BUG=none
Review URL: https://codereview.chromium.org/88483004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Restrict the printf check to stdout / stderr
2. sandbox/linux uses printf and fprintf for good reason in a few places.
None of these would ever spam Chrome's stderr.
- Tests inside sandbox/linux have to run within their own small test
framework (so that they can run each in their own process). In this
framework, fprintf(stderr, XX) can be used to fail a test.
- The setuid sandbox is its own command line executable. It uses fprintf.
- A small number of tests (2), use fprintf to report kernel status while
running the test. It's extremely useful.
- The code generator in the BPF compiler was developped without base/
originally. It uses fprintf in a debug mode to print the assembled
program. This will only trigger on the equivalent of "compilation errors".
R=maruel@chromium.org, thakis@chromium.org
Review URL: https://codereview.chromium.org/89073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
R=joi@chromium.org
Review URL: https://codereview.chromium.org/87223002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the presubmit check. This won't spam the chrome output because the chromoting host code doesn't run in the chrome processes.
BUG=
Review URL: https://codereview.chromium.org/86523005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237431 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
See thread "[chromium-dev] Say no to excessive debug logging"
BUG=none
Review URL: https://codereview.chromium.org/79173008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236715 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
UNIT_TEST_MODE was being flagged as use of UNIT_TEST on a cc file.
NOTRY=true
R=joi@chromium.org
BUG=
Review URL: https://codereview.chromium.org/60573010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235987 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Improve the implementation so it's easy to add other such directories if/when needed.
BUG=none
Review URL: https://codereview.chromium.org/72763002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235179 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
away.
BUG=316199
R=joi@chromium.org, phajdan.jr@chromium.org, stip@chromium.org
Review URL: https://codereview.chromium.org/62213006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This broke git cl try
> Sync PRESUBMIT.py with what is run on CQ.
>
> This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the
> New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/.
>
> BUG=278554
> R=maruel@chromium.org
>
> Review URL: https://codereview.chromium.org/58803002
TBR=stip@chromium.org
Review URL: https://codereview.chromium.org/64473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the
New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/.
BUG=278554
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/58803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233509 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also split up breakpad component in more subdirectories and tighten up DEPS
rules
BUG=247431
R=rsesek@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/31243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
BUG=304877
Review URL: https://codereview.chromium.org/27751002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229252 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247431
R=joi@chromium.org, rsesek@chromium.org, thakis@chromium.org
TBR=mark@chromium.org
Review URL: https://codereview.chromium.org/26856002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Without this change, xxx_unittest_win.cc would cause an erroneous presubmit error by including xxx_win.h as its first 'special' include.
BUG=None
Review URL: https://codereview.chromium.org/26486003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since the full chromeos builders are sensitive to high level gypi
changes, make sure to do full tryjobs on them in addition to the faster
linux_chromeos bots when gyp files change.
BUG=none
R=maruel@chromium.org, phajdan.jr@chromium.org
Review URL: https://codereview.chromium.org/24366005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These files need to be included out-of-order.
BUG=NONE
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/24177004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224367 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=maruel@chromium.org
Review URL: https://chromiumcodereview.appspot.com/22338004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=180021
R=marja@chromium.org
TBR=joi@chromium.org,ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23316003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following GPU source files contain JSON data with long lines,
causing them to fail presubmit checks:
gpu/config/gpu_driver_bug_list_json.cc
gpu/config/gpu_switching_list_json.cc
gpu/config/software_rendering_list_json.cc
This patch adds them to the presubmit exclusion list so that changes to
these files may still be landed using the commit queue.
Review URL: https://chromiumcodereview.appspot.com/22891010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/19741006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes the trailing slash doesn't exist on the DEPS on grit, but we
were expecting it.
BUG=None
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/20770002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=jschuh,iannucci
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/19781004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It ain't flaky anymore cause it's fails consistently now.
TBR=iannucci@chromium.org
BUG=245262
Review URL: https://codereview.chromium.org/19873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212699 0039d316-1c4b-4281-b951-d872f2087c98
|