summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Added presubmit warning for ScopedAllowIO usesjoaodasilva@chromium.org2012-03-221-0/+18
| | | | | | | | | | BUG=119550 TEST=Adding new uses of ScopedAllowIO triggers a presubmit warning Review URL: http://codereview.chromium.org/9826024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128312 0039d316-1c4b-4281-b951-d872f2087c98
* Make presubmit ignore files that end in _autogen.hgman@chromium.org2012-03-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | The GPU code generates relatively complicated code. We generate that code and check in the generated files to make it easy to use codereview to see what was generated makes sense. Unfortunately, keeping the generator always generating lint error free code is hard. We mark lines that have issues with // NOLINT but that feature has apparently been removed from our lint so instead we'd just like to have presubmit ignore *_autogen.h files. R=maruel@chromium.org BUG=none TEST=checked that it did indeed exclude *_autogen.h files Review URL: http://codereview.chromium.org/9692059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126542 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_clang to default try jobsmaruel@chromium.org2012-03-091-0/+1
| | | | | | | | | | | R=thakis@chromium.org BUG= TEST= NOTRY=true Review URL: http://codereview.chromium.org/7465043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125922 0039d316-1c4b-4281-b951-d872f2087c98
* Add a win_dbg:compile bot to the default set to cover the shared build.dpranke@chromium.org2012-03-091-1/+2
| | | | | | | | | | | R=maruel@chromium.org BUG=117475 TEST=more trybots get hammered! Review URL: http://codereview.chromium.org/9651013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125841 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT.py to be less likely to hit the android bot.jrg@google.com2012-03-011-1/+22
| | | | | | | | | BUG=None TEST= Review URL: https://chromiumcodereview.appspot.com/9566028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124485 0039d316-1c4b-4281-b951-d872f2087c98
* Android build: move content_unittests to default target.jrg@chromium.org2012-02-291-14/+1
| | | | | | | | | | | | Also expand PRESUBMIT.py to include content files (e.g. everything). BUG=None TEST= Review URL: http://codereview.chromium.org/9416117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124108 0039d316-1c4b-4281-b951-d872f2087c98
* Add *_test_util.* to whitelist for test-only presubmit check.joi@chromium.org2012-02-281-1/+1
| | | | | | | | | BUG=none Review URL: http://codereview.chromium.org/9460063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123871 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT doesn't need to check for old callback systemgroby@chromium.org2012-02-191-30/+0
| | | | | | | | | | | | It's officially dead since Jan. 10 2012 BUG=none TEST=none Review URL: http://codereview.chromium.org/9423025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122702 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_clang to default try set so when one runs `git try` or `gcl try` itdbeam@chromium.org2012-02-151-5/+7
| | | | | | | | | | | | will add linux_clang automatically. TEST=Less tree breakage because of not trying changes on clang first. BUG=None NOTRY=true Review URL: http://codereview.chromium.org/9395027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122041 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit change to add android trybots when needed.jrg@chromium.org2012-02-101-0/+13
| | | | | | | | | | | | | Also add warning in android_all.gyp that extra targets in 'all' can have a significant impact on the try load so coordinate appropriately. BUG=None TEST= Review URL: http://codereview.chromium.org/9360028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121560 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed old bot to existing trybot.saintlou@chromium.org2012-02-031-1/+1
| | | | | | | | | | TBR=ben@chromium.org BUG=112154 TEST=none Review URL: https://chromiumcodereview.appspot.com/9325016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120259 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test for files starting with test_ and mock_ for Windows.joi@chromium.org2012-01-041-1/+1
| | | | | | | | | BUG=none Review URL: http://codereview.chromium.org/9008064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116345 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bugs in PRESUBMIT.py's file exclusions.wez@chromium.org2012-01-031-2/+3
| | | | | | | | | | | | native_client_sdk uses a different copyright header so it must not be processed by this check. NOTRY=true BUG=109004 Review URL: http://codereview.chromium.org/9071009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116143 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove NewRunnableFunction.jhawkins@chromium.org2012-01-011-1/+0
| | | | | | | | | | BUG=none TEST=none R=groby,ajwong Review URL: http://codereview.chromium.org/8960011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116072 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114877 (infrastructure can't handle the load, see bug)thakis@chromium.org2011-12-211-1/+1
| | | | | | | | | | | | | | | - Add linux_shared to the default try set! BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8969030 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/8999027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115443 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_shared to the default try set!thakis@chromium.org2011-12-161-1/+1
| | | | | | | | | | BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8969030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114877 0039d316-1c4b-4281-b951-d872f2087c98
* Update the aura tester used to the linux_chromeos_aura.petermayo@chromium.org2011-12-161-1/+1
| | | | | | | | | | | | | | Sky assures me this will point the devs who hit problems to relevant problems quickly and more often. BUG=chromium:107599 TEST=None TBR=God NOTRY=true Review URL: http://codereview.chromium.org/8968019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114830 0039d316-1c4b-4281-b951-d872f2087c98
* Add aura compile testing by default to likely areas (1).petermayo@chromium.org2011-12-141-1/+8
| | | | | | | | | | | TBR=God NOTRY=true BUG=chromium:107599 TEST=None Review URL: http://codereview.chromium.org/8818013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114490 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the default `git try` / `gcl try` bots to _rel.thakis@chromium.org2011-12-121-4/+4
| | | | | | | | | | | | | | That matches the CQ bots, and they're significantly faster. The global trybots are added to all subdirectory PRESUBMITs automatically, so remove win, linux, mac from subdirectory PRESUBMITs (instead of changing them too). BUG=99521 TEST=`git try` creates faster tryjobs. TBR=willchan (net), akalin (sync) Review URL: http://codereview.chromium.org/8162009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113979 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the presubmit check for empty descriptions.thestig@chromium.org2011-12-051-0/+2
| | | | | | | | | | BUG=none TEST=none NOTRY=true Review URL: http://codereview.chromium.org/8812001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112034 - Add win_shared and linux_shared builder into the default try ↵ajwong@chromium.org2011-11-301-1/+1
| | | | | | | | | | | | | | | | bot set. Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build. BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8726043 TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/8762005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112317 0039d316-1c4b-4281-b951-d872f2087c98
* Add win_shared and linux_shared builder into the default try bot set.ajwong@chromium.org2011-11-291-1/+1
| | | | | | | | | | | Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build. BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8726043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in FRIEND_TEST presubmit nag.robertshield@chromium.org2011-11-291-1/+1
| | | | | | | | | BUG=NONE TEST=NONE TBR=maruel Review URL: http://codereview.chromium.org/8687033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111943 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit to find new uses of the old callback system.dcheng@chromium.org2011-11-281-0/+31
| | | | | | | | | BUG=none TEST=edit files locally, add random references to the old callback system, and run presubmit. Review URL: http://codereview.chromium.org/8714008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111729 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that enforces the use of FRIEND_TEST_ALL_PREFIXES() ↵robertshield@chromium.org2011-11-281-4/+24
| | | | | | | | | | | | rather than FRIEND_TEST() since the former allows tests to be marked FLAKY_/FAILS_/DISABLED_. Also speed up _CheckNoNewWStrings() a bit. BUG=NONE TEST=Attempt to submit a change that includes FRIEND_TEST(). Get scolded. Review URL: http://codereview.chromium.org/8660006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111699 0039d316-1c4b-4281-b951-d872f2087c98
* ForTest presubmit check non-failing for CQ by making it just a messagejoi@chromium.org2011-11-181-5/+15
| | | | | | | | | | | | | | | | instead of a warning on commit, since there continue to be occasional fale positives and to fix the last ones the presubmit script would need to invoke a full C++ parser. Update the warning text. BUG=none TEST=dev tested locally on a specially set-up branch with various files that tickle the presubmit test. Review URL: http://codereview.chromium.org/8586024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110690 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of things to the whitelist as requested. Refactor.joi@chromium.org2011-10-201-5/+12
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8355017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106455 0039d316-1c4b-4281-b951-d872f2087c98
* Try to annoy users with a presubmit check when they hack around .DEPS.gitmaruel@chromium.org2011-10-191-0/+14
| | | | | | | | | | | R=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8346021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106313 0039d316-1c4b-4281-b951-d872f2087c98
* Make whitelist for files starting with test_ or mock_ treat pathjoi@chromium.org2011-10-181-1/+1
| | | | | | | | | | | before filename correctly. BUG=none TEST=none Review URL: http://codereview.chromium.org/8341004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106008 0039d316-1c4b-4281-b951-d872f2087c98
* Downgrade the wstring check from an error to a warning.tony@chromium.org2011-10-121-6/+7
| | | | | | | | | | BUG=None TEST=manual Review URL: http://codereview.chromium.org/8229016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104970 0039d316-1c4b-4281-b951-d872f2087c98
* Add test_ and mock_ prefixes to whitelist.joi@chromium.org2011-10-041-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8137001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104005 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send CLs with only *.mm files to non-Mac try bots by default.asvitkine@chromium.org2011-09-271-1/+5
| | | | | | | | | | | Depends on: http://codereview.chromium.org/7925014/ BUG=none TEST=Create a CL with only *.mm files: gcl/git try should send only to mac bot. Create a CL that has non-*.mm files: try should send to windows and linux bots too. Review URL: http://codereview.chromium.org/8046013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103040 0039d316-1c4b-4281-b951-d872f2087c98
* presubmit - don't check test functions for wstringestade@chromium.org2011-09-231-1/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7969020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102438 0039d316-1c4b-4281-b951-d872f2087c98
* Fix false positive that occurred because _test.cc files were notjoi@chromium.org2011-09-211-2/+1
| | | | | | | | | | | matched by the whitelist regexp. BUG=none TEST=none Review URL: http://codereview.chromium.org/7980032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102159 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT: reject changes that add wstringsevan@chromium.org2011-09-131-0/+18
| | | | | | | | | We are trying to get rid of wstrings, but new code keeps getting checked in that adds more. This will help prevent future mistakes. Review URL: http://codereview.chromium.org/7886019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100974 0039d316-1c4b-4281-b951-d872f2087c98
* Add profile_sync_service_harness.cc to presubmit whitelist as it is ajoi@chromium.org2011-09-121-1/+3
| | | | | | | | | | | testing-only file. BUG=none TEST=none Review URL: http://codereview.chromium.org/7796039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100798 0039d316-1c4b-4281-b951-d872f2087c98
* Fix libbase interface check.avi@chromium.org2011-09-081-2/+1
| | | | | | | | | | | It was triggering for things like ui/base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7861006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100240 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that catches iostream usage in header files.thakis@chromium.org2011-09-021-0/+22
| | | | | | | | | BUG=94794 TEST=none Review URL: http://codereview.chromium.org/7792076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99291 0039d316-1c4b-4281-b951-d872f2087c98
* Add rules to exclude files with paths containing /test/, /tool/ and /tools/.joi@chromium.org2011-08-151-2/+3
| | | | | | | | | BUG=none TEST=manually tested by developer Review URL: http://codereview.chromium.org/7637015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96768 0039d316-1c4b-4281-b951-d872f2087c98
* Add check to help prevent test-only function usage in production code.joi@chromium.org2011-08-101-0/+52
| | | | | | | | | BUG=none TEST=Manual testing was performed. Warning message from presubmit test includes note to report issues to joi@chromium.org Review URL: http://codereview.chromium.org/7582002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96184 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify the author check.maruel@chromium.org2011-06-151-3/+1
| | | | | | | | | | | | | 2 lines removed! R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/7144016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89182 0039d316-1c4b-4281-b951-d872f2087c98
* Allow wildcard for corporate CLA. Add nvidia to AUTHORS.maruel@chromium.org2011-06-131-3/+10
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7003151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88891 0039d316-1c4b-4281-b951-d872f2087c98
* presubmit: Make AUTHORS presubmit check use lower-cased email addresses.thakis@chromium.org2011-06-061-2/+2
| | | | | | | | | | | This is so that presubmit stops complaining about Takano.Naoki@gmail.com. BUG=none TEST=none Review URL: http://codereview.chromium.org/7024048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88004 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit check for non committersmaruel@chromium.org2011-05-311-1/+1
| | | | | | | | TBR=dpranke@chromium.org BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87346 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure non chromite/googler contributor is listed in AUTHORS.maruel@chromium.org2011-05-281-0/+26
| | | | | | | | | | | | | | It's easy to get a non-committer patch in with the commit-queue. Verifying CLA is outside the scope of this change. BUG= TEST= Review URL: http://codereview.chromium.org/6794027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87177 0039d316-1c4b-4281-b951-d872f2087c98
* Don't check for @interface in _unittest.mm files in basethakis@chromium.org2011-05-021-1/+2
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6880347 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83737 0039d316-1c4b-4281-b951-d872f2087c98
* Don't let the presubmit check warn about |@interface| in comments in base.thakis@chromium.org2011-04-291-1/+1
| | | | | | | | | | | | | | Doesn't catch all /**/ style comments, but in practice we don't use /**/ comments, and when we do, we start every line with a *, and that's caught. (On the flipside, this doesn't catch "/**/@interface". http://stackoverflow.com/questions/1732348/regex-match-open-tags-except-xhtml-self-contained-tags/1732454#1732454) BUG=none TEST=none Review URL: http://codereview.chromium.org/6905134 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83578 0039d316-1c4b-4281-b951-d872f2087c98
* Remove pending builds check, it's going to interfere with the commit queuemaruel@chromium.org2011-04-221-25/+0
| | | | | | | | | | | | | | | and slows down presubmit without much advantage anymore. Remove input_api.json check, it cannot be None anymore. R=nsylvain@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6896011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82611 0039d316-1c4b-4281-b951-d872f2087c98
* Migrating common checks to a location that affects all chromium projects.bradnelson@google.com2011-03-271-93/+9
| | | | | | | | | | BUG=None TEST=None R=erikkay@chromium.org,dpranke@chromium.org,maruel@chromium.org Review URL: http://codereview.chromium.org/6676115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79515 0039d316-1c4b-4281-b951-d872f2087c98
* Turn on OWNERS checking in chromium/srcdpranke@chromium.org2011-03-181-0/+6
| | | | | | Review URL: http://codereview.chromium.org/6597065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78699 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 14:45:29 +0000