summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Ignore hardcoded URLs and ForTest(ing)/for_test(ing) in comments.joi@chromium.org2013-05-231-4/+8
| | | | | | | | | | | | | This addresses a couple of bug reports I've received on these presubmit checks. I also fixed how reviewers_plus_owner is created in _CheckAddedDepsHaveTargetApprovals based on comments on a previous patch. BUG=None Review URL: https://chromiumcodereview.appspot.com/15755002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201792 0039d316-1c4b-4281-b951-d872f2087c98
* Fix _CheckAddedDepsHaveTargetApprovals for the case where no owner has been ↵joi@chromium.org2013-05-221-1/+3
| | | | | | | | | | | specified. TBR=maruel@chromium.org BUG=none Review URL: https://codereview.chromium.org/15491008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201426 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid unwanted Skia ref-counting containersenne@chromium.org2013-05-201-0/+37
| | | | | | | | | | | | | | | | | | | | | | skia::RefPtr is the closest Chromium construct to scoped_refptr and also the safest Skia refcounting class. To avoid other people continually shooting themselves in the face mistaking SkRefPtr for skia::RefPtr (one of which refs the pointer you give it and the other doesn't), ban this in Chromium via global PRESUBMIT. The Skia team also prefers to keep the SkAutoTUnref template private (see discussion here: https://codereview.appspot.com/6849109/), so prefer SkRefPtr over that as well. Finally, SkAutoUnref and SkAutoRef are both templates that support SkRefPtr and SkAutoTUnref, so make sure these are unused as well. R=maruel@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/15063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201029 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that requires an OWNERS approval from foo/bar/OWNERS ↵joi@chromium.org2013-05-131-0/+72
| | | | | | | | | | | if adding a "+foo/bar" rule to DEPS. BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/15043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199726 0039d316-1c4b-4281-b951-d872f2087c98
* Using explicit checkout local path in presubmit checkdepsalancutter@chromium.org2013-05-091-1/+1
| | | | | | | | | | | | Ensure checkdeps searches the current repository instead of only Chromium's. This is part of enabling checkdeps in Blink. BUG=238992 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14779012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199296 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude content shell files from the "for testing" presubmit check.jochen@chromium.org2013-05-031-0/+2
| | | | | | | | | | We're using plenty of ...ForTesting() methods to run layout tests R=joi@chromium.org Review URL: https://codereview.chromium.org/14913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198094 0039d316-1c4b-4281-b951-d872f2087c98
* Add "pixeltest" as a test type for presubmit.danakj@chromium.org2013-04-261-1/+1
| | | | | | | | | | | Similar to foo_unittest and foo_browsertest, the compositor also has foo_pixeltest files. R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/14315013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196796 0039d316-1c4b-4281-b951-d872f2087c98
* Allow test files to use non-platform suffixes for PRESUBMIT checks.danakj@chromium.org2013-04-231-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The current check for deciding if a file is a unittest allows a strict whitelist of platforms as suffixes. However, when a unittest file becomes too large, it is useful to split it on other axes than by platform. This allows a _suffix for a topic to be used without failing production-only presubmit checks. In other words, it considers foo_bar_unittest_baz.cc to be a unittest. There are many examples of foo_unittest_utils.cc which are used only by unit tests throughout chromium, but they have been lucky to avoid using FunctionForTesting type functions. In cc/ we have run into this problem, so allowing our unittests to be considered non-production code prevents false positive warnings about our test files. NOTRY=true R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14317011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195780 0039d316-1c4b-4281-b951-d872f2087c98
* Convert an OS_SUN use to OS_SOLARIS.shess@chromium.org2013-04-171-1/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/14101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194681 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper.wez@chromium.org2013-04-021-25/+4
| | | | | | | | NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191863 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the simple cache backend at runtime. pasko@google.com2013-04-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will need to choose the backend at runtime for A/B testing. This change is the first step towards backend comparisons: it moves the logic of choosing among cache backends to a single point (cache_creator.cc) and makes it logically separate from BackendImpl. Next step would be to inject performance-analyzer backend into this cache backend choice logic. The analyzer is going to be under a compile-time flag. With this change the Simple Cache Backend operation gets enabled when the "SimpleCacheTrial" experiment is set. Cache Initialization. The Simple Cache Backend now shares the common initialization/cleanup code. So it can delete inconsistent cache, cache of a different version etc asynchronously. It is just a positive side-effect of moving the backend choice to a single point. The CacheCreator with almost no change. To see the difference: shell> out/Debug/chrome --enable-logging=stderr --v=1 \ --user-data-dir=/tmp/unique --use-simple-cache-backend=on \ http://url 2>&1 | grep "Simple Cache" BUG=173390, 173384 TBR=maruel Review URL: https://chromiumcodereview.appspot.com/12794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191830 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cc/ from PRESUBMIT.py exception listjamesr@chromium.org2013-03-281-1/+0
| | | | | | | | | | | This directory should now always pass chromium's PRESUBMITs BUG=144577 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191184 0039d316-1c4b-4281-b951-d872f2087c98
* Adding _Check* function for invalid OS_MACROs in src/PRESUBMIT.pydbeam@chromium.org2013-03-261-0/+70
| | | | | | | | | | | | R=maruel@chromium.org BUG=none CONTEXT=http://goo.gl/hrlj1 TEST=PRESUBMIT_test.py and less OS_MAXOSX! NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12845013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190693 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webkit/compositor_bindings from PRESUBMIT exclusion listjamesr@chromium.org2013-03-191-1/+0
| | | | | | | | | | | | | | This was added when initially importing this code from WebKit that didn't comply with chromium's style rules. This code now passes lint and presubmit checks so there's no need for the exclusion. NOTRY=true BUG=144577 Review URL: https://chromiumcodereview.appspot.com/12695010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189029 0039d316-1c4b-4281-b951-d872f2087c98
* Add a few more configs to try jobs to match CQ (win:compile, mac:compile).jam@chromium.org2013-02-211-2/+4
| | | | | | Review URL: https://codereview.chromium.org/12328039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183833 0039d316-1c4b-4281-b951-d872f2087c98
* [NaCl SDK] make example Makefiles quiet by defaultsbc@chromium.org2013-02-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | This is a port of some of the changes made to the common.mk system when it was ported to support building nacltoons. Also, change oshelpers "rm -f" so that is doesn't output anything when it can't find files (this matches /bin/rm behavior). Also, remove redundant nmf build rules from host_vc.mk and host_gcc.mk. Also, add .mk files to exclusion list in top level PRESUBMIT.py since they contain lines longer than 80 chars and fixing this would make them harder to read. BUG=None Review URL: https://chromiumcodereview.appspot.com/12209097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181856 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit fix: add missing png suffix.oshima@chromium.org2013-01-251-1/+1
| | | | | | | | | | TBR=maruel@chromium.org BUG=none TEST=none Review URL: https://codereview.chromium.org/12033111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178899 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit check for the name of png files. They should not have abbreviations.oshima@chromium.org2013-01-251-0/+19
| | | | | | | | | | | NOTRY=true BUG=150046 TEST=none Review URL: https://chromiumcodereview.appspot.com/12047112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178837 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT.py: Run only PRESUBMIT_test.py if PRESUBMIT.py changes.marja@chromium.org2013-01-211-1/+1
| | | | | | | | | | | | Previously, we used to run all _test.py files in this directory. BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12037006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177927 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 176986 - breaks tools/perf and tools/telemetry presubmitnduca@chromium.org2013-01-161-77/+28
| | | | | | | | | | | | | | | | | | | | | | While I totally get this for production code, it doesn't apply to for example tools/perf, where we keep sitelists intentionally. Because this hooks into common checks, there's no clean way to disable it that I can see. > Warn when committing code with http:// URLs. > > We prefer HTTPS for everything, to the extent possible. > > NOTRY=true > BUG=156396 > > > Review URL: https://chromiumcodereview.appspot.com/11779037 TBR=palmer@chromium.org Review URL: https://codereview.chromium.org/11811004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177079 0039d316-1c4b-4281-b951-d872f2087c98
* Warn when committing code with http:// URLs.palmer@chromium.org2013-01-151-28/+77
| | | | | | | | | | | | We prefer HTTPS for everything, to the extent possible. NOTRY=true BUG=156396 Review URL: https://chromiumcodereview.appspot.com/11779037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176986 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate presubmit check for FilePathWatcher::Delegate, which no longer exists.darin@chromium.org2013-01-151-9/+0
| | | | | | | | BUG=130980 Review URL: https://codereview.chromium.org/11917002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176945 0039d316-1c4b-4281-b951-d872f2087c98
* Fix "gcl try" not working. I think the server was crashing because it didn't ↵jam@chromium.org2013-01-111-1/+1
| | | | | | | | | know what win_aura bots are anymore. Renamed to win7_aura. TBR=cmp Review URL: https://codereview.chromium.org/11853006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176262 0039d316-1c4b-4281-b951-d872f2087c98
* Don't issue try jobs for OWNERS-only changes.dbeam@chromium.org2013-01-101-1/+1
| | | | | | | | | | | BUG=None R=maruel@chromium.org TEST=PRESUBMIT_test.py, less needless try jobs. NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11830057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176192 0039d316-1c4b-4281-b951-d872f2087c98
* Silence Valid authors debug msg in presubmitilevy@chromium.org2013-01-071-2/+1
| | | | | | | | | | | | | | Silence the valid authors debug message, unless the check fails. The message takes a lot of space because the author file is big, and is not especially helpful (just lists parse results from the authors file). NOTRY=True Review URL: https://chromiumcodereview.appspot.com/11782010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175360 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last remaining call to FindOrCreateTabbedBrowser(). Fix up presubmit ↵robertshield@chromium.org2012-12-211-10/+0
| | | | | | | | | | | | check. BUG=129187 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/11554003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174348 0039d316-1c4b-4281-b951-d872f2087c98
* base: Remove deprecated RunAllPending() function from MessageLoop API.tfarina@chromium.org2012-12-191-10/+0
| | | | | | | | | | | | | All the calls to RunAllPending() were moved to RunUntilIdle(), so now we can remove this. BUG=131220 R=willchan@chromium.org TBR=maruel@chromium.org # for presubmit Review URL: https://chromiumcodereview.appspot.com/11635008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173939 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check: exclude known cases which need a non-standard order.marja@chromium.org2012-12-181-2/+9
| | | | | | | | | | BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/11607019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173773 0039d316-1c4b-4281-b951-d872f2087c98
* Pass a list of strings rather than a string-as-list.joi@chromium.org2012-12-111-1/+1
| | | | | | | | | | | | | | This fixes a stupid bug that got past my testing (I tested the positive case but not the negative). TBR=maruel@chromium.org NOTRY=true BUG=None Review URL: https://chromiumcodereview.appspot.com/11534010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172328 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit check to avoid adding hard-coded URLs or hostnames for ↵joi@chromium.org2012-12-111-17/+62
| | | | | | | | | | | server-side services to lower layers. BUG=164568 Review URL: https://chromiumcodereview.appspot.com/11475030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172221 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check: don't add a warning if we're committing.marja@chromium.org2012-12-101-2/+7
| | | | | | | | | | | | | This enables the commit queue to commit patches where the #include order is "wrong" according to the check. NOTRY=true BUG= Review URL: https://chromiumcodereview.appspot.com/11496010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172084 0039d316-1c4b-4281-b951-d872f2087c98
* Remove almost all usages of the context-free FindOrCreateTabbedBrowser.robertshield@chromium.org2012-12-061-1/+1
| | | | | | | | | | | Alter presubmit check to only warn about the deprecated flavour of FindOrCreateTabbedBrowser. BUG=129187 TEST=NONE Review URL: https://codereview.chromium.org/11444010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171570 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check enhancements.marja@chromium.org2012-12-061-29/+26
| | | | | | | | | | | | | | | | | 1) Handle #define and #undef the same way as #if etc. See e.g., https://codereview.chromium.org/11363222/diff/10015/chrome/browser/history/history_unittest.cc line 545. 2) Also headers can have the special first include, not only sources. See e.g., net/disk_cache/storage_block-inl.h. NOTRY=true BUG=NONE Review URL: https://chromiumcodereview.appspot.com/11441035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171511 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check to prevent committing .rej/.orig patch filesenne@chromium.org2012-12-051-0/+11
| | | | | | | | | | | | | This is a follow-up to me having to remove some of these by hand in r171143. R=maruel@chromium.org NOTRY=true BUG=none Review URL: https://chromiumcodereview.appspot.com/11448014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171287 0039d316-1c4b-4281-b951-d872f2087c98
* Add HostDesktopType parameter to browser::FindAnyBrowser().gab@chromium.org2012-12-051-10/+0
| | | | | | | | | BUG=129187 Review URL: https://chromiumcodereview.appspot.com/11416349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171175 0039d316-1c4b-4281-b951-d872f2087c98
* Remove last usages of FindTabbedBrowserDeprecated.robertshield@chromium.org2012-12-041-10/+0
| | | | | | | | | | BUG=129187 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/11348344 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171057 0039d316-1c4b-4281-b951-d872f2087c98
* FindLastActiveWithProfile now requires a HostDesktopType.grt@chromium.org2012-11-291-10/+0
| | | | | | | | | | | BUG=129187 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=169654 Review URL: https://codereview.chromium.org/11365128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170176 0039d316-1c4b-4281-b951-d872f2087c98
* Add win_aura and linux_aura to default try jobs.jam@chromium.org2012-11-291-5/+4
| | | | | | | BUG=154081 Review URL: https://codereview.chromium.org/11411213 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170135 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing PRESUBMIT.py broken by r169664.alexeypa@chromium.org2012-11-271-0/+1
| | | | | | | | TBR=joi@chromium.org Review URL: https://codereview.chromium.org/11308228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169666 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 169654 - FindLastActiveWithProfile now requires a HostDesktopType.joi@chromium.org2012-11-271-0/+9
| | | | | | | | | | | | | | | BUG=129187 TEST=none Review URL: https://chromiumcodereview.appspot.com/11365128 Speculative revert to fix Win Aura crash in unit test ExtensionServiceTest.LoadExtensionsWithPlugins. TBR=grt@chromium.org Review URL: https://codereview.chromium.org/11413189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169664 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for excluding individual paths (matching a pattern) from the ↵jochen@chromium.org2012-11-271-1/+18
| | | | | | | | | | | | | banned CPP functions check Also add shell_browser_main.cc to the list of excluded paths for the ScopedAllowIO object. This file does the setup for layout tests which requires a fair number of IO. BUG=none R=joi@chromium.org Review URL: https://codereview.chromium.org/11419182 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169657 0039d316-1c4b-4281-b951-d872f2087c98
* FindLastActiveWithProfile now requires a HostDesktopType.grt@chromium.org2012-11-271-9/+0
| | | | | | | | | BUG=129187 TEST=none Review URL: https://chromiumcodereview.appspot.com/11365128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169654 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT #include check enhancement: <sys/..> includes can be in any order.marja@chromium.org2012-11-221-2/+6
| | | | | | | | | | | E.g., need to be in this order, since the latter uses definitions from the former. BUG=NONE Review URL: https://codereview.chromium.org/11418128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169290 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a presubmit that looks for version control conflicts.dbeam@chromium.org2012-11-201-0/+23
| | | | | | | | | | R=maruel@chromium.org,thakis@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/11417044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix include order PRESUBMIT check: #if-#elif-#elsemarja@chromium.org2012-11-161-5/+3
| | | | | | | | BUG=161390 Review URL: https://codereview.chromium.org/11413036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168191 0039d316-1c4b-4281-b951-d872f2087c98
* Disable PRESUBMIT check _CheckIncludeOrder().maruel@chromium.org2012-11-161-1/+2
| | | | | | | | | | | | | It's failing to handle some #ifdef properly. TBR=marja@chromium.org NOTRY=true BUG=161390 Review URL: https://chromiumcodereview.appspot.com/11417018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168107 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing the PRESUBMIT include check some more.marja@chromium.org2012-11-151-18/+32
| | | | | | | | | | | | The previous version didn't take into account that source files can have a platform specific suffix. BUG=NONE TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11413012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167996 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the presubmit include check.marja@chromium.org2012-11-141-9/+15
| | | | | | | | | | | | | Some files in content/ can have their first include in content/public. Also, the check didn't detect all the error where there were non-include lines between two conflicting #include lines. BUG=NONE Review URL: https://codereview.chromium.org/11365263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167735 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT.py: Check #include file order.marja@chromium.org2012-11-141-0/+123
| | | | | | | | BUG=NONE Review URL: https://codereview.chromium.org/11364156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167654 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Move FindLastActiveWithProfile() into chrome namespace.tfarina@chromium.org2012-11-121-1/+1
| | | | | | | | | BUG=133088 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/11363188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167131 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-13 08:40:31 +0000