| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=maruel@chromium.org
R=szager@chromium.org
BUG=362394
Review URL: https://codereview.chromium.org/484393003
Cr-Commit-Position: refs/heads/master@{#291613}
|
|
|
|
|
|
|
|
|
|
|
|
| |
android_dbg_triggered_tests since that's what the CQ uses now.
BUG=403411
NOTRY=true
Review URL: https://codereview.chromium.org/496873002
Cr-Commit-Position: refs/heads/master@{#291520}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changed as well.
R=scottmg@chromium.org
Review URL: https://codereview.chromium.org/482433002
Cr-Commit-Position: refs/heads/master@{#290051}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The header include order checks were running on all
affected files, including third_party for example,
this causes issues when rolling harfbuzz-ng.
BUG=404105
NOTRY=true
Review URL: https://codereview.chromium.org/462323003
Cr-Commit-Position: refs/heads/master@{#289968}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
the CQ has switched over.
R=avi@chromium.org
Review URL: https://codereview.chromium.org/461313002
Cr-Commit-Position: refs/heads/master@{#289157}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/452313003
Cr-Commit-Position: refs/heads/master@{#288447}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=maruel
Review URL: https://codereview.chromium.org/458503002
Cr-Commit-Position: refs/heads/master@{#288440}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://codereview.chromium.org/448013004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
since they're switched by CQ already.
TBR=ben
Review URL: https://codereview.chromium.org/450583002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
None of chromecast/ is part of chrome binary.
R=lcwu@chromium.org,maruel@chromium.org
BUG=None
NOTRY=true
Review URL: https://codereview.chromium.org/448903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287946 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also replace deprecated linux_chromium_rel with linux_chromium_rel_swarming, while I'm at it.
R=agable@chromium.org, maruel@chromium.org
BUG=395196
Review URL: https://codereview.chromium.org/415323002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://codereview.chromium.org/360563002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@280529 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/344563003/)
Reason for revert:
It seems to be checking code that is not part of the diff.
I also think there are some legitimate cases for not reached in the middle of a block but that is something that can be discussed on the bug.
Filed https://code.google.com/p/chromium/issues/detail?id=388731 to track.
Original issue's description:
> Add PRESUBMIT.py warning for contradictory NOTREACHED() use.
>
> As recently discussed on chromium-dev [1] and subsequently incorporated into the
> Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern.
> This CL lets PRESUBMIT.py detect most of these cases and print a warning to the
> developer.
> [1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J
> [2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-
>
> BUG=none
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279681
TBR=maruel@chromium.org,tnagel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=none
Review URL: https://codereview.chromium.org/357693004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279710 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As recently discussed on chromium-dev [1] and subsequently incorporated into the
Chromium Coding Style [2], NOTREACHED() followed by code is an anti-pattern.
This CL lets PRESUBMIT.py detect most of these cases and print a warning to the
developer.
[1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/c2X0D1Z6X2o/ddkFLqQP0P0J
[2] http://www.chromium.org/developers/coding-style#TOC-CHECK-DCHECK-and-NOTREACHED-
BUG=none
Review URL: https://codereview.chromium.org/344563003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Xcode 6 moved the location of the frameworks that iossim depends on and
added a few new dependecies so new header files need to be generated by
the gyp target.
Note that this CL gets iossim to compile but iossim will not launch the
Xcode 6 simulator.
BUG=381213
NOTRY=true
TBR=rohitrao@chromium.org
Review URL: https://codereview.chromium.org/336773002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
See https://codereview.chromium.org/323483002/
BUG=380709
R=kjellander@chromium.org
Review URL: https://codereview.chromium.org/320823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Writing logout-started on process exit is unstable.
So moving it to next boot.
BUG=352130
TEST=manual
Review URL: https://codereview.chromium.org/303233004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274649 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes, changes to JSON/IDL files make them invalid. It's easier to check these at presubmit time than discovering they can't be parsed at runtime.
This just moves the check from chrome/common/extensions/api to top-level.
This presubmit check excludes files in test/data directories.
BUG=366395
Review URL: https://codereview.chromium.org/239283008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
And run the new Python-driven test_mini_installer on win_rel trybot.
BUG=277655
Review URL: https://codereview.chromium.org/301223007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=brettw@chromium.org
Review URL: https://codereview.chromium.org/305633007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
There are some documentation in the Chromium tree that
is meant for external consumption (which includes
WebKit) so it can't use the unprefixed CSS
properties / values or functions.
Review URL: https://codereview.chromium.org/294893003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272027 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
function in test namespace
BUG=None
NOTRY=true
Review URL: https://codereview.chromium.org/285623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270300 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also implements TestURLFetcher::SaveResponseToTemporaryFile(),
and explicitly allows ScopedIO in TestURLFetcher, as it doesn't support
asynchronous IO by design.
Note to tree sheriffs: this CL can break tests using FakeURLFetcherFactory.
BUG=366614
TEST=none
Review URL: https://codereview.chromium.org/253833006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
mac_gpu is already experimentally receiving a percentage of the
Chromium and Blink CQs' load, and the hardware has just been fully
built out. Expand its testing to cover manually submitted try jobs.
BUG=327170
R=phajdan.jr@chromium.org,maruel@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/269313009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chromium's resources are using a gazillion deprecated
CSS properties, functions or values.
This is bothering as Blink's UseCounter doesn't discriminate
between chrome:// pages and web pages so they get counted. But
more conceptually, Chromium's developers should be leading
the way and not use some CSS that was deprecated 2+ years ago.
The initial list only contains items with an unprefixed
counterpart.
Review URL: https://codereview.chromium.org/261773009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=brettw@chromium.org, phajdan.jr@chromium.org
BUG=353690
Review URL: https://codereview.chromium.org/263293004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
win_gpu is already experimentally receiving a percentage of the
Chromium and Blink CQs' load. Expand its testing to cover manually
submitted try jobs.
BUG=327170
R=phajdan.jr@chromium.org,maruel@chromium.org
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/258233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
with .json can"
Revert 266019 - "Add detail to 'invalid JSON' message in PRESUBMIT.py."
This presubmit check is invalid - it fails on existing .json files in the tree that contain comments. (Other JSON-reading tools strip out these comments.) Any changes to these .json files are incorrectly rejected by this check.
BUG=366395
TBR=iannucci@chromium.org,tnagel@chromium.org
Review URL: https://codereview.chromium.org/252713003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/255613002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
be loaded as json.
R=jochen@chromium.org, maruel@chromium.org
BUG=366395
Review URL: https://codereview.chromium.org/258473002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This configuration is already experimentally receiving 100% of the
Chromium and Blink CQs' load. Expand its testing to cover manually
submitted try jobs as well.
As a side-effect, added multi-master support to GetDefaultTryConfigs.
Tested manually.
BUG=327170
Review URL: https://codereview.chromium.org/242963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This moves several native handlers out of //chrome/renderer/extensions and into
//extensions/renderer.
Many of the changes are mechanical. Where applicable,
ChromeV8Extension has been wiped out.
BUG=359836
R=yoz@chromium.org
TBR=reed@google.com for skia +DEPS
TBR=ericu@chromium.org for fileapi +DEPS
TBR=eseidel@chromium.org for WebKit/public/platform +DEPS
TBR=sky@chromium.org for chrome/test
TBR=maruel@chromium.org for PRESUBMIT.py
Review URL: https://codereview.chromium.org/235943018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264413 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Uses the regex to allow use of NSTrackingAreaOptions, while still
banning NSTrackingArea.
BUG=None
Review URL: https://codereview.chromium.org/237463003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264109 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=358130
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/239223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263891 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/237383002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263810 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also moves ModuleSystem, RequestSender,
ObjectBackedNativeHandler, and SafeBuiltins
over to //extensions.
Other renderer code is updated minimally to support
these changes.
BUG=359836
TBR=sky@chromium.org for chrome/test
TBR=jamescook@chromium.org for apps/shell
TBR=maruel@chromium.org for PRESUBMIT.py
Review URL: https://codereview.chromium.org/234413005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=331299
TBR=maruel@chromium.org
R=marja@chromium.org
Review URL: https://codereview.chromium.org/225543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
New code should use gin::Wrappable<> instead
BUG=334679
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/225863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/214703002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Without this _exit() can lose messages that are still
in transit to JavaScript.
Also, fix using_ppapi_simple example.
Exclude native_client_sdk from PRESUBMIT check on
stdout/stderr. The code here doesn't get built into chrome
itself.
BUG=337584
R=binji@chromium.org, maruel@chromium.org
Review URL: https://codereview.chromium.org/152743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258953 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(Unfortunately, base::SharedMemory doesn't quite meet our needs right
now, and it'll be a while -- if ever -- before I manage to refactor it
so that it does.)
Not yet implemented on Windows. (This should be simple, but I'll do it
separately.)
R=darin@chromium.org
Review URL: https://codereview.chromium.org/205583008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258667 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The failure rate is currently unacceptably high. Disabling normal runs will
permits us to run more perf tests on the prod instance.
R=vadimsh@chromium.org
BUG=354263
NOTRY=true
Review URL: https://codereview.chromium.org/206773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=354052
Review URL: https://codereview.chromium.org/204753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use libevent as the implementation of MessagePumpForUI.
BUG=346113
Review URL: https://codereview.chromium.org/176713005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This removes some configs that were here below in an attempt to reduce
the tryserver load.
They can be added later slowly after we verify they don't cause unnecessary
load. Note that CQ was not checking them anyway, so they were losing at least
50% CL coverage.
TBR=maruel
BUG=317931
Review URL: https://codereview.chromium.org/198333003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also fixes problems with generic trybots not being triggered
when other presubmit files which already support multiple masters
get in scope.
BUG=334892
R=maruel@chromium.org
Review URL: https://codereview.chromium.org/197963003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256698 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this way, more information can be added (currently added 'description' and 'owner' for each action)
A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms.
CL 149503005 broke in http://crrev.com/255357. Add a patch to fix histograms presubmit.
BUG=340735
NOTRY=true
Review URL: https://codereview.chromium.org/180743027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=340735
TBR=maruel@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/189783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255530 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Believed to be behind the failures in the Linux builder:
http://build.chromium.org/p/chromium/builders/Linux/builds/47996
Errors in the log:
.../actions/print_style.py: Has executable bit but not shebang or ELF header
.../histograms/print_style.py: Has executable bit but not shebang or ELF header
Refers to files in the CL.
> Change the user action file format from .txt to .xml.
>
> In this way, more information can be added (currently added 'description' and 'owner' for each action)
>
> A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms.
>
> BUG=340735
> NOTRY=true
>
> Review URL: https://codereview.chromium.org/149503005
TBR=yiyaoliu@chromium.org
Review URL: https://codereview.chromium.org/188793003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this way, more information can be added (currently added 'description' and 'owner' for each action)
A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms.
BUG=340735
NOTRY=true
Review URL: https://codereview.chromium.org/149503005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255357 0039d316-1c4b-4281-b951-d872f2087c98
|