summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Use the newly added CheckLicense() canned check to verify license boiler ↵maruel@chromium.org2010-01-281-18/+21
| | | | | | | | | | | | | plate on source files. Don't check for the year since there was no clear concensus about systematically updating the year on every change. TEST=none BUG=28291 Review URL: http://codereview.chromium.org/552203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37361 0039d316-1c4b-4281-b951-d872f2087c98
* Remove old files.nsylvain@chromium.org2009-11-201-3/+0
| | | | | | Review URL: http://codereview.chromium.org/425008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32711 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the botsnsylvain@chromium.org2009-11-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32026 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PRESUBMIT.py when simplejson is present.maruel@chromium.org2009-11-091-1/+1
| | | | | | | | | TBR=nsylvain TEST=none BUG=none Review URL: http://codereview.chromium.org/380005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31477 0039d316-1c4b-4281-b951-d872f2087c98
* Warn when number of inflight build is too high.maruel@chromium.org2009-11-091-0/+57
| | | | | | | | TEST=none BUG=27143 Review URL: http://codereview.chromium.org/381005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31470 0039d316-1c4b-4281-b951-d872f2087c98
* Remove executable bit on PRESUBMIT.py since it is not an executable.maruel@chromium.org2009-10-241-1/+0
| | | | | | | | | | NO CODE CHANGE. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30015 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the builbotnsylvain@chromium.org2009-10-111-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28683 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the buildbotsnsylvain@chromium.org2009-10-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28676 0039d316-1c4b-4281-b951-d872f2087c98
* Disable CheckSvnModifiedDirectories for now. It doesn't work well in ↵thestig@chromium.org2009-10-011-2/+3
| | | | | | | | | | | third_party. BUG=none TEST=none TBR=maruel Review URL: http://codereview.chromium.org/246055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27710 0039d316-1c4b-4281-b951-d872f2087c98
* Add GetPreferredTrySlaves() to presubmit scripts.thestig@chromium.org2009-09-291-0/+4
| | | | | | | | BUG=23071 TEST=none Review URL: http://codereview.chromium.org/251024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27449 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the botsnsylvain@chromium.org2009-09-241-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27028 0039d316-1c4b-4281-b951-d872f2087c98
* Fix try job status PRESUBMIT check when an issue is private.maruel@chromium.org2009-09-181-0/+3
| | | | | | | | TEST=presubmit doesn't throw an exception on private issues BUG=none Review URL: http://codereview.chromium.org/207030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26598 0039d316-1c4b-4281-b951-d872f2087c98
* Check for svn directories with modified properties during presubmit. These ↵thestig@chromium.org2009-08-151-0/+2
| | | | | | | | directories may trigger unwanted commits due to svn's recursive behavior. Review URL: http://codereview.chromium.org/165427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23506 0039d316-1c4b-4281-b951-d872f2087c98
* Make the try job presubmit check (CheckTryJobExecution) less verbose.maruel@chromium.org2009-08-121-21/+19
| | | | | | | | | | Also clean up the Tree is closed presubmit check (CheckTreeIsOpen). TEST=none BUG=none Review URL: http://codereview.chromium.org/165251 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23195 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the botsnsylvain@chromium.org2009-07-311-2/+2
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22160 0039d316-1c4b-4281-b951-d872f2087c98
* Make the "tree is closed" presubmit check an error, not ansylvain@chromium.org2009-07-291-2/+2
| | | | | | | | | warning. pressing "y" is too easy. It's better to have to use "--force" or "--no_presubmit" Review URL: http://codereview.chromium.org/159596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21978 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce presubmit check of try run. Add a nice message to give feedback to ↵maruel@chromium.org2009-07-101-10/+9
| | | | | | | | | | the right person. BUG=none TEST=none Review URL: http://codereview.chromium.org/155354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20397 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce correct mime-type on some files formats (especially images).maruel@chromium.org2009-06-261-0/+4
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/147221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19437 0039d316-1c4b-4281-b951-d872f2087c98
* Display the actual tree status when the tree is closed. Much more helpful.maruel@chromium.org2009-06-111-4/+32
| | | | | | | | TEST=Try committing when the tree is closed to see. BUG=none Review URL: http://codereview.chromium.org/119437 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18125 0039d316-1c4b-4281-b951-d872f2087c98
* Use new canned checks in PRESUBMIT.pymaruel@chromium.org2009-06-111-109/+39
| | | | | | | | | | | | Also fix gcl presubmit tree status check when the change hasn't been uploaded nor gcl try'ed. Remove PRESUBMIT_unittest.py since it's not useful anymore. TEST=none BUG=none Review URL: http://codereview.chromium.org/119432 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18124 0039d316-1c4b-4281-b951-d872f2087c98
* Use input_api.ReadFile() instead of rolling out its own.maruel@chromium.org2009-06-101-13/+1
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/118484 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18051 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the buildbotsnsylvain@chromium.org2009-06-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18019 0039d316-1c4b-4281-b951-d872f2087c98
* Add try job status check on commit.maruel@chromium.org2009-06-081-0/+44
| | | | | | | | | | It acts as an advisory presubmit check for now since the try server isn't that stable. BUG=none TEST=gcl commit warns the user when a pending change hasn't passed the try job. Review URL: http://codereview.chromium.org/119295 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17870 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the slaves - NO CODE CHANGEnsylvain@chromium.org2009-06-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17846 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy change to trigger the build slaves - NO CODE CHANGEnsylvain@chromium.org2009-06-071-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17845 0039d316-1c4b-4281-b951-d872f2087c98
* Add the tree check there instead of implementing it in the root PRESUBMIT.py.maruel@chromium.org2009-06-051-7/+19
| | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/119201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17729 0039d316-1c4b-4281-b951-d872f2087c98
* Fix PRESUBMIT.py's path handling.maruel@chromium.org2009-06-041-1/+1
| | | | | | Review URL: http://codereview.chromium.org/118202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17574 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert "Add presubmit checks to look for BUG= and TEST= tags in ↵kuchhal@chromium.org2009-05-211-2/+6
| | | | | | | | | | | change list description."" This reverts commit fb3644d302ea26efbe2a2e761beea2d3f26bac59. Review URL: http://codereview.chromium.org/115577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16612 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Add presubmit checks to look for BUG= and TEST= tags in change list ↵kuchhal@chromium.org2009-05-121-6/+2
| | | | | | | | | description." Review URL: http://codereview.chromium.org/113309 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15909 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit checks to look for BUG= and TEST= tags in change list ↵kuchhal@chromium.org2009-05-121-2/+6
| | | | | | | | | | | | description (Part 2 of 2). BUG=11287 TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used. Review URL: http://codereview.chromium.org/115261 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15906 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the build errorwtc@chromium.org2009-04-261-1/+1
| | | | | | | | | "Chromium XP :archived build failed". TBR=nsylvain Review URL: http://codereview.chromium.org/99034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14556 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoring - part 4nsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14536 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoring - part 3nsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14535 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoringnsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14532 0039d316-1c4b-4281-b951-d872f2087c98
* Dummy checkin to trigger the bots after the master factory refactoringnsylvain@chromium.org2009-04-251-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14531 0039d316-1c4b-4281-b951-d872f2087c98
* REmove one unneeded seam.maruel@chromium.org2009-04-161-5/+1
| | | | | | Review URL: http://codereview.chromium.org/69019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13853 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the 'Hammer' name in favor of the Debug|Release namessgk@google.com2009-04-011-1/+1
| | | | | | | and paths we'll use in gyp-generated files. Review URL: http://codereview.chromium.org/56158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12975 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r12849 (conversion of "Hammer" names to "Debug").sgk@google.com2009-03-311-1/+1
| | | | | | Review URL: http://codereview.chromium.org/57051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12854 0039d316-1c4b-4281-b951-d872f2087c98
* Replace "Hammer" references with "Debug" as appropriate.sgk@google.com2009-03-311-1/+1
| | | | | | Review URL: http://codereview.chromium.org/53118 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix style in Presubmit.pynsylvain@chromium.org2009-03-151-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11715 0039d316-1c4b-4281-b951-d872f2087c98
* Allow PRESUBMIT.py to handle deleted files.thestig@chromium.org2009-03-131-1/+1
| | | | | | | This is a follow up to Issue 43098. Review URL: http://codereview.chromium.org/42086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11619 0039d316-1c4b-4281-b951-d872f2087c98
* Add exceptions to max_cols rule.maruel@chromium.org2009-03-101-2/+8
| | | | | | Review URL: http://codereview.chromium.org/42019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11340 0039d316-1c4b-4281-b951-d872f2087c98
* Add end of file newline checks to PRESUBMIT.py.deanm@chromium.org2009-03-101-0/+10
| | | | | | | | | | This makes sure that: - Files end in a newline character, this is otherwise a fatal error with GCC. - Files end in only one newline character, and not a bunch of whitespace. Review URL: http://codereview.chromium.org/43017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11330 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable max_cols=80 rule since there's too many source files ↵maruel@chromium.org2009-03-051-2/+6
| | | | | | | | that trigger this rule at the moment. Review URL: http://codereview.chromium.org/39192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10992 0039d316-1c4b-4281-b951-d872f2087c98
* - Add «no trailing whitespace» and <=80 cols rules.maruel@chromium.org2009-03-051-29/+73
| | | | | | | | | | - Remove the invalid import os statement (PRESUBMIT.py shouldn't import anything). - Add excluded paths. Mostly third parties. - Increase what is considered a source file. - Don't check for DO NOT SUBMIT on upload. Review URL: http://codereview.chromium.org/28219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10983 0039d316-1c4b-4281-b951-d872f2087c98
* Very basic starter presubmit script for Chromium, as requested by maruel.maruel@chromium.org2009-02-191-0/+73
At present this checks the following: - No tabs in source files - The words "DO-NOT-SUBMIT" (without the dashes) do not appear in the CL description or in files in the change - No CRLF in source files (.cc, .h, .mm, .py) Limitations: - The general limitations of the current presubmit API implementation apply. One of these is that gcl only walks up to the checkout root searching for presubmit files, so if you've mapped stuff into your client using DEPS, it will only walk up to where the root of that mapping. Patch contributed by Jói. Review: http://codereview.chromium.org/20474 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10015 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 05:27:19 +0000