| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since With this change we will start compiling unit_tests_apk on the main
waterfall, we are making android a default try bot.
To be submitted after we have increased our capacity to handle the extra
load.
BUG=117407
TEST=
Review URL: https://chromiumcodereview.appspot.com/10808022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=git cl presubmit
Review URL: https://chromiumcodereview.appspot.com/10704150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- android doesn't currently build anything in chrome/
so we're changing try job logic to send builds to android
unless the CL was exclusively in chrome/
Previously we would have built on roughly 20% of cls with 'git try'
After this change we will build on roughly 60% of cls (based on last 10k
commits)
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10694029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- clean up logic for determining preferred trybots
- allow windows only CLs to try only on win_rel
- less restrictive filter for mac only CLs
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com/10667007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144372 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
methods while we work through the existing list.
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/10636058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10572054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143389 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10554009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=132984
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10556015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
being allowed to call test-only code.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10535106
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=130980
TEST=browser_tests:FilePathWatcher* are green
Review URL: https://chromiumcodereview.appspot.com/10519003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So when a user does git try -t base_unittests, base_unittests is not run on
linux_clang.
Remove an invalid line added in r125922.
R=thakis@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/10263007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=119550
TEST=Adding new uses of ScopedAllowIO triggers a presubmit warning
Review URL: http://codereview.chromium.org/9826024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The GPU code generates relatively complicated code.
We generate that code and check in the generated files
to make it easy to use codereview to see what was generated
makes sense.
Unfortunately, keeping the generator always generating
lint error free code is hard. We mark lines that have issues
with // NOLINT but that feature has apparently been removed
from our lint so instead we'd just like to have presubmit
ignore *_autogen.h files.
R=maruel@chromium.org
BUG=none
TEST=checked that it did indeed exclude *_autogen.h files
Review URL: http://codereview.chromium.org/9692059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126542 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=thakis@chromium.org
BUG=
TEST=
NOTRY=true
Review URL: http://codereview.chromium.org/7465043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=maruel@chromium.org
BUG=117475
TEST=more trybots get hammered!
Review URL: http://codereview.chromium.org/9651013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=
Review URL: https://chromiumcodereview.appspot.com/9566028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also expand PRESUBMIT.py to include content files (e.g. everything).
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9416117
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/9460063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It's officially dead since Jan. 10 2012
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/9423025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
will add linux_clang automatically.
TEST=Less tree breakage because of not trying changes on clang first.
BUG=None
NOTRY=true
Review URL: http://codereview.chromium.org/9395027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122041 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also add warning in android_all.gyp that extra targets in 'all' can
have a significant impact on the try load so coordinate appropriately.
BUG=None
TEST=
Review URL: http://codereview.chromium.org/9360028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=ben@chromium.org
BUG=112154
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9325016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: http://codereview.chromium.org/9008064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
native_client_sdk uses a different copyright header so it must not be processed by this check.
NOTRY=true
BUG=109004
Review URL: http://codereview.chromium.org/9071009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=groby,ajwong
Review URL: http://codereview.chromium.org/8960011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116072 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add linux_shared to the default try set!
BUG=105750
TEST=none
Review URL: http://codereview.chromium.org/8969030
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/8999027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115443 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105750
TEST=none
Review URL: http://codereview.chromium.org/8969030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sky assures me this will point the devs who hit problems to relevant problems
quickly and more often.
BUG=chromium:107599
TEST=None
TBR=God
NOTRY=true
Review URL: http://codereview.chromium.org/8968019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=God
NOTRY=true
BUG=chromium:107599
TEST=None
Review URL: http://codereview.chromium.org/8818013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
That matches the CQ bots, and they're significantly faster.
The global trybots are added to all subdirectory PRESUBMITs automatically, so remove win, linux, mac from subdirectory PRESUBMITs (instead of changing them too).
BUG=99521
TEST=`git try` creates faster tryjobs.
TBR=willchan (net), akalin (sync)
Review URL: http://codereview.chromium.org/8162009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113979 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
NOTRY=true
Review URL: http://codereview.chromium.org/8812001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bot set.
Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build.
BUG=105750
TEST=none
Review URL: http://codereview.chromium.org/8726043
TBR=ajwong@chromium.org
Review URL: http://codereview.chromium.org/8762005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build.
BUG=105750
TEST=none
Review URL: http://codereview.chromium.org/8726043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=NONE
TEST=NONE
TBR=maruel
Review URL: http://codereview.chromium.org/8687033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111943 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=edit files locally, add random references to the old callback system, and run presubmit.
Review URL: http://codereview.chromium.org/8714008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
rather than FRIEND_TEST() since the former allows tests to be marked FLAKY_/FAILS_/DISABLED_.
Also speed up _CheckNoNewWStrings() a bit.
BUG=NONE
TEST=Attempt to submit a change that includes FRIEND_TEST(). Get scolded.
Review URL: http://codereview.chromium.org/8660006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111699 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
instead of a warning on commit, since there continue to be occasional
fale positives and to fix the last ones the presubmit script would
need to invoke a full C++ parser.
Update the warning text.
BUG=none
TEST=dev tested locally on a specially set-up branch with various
files that tickle the presubmit test.
Review URL: http://codereview.chromium.org/8586024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110690 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8355017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=cmp@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8346021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106313 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
before filename correctly.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8341004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=manual
Review URL: http://codereview.chromium.org/8229016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8137001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104005 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on: http://codereview.chromium.org/7925014/
BUG=none
TEST=Create a CL with only *.mm files: gcl/git try should send only to mac bot. Create a CL that has non-*.mm files: try should send to windows and linux bots too.
Review URL: http://codereview.chromium.org/8046013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7969020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
matched by the whitelist regexp.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7980032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102159 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
We are trying to get rid of wstrings, but new code keeps getting
checked in that adds more. This will help prevent future mistakes.
Review URL: http://codereview.chromium.org/7886019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
testing-only file.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7796039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It was triggering for things like ui/base.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7861006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=94794
TEST=none
Review URL: http://codereview.chromium.org/7792076
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99291 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=manually tested by developer
Review URL: http://codereview.chromium.org/7637015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96768 0039d316-1c4b-4281-b951-d872f2087c98
|