summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Adding Java style presubmit check.aurimas@chromium.org2013-12-101-1/+17
| | | | | | | | BUG=320711 Review URL: https://codereview.chromium.org/110773002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239824 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 239219 - "Revert of https://codereview.chromium.org/104593008/"jochen@chromium.org2013-12-091-0/+1
| | | | | | | | | | | | | | > [breakpad] remove dependency on content_switches.cc > > https://codereview.chromium.org/104593008/ R=noms@chromium.org TBR=joi@chromium.org BUG=none Review URL: https://codereview.chromium.org/110113002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239502 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of https://codereview.chromium.org/104593008/noms@chromium.org2013-12-061-1/+0
| | | | | | | | | | | | Reason for revert: Failed on the waterfall ([ FAILED ] nacl_newlib.run_breakpad_crash_in_syscall_test (250 ms). This error also happened on the trybot. TBR=scottmg@chromium.org,joi@chromium.org,jochen@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/101623005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239219 0039d316-1c4b-4281-b951-d872f2087c98
* [breakpad] remove dependency on content_switches.ccjochen@chromium.org2013-12-061-0/+1
| | | | | | | | | R=joi@chromium.org, scottmg@chromium.org BUG=none Review URL: https://codereview.chromium.org/104593008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239179 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit check for bad anonymous variablesenne@chromium.org2013-12-041-0/+57
| | | | | | | | | | | | | | | | | | These types are all scoped locks and should never be in an anonymous variable. A presubmit check is not watertight, but should go a long way towards avoiding this class of bugs. I ran this check over Chromium and there were no false positives in the codebase. This CL is meant as an alternative to the macro and extra parentheses approach described in https://codereview.chromium.org/71713004/ BUG=none Review URL: https://codereview.chromium.org/100743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238618 0039d316-1c4b-4281-b951-d872f2087c98
* Uninstall multi-install Chrome Frame when updated.grt@chromium.org2013-12-041-0/+1
| | | | | | | | | | | | | | If multi-install Chrome Frame is present when a multi-install install or update is processed, CF is uninstalled prior to ordinary processing. The binaries will be removed if they are not in use. Otherwise, they will stick around until the next update for which they are not in use. BUG=316496 R=robertshield@chromium.org Review URL: https://codereview.chromium.org/96193003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238588 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude chrome_browser_main.cc's printf in PRESUBMIT.py.asvitkine@chromium.org2013-12-041-1/+2
| | | | | | | | | | | | The printf in that file is legitimate, so it shouldn't trigger the warning. BUG=none NOTRY=true Review URL: https://codereview.chromium.org/103133002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238522 0039d316-1c4b-4281-b951-d872f2087c98
* Don't HANDLE_EINTR(close). Either IGNORE_EINTR(close) or just close.mark@chromium.org2013-12-031-1/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It is incorrect to wrap close in HANDLE_EINTR on Linux. Correctness is generally undefined on Mac, but as of r223369, it is incorrect in Chrome on Mac. To avoid new offenders, a PRESUBMIT check ensures that HANDLE_EINTR is not used with close, and that IGNORE_EINTR is only used with close. Unnecessary #includes of eintr_wrapper.h are also removed. base/posix/einter_wrapper.h, PRESUBMIT.py, and ppapi/tests/test_broker.cc contain non-mechanical changes. Variable naming within the latter is updated per r178174. Missing #includes for <errno.h> in content/zygote/zygote_main_linux.cc and tools/android/common/daemon.cc were manually added. Mechanical changes were generated by running: sed -E -i '' \ -e 's/((=|if|return|CHECK|EXPECT|ASSERT).*)HANDLE(_EINTR\(.*close)/\1IGNORE\3/' \ -e 's/(ignore_result|void ?)\(HANDLE_EINTR\((.*close\(.*)\)\)/\2/' \ -e 's/(\(void\) ?)?HANDLE_EINTR\((.*close\(.*)\)/\2/' \ $(git grep -El 'HANDLE_EINTR.*close') sed -E -i '' -e '/#include.*eintr_wrapper\.h"/d' \ $(grep -EL '(HANDLE|IGNORE)_EINTR' \ $(git grep -El '#include.*eintr_wrapper\.h"')) BUG=269623 R=agl@chromium.org, jln@chromium.org TBR=OWNERS Review URL: https://codereview.chromium.org/100253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238390 0039d316-1c4b-4281-b951-d872f2087c98
* Catch printf() in CheckSpamLoggingjln@chromium.org2013-12-021-2/+5
| | | | | | | | R=maruel@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/99653004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238199 0039d316-1c4b-4281-b951-d872f2087c98
* Remove usage of deprecated V8 APIs from c/r/extensionsjochen@chromium.org2013-12-021-0/+2
| | | | | | | | | BUG=324225 R=joi@chromium.org, marja@chromium.org Review URL: https://codereview.chromium.org/98543004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238095 0039d316-1c4b-4281-b951-d872f2087c98
* Add PRESUBMIT disallowing msvs_cygwin_shellscottmg@chromium.org2013-11-291-0/+18
| | | | | | | | | | | | | build/common.gypi now has the default set to 0, avoid using 1 or introducing more uses of manual setting to 0. Only checks the diff, not the full file, so shouldn't be annoying. R=maruel@chromium.org BUG=123026 Review URL: https://codereview.chromium.org/93543002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237855 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for checking DLOG_IF(INFO, ...) in PRESUBMIT.pydanakj@chromium.org2013-11-281-0/+2
| | | | | | | | | | | | This was missed in https://codereview.chromium.org/79173008/ (or really in the original implementation of these checks for cc/). R=ben@chromium.org, thakis BUG=none Review URL: https://codereview.chromium.org/88483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237693 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude sandbox/linux from SpamLogging check and restrict printf check.jln@chromium.org2013-11-271-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | 1. Restrict the printf check to stdout / stderr 2. sandbox/linux uses printf and fprintf for good reason in a few places. None of these would ever spam Chrome's stderr. - Tests inside sandbox/linux have to run within their own small test framework (so that they can run each in their own process). In this framework, fprintf(stderr, XX) can be used to fail a test. - The setuid sandbox is its own command line executable. It uses fprintf. - A small number of tests (2), use fprintf to report kernel status while running the test. It's extremely useful. - The code generator in the BPF compiler was developped without base/ originally. It uses fprintf in a debug mode to print the assembled program. This will only trigger on the equivalent of "compilation errors". R=maruel@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/89073002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237624 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude mojo/examples from production related presubmit checksdarin@chromium.org2013-11-271-0/+2
| | | | | | | | R=joi@chromium.org Review URL: https://codereview.chromium.org/87223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237451 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all usage of LOG(INFO) in Chromoting host with HOST_LOG to bypass ↵weitaosu@chromium.org2013-11-261-1/+2
| | | | | | | | | | the presubmit check. This won't spam the chrome output because the chromoting host code doesn't run in the chrome processes. BUG= Review URL: https://codereview.chromium.org/86523005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237431 0039d316-1c4b-4281-b951-d872f2087c98
* Move CheckSpamLogging from cc's PRESUBMIT into the global PRESUBMITthakis@chromium.org2013-11-221-0/+32
| | | | | | | | | | See thread "[chromium-dev] Say no to excessive debug logging" BUG=none Review URL: https://codereview.chromium.org/79173008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236715 0039d316-1c4b-4281-b951-d872f2087c98
* Make presumbit warnings ignore symbols that start with UNIT_TESTrvargas@chromium.org2013-11-191-1/+1
| | | | | | | | | | | | UNIT_TEST_MODE was being flagged as use of UNIT_TEST on a cc file. NOTRY=true R=joi@chromium.org BUG= Review URL: https://codereview.chromium.org/60573010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235987 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore jni/ paths in _CheckAddedDepsHaveTargetApprovals presubmit check.joi@chromium.org2013-11-141-2/+4
| | | | | | | | | | Improve the implementation so it's easy to add other such directories if/when needed. BUG=none Review URL: https://codereview.chromium.org/72763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235179 0039d316-1c4b-4281-b951-d872f2087c98
* Don't send try jobs to win7_aura since it's a subset of win_rel and will go ↵jam@chromium.org2013-11-121-2/+1
| | | | | | | | | | | away. BUG=316199 R=joi@chromium.org, phajdan.jr@chromium.org, stip@chromium.org Review URL: https://codereview.chromium.org/62213006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234544 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 233509 "Sync PRESUBMIT.py with what is run on CQ."jochen@chromium.org2013-11-071-185/+14
| | | | | | | | | | | | | | | | | | | | This broke git cl try > Sync PRESUBMIT.py with what is run on CQ. > > This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the > New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/. > > BUG=278554 > R=maruel@chromium.org > > Review URL: https://codereview.chromium.org/58803002 TBR=stip@chromium.org Review URL: https://codereview.chromium.org/64473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233609 0039d316-1c4b-4281-b951-d872f2087c98
* Sync PRESUBMIT.py with what is run on CQ.stip@chromium.org2013-11-071-14/+185
| | | | | | | | | | | | This is a repeat of https://chromiumcodereview.appspot.com/11553016/, using the New Advanced Technology™ in https://chromiumcodereview.appspot.com/54373011/. BUG=278554 R=maruel@chromium.org Review URL: https://codereview.chromium.org/58803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233509 0039d316-1c4b-4281-b951-d872f2087c98
* Move Linux/Android breakpad implementation to breakpad componentjochen@chromium.org2013-10-221-1/+1
| | | | | | | | | | | | | Also split up breakpad component in more subdirectories and tighten up DEPS rules BUG=247431 R=rsesek@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/31243002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229964 0039d316-1c4b-4281-b951-d872f2087c98
* switch win_x64_rel to base_unittests so it's not building Allscottmg@chromium.org2013-10-171-1/+1
| | | | | | | | | R=maruel@chromium.org BUG=304877 Review URL: https://codereview.chromium.org/27751002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229252 0039d316-1c4b-4281-b951-d872f2087c98
* Move breakpad_mac* to breakpad componentjochen@chromium.org2013-10-111-0/+1
| | | | | | | | | | BUG=247431 R=joi@chromium.org, rsesek@chromium.org, thakis@chromium.org TBR=mark@chromium.org Review URL: https://codereview.chromium.org/26856002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228167 0039d316-1c4b-4281-b951-d872f2087c98
* Implement presubmit support for _unittest_win includes, etc.erikwright@chromium.org2013-10-091-3/+13
| | | | | | | | | | Without this change, xxx_unittest_win.cc would cause an erroneous presubmit error by including xxx_win.h as its first 'special' include. BUG=None Review URL: https://codereview.chromium.org/26486003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227823 0039d316-1c4b-4281-b951-d872f2087c98
* Run cros_x86 trybots on changes to ^(base|build|chromeos).*\.gypi?$.erg@chromium.org2013-09-301-0/+8
| | | | | | | | | | | | | Since the full chromeos builders are sensitive to high level gypi changes, make sure to do full tryjobs on them in addition to the faster linux_chromeos bots when gyp files change. BUG=none R=maruel@chromium.org, phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/24366005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226033 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude more files from the PRESUBMIT #include check.marja@chromium.org2013-09-201-3/+6
| | | | | | | | | | | These files need to be included out-of-order. BUG=NONE NOTRY=true Review URL: https://chromiumcodereview.appspot.com/24177004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224367 0039d316-1c4b-4281-b951-d872f2087c98
* Don't issue presubmit warning for use of wstrings in Windows-only files.isherman@chromium.org2013-08-291-1/+1
| | | | | | | | | | BUG=none TEST=none R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/22338004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220415 0039d316-1c4b-4281-b951-d872f2087c98
* [content shell] move browser process stuff into browser/ subdirjochen@chromium.org2013-08-201-1/+2
| | | | | | | | | | BUG=180021 R=marja@chromium.org TBR=joi@chromium.org,ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/23316003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218441 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude GPU JSON data files from presubmit checksskyostil@chromium.org2013-08-201-0/+1
| | | | | | | | | | | | | | | | The following GPU source files contain JSON data with long lines, causing them to fail presubmit checks: gpu/config/gpu_driver_bug_list_json.cc gpu/config/gpu_switching_list_json.cc gpu/config/software_rendering_list_json.cc This patch adds them to the presubmit exclusion list so that changes to these files may still be landed using the commit queue. Review URL: https://chromiumcodereview.appspot.com/22891010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218373 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check for tabs in grd files.thestig@chromium.org2013-07-311-0/+5
| | | | | | Review URL: https://chromiumcodereview.appspot.com/19741006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214530 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore +grit entries in DEPS files.tony@chromium.org2013-07-261-14/+21
| | | | | | | | | | | | Sometimes the trailing slash doesn't exist on the DEPS on grit, but we were expecting it. BUG=None R=maruel@chromium.org Review URL: https://codereview.chromium.org/20770002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213989 0039d316-1c4b-4281-b951-d872f2087c98
* add win_x64_rel to default trybotsscottmg@chromium.org2013-07-231-0/+1
| | | | | | | | | R=jschuh,iannucci NOTRY=true Review URL: https://chromiumcodereview.appspot.com/19781004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213014 0039d316-1c4b-4281-b951-d872f2087c98
* Remove mac_asan from default try set because it's consistently failing.ajwong@chromium.org2013-07-191-2/+1
| | | | | | | | | | | It ain't flaky anymore cause it's fails consistently now. TBR=iannucci@chromium.org BUG=245262 Review URL: https://codereview.chromium.org/19873002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212699 0039d316-1c4b-4281-b951-d872f2087c98
* Add the android_aosp trybot to PRESUBMIT.pymkosiba@chromium.org2013-07-021-1/+8
| | | | | | | | | | | This adds the android_aosp trybot to the preferred trybot set. BUG=None NOTRY=true Review URL: https://chromiumcodereview.appspot.com/18367002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209667 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore "incoming" DEPS on grit/ since it is generated code.joi@chromium.org2013-07-011-1/+3
| | | | | | | | | BUG=255149 R=finnur@chromium.org Review URL: https://codereview.chromium.org/18191003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209432 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore hardcoded URLs and ForTest(ing)/for_test(ing) in comments.joi@chromium.org2013-05-231-4/+8
| | | | | | | | | | | | | This addresses a couple of bug reports I've received on these presubmit checks. I also fixed how reviewers_plus_owner is created in _CheckAddedDepsHaveTargetApprovals based on comments on a previous patch. BUG=None Review URL: https://chromiumcodereview.appspot.com/15755002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201792 0039d316-1c4b-4281-b951-d872f2087c98
* Fix _CheckAddedDepsHaveTargetApprovals for the case where no owner has been ↵joi@chromium.org2013-05-221-1/+3
| | | | | | | | | | | specified. TBR=maruel@chromium.org BUG=none Review URL: https://codereview.chromium.org/15491008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201426 0039d316-1c4b-4281-b951-d872f2087c98
* Forbid unwanted Skia ref-counting containersenne@chromium.org2013-05-201-0/+37
| | | | | | | | | | | | | | | | | | | | | | skia::RefPtr is the closest Chromium construct to scoped_refptr and also the safest Skia refcounting class. To avoid other people continually shooting themselves in the face mistaking SkRefPtr for skia::RefPtr (one of which refs the pointer you give it and the other doesn't), ban this in Chromium via global PRESUBMIT. The Skia team also prefers to keep the SkAutoTUnref template private (see discussion here: https://codereview.appspot.com/6849109/), so prefer SkRefPtr over that as well. Finally, SkAutoUnref and SkAutoRef are both templates that support SkRefPtr and SkAutoTUnref, so make sure these are unused as well. R=maruel@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/15063008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201029 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that requires an OWNERS approval from foo/bar/OWNERS ↵joi@chromium.org2013-05-131-0/+72
| | | | | | | | | | | if adding a "+foo/bar" rule to DEPS. BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/15043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199726 0039d316-1c4b-4281-b951-d872f2087c98
* Using explicit checkout local path in presubmit checkdepsalancutter@chromium.org2013-05-091-1/+1
| | | | | | | | | | | | Ensure checkdeps searches the current repository instead of only Chromium's. This is part of enabling checkdeps in Blink. BUG=238992 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/14779012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199296 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude content shell files from the "for testing" presubmit check.jochen@chromium.org2013-05-031-0/+2
| | | | | | | | | | We're using plenty of ...ForTesting() methods to run layout tests R=joi@chromium.org Review URL: https://codereview.chromium.org/14913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198094 0039d316-1c4b-4281-b951-d872f2087c98
* Add "pixeltest" as a test type for presubmit.danakj@chromium.org2013-04-261-1/+1
| | | | | | | | | | | Similar to foo_unittest and foo_browsertest, the compositor also has foo_pixeltest files. R=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/14315013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196796 0039d316-1c4b-4281-b951-d872f2087c98
* Allow test files to use non-platform suffixes for PRESUBMIT checks.danakj@chromium.org2013-04-231-6/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | The current check for deciding if a file is a unittest allows a strict whitelist of platforms as suffixes. However, when a unittest file becomes too large, it is useful to split it on other axes than by platform. This allows a _suffix for a topic to be used without failing production-only presubmit checks. In other words, it considers foo_bar_unittest_baz.cc to be a unittest. There are many examples of foo_unittest_utils.cc which are used only by unit tests throughout chromium, but they have been lucky to avoid using FunctionForTesting type functions. In cc/ we have run into this problem, so allowing our unittests to be considered non-production code prevents false positive warnings about our test files. NOTRY=true R=maruel@chromium.org BUG= Review URL: https://chromiumcodereview.appspot.com/14317011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195780 0039d316-1c4b-4281-b951-d872f2087c98
* Convert an OS_SUN use to OS_SOLARIS.shess@chromium.org2013-04-171-1/+0
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/14101006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194681 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT scripts to use PresubmitPromptOrNotify helper.wez@chromium.org2013-04-021-25/+4
| | | | | | | | NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13093006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191863 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize the simple cache backend at runtime. pasko@google.com2013-04-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We will need to choose the backend at runtime for A/B testing. This change is the first step towards backend comparisons: it moves the logic of choosing among cache backends to a single point (cache_creator.cc) and makes it logically separate from BackendImpl. Next step would be to inject performance-analyzer backend into this cache backend choice logic. The analyzer is going to be under a compile-time flag. With this change the Simple Cache Backend operation gets enabled when the "SimpleCacheTrial" experiment is set. Cache Initialization. The Simple Cache Backend now shares the common initialization/cleanup code. So it can delete inconsistent cache, cache of a different version etc asynchronously. It is just a positive side-effect of moving the backend choice to a single point. The CacheCreator with almost no change. To see the difference: shell> out/Debug/chrome --enable-logging=stderr --v=1 \ --user-data-dir=/tmp/unique --use-simple-cache-backend=on \ http://url 2>&1 | grep "Simple Cache" BUG=173390, 173384 TBR=maruel Review URL: https://chromiumcodereview.appspot.com/12794003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191830 0039d316-1c4b-4281-b951-d872f2087c98
* Remove cc/ from PRESUBMIT.py exception listjamesr@chromium.org2013-03-281-1/+0
| | | | | | | | | | | This directory should now always pass chromium's PRESUBMITs BUG=144577 NOTRY=true Review URL: https://chromiumcodereview.appspot.com/13201005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191184 0039d316-1c4b-4281-b951-d872f2087c98
* Adding _Check* function for invalid OS_MACROs in src/PRESUBMIT.pydbeam@chromium.org2013-03-261-0/+70
| | | | | | | | | | | | R=maruel@chromium.org BUG=none CONTEXT=http://goo.gl/hrlj1 TEST=PRESUBMIT_test.py and less OS_MAXOSX! NOTRY=true Review URL: https://chromiumcodereview.appspot.com/12845013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190693 0039d316-1c4b-4281-b951-d872f2087c98
* Remove webkit/compositor_bindings from PRESUBMIT exclusion listjamesr@chromium.org2013-03-191-1/+0
| | | | | | | | | | | | | | This was added when initially importing this code from WebKit that didn't comply with chromium's style rules. This code now passes lint and presubmit checks so there's no need for the exclusion. NOTRY=true BUG=144577 Review URL: https://chromiumcodereview.appspot.com/12695010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189029 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2024-10-27 20:16:27 +0000