summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Here are gyp targets and stubs for compiling libcc and the webkit_compositor ↵jamesr@chromium.org2012-08-251-0/+1
| | | | | | | | | | | | bindings in chromium. Everything is guarded behind the off-by-default use_libcc_for_compositor gyp variable. I haven't included the actual code here, but there are scripts to sync. I plan to land + manually sync the code into place until we're ready to flip the gyp switch. Snapshot from r126652 BUG= Review URL: https://chromiumcodereview.appspot.com/10828381 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153354 0039d316-1c4b-4281-b951-d872f2087c98
* Give access to browsers by Profile/HostDesktopType.mad@chromium.org2012-08-241-9/+0
| | | | | | | | | | | | | And fix existing callers of FindBrowserForProfile. BUG=None TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152788 Review URL: https://chromiumcodereview.appspot.com/10855183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153207 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 152788 - Give access to browsers by Profile/HostDesktopType.mad@chromium.org2012-08-221-0/+9
| | | | | | | | | | | | | | And fix existing callers of FindBrowserForProfile. BUG=None TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API). Review URL: https://chromiumcodereview.appspot.com/10855183 TBR=mad@chromium.org Review URL: https://chromiumcodereview.appspot.com/10870014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152790 0039d316-1c4b-4281-b951-d872f2087c98
* Give access to browsers by Profile/HostDesktopType.mad@chromium.org2012-08-221-9/+0
| | | | | | | | | | | And fix existing callers of FindBrowserForProfile. BUG=None TEST=Make sure that the page cyclers still work (they're one of the users of the API), as well as the download page gets opened properly on the Mac when the user chooses to wait (the other user of the API). Review URL: https://chromiumcodereview.appspot.com/10855183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152788 0039d316-1c4b-4281-b951-d872f2087c98
* Don't block CQ usage when includes that violate temporarily-allowedjoi@chromium.org2012-08-211-1/+7
| | | | | | | | | | | | | | DEPS rules are added. Includes that violate permant rules are still errors, and on upload there is still a prompt, so the author of the change will definitely know about the problem. BUG=138280 Review URL: https://chromiumcodereview.appspot.com/10855266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152581 0039d316-1c4b-4281-b951-d872f2087c98
* Over the last week (or so) a couple of CLs had to be reverted because ↵saintlou@chromium.org2012-08-101-3/+6
| | | | | | | | | | | | | | developers had not tested win_aura, specifically: 1. The default trybot rules don't include win_aura in enough cases 2. The CQ did not build win_aura BUG=141701 TBR=sky Review URL: https://chromiumcodereview.appspot.com/10831242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150950 0039d316-1c4b-4281-b951-d872f2087c98
* Add permission checking to the presumit checks.csharp@chromium.org2012-08-081-0/+18
| | | | | | | | | BUG=71975 Review URL: https://chromiumcodereview.appspot.com/10831194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150557 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaned up usage of std::wstring in src/remoting. Added presubmit warning ↵alexeypa@chromium.org2012-08-071-2/+9
| | | | | | | | | | | supressions for the remaning instances because they depend on hard-to-change public APIs. BUG=133003 Review URL: https://chromiumcodereview.appspot.com/10824166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150224 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_chromeos and linux_chromeos_clang as preferred try bots whenever ↵joaodasilva@chromium.org2012-08-021-3/+5
| | | | | | | | | | chromeos files are modified. TBR=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10827137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149616 0039d316-1c4b-4281-b951-d872f2087c98
* Add checkdeps presubmit check. Warns on new #includes of dependenciesjoi@chromium.org2012-07-311-0/+55
| | | | | | | | | | | we are working to eliminate, and errors on new #includes of disallowed dependencies. BUG=138280 Review URL: https://chromiumcodereview.appspot.com/10806049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149167 0039d316-1c4b-4281-b951-d872f2087c98
* Alters test field requirement in change descriptionjamesr@chromium.org2012-07-261-2/+0
| | | | | | | | | | | | | This seems to have outlived its usefulness. NOTRY=true BUG=none TEST=lol Review URL: https://chromiumcodereview.appspot.com/10826040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148666 0039d316-1c4b-4281-b951-d872f2087c98
* Add unit_tests bundle as a default compile target for Android.nileshagrawal@chromium.org2012-07-191-4/+2
| | | | | | | | | | | | | | | | Since With this change we will start compiling unit_tests_apk on the main waterfall, we are making android a default try bot. To be submitted after we have increased our capacity to handle the extra load. BUG=117407 TEST= Review URL: https://chromiumcodereview.appspot.com/10808022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147453 0039d316-1c4b-4281-b951-d872f2087c98
* Add presubmit check for #pragma once.dcheng@chromium.org2012-07-111-2/+22
| | | | | | | | | BUG=none TEST=git cl presubmit Review URL: https://chromiumcodereview.appspot.com/10704150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146166 0039d316-1c4b-4281-b951-d872f2087c98
* Change PRESUBMIT to try more cls on androidilevy@chromium.org2012-06-291-3/+4
| | | | | | | | | | | | | | | | | | - android doesn't currently build anything in chrome/ so we're changing try job logic to send builds to android unless the CL was exclusively in chrome/ Previously we would have built on roughly 20% of cls with 'git try' After this change we will build on roughly 60% of cls (based on last 10k commits) BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10694029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144841 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict try bots for platform specific CLsilevy@chromium.org2012-06-271-29/+19
| | | | | | | | | | | | | - clean up logic for determining preferred trybots - allow windows only CLs to try only on win_rel - less restrictive filter for mac only CLs BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10667007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144372 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check to stop any more usages of harmful browser::Find* ↵jam@chromium.org2012-06-261-5/+50
| | | | | | | | | methods while we work through the existing list. BUG=129187 Review URL: https://chromiumcodereview.appspot.com/10636058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144245 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit warning for not using UNIT_TEST in source files.jam@chromium.org2012-06-211-0/+18
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10572054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143389 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify PRESUBMITs.avi@chromium.org2012-06-161-85/+43
| | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10554009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142608 0039d316-1c4b-4281-b951-d872f2087c98
* Added presubmit warnings about base coordinate system.avi@chromium.org2012-06-161-0/+113
| | | | | | | | | | BUG=132984 TEST=none Review URL: https://chromiumcodereview.appspot.com/10556015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142578 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit check to account for e.g. fooblat_unittest_android.ccjoi@chromium.org2012-06-111-1/+3
| | | | | | | | | | | being allowed to call test-only code. BUG=none Review URL: https://chromiumcodereview.appspot.com/10535106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141558 0039d316-1c4b-4281-b951-d872f2087c98
* Added a base::Callback interface to FilePathWatcher.joaodasilva@chromium.org2012-06-041-0/+18
| | | | | | | | | BUG=130980 TEST=browser_tests:FilePathWatcher* are green Review URL: https://chromiumcodereview.appspot.com/10519003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140285 0039d316-1c4b-4281-b951-d872f2087c98
* Fix linux_clang default try builder to only compile and not run tests.maruel@chromium.org2012-05-071-4/+1
| | | | | | | | | | | | | | | | So when a user does git try -t base_unittests, base_unittests is not run on linux_clang. Remove an invalid line added in r125922. R=thakis@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/10263007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135696 0039d316-1c4b-4281-b951-d872f2087c98
* Added presubmit warning for ScopedAllowIO usesjoaodasilva@chromium.org2012-03-221-0/+18
| | | | | | | | | | BUG=119550 TEST=Adding new uses of ScopedAllowIO triggers a presubmit warning Review URL: http://codereview.chromium.org/9826024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128312 0039d316-1c4b-4281-b951-d872f2087c98
* Make presubmit ignore files that end in _autogen.hgman@chromium.org2012-03-141-0/+1
| | | | | | | | | | | | | | | | | | | | | | The GPU code generates relatively complicated code. We generate that code and check in the generated files to make it easy to use codereview to see what was generated makes sense. Unfortunately, keeping the generator always generating lint error free code is hard. We mark lines that have issues with // NOLINT but that feature has apparently been removed from our lint so instead we'd just like to have presubmit ignore *_autogen.h files. R=maruel@chromium.org BUG=none TEST=checked that it did indeed exclude *_autogen.h files Review URL: http://codereview.chromium.org/9692059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126542 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_clang to default try jobsmaruel@chromium.org2012-03-091-0/+1
| | | | | | | | | | | R=thakis@chromium.org BUG= TEST= NOTRY=true Review URL: http://codereview.chromium.org/7465043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125922 0039d316-1c4b-4281-b951-d872f2087c98
* Add a win_dbg:compile bot to the default set to cover the shared build.dpranke@chromium.org2012-03-091-1/+2
| | | | | | | | | | | R=maruel@chromium.org BUG=117475 TEST=more trybots get hammered! Review URL: http://codereview.chromium.org/9651013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125841 0039d316-1c4b-4281-b951-d872f2087c98
* Update PRESUBMIT.py to be less likely to hit the android bot.jrg@google.com2012-03-011-1/+22
| | | | | | | | | BUG=None TEST= Review URL: https://chromiumcodereview.appspot.com/9566028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124485 0039d316-1c4b-4281-b951-d872f2087c98
* Android build: move content_unittests to default target.jrg@chromium.org2012-02-291-14/+1
| | | | | | | | | | | | Also expand PRESUBMIT.py to include content files (e.g. everything). BUG=None TEST= Review URL: http://codereview.chromium.org/9416117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124108 0039d316-1c4b-4281-b951-d872f2087c98
* Add *_test_util.* to whitelist for test-only presubmit check.joi@chromium.org2012-02-281-1/+1
| | | | | | | | | BUG=none Review URL: http://codereview.chromium.org/9460063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123871 0039d316-1c4b-4281-b951-d872f2087c98
* PRESUBMIT doesn't need to check for old callback systemgroby@chromium.org2012-02-191-30/+0
| | | | | | | | | | | | It's officially dead since Jan. 10 2012 BUG=none TEST=none Review URL: http://codereview.chromium.org/9423025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122702 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_clang to default try set so when one runs `git try` or `gcl try` itdbeam@chromium.org2012-02-151-5/+7
| | | | | | | | | | | | will add linux_clang automatically. TEST=Less tree breakage because of not trying changes on clang first. BUG=None NOTRY=true Review URL: http://codereview.chromium.org/9395027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122041 0039d316-1c4b-4281-b951-d872f2087c98
* Presubmit change to add android trybots when needed.jrg@chromium.org2012-02-101-0/+13
| | | | | | | | | | | | | Also add warning in android_all.gyp that extra targets in 'all' can have a significant impact on the try load so coordinate appropriately. BUG=None TEST= Review URL: http://codereview.chromium.org/9360028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121560 0039d316-1c4b-4281-b951-d872f2087c98
* Renamed old bot to existing trybot.saintlou@chromium.org2012-02-031-1/+1
| | | | | | | | | | TBR=ben@chromium.org BUG=112154 TEST=none Review URL: https://chromiumcodereview.appspot.com/9325016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120259 0039d316-1c4b-4281-b951-d872f2087c98
* Fix test for files starting with test_ and mock_ for Windows.joi@chromium.org2012-01-041-1/+1
| | | | | | | | | BUG=none Review URL: http://codereview.chromium.org/9008064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116345 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bugs in PRESUBMIT.py's file exclusions.wez@chromium.org2012-01-031-2/+3
| | | | | | | | | | | | native_client_sdk uses a different copyright header so it must not be processed by this check. NOTRY=true BUG=109004 Review URL: http://codereview.chromium.org/9071009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116143 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Remove NewRunnableFunction.jhawkins@chromium.org2012-01-011-1/+0
| | | | | | | | | | BUG=none TEST=none R=groby,ajwong Review URL: http://codereview.chromium.org/8960011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116072 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 114877 (infrastructure can't handle the load, see bug)thakis@chromium.org2011-12-211-1/+1
| | | | | | | | | | | | | | | - Add linux_shared to the default try set! BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8969030 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/8999027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115443 0039d316-1c4b-4281-b951-d872f2087c98
* Add linux_shared to the default try set!thakis@chromium.org2011-12-161-1/+1
| | | | | | | | | | BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8969030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114877 0039d316-1c4b-4281-b951-d872f2087c98
* Update the aura tester used to the linux_chromeos_aura.petermayo@chromium.org2011-12-161-1/+1
| | | | | | | | | | | | | | Sky assures me this will point the devs who hit problems to relevant problems quickly and more often. BUG=chromium:107599 TEST=None TBR=God NOTRY=true Review URL: http://codereview.chromium.org/8968019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114830 0039d316-1c4b-4281-b951-d872f2087c98
* Add aura compile testing by default to likely areas (1).petermayo@chromium.org2011-12-141-1/+8
| | | | | | | | | | | TBR=God NOTRY=true BUG=chromium:107599 TEST=None Review URL: http://codereview.chromium.org/8818013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114490 0039d316-1c4b-4281-b951-d872f2087c98
* Switch the default `git try` / `gcl try` bots to _rel.thakis@chromium.org2011-12-121-4/+4
| | | | | | | | | | | | | | That matches the CQ bots, and they're significantly faster. The global trybots are added to all subdirectory PRESUBMITs automatically, so remove win, linux, mac from subdirectory PRESUBMITs (instead of changing them too). BUG=99521 TEST=`git try` creates faster tryjobs. TBR=willchan (net), akalin (sync) Review URL: http://codereview.chromium.org/8162009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113979 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the presubmit check for empty descriptions.thestig@chromium.org2011-12-051-0/+2
| | | | | | | | | | BUG=none TEST=none NOTRY=true Review URL: http://codereview.chromium.org/8812001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113063 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112034 - Add win_shared and linux_shared builder into the default try ↵ajwong@chromium.org2011-11-301-1/+1
| | | | | | | | | | | | | | | | bot set. Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build. BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8726043 TBR=ajwong@chromium.org Review URL: http://codereview.chromium.org/8762005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112317 0039d316-1c4b-4281-b951-d872f2087c98
* Add win_shared and linux_shared builder into the default try bot set.ajwong@chromium.org2011-11-291-1/+1
| | | | | | | | | | | Component builds breakages are easy to introduce because you can accidentally add a cross-component dependency without any warning if you're doing a normal static build. BUG=105750 TEST=none Review URL: http://codereview.chromium.org/8726043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112034 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in FRIEND_TEST presubmit nag.robertshield@chromium.org2011-11-291-1/+1
| | | | | | | | | BUG=NONE TEST=NONE TBR=maruel Review URL: http://codereview.chromium.org/8687033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111943 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit to find new uses of the old callback system.dcheng@chromium.org2011-11-281-0/+31
| | | | | | | | | BUG=none TEST=edit files locally, add random references to the old callback system, and run presubmit. Review URL: http://codereview.chromium.org/8714008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111729 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit check that enforces the use of FRIEND_TEST_ALL_PREFIXES() ↵robertshield@chromium.org2011-11-281-4/+24
| | | | | | | | | | | | rather than FRIEND_TEST() since the former allows tests to be marked FLAKY_/FAILS_/DISABLED_. Also speed up _CheckNoNewWStrings() a bit. BUG=NONE TEST=Attempt to submit a change that includes FRIEND_TEST(). Get scolded. Review URL: http://codereview.chromium.org/8660006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111699 0039d316-1c4b-4281-b951-d872f2087c98
* ForTest presubmit check non-failing for CQ by making it just a messagejoi@chromium.org2011-11-181-5/+15
| | | | | | | | | | | | | | | | instead of a warning on commit, since there continue to be occasional fale positives and to fix the last ones the presubmit script would need to invoke a full C++ parser. Update the warning text. BUG=none TEST=dev tested locally on a specially set-up branch with various files that tickle the presubmit test. Review URL: http://codereview.chromium.org/8586024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110690 0039d316-1c4b-4281-b951-d872f2087c98
* Add a couple of things to the whitelist as requested. Refactor.joi@chromium.org2011-10-201-5/+12
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8355017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106455 0039d316-1c4b-4281-b951-d872f2087c98
* Try to annoy users with a presubmit check when they hack around .DEPS.gitmaruel@chromium.org2011-10-191-0/+14
| | | | | | | | | | | R=cmp@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8346021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106313 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-13 11:58:19 +0000