summaryrefslogtreecommitdiffstats
path: root/PRESUBMIT.py
Commit message (Collapse)AuthorAgeFilesLines
* Remove from PRESUBMIT.py builders that will get removed from the tryserverphajdan.jr@chromium.org2014-06-091-53/+0
| | | | | | | | | | | See https://codereview.chromium.org/323483002/ BUG=380709 R=kjellander@chromium.org Review URL: https://codereview.chromium.org/320823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275798 0039d316-1c4b-4281-b951-d872f2087c98
* Write "logout-started" event on next boot.alemate@chromium.org2014-06-031-0/+1
| | | | | | | | | | | | Writing logout-started on process exit is unstable. So moving it to next boot. BUG=352130 TEST=manual Review URL: https://codereview.chromium.org/303233004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274649 0039d316-1c4b-4281-b951-d872f2087c98
* Add global presubmit that JSON and IDL files can be parsed.yoz@chromium.org2014-06-031-0/+101
| | | | | | | | | | | | | Sometimes, changes to JSON/IDL files make them invalid. It's easier to check these at presubmit time than discovering they can't be parsed at runtime. This just moves the check from chrome/common/extensions/api to top-level. This presubmit check excludes files in test/data directories. BUG=366395 Review URL: https://codereview.chromium.org/239283008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274432 0039d316-1c4b-4281-b951-d872f2087c98
* Delete old mini_installer_test.grt@chromium.org2014-06-021-1/+1
| | | | | | | | | | And run the new Python-driven test_mini_installer on win_rel trybot. BUG=277655 Review URL: https://codereview.chromium.org/301223007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274260 0039d316-1c4b-4281-b951-d872f2087c98
* Update path of checkdeps to buildtools checkoutjochen@chromium.org2014-05-291-1/+1
| | | | | | | | | BUG=none R=brettw@chromium.org Review URL: https://codereview.chromium.org/305633007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273587 0039d316-1c4b-4281-b951-d872f2087c98
* Blacklist some file for the CSS deprecation hookjchaffraix@chromium.org2014-05-221-2/+12
| | | | | | | | | | | There are some documentation in the Chromium tree that is meant for external consumption (which includes WebKit) so it can't use the unprefixed CSS properties / values or functions. Review URL: https://codereview.chromium.org/294893003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272027 0039d316-1c4b-4281-b951-d872f2087c98
* Add check to make sure to make surethe production code is not calling a ↵oshima@chromium.org2014-05-141-2/+2
| | | | | | | | | | | function in test namespace BUG=None NOTRY=true Review URL: https://codereview.chromium.org/285623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270300 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser test for CustomizationWallpaperDownloader.alemate@chromium.org2014-05-121-0/+1
| | | | | | | | | | | | | | | Also implements TestURLFetcher::SaveResponseToTemporaryFile(), and explicitly allows ScopedIO in TestURLFetcher, as it doesn't support asynchronous IO by design. Note to tree sheriffs: this CL can break tests using FakeURLFetcherFactory. BUG=366614 TEST=none Review URL: https://codereview.chromium.org/253833006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269907 0039d316-1c4b-4281-b951-d872f2087c98
* Added mac_gpu to the default set of try servers.kbr@chromium.org2014-05-091-0/+3
| | | | | | | | | | | | | | mac_gpu is already experimentally receiving a percentage of the Chromium and Blink CQs' load, and the hardware has just been fully built out. Expand its testing to cover manually submitted try jobs. BUG=327170 R=phajdan.jr@chromium.org,maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/269313009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269410 0039d316-1c4b-4281-b951-d872f2087c98
* Add a presubmit hook for deprecated CSSjchaffraix@chromium.org2014-05-091-0/+39
| | | | | | | | | | | | | | | | | Chromium's resources are using a gazillion deprecated CSS properties, functions or values. This is bothering as Blink's UseCounter doesn't discriminate between chrome:// pages and web pages so they get counted. But more conceptually, Chromium's developers should be leading the way and not use some CSS that was deprecated 2+ years ago. The initial list only contains items with an unprefixed counterpart. Review URL: https://codereview.chromium.org/261773009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269149 0039d316-1c4b-4281-b951-d872f2087c98
* Add GN bots to default try set to match the CQ.dpranke@chromium.org2014-05-071-0/+4
| | | | | | | | | R=brettw@chromium.org, phajdan.jr@chromium.org BUG=353690 Review URL: https://codereview.chromium.org/263293004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268748 0039d316-1c4b-4281-b951-d872f2087c98
* Added win_gpu to the default set of try servers.kbr@chromium.org2014-04-301-0/+3
| | | | | | | | | | | | | | win_gpu is already experimentally receiving a percentage of the Chromium and Blink CQs' load. Expand its testing to cover manually submitted try jobs. BUG=327170 R=phajdan.jr@chromium.org,maruel@chromium.org TBR=darin@chromium.org Review URL: https://codereview.chromium.org/258233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267023 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 265881 - "Add simple PRESUBMIT check to ensure that all files ending ↵yoz@chromium.org2014-04-251-16/+0
| | | | | | | | | | | | | | | with .json can" Revert 266019 - "Add detail to 'invalid JSON' message in PRESUBMIT.py." This presubmit check is invalid - it fails on existing .json files in the tree that contain comments. (Other JSON-reading tools strip out these comments.) Any changes to these .json files are incorrectly rejected by this check. BUG=366395 TBR=iannucci@chromium.org,tnagel@chromium.org Review URL: https://codereview.chromium.org/252713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266191 0039d316-1c4b-4281-b951-d872f2087c98
* Add detail to 'invalid JSON' message in PRESUBMIT.py.tnagel@chromium.org2014-04-241-2/+3
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/255613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266019 0039d316-1c4b-4281-b951-d872f2087c98
* Add simple PRESUBMIT check to ensure that all files ending with .json caniannucci@chromium.org2014-04-241-0/+15
| | | | | | | | | | | be loaded as json. R=jochen@chromium.org, maruel@chromium.org BUG=366395 Review URL: https://codereview.chromium.org/258473002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265881 0039d316-1c4b-4281-b951-d872f2087c98
* Added linux_gpu to the default set of try servers.kbr@chromium.org2014-04-231-9/+23
| | | | | | | | | | | | | | | This configuration is already experimentally receiving 100% of the Chromium and Blink CQs' load. Expand its testing to cover manually submitted try jobs as well. As a side-effect, added multi-master support to GetDefaultTryConfigs. Tested manually. BUG=327170 Review URL: https://codereview.chromium.org/242963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265455 0039d316-1c4b-4281-b951-d872f2087c98
* Move extensions bindings code out of //chromerockot@chromium.org2014-04-171-2/+1
| | | | | | | | | | | | | | | | | | | | This moves several native handlers out of //chrome/renderer/extensions and into //extensions/renderer. Many of the changes are mechanical. Where applicable, ChromeV8Extension has been wiped out. BUG=359836 R=yoz@chromium.org TBR=reed@google.com for skia +DEPS TBR=ericu@chromium.org for fileapi +DEPS TBR=eseidel@chromium.org for WebKit/public/platform +DEPS TBR=sky@chromium.org for chrome/test TBR=maruel@chromium.org for PRESUBMIT.py Review URL: https://codereview.chromium.org/235943018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264413 0039d316-1c4b-4281-b951-d872f2087c98
* Enable use of regular expressions in banned obj-c function list.leng@chromium.org2014-04-161-2/+9
| | | | | | | | | | | Uses the regex to allow use of NSTrackingAreaOptions, while still banning NSTrackingArea. BUG=None Review URL: https://codereview.chromium.org/237463003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@264109 0039d316-1c4b-4281-b951-d872f2087c98
* Sync PRESUBMIT with CQ: win_x64_rel -> win_chromium_x64_relphajdan.jr@chromium.org2014-04-151-1/+2
| | | | | | | | | BUG=358130 R=maruel@chromium.org Review URL: https://codereview.chromium.org/239223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263891 0039d316-1c4b-4281-b951-d872f2087c98
* Sync PRESUBMIT files with latest CQ changesphajdan.jr@chromium.org2014-04-151-2/+4
| | | | | | | | | BUG=none R=maruel@chromium.org Review URL: https://codereview.chromium.org/237383002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263810 0039d316-1c4b-4281-b951-d872f2087c98
* Move most of ChromeV8Context to a base ScriptContextrockot@chromium.org2014-04-121-1/+3
| | | | | | | | | | | | | | | | | | This also moves ModuleSystem, RequestSender, ObjectBackedNativeHandler, and SafeBuiltins over to //extensions. Other renderer code is updated minimally to support these changes. BUG=359836 TBR=sky@chromium.org for chrome/test TBR=jamescook@chromium.org for apps/shell TBR=maruel@chromium.org for PRESUBMIT.py Review URL: https://codereview.chromium.org/234413005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263429 0039d316-1c4b-4281-b951-d872f2087c98
* Update content/shell/common/test_runner to chromium coding stylejochen@chromium.org2014-04-041-1/+0
| | | | | | | | | | BUG=331299 TBR=maruel@chromium.org R=marja@chromium.org Review URL: https://codereview.chromium.org/225543003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261881 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure no new v8::Extensions are added.jochen@chromium.org2014-04-041-0/+9
| | | | | | | | | | | New code should use gin::Wrappable<> instead BUG=334679 R=maruel@chromium.org Review URL: https://codereview.chromium.org/225863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261804 0039d316-1c4b-4281-b951-d872f2087c98
* Removing my contact details from PRESUBMIT.pyjoi@chromium.org2014-03-271-3/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/214703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259914 0039d316-1c4b-4281-b951-d872f2087c98
* [NaCl SDK] nacl_io: Add support for JavaScript handshake on exitsbc@chromium.org2014-03-241-0/+1
| | | | | | | | | | | | | | | | | | Without this _exit() can lose messages that are still in transit to JavaScript. Also, fix using_ppapi_simple example. Exclude native_client_sdk from PRESUBMIT check on stdout/stderr. The code here doesn't get built into chrome itself. BUG=337584 R=binji@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/152743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258953 0039d316-1c4b-4281-b951-d872f2087c98
* Mojo: Add a simple platform-level shared memory implementation.viettrungluu@chromium.org2014-03-211-0/+1
| | | | | | | | | | | | | | | (Unfortunately, base::SharedMemory doesn't quite meet our needs right now, and it'll be a while -- if ever -- before I manage to refactor it so that it does.) Not yet implemented on Windows. (This should be simple, but I'll do it separately.) R=darin@chromium.org Review URL: https://codereview.chromium.org/205583008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258667 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily disable swarming jobs.maruel@chromium.org2014-03-201-3/+4
| | | | | | | | | | | | | The failure rate is currently unacceptably high. Disabling normal runs will permits us to run more perf tests on the prod instance. R=vadimsh@chromium.org BUG=354263 NOTRY=true Review URL: https://codereview.chromium.org/206773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258382 0039d316-1c4b-4281-b951-d872f2087c98
* Change asan builders to only set compile by default.stip@chromium.org2014-03-191-2/+3
| | | | | | | | BUG=354052 Review URL: https://codereview.chromium.org/204753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258121 0039d316-1c4b-4281-b951-d872f2087c98
* Remove X11 and GTK dependencies from host_forwarderzhenyu.liang@intel.com2014-03-191-0/+1
| | | | | | | | | | Use libevent as the implementation of MessagePumpForUI. BUG=346113 Review URL: https://codereview.chromium.org/176713005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257853 0039d316-1c4b-4281-b951-d872f2087c98
* More sync of PRESUBMIT with what CQ runsphajdan.jr@chromium.org2014-03-131-9/+2
| | | | | | | | | | | | | | | | | This removes some configs that were here below in an attempt to reduce the tryserver load. They can be added later slowly after we verify they don't cause unnecessary load. Note that CQ was not checking them anyway, so they were losing at least 50% CL coverage. TBR=maruel BUG=317931 Review URL: https://codereview.chromium.org/198333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256739 0039d316-1c4b-4281-b951-d872f2087c98
* Change top-level PRESUBMIT to support split tryserverphajdan.jr@chromium.org2014-03-121-11/+20
| | | | | | | | | | | | | This also fixes problems with generic trybots not being triggered when other presubmit files which already support multiple masters get in scope. BUG=334892 R=maruel@chromium.org Review URL: https://codereview.chromium.org/197963003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256698 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land: Change the user action file format from .txt to .xml.yiyaoliu@chromium.org2014-03-071-10/+14
| | | | | | | | | | | | | | | In this way, more information can be added (currently added 'description' and 'owner' for each action) A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. CL 149503005 broke in http://crrev.com/255357. Add a patch to fix histograms presubmit. BUG=340735 NOTRY=true Review URL: https://codereview.chromium.org/180743027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255680 0039d316-1c4b-4281-b951-d872f2087c98
* Fix UserAction presubmit incorrectly not matching existing actions.tedchoc@chromium.org2014-03-071-1/+1
| | | | | | | | | | BUG=340735 TBR=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/189783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255530 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 255357 "Change the user action file format from .txt to ...."dcaiafa@google.com2014-03-061-14/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Believed to be behind the failures in the Linux builder: http://build.chromium.org/p/chromium/builders/Linux/builds/47996 Errors in the log: .../actions/print_style.py: Has executable bit but not shebang or ELF header .../histograms/print_style.py: Has executable bit but not shebang or ELF header Refers to files in the CL. > Change the user action file format from .txt to .xml. > > In this way, more information can be added (currently added 'description' and 'owner' for each action) > > A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. > > BUG=340735 > NOTRY=true > > Review URL: https://codereview.chromium.org/149503005 TBR=yiyaoliu@chromium.org Review URL: https://codereview.chromium.org/188793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255404 0039d316-1c4b-4281-b951-d872f2087c98
* Change the user action file format from .txt to .xml.yiyaoliu@chromium.org2014-03-061-10/+14
| | | | | | | | | | | | | In this way, more information can be added (currently added 'description' and 'owner' for each action) A few functions are moved from tools/metrics/histograms to tools/metrics/common to be shared by tools/metrics and tools/histograms. BUG=340735 NOTRY=true Review URL: https://codereview.chromium.org/149503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@255357 0039d316-1c4b-4281-b951-d872f2087c98
* Add user action check to general presubmit.yiyaoliu@chromium.org2014-03-031-0/+29
| | | | | | | | BUG=340735 Review URL: https://codereview.chromium.org/179993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254543 0039d316-1c4b-4281-b951-d872f2087c98
* Add UMA stats to record when DLLs are successfully blocked in the Browser.csharp@chromium.org2014-03-031-0/+1
| | | | | | | | BUG=345287 Review URL: https://codereview.chromium.org/174013007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254480 0039d316-1c4b-4281-b951-d872f2087c98
* Fix presubmit after my latest changesphajdan.jr@chromium.org2014-02-271-9/+11
| | | | | | | | | | | | | | | This is a follow-up to https://codereview.chromium.org/179453003/ Removing CheckRietveldTryJobExecution because the implementation is currently empty anyway and the trybot config will become more and more dynamic so that static list is becoming less and less accurate. BUG=317931 R=maruel@chromium.org Review URL: https://codereview.chromium.org/183623002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253896 0039d316-1c4b-4281-b951-d872f2087c98
* Update presubmit default trybots to be more similar to CQ configphajdan.jr@chromium.org2014-02-271-42/+7
| | | | | | | | | BUG=317931 R=maruel@chromium.org Review URL: https://codereview.chromium.org/179453003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253867 0039d316-1c4b-4281-b951-d872f2087c98
* Add gfx_unittests to trybot list for mac and windows.stip@chromium.org2014-02-271-1/+2
| | | | | | | | BUG=331829, 299841 Review URL: https://codereview.chromium.org/178153005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253820 0039d316-1c4b-4281-b951-d872f2087c98
* Only run Java checkstyle on Upload and not Submit.aurimas@chromium.org2014-02-201-1/+1
| | | | | | | | | BUG=None NOTRY=true Review URL: https://codereview.chromium.org/171773007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252207 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude vulcanize-generated HTML/JS from PRESUBMIT.py checksraymes@google.com2014-02-191-0/+1
| | | | | | | | | | | | | These files are automatically generated for the PDF extension. The long term solution is not to check in vulcanize-generated files. These files may not be needed once HTMLImports are fully implemented in chrome. BUG=303491 R=arv@chromium.org, maruel@chromium.org Review URL: https://codereview.chromium.org/154223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/cloud_print from _CheckSpamLogging.vitalybuka@chromium.org2014-02-111-0/+1
| | | | | | | | | | None of src/cloud_print is part of chrome binary. NOTRY=true Review URL: https://codereview.chromium.org/159933005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250550 0039d316-1c4b-4281-b951-d872f2087c98
* Exclude tools/ from console spam PRESUBMITscottmg@chromium.org2014-02-111-2/+1
| | | | | | | | | | tools/ are often standalone or intended to interact with console output. R=maruel@chromium.org Review URL: https://codereview.chromium.org/130263011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250455 0039d316-1c4b-4281-b951-d872f2087c98
* Swap linux_aura for linux_gtk in PRESUBMIT try stuff.agable@chromium.org2014-02-071-13/+6
| | | | | | | | | | | | | Needs to land at the same time as the master restart for https://codereview.chromium.org/151393003/ BUG=336581 NOTRY=true R=phajdan.jr@chromium.org Review URL: https://codereview.chromium.org/147233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249591 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for threading and atomic ops in QNX Neutrino.ctruta@blackberry.com2014-02-061-0/+1
| | | | | | | | | | | | | BUG= Patch by: Eli Fidler <efidler@blackberry.com>, Jeff Rogers <jrogers@blackberry.com>, Cosmin Truta <ctruta@blackberry.com>. Review URL: https://codereview.chromium.org/156233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249390 0039d316-1c4b-4281-b951-d872f2087c98
* Skip _CheckFilePermissions check on Windowsadamk@chromium.org2014-02-031-0/+2
| | | | | | | | | | | | Executable bits are wonky on Windows, so checking them doesn't get us anything and incorrectly disallows uploading of, e.g., python scripts. R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/142973008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248605 0039d316-1c4b-4281-b951-d872f2087c98
* content: Add a new target 'test_netscape_plugin' to build the module in ↵tfarina@chromium.org2014-02-011-2/+3
| | | | | | | | | | | | shell/tools/plugin BUG=331302 TEST=ninja -C out_cros/Debug test_netscape_plugin builds R=jochen@chromium.org Review URL: https://codereview.chromium.org/145723004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248358 0039d316-1c4b-4281-b951-d872f2087c98
* Fix _CheckFilePermissions to actually flag presubmit errorsadamk@chromium.org2014-01-301-8/+6
| | | | | | | | | | | | | | Previously it was misusing subprocess.Popen such that no output was ever captured from checkperms.py. Also, changed the check to use input_api.subprocess instead of importing subprocess. R=maruel@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/143013004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247805 0039d316-1c4b-4281-b951-d872f2087c98
* Recognize KIF tests in top-level PRESUBMIT.pypvalenzuela@chromium.org2014-01-291-1/+1
| | | | | | | | | | | | This change allows KIF (an iOS integration test framework) tests to be analyzed appropriately by presubmit checks such as _CheckNoProductionCodeUsingTestOnlyFunctions. BUG=NONE Review URL: https://codereview.chromium.org/133233009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247718 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 14:58:18 +0000