| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11413172
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169635 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests:
content_unittests:CCMessagesTest.AllQuads
R=piman
BUG=152337
Depends on: https://codereview.chromium.org/11413106/
Review URL: https://chromiumcodereview.appspot.com/11418111
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=1
Review URL: https://chromiumcodereview.appspot.com/11414053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168950 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
R=marja@chromium.org
Review URL: https://codereview.chromium.org/11414061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=erikwright@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11362254
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=
TBR=jrg@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11410079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11361244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=estade@chromium.org
BUG=None
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11363132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/11377034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11369098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11366105
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166361 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=miket@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11364101
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166265 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This class is composed of four points representing its corners. It does not
have to be axis-aligned, unlike a rectangle. The class supports the following
operations:
IsRectilinear()
- True if the quad is an axis-aligned rectangle.
IsCounterClockwise()
- True if the points of the quad are in counter-clockwise order.
Contains(Point)
- True if Point is inside the quad or on its boundary.
BoundingBox()
- A Rectangle whose edges are defined by the four points of the quad.
Scale()
- Scales each point on the quad by the given scale factors.
operator+/-
- Moves each point in the quad by the given offset.
The operations on this class are inspired by, but not copied from, the
FloatQuad class in WebCore. I've written my own implementation to match those
in WebCore for each of them, with exception of IsRectilinear() as I also
wrote the current method in WebCore.
Tests:
ui_unittests:QuadTest.Construction
ui_unittests:QuadTest.AddingVectors
ui_unittests:QuadTest.IsRectilinear
ui_unittests:QuadTest.IsCounterClockwise
ui_unittests:QuadTest.BoundingBox
ui_unittests:QuadTest.ContainsPoint
ui_unittests:QuadTest.Scale
BUG=147395
R=sky,pkasting
Review URL: https://codereview.chromium.org/11369043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165689 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11343034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165604 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously Point served two purposes, to be a position in 2d space, and also
an offset from the origin. This introduces a Vector2d class to represent an
offset, allowing typesafety checks for geometric operations.
The following are now the case:
Point +/- Vector = Point
- A point plus/minus an offset gives you a point at a position offset by the
vector.
Vector +/- Vector = Vector
- Two offsets can be added together to make a new offset.
Point - Point = Vector
- Subtracting one point from another gives you the offset between the two
points.
We add some new methods to perform these operations:
Rect::OffsetFromOrigin() gives the offset between the position of the rect
and the origin.
Point::OffsetFromOrigin() gives the offset between the point and the origin.
PointAtOffsetFromOrigin(Vector2d) converts a Vector2d to a Point at the given
offset away from the origin.
Rect::Offset(), Point::Add(), and Point::Subtract() now receive a Vector2d
instead of a point.
BUG=147395
R=sky
Review URL: https://codereview.chromium.org/11269022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165198 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Adding dominich and shishir to predictors and removing shishir from instant.
Review URL: https://chromiumcodereview.appspot.com/11337013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164831 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11345006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164693 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11316004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164551 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/11140034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163961 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=NONE
Review URL: https://codereview.chromium.org/11233069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163681 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added gaurav, me, and steven to the list.
BUG=none
TEST=none
TBR=stevenjb@chromium.org
Review URL: https://codereview.chromium.org/11238040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163365 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=miket@chromium.org
Review URL: https://codereview.chromium.org/11189072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162826 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
TBR=rlp@chromium.org
R=sky@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11085084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161447 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
NOTRY=true
R=dennisjeffrey@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11087036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation for this CL is to move PasswordForm and friends (which are totally unrelated to WebKit) out of webkit/ and into a target that platforms that do not use WebKit (such as iOS) can logically depend on.
As such, this CL does three things:
1. Separates the WebKit-related code in webkit/forms from the
non-WebKit-related code. Concretely, this means having the WebKit::WebFormElement->PasswordForm conversion function in its own file.
2. Moves the core, non-WebKit-related forms code to chrome/common and content/public/common depending on where its usage points are.
3. Moves the above-mentioned conversion function to content/public/renderer. It cannot stay in webkit/ as it (now) has a dependency on content/, and as it is used only in chrome/renderer and content/renderer, this is a good place for it.
The rest of this CL is churn due to namespace, file location, and GYP target changes.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11000016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=nirnimesh
Review URL: https://codereview.chromium.org/11048011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159791 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=nirnimesh,jrg
BUG=
Review URL: https://chromiumcodereview.appspot.com/11034007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Files moved from chrome/browser/ui/panels:
cocoa files -> chrome/browser/ui/cocoa/panels
gtk files -> chrome/browser/ui/gtk/panels
views files -> chrome/browser/ui/views/panels
Only 'git mv', change in ifdef guards, #include and gypi and other move changes, no functional changes.
BUG=150887
Review URL: https://chromiumcodereview.appspot.com/10985010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies)
This is a copy of https://src.chromium.org/viewvc/chrome?view=rev&revision=157475
c/b/common dir is for utility/library code shared by chrome browser code.
BUG=144783
TBR=joi,ben
Review URL: https://codereview.chromium.org/10948045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/10945029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
url_database(and its dependencies).
c/b/common dir is for utility/library code shared by chrome browser code.
BUG=144783
Review URL: https://chromiumcodereview.appspot.com/10908155
TBR=kaiwang@chromium.org
Review URL: https://codereview.chromium.org/10941028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dependencies).
c/b/common dir is for utility/library code shared by chrome browser code.
BUG=144783
Review URL: https://chromiumcodereview.appspot.com/10908155
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means, add the intended DEPS rules for a Browser Component
(depend on nothing within chrome/browser outside the component except
chrome/browser/api) and add a temporary owner for pure refactoring
changes so that such changes can be done more quickly. Larger changes
(that affect functionality or interfaces in non-refactoring ways) will
still be sent to a proper OWNER.
With the new DEPS, a presubmit check will warn developers that add new
temporarily-allowed (the files designated with a "!" rule in the DEPS
file).
BUG=146851
Review URL: https://chromiumcodereview.appspot.com/10928053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10933099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Compositor subdirectories.
Review URL: https://chromiumcodereview.appspot.com/10919280
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/10911240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156469 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10919235
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10905222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=ran 'python depot_tools/watchlists.py ppapi/c/ppb_var.h'
TBR=nirnimesh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10907158
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webintents.
TBR=jhawkins@chromium.org for the watchlist file.
Review URL: https://chromiumcodereview.appspot.com/10919129
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155255 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10919128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155204 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10920011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=None
Review URL: https://chromiumcodereview.appspot.com/10896045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
R=craigdh@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10886049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The DEPS files means bookmarks component should depend on nothing within
chrome/browser except chrome/browser/api.
The goal is to remove all the temporarily allowed dependencies (start with !).
Also adding myself as a temporary owner only for refactoring changes.
BUG=144783
Review URL: https://chromiumcodereview.appspot.com/10899015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=joi,sky
BUG=144050
Review URL: https://chromiumcodereview.appspot.com/10867028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/10872056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10831250
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/10831244
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=robertshield
BUG=None
TEST=None
NOTRY=TRUE
Review URL: https://chromiumcodereview.appspot.com/10854042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150819 0039d316-1c4b-4281-b951-d872f2087c98
|