summaryrefslogtreecommitdiffstats
path: root/android_webview/browser/icon_helper.cc
Commit message (Collapse)AuthorAgeFilesLines
* [Android WebView] Add an API to control favicon loading.benm@chromium.org2013-10-041-3/+1
| | | | | | Review URL: https://codereview.chromium.org/25878003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227129 0039d316-1c4b-4281-b951-d872f2087c98
* This CL:pkotwicz@chromium.org2013-09-181-3/+6
| | | | | | | | | | | | | | | - Passes in ImageHostMsg_DidDownloadImage the original sizes of the bitmaps before they were resized as a result of the max size passed by ImageMsg_DownloadImage. This enables FaviconHandler to properly score the "goodness" of a bitmap. - Removes the unused "preferred size" parameters from the ImageMsg_DownloadImage and ImageHostMsg_DidDownloadImage messages - Adds a method in the anonymous namespace of FaviconUtil so that FaviconUtil::SelectFaviconFramesFromPNGs() does not use SelectFaviconFrames(). The old behavior is confusing because the call to SelectFaviconFrames() in FaviconUtil::SelectFaviconFramesFromPNGs() was operating on already resized bitmaps BUG=278457 TEST=FaviconHandlerTest.MultipleFavicons R=joth,cevans,jam,sky TBR=benwells (For trivial change to shell_window.*) Review URL: https://chromiumcodereview.appspot.com/23708024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223748 0039d316-1c4b-4281-b951-d872f2087c98
* [Android WebView] Update the NavigationEntry with favicon details.benm@chromium.org2013-07-191-1/+1
| | | | | | | | | | | Once we reveive a new favicon for a navigation, insert it into the NavigationEntry. BUG=b/9121594 Review URL: https://chromiumcodereview.appspot.com/19528004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212555 0039d316-1c4b-4281-b951-d872f2087c98
* Resizing huge favicons when retrieving those.qsr@chromium.org2013-06-201-2/+3
| | | | | | | | | | | | | | | Favicons and touch icons have no reason to ever be larger than 114 pixels. As we need to re-encode those on the browser process, very large favicon have an impact on the CPU used on the browser process. It also means bigger messages passed from a process to the other. This CL add a parameter so that the browser process can specify the maximal size of the images it is interested in, so that the renderer can resize the images if none match the criteria. BUG=248561 Review URL: https://chromiumcodereview.appspot.com/17069002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207303 0039d316-1c4b-4281-b951-d872f2087c98
* Don't request missing favicon on every page request. mef@chromium.org2013-05-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | Mark Favicon as 'Unable to Download' if server returns HTTP status 404 and don't try to download it again until user closes the browser or clicks 'Shift-Reload' (RELOAD_IGNORING_CACHE). Firefox 20 and IE 10 don't request missing favicon.ico on every page request. Propagated HTTP Status Code from MultiResolutionImageResourceFetcher all the way up to FaviconTabHelper, which required extension of 3 interfaces. BUG=39402 TEST=FaviconHandlerTest.UnableToDownloadFavicon Reviewers: sky@chromium.org - Overall CL, chrome/browser/*, content/browser/* palmer@chromium.org - content/common/image_messages.h joi@chromium.org - content/public/browser/web_contents.h jamesr@chromium.org - content/renderer/*, webkit/glue/* mnaganov@chromium.org - android_webview/browser/icon_helper.* Review URL: https://chromiumcodereview.appspot.com/14322023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200194 0039d316-1c4b-4281-b951-d872f2087c98
* Split FaviconHelper in two: ImageLoadingHelper and FaviconHelper.dimich@chromium.org2013-03-291-1/+1
| | | | | | | | | | | | | | | | | | This is the first step of fixing http://crbug.com/196769. The problem is that there are two types of users of Content::DownloadFavicon() - the favicon consumers and regular icons and images consumers. Recently, the otherwise-generic image download+decoding implementation regressed because it was assumed to be only used for favicon loading. The proposed fix is to add a parameter to the method (enum, FAVICON/IMAGE) and rename it from DownloadFavicon to DownloadImage, to make sure the name corresponds to the impl/usage. This is rename-only part, no additional parameter yet. The FaviconHelper class was split in 2, with new ImageLoadingHelper dealing with images. BUG=196769 Review URL: https://chromiumcodereview.appspot.com/12780024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191304 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Notifications Icon loading.dimich@chromium.org2013-03-201-2/+5
| | | | | | | | | | | | | | | The recent change to loading favicons regressed the loading regular icons that used the same codepath (https://chromiumcodereview.appspot.com/12218057) The fix is to add a parameter to WebContent::DownloadFavicon(...) to differentiate the loading of favicon and regular images. There is a separate patch, for renaming DownloadFavicon -> DownloadImage (https://codereview.chromium.org/12780024/) TBR=palmer@chromium.org BUG=196769 Review URL: https://codereview.chromium.org/12945007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@189349 0039d316-1c4b-4281-b951-d872f2087c98
* Implement touch icon functionalitysgurun@chromium.org2013-03-131-2/+6
| | | | | | | | | BUG=b/6295380 Review URL: https://chromiumcodereview.appspot.com/12600025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187857 0039d316-1c4b-4281-b951-d872f2087c98
* Implements onReceivedIconacleung@chromium.org2013-01-221-0/+79
This patch implements both WebChromeClient.onReceivedIcon and WebView.getFavIcon, and provides most the support for WebChromeClient.onReceivedTouchIcon. It also includes instrumentation tests for onReceivedIcon. What is still missing: Ability to turn it on and off. TouchIcon currently isn't working. Navigation history is not updated as of this patch. BUG= Review URL: https://chromiumcodereview.appspot.com/11575022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178158 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-05 15:20:20 +0000