| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This includes:
-- passing 'isMainFrame' bit to WebViewClient.scheduleContentIntent
(in blink);
-- also passing this bit in AwViewHostMsg_ShouldOverrideUrlLoading;
-- refactoring of the "call client or launch intent" logic
in AwContentsClient;
-- extending and refactoring of
AwContentsClientShouldOverrideUrlLoadingTest suite.
BUG=549369
Review URL: https://codereview.chromium.org/1411173009
Cr-Commit-Position: refs/heads/master@{#357468}
|
|
|
|
|
|
|
|
|
|
|
|
| |
In WebView we initalize popup windows asynchronously so loading a url
synchronously can result in it being loaded before the WebView
sets its webcontentsdelegate.
BUG=548316, 542548
Review URL: https://codereview.chromium.org/1405333005
Cr-Commit-Position: refs/heads/master@{#357127}
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebView's context wrapper will automatically set the
FLAG_ACTIVITY_NEW_TASK if the context is not an Activity. So the call
sites don't need to set the flag explictly.
BUG=
Review URL: https://codereview.chromium.org/1422813005
Cr-Commit-Position: refs/heads/master@{#356701}
|
|
|
|
|
|
|
|
|
|
|
| |
Context#startActivity requires that the intent has
FLAG_ACTIVITY_NEW_TASK set if the context is not an Activity.
BUG=548807
Review URL: https://codereview.chromium.org/1413513008
Cr-Commit-Position: refs/heads/master@{#356682}
|
|
|
|
|
|
|
|
|
|
|
| |
This CL takes the flags from WebSettings and enforces them when an action
mode is created.
BUG=546762
Review URL: https://codereview.chromium.org/1418113005
Cr-Commit-Position: refs/heads/master@{#356655}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL uses WindowAndroid to send intents and receive results for Chrome. It
is not possible to do the same for WebView because WebView is not by itself an
application.
WebView needs to use View#startActivityForResult to send intents and use
View#onActivityResult to receive the process text. Both of these View APIs are
in M.
BUG=521027
Review URL: https://codereview.chromium.org/1409443002
Cr-Commit-Position: refs/heads/master@{#355858}
|
|
|
|
|
|
|
|
|
|
| |
The old code was only necessary before L release.
BUG=
Review URL: https://codereview.chromium.org/1422563004
Cr-Commit-Position: refs/heads/master@{#355705}
|
|
|
|
|
|
|
|
| |
BUG=521027
Review URL: https://codereview.chromium.org/1399613002
Cr-Commit-Position: refs/heads/master@{#355390}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In certain (as yet undiagnosed) circumstances it seems possible
for WebView instances to appear to become unresponsive, without
crashing. In order to debug this case, add
AwDebug.dumpWithoutCrashing(File) - which allows a caller to use
the breakpad minidump mechanism to produce a dump that can be
processed to extract useful information about the state of the
WebView threads.
(NOPRESUBMIT to bypass ScopedAllowIO restriction; per comment in
aw_debug.cc, this is meant to be used when WebView is in an
undefined state, and posting I/O to another thread is impossible)
BUG=537579
NOPRESUBMIT=TRUE
Review URL: https://codereview.chromium.org/1384823004
Cr-Commit-Position: refs/heads/master@{#353504}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I walked through all AwContents method that are called from glue and
made sure we check `isDestroyed` in them, and made the latter to
emit a warning message on attempts to call after WebView has been
destroyed.
Excepted are methods that are overrides of Android's View class,
some internal methods (e.g. related to draw functor), and
`getSettings` as it can be called from arbitrary threads, thus
checking `isDestroyed` will be racey.
Also, minimized usage of the private generic version of
loadUrl(LoadUrlParams) in tests, as they should really test
the same methods the embedders use.
BUG=532974
Review URL: https://codereview.chromium.org/1386243002
Cr-Commit-Position: refs/heads/master@{#353080}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
change"
Reverting because of crbug.com/534758, to fix that bug we will have to
make a blink change adding a callback to let WebView know when a
document is not longer loading. The current callback DidFinishLoad does
not fire if a new load is in its provisional state, which is sometimes
the case if we load a webpage containing a redirect in the form of a
href assignment: window.location.href = '...'.
This revert was not clean because of the transition to using
NavigationThrottles over in https://codereview.chromium.org/1363483007
This reverts commit 777bb78a111aee919e07f5206267915a87639f88.
TBR=palmer@chromium.org,jam@chromium.org
BUG=534758
Review URL: https://codereview.chromium.org/1375993004
Cr-Commit-Position: refs/heads/master@{#352318}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the call to WebViewClient.shouldInterceptRequest from IO thread
to a background thread. This is in order to avoid situations when
embedder's code blocks inside shouldInterceptRequest callback, and
this effectively shuts down IPC messages processing.
BUG=533082
R=boliu@chromium.org, mmenke@chromium.org
Review URL: https://codereview.chromium.org/1350553005 .
Cr-Commit-Position: refs/heads/master@{#351894}
|
|
|
|
|
|
|
|
|
|
|
| |
The page visiblity will be calculated in BVR::IsVisible and AwContents
will not calculate it again. It reads from BVR via JNI instead.
BUG=520089
Review URL: https://codereview.chromium.org/1377593003
Cr-Commit-Position: refs/heads/master@{#351253}
|
|
|
|
|
|
|
|
|
|
| |
This makes these files consistent with all the other grds and a bit
easier to scan. This CL also fills in missing string descriptions in
android_content_strings.grd.
Review URL: https://codereview.chromium.org/1355853004
Cr-Commit-Position: refs/heads/master@{#349982}
|
|
|
|
|
|
|
|
|
|
|
| |
Most likely the Java side is trying to call a native method on
an already destroyed object.
BUG=532079
Review URL: https://codereview.chromium.org/1339103003
Cr-Commit-Position: refs/heads/master@{#349430}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 7d01bcecee8bda46001ac56a5e38574a9084679b.
Reverting, as it has been confirmed that this patch causes intermittent
ERR_NETWORK_CHANGED errors.
BUG=529434
TBR=timvolodine@chromium.org
Review URL: https://codereview.chromium.org/1339653003
Cr-Commit-Position: refs/heads/master@{#348420}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix a couple of typos in variable names/commentary introduced in:
https://codereview.chromium.org/1315633003/
No functional effect.
BUG=156062
Review URL: https://codereview.chromium.org/1331943002
Cr-Commit-Position: refs/heads/master@{#348175}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add support for policies, the first 2 implemented here being
URLBlacklist and URLWhitelist.
They are to be set via app restrictions on the embedder app,
by prefixing the policy name with "com.android.browser:"
BUG=506808
TBR=bartfab@chromium.org
Review URL: https://codereview.chromium.org/1234943010
Cr-Commit-Position: refs/heads/master@{#347908}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Android WebView uses android.widget.OverScroller#startScroll
implement pageUp/pageDown. Since blink internally knows how
to do a smooth scroll via page scale animation, WebView just
need to send an IPC to blink with the target position and
duration.
The blink change to support smooth scroll:
https://codereview.chromium.org/1251473003
BUG=378984
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1251323002
Cr-Commit-Position: refs/heads/master@{#347770}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
So it no longer depends on in_process code, in particular having android
webview be single process.
Preference is passed to RenderViewImpl on init, which is then used to
initialize blink and the compositor.
BUG=526842
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1309003006
Cr-Commit-Position: refs/heads/master@{#347528}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#347232}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To run AwShell in this mode (no graphical output):
build/android/adb_android_webview_command_line --webview-sandboxed-renderer
Added a simple test for this mode. The next step will be to run all AW
instrumentation tests like this in addition to normal mode.
BUG=156062,525697
Review URL: https://codereview.chromium.org/1315633003
Cr-Commit-Position: refs/heads/master@{#346963}
|
|
|
|
|
|
|
|
|
|
|
|
| |
This has not been in use since r342756 when smoothness is disabled.
New plan to enable smoothness no longer involves this call.
BUG=520149
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1316933003
Cr-Commit-Position: refs/heads/master@{#346527}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary upstream WebActionMode hooks, as well as
ContentViewClient hooks for configuring the WebActionModeCallback.
BUG=523432
Review URL: https://codereview.chromium.org/1317893002
Cr-Commit-Position: refs/heads/master@{#345638}
|
|
|
|
|
|
|
|
|
|
| |
Add floating toolbar support for web content selections.
BUG=389153
Review URL: https://codereview.chromium.org/1242613002
Cr-Commit-Position: refs/heads/master@{#345172}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix unintented behaviour where shouldOverrideUrlLoading is called for
reloads (in earlier WebView versions shouldOverrideUrlLoading was not
called for reloads and there are apps relying on this behaviour). This
behaviour was introduced in https://codereview.chromium.org/1155713005/.
BUG=522743
Review URL: https://codereview.chromium.org/1308073003
Cr-Commit-Position: refs/heads/master@{#345079}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://errorprone.info/bugpattern/SynchronizeOnNonFinalField
android_webview/java/src/org/chromium/android_webview/AwMessagePortService.java
android_webview/javatests/src/org/chromium/android_webview/test/PostMessageTest.java
android_webview/javatests/src/org/chromium/android_webview/test/util/JavascriptEventObserver.java
base/test/android/javatests/src/org/chromium/base/test/util/TestThread.java
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTestHelper.java
components/gcm_driver/android/java/src/org/chromium/components/gcm_driver/GoogleCloudMessagingV2.java
content/public/android/javatests/src/org/chromium/content/browser/VSyncMonitorTest.java
remoting/android/java/src/org/chromium/chromoting/CardboardDesktopRenderer.java
remoting/android/java/src/org/chromium/chromoting/DesktopView.java
remoting/android/java/src/org/chromium/chromoting/TrackingInputHandler.java
http://errorprone.info/bugpattern/ElementsCountedInLoop
base/android/javatests/src/org/chromium/base/ObserverListTest.java
http://errorprone.info/bugpattern/TypeParameterUnusedInFormals
chrome/android/java/src/org/chromium/chrome/browser/ChromeBrowserProviderClient.java
http://errorprone.info/bugpattern/NarrowingCompoundAssignment
chrome/android/javatests/src/org/chromium/chrome/browser/WebappAuthenticatorTest.java
http://errorprone.info/bugpattern/WaitNotInLoop
chrome/android/javatests/src/org/chromium/chrome/browser/widget/ToolbarProgressBarTest.java
BUG=485599
Review URL: https://codereview.chromium.org/1297073004
Cr-Commit-Position: refs/heads/master@{#344840}
|
|
|
|
|
|
|
|
|
|
|
| |
Remove already empty setErrorPageResources method, as the "next" glue
has been updated to not call it anymore.
BUG=515691
Review URL: https://codereview.chromium.org/1308473002
Cr-Commit-Position: refs/heads/master@{#344620}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable Network Information API for Webview by default.
The API is *not* enabled in the following cases:
1. if the embedding application does not have sufficient permissions
(i.e. at least android.permission.ACCESS_NETWORK_STATE) and
2. when there are no WebView instances (i.e. instances of AwContents).
BUG=520088
Review URL: https://codereview.chromium.org/1297943003
Cr-Commit-Position: refs/heads/master@{#344569}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ActionMode is the standard naming for the copy-paste-select bar in
android. (http://developer.android.com/guide/topics/ui/menus.html) In
chrome on android, three types of ActionMode exist:
1. ContextualMenuBar and CustomSelectionActionModeCallback. This is for
toolbar and omnibox editing. On tablet, ContextualMenuBar controls the
animation to move toolbar downwards, hiding the tabstrip.
2. SelectionActionModeCallback and SelectionActionMode are content
layer concept for selecting strings inside of the webcontents.
3. ChromeSelectActionModeCallback is the same thing in chrome layer.
To make our naming more clear and more intuitive, several renamings are
proposed in this CL:
1. ContextualMenuBar -> ActionModeController. This class only handles
animation for toolbar, and it is essentially a controller/manager.
2. CustomSelectionActionModeCallback -> ToolbarActionModeCallback. This
callback only serves content editing in toolbar and omnibox.
3. SelectActionMode -> WebActionMode; SelectActionModeCallback ->
WebActionModeCallback. This renaming is to distinguish between
webcontents and android native views.
This CL also removes the unused code in ChromeTabbedActivity.
BUG=521194
Review URL: https://codereview.chromium.org/1292923004
Cr-Commit-Position: refs/heads/master@{#344336}
|
|
|
|
|
|
|
|
| |
BUG=428087
Review URL: https://codereview.chromium.org/1281323003
Cr-Commit-Position: refs/heads/master@{#343764}
|
|
|
|
| |
Cr-Commit-Position: refs/heads/master@{#343737}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Enable page visibility behind a command line switch. There should be
no change in behavior if enable-page-visibility switch is missing.
When it's added:
* Visibility is changed to
(view visible) && (!attached or window visible) && (!onPause-ed)
The existing implementation is simply !onPaused.
* Pass page visibility signal into blink, and in turn, the compositor.
BUG=520089
Review URL: https://codereview.chromium.org/1291653004
Cr-Commit-Position: refs/heads/master@{#343396}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implemented similarly to ChromeContentBrowserClient. The only trick is that 'false' is still returned for "special" Android file URLs (file:///android_asset/* and file:///android_res/) that should work even if file access is disabled. By returning 'false' from IsHandledURL we bypass the scheme check in ChildProcessSecurityPolicy.
Access to 'file:' scheme is granted to child processes after the first call to WebView.loadDataWithBaseUrl with non-data: base URL.
Access to 'content:' scheme is always granted, as access to it is enabled by default in WebSettings.
BUG=516546
Review URL: https://codereview.chromium.org/1275163004
Cr-Commit-Position: refs/heads/master@{#343214}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
An app that calls destroy() on a WebView for which a callback is pending
(e.g. onPageFinished) can accidentically use the WebView from that
callback after the destroy method has finished.
To prevent this from happening we now reset the WebView callback
listeners (e.g. WebViewClient) when destroying WebView.
BUG=498796
Review URL: https://codereview.chromium.org/1284923002
Cr-Commit-Position: refs/heads/master@{#343006}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Historically, the load error pages displayed by WebView were a part of
Android framework resources. This change adds them into WebView
resources. This way, the pages will be accessible to sandboxed child
services, using Chromium's resource sharing mechanisms.
Unlike Chrome's error pages, which use WebUI, WebView pages are
completely static, as JavaScript can be disabled.
BUG=515691
Review URL: https://codereview.chromium.org/1270793002
Cr-Commit-Position: refs/heads/master@{#341951}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of using a static accept language and user agent,
we set a HttpUserAgentSettings delegate to allow those
values to change dynamically.
BUG=35049
Review URL: https://codereview.chromium.org/1172093002
Cr-Commit-Position: refs/heads/master@{#341931}
|
|
|
|
|
|
|
|
|
|
| |
This patch denies the request if there is no response when GeolocationPermission.Callback object is gc-ed.
BUG=513752
Review URL: https://codereview.chromium.org/1267103003
Cr-Commit-Position: refs/heads/master@{#341760}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The rest of the annotations already live in this package,
so this CL moves CalledByNative, NativeCall, JNIAdditionalImport,
NativeClassQualifiedName and JNINamespace to the same package.
BUG=None
TBR=armansito@chromium.org,asvitkine@chromium.org,atwilson@chromium.org,avayvod@chromium.org,bauerb@chromium.org,boliu@chromium.org,brettw@chromium.org,dtrainor@chromium.org,gunsch@chromium.org,lambroslambrou@chromium.org,mef@chromium.org,mnaganov@chromium.org,mnissler@chromium.org,peter@chromium.org,qinmin@chromium.org,sky@chromium.org,yfriedman@chromium.org,yukawa@chromium.org,zea@chromium.org
Review URL: https://codereview.chromium.org/1263053002
Cr-Commit-Position: refs/heads/master@{#341175}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original issue's description:
> Additionally, restrict the URLs that ExecuteJavaScript can be invoked on
> to chrome-controlled URLs.
>
> R=jam@chromium.org
> BUG=507809
>
> Review URL: https://codereview.chromium.org/1123783002
>
> Cr-Commit-Position: refs/heads/master@{#340231}
R=mkwst@chromium.org
TBR=jam@chromium.org
BUG=507809
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
Review URL: https://codereview.chromium.org/1258593002 .
Cr-Commit-Position: refs/heads/master@{#340260}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
#15 id:270001 of https://codereview.chromium.org/1123783002/)
Reason for revert:
Speculatively reverting to address failures,
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/51422
Original issue's description:
> Add ExecuteJavaScriptForTest and make all tests use it
>
> Additionally, restrict the URLs that ExecuteJavaScript can be invoked on
> to chrome-controlled URLs.
>
> R=jam@chromium.org
> BUG=507809
>
> Committed: https://crrev.com/904f14ebdc3bdb8e893df0a3211d09de42d5619c
> Cr-Commit-Position: refs/heads/master@{#340231}
TBR=jam@chromium.org,mdjones@chromium.org,torne@chromium.org,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=507809
Review URL: https://codereview.chromium.org/1257603003
Cr-Commit-Position: refs/heads/master@{#340241}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Additionally, restrict the URLs that ExecuteJavaScript can be invoked on
to chrome-controlled URLs.
R=jam@chromium.org
BUG=507809
Review URL: https://codereview.chromium.org/1123783002
Cr-Commit-Position: refs/heads/master@{#340231}
|
|
|
|
|
|
|
|
|
|
| |
- Used java_cpp_enum to sync the resources definition.
BUG=504037
Review URL: https://codereview.chromium.org/1203163002
Cr-Commit-Position: refs/heads/master@{#340202}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=497258
Provide an accessibility tree snapshot when requested. This CL
contains a frameworks class that is taken from preview release
and will be removed when the public SDK is available.
Depends on https://codereview.chromium.org/1246163003/
Review URL: https://codereview.chromium.org/1246823003
Cr-Commit-Position: refs/heads/master@{#339968}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have been using both a resource throttle and a sync IPC to implement
shouldOverrideUrlLoading, with this patch we use only a resource
throttle instead.
This patch depends on https://codereview.chromium.org/1194383003 which
adds a flag indicating that the current request was overridden. The flag
is passed down to AwWebContentsObserver.didFailLoad. That CL in turn
depends on https://codereview.chromium.org/1178273007/ which adds the
flag to blink errors.
BUG=325351
Review URL: https://codereview.chromium.org/1155713005
Cr-Commit-Position: refs/heads/master@{#339109}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Only fire intents when navigation is initiated by the user
(via a gesture), or by the server (a redirect). This curbs
down attempts to launch intents purely by JS code, which
lead to a poor UX -- tasks appearing from nowhere.
BUG=501633
Review URL: https://codereview.chromium.org/1180223004
Cr-Commit-Position: refs/heads/master@{#338133}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts b853e3b94ebc92a96132bbf6e79c47483c694b7d
Lint is fatal since 8db283ac6beb49ad8032a8e6c65e4cc76db65ffd, so also
point the linter to AndroidManifests with higher minSdkVersions.
BUG=241521
Review URL: https://codereview.chromium.org/1192003007
Cr-Commit-Position: refs/heads/master@{#337861}
|
|
|
|
|
|
|
|
| |
BUG=507446
Review URL: https://codereview.chromium.org/1214853021
Cr-Commit-Position: refs/heads/master@{#337542}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The load library from APK configuration of Chrome is only
going to be used on version of Lollipop onwards where there
should be no need to trigger the unpack fallback. UMA shows
no use of this fallback in the wild, so let's remove it.
BUG=398425, 390618
Review URL: https://codereview.chromium.org/1216703003
Cr-Commit-Position: refs/heads/master@{#337222}
|
|
|
|
|
|
|
|
|
|
|
|
| |
If AX tree is requested before a navigation, then the request is
silently dropped since there is no renderer associated with the routing id
yet.
BUG=505023
Review URL: https://codereview.chromium.org/1221643005
Cr-Commit-Position: refs/heads/master@{#336694}
|