| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The InProcessViewRenderer needs to know the current pageScale so
that it can correctly convert phsical <-> CSS pixels.
BUG=b/9756394
TEST=AndroidWebViewTest
Android-only change, trybots are happy with it.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18242011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This applies to software, hardware, software fallback, and capture
picture. Has the nice benefit that if we are in hardware mode, we will
never create the auxillary bitmap.
An additional change that we will no longer fallback into software draw
if hardware RequestDrawGL fails. In practice this should fail visibily
if it happens, but instrumentation tests may have been relying on this
behavior, so make sure instrumentation tests run in pure software mode.
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18523007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210407 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This plumbs the DidOverScroll notification from the content layer to the
android_webview layer and hooks it up to the View.overScrollBy method.
BUG=178399
TEST=AndroidWebViewTest (AndroidScrollIntegrationTest)
ran through Android trybots and win/linux/mac compile.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18717002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The public API can be used without instantiating a webview, so this test is needed to ensure there's no hidden interdependencies.
NOTRY=true
BUG=180061
Review URL: https://chromiumcodereview.appspot.com/17274011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is more reliable than stashing the last navigated URL for
char-by-char comparison, and specifically deals with the case of a
second javascript: navigation racing in before the prior real navigation
has been processed.
BUG=b/9681730
Review URL: https://chromiumcodereview.appspot.com/18147012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the test code to send generated touch events directly
to the view instead of going through the Instrumentation class.
This allows us to successfully complete the test case even if a modal
dialog pops over the Activity under test.
BUG=256774
TEST=run AndroidWebViewTest with the 'power off' modal dialog up.
Java-only change, did fine on Android trybots.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/18259009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210172 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
AndroidWebView.testTouchScrollCanBeAlteredByUi is flaky, disable it.
TBR=mkosiba
BUG=256774
Review URL: https://codereview.chromium.org/18272011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209750 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a view integration test for content size changes in
wrap-content mode.
BUG=None
TEST=AndroidWebViewTests
Review URL: https://chromiumcodereview.appspot.com/16658010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This connects the scroll offset that is delegated from the
CC all the way up to the Java android.view.View class.
BUG=b/6029133
TEST=AndroidWebViewTest
Review URL: https://chromiumcodereview.appspot.com/16255010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207614 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to ensure instances do not get leaked after GC, even if
AwContents.destroy() is not called.
This is a resurrection of the test in
https://codereview.chromium.org/12658010/diff/23001/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java
now that crbug.com/197020 is no longer an issue (due to new graphics pipeline)
BUG=197020
Review URL: https://chromiumcodereview.appspot.com/16983009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207464 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
It looks like the test wasn't flaky but just plain wrong. After fixing
the test works reliably.
BUG=243094
R=boliu@chromium.org
Review URL: https://codereview.chromium.org/17449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This was disabled awaiting new rendering mode; now we have that,
re-enable it.
NOTRY=true
BUG=176940
Review URL: https://chromiumcodereview.appspot.com/17162004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207088 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow-up to crrev.com/206516
As mCleanupReference is nulled out in destroy() it now must be
null-checked to allow repeat calls to destroy().
BUG=
Review URL: https://chromiumcodereview.appspot.com/17301002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
testGetFavicon need to use AwContents on UI thread.
Fix indent/imports etc.
BUG=
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/17118010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206896 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Blink now has more reasonable behavior of LoadsImagesAutomatically and
ImagesDisabled settings. Namely, ImagesDisabled prevents any images from
showing up, including cached ones. LoadsImagesAutomatically now allows
"loading" of data uri images embedded in pages.
This allows us to simplify our wirings for implementing Android WebView's
LoadsImagesAutomatically and BlockNetworkImage. The trick is that we should
wire them cris-cross, as WebView's LoadsImagesAutomatically must block
all images from loading / showing up (as ImagesDisabled), while
BlockNetworkImage's contract is now fulfilled by Blink's
LoadsImagesAutomatically. Please read comments on the bugs referenced
if this sounds weird to you.
AwSettingsTest.testLoadsImagesAutomaticallyWithCachedImage is removed because
this behavior is not in fact standardized in WebView Classic and isn't
preserved anymore. In fact, as cache is transient, it would be unwise for an
application to rely on the fact that cached images will stay there forever
and thus could be shown even if LoadsImagesAutomatically is disabled.
BUG=248249,224317
R=benm@chromium.org, joth@chromium.org
Review URL: https://codereview.chromium.org/16932006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Follow up to crrev.com/206516 - in the end that patch didn't need this
part of the change and it turns out to be awkward to provide this info
at browser context creation time anyway.
BUG=
Review URL: https://chromiumcodereview.appspot.com/17132003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This switches around the object lifetimes, so WebContents and AwContents
(native) have identical lifetimes, but now the native AwContents may
exist before its java counterpart, and in the popup flow the java
object may switch from its default peer instance to acquire the pop-up
AwContents/WebContents instead.
Additionally, makes some simplifications to the way AwSettings is created
and also fixes a potential leak (the native instance was never deleted if
destroy() was not called).
NOTRY=true
BUG=245801
Review URL: https://chromiumcodereview.appspot.com/16843008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
If the WebContents is destroyed then the SynchronousCompositor will
be deleted before the InputHandler is deleted.
Additionally we also NULL out the back pointer to the synchronous
compositor from the input handler when the synchronous compositor
is destroyed.
BUG=
Review URL: https://chromiumcodereview.appspot.com/16560007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
@DisabledTest must be the only annotation on a test.
BUG=248249
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/16777002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
These test failures appear to be caused by the images loading even though setLoadsImagesAutomatically is false. The full failure is visible here:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/9587/steps/androidwebview_instrumentation_tests/logs/stdio
This would be expected as data uri images would load without hitting the network.
BUG=248249
R=benm@chromium.org
Review URL: https://codereview.chromium.org/16404010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205283 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Video is broken in merged thread mode. Disable these tests until
it works.
BUG=239760
NOTRY=true
R=joth@chromium.org
Review URL: https://codereview.chromium.org/16395005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204969 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
When provisional load fails, there is no HTML error page, so
the change I've made in https://codereview.chromium.org/15979017/
wasn't working properly. Now fixed.
R=benm@chromium.org
Review URL: https://codereview.chromium.org/16441002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204272 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Since not all net error codes can be mapped onto Android error codes,
at least provide a minimal description for the client.
Review URL: https://chromiumcodereview.appspot.com/15979017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add a regression test for a non-cacheable login page with a help link.
BUG=b/8888772
Review URL: https://chromiumcodereview.appspot.com/16337004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
findAllSync() is no longer used.
Deprecation happens at the public API so repeating in the
implementation class doesn't have much effect besides generating
warnings in test code.
../android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:235:warning:
[deprecation] getPluginsEnabled() in
org.chromium.android_webview.AwSettings has been deprecated
return mAwSettings.getPluginsEnabled();
BUG=
Review URL: https://chromiumcodereview.appspot.com/16231015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203315 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for details.
BUG=243094
NOTRY=true
TBR=joth
Review URL: https://chromiumcodereview.appspot.com/15744015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 269ba3428afe7cd2dfcf95f48e12f6b3b8402cec.
As the change that had broken the test has been rolled out,
restore the test to retain coverage.
BUG=242526
R=mkosiba@chromium.org
Review URL: https://codereview.chromium.org/15706002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201478 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Blink roll mentioned in the attached bug fixes the downstream
build but also breaks this test. Disabling the test as a working
build is more important.
BUG=242526
R=mnaganov@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/15288010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tests."
Fixed by r199515
BUG=239439
Review URL: https://chromiumcodereview.appspot.com/14925013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199786 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=239439
NOTRY=True
Review URL: https://chromiumcodereview.appspot.com/14890011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=239400
TBR=sgurun@chromium.org
NOTRY=True
Review URL: https://codereview.chromium.org/14833006
Patch from acleung <acleung@chromium.org>.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199162 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- only set EnableWebViewSynchronousAPIs in unmerge mode
- Allow wait in UI thread
- Disable 8 unit tests since SW renderer didn't work.
BUG=235702, 239144, 238735
Review URL: https://chromiumcodereview.appspot.com/13907007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome for Android doesn't use zoom controls, so it makes sense
to move all the related code into android_webview.
However, as visibility of zoom controls is controlled from the
internals of ContentView*, we are providing hooks through a new
delegate interface.
BUG=b/8296421
R=benm@chromium.org, joth@chromium.org
Review URL: https://codereview.chromium.org/14840011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The issue was due to a possibility of a delay in page scale factor
initialization, which lead to a situation when we were trying
to display zoom controls while zooming wasn't yet allowed.
Resolved by synchronizing on the page scale update after page load.
Also, just in case, made zoom controls visibility to be retrieved
on the UI thread in order to avoid races.
BUG=153522
R=benm@chromium.org
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14850005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197887 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This test is flaky. See bug for details.
BUG=153522
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14786009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This keeps the layers better isolated, and avoids the aw embedder having
to use content layer classes directly.
BUG=
Review URL: https://chromiumcodereview.appspot.com/13136002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- wait for onScaleChanged event instead of polling canZoomOutOnUiThread;
- reduce page content size to avoid hitting
"All tiles considered for activation should be live" assertion
in picture_layer_impl.cc;
- remove unneeded "setUseWideViewPort".
BUG=153522
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14539002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Missing a call to dismissZoomPicker on window detachment was
causing WindowManager to throw an exception about leaked window
BUG=153522
R=benm@chromium.org, bulach@chromium.org
Review URL: https://codereview.chromium.org/14509013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Historically, WebSettings management is used to be in the ContentSettings class,
while only WebView actually needs it. Chrome for Android is only interested in
the value of the "JavaScript enabled" setting.
This change leaves zoom-related settings intact, as moving them will require
decoupling of the ZoomManager class from the ContentView* family of classes,
which deserves a separate change.
BUG=b/8296421
Review URL: https://chromiumcodereview.appspot.com/14271024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
See bug for details.
BUG=230186
Disabling Android only test.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/14449002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195956 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This changes the content size update path for android_webview to use
the preferred size RenderView mechanism instead of the
CompositorFrameMetadata.
The reason for the change is due to the fact that the CompositorFrameMetadata
is not updated when the view size is 0x0, which is a common use case
for the WebView when it's layout mode is set to "wrap content".
BUG=b/8187850
TEST=AndroidWebViewTests
Review URL: https://chromiumcodereview.appspot.com/12567020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is to avoid skipping "meta viewport" tag processing.
For controlling wide viewport-related behavior, a corresponding
WebSetting has been added into Blink.
Review URL: https://codereview.chromium.org/14234002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194576 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The log is not available now, the assert in bug description isn't directly
related and can't reproduce it locally. Enable and bake them again.
BUG=180061
Review URL: https://chromiumcodereview.appspot.com/14181003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193823 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=http://b/8589376
Review URL: https://chromiumcodereview.appspot.com/13828010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193634 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Turns on the corresponding setting in Blink for AW.
Review URL: https://chromiumcodereview.appspot.com/13814013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=224923
Review URL: https://chromiumcodereview.appspot.com/13510002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192536 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Since we don't know when the page stop rendering, have to add a long
wait time, hope it could work for all bots.
NOTRY=true
BUG=224923
Review URL: https://chromiumcodereview.appspot.com/13317004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=180575
Review URL: https://chromiumcodereview.appspot.com/12928005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AwSettingsTest#testUseWideViewportControlsDoubleTabToZoom
The corresponding WebKit fix has been landed and rolled into Chromium.
BUG=222584
TBR=mkosiba@chromium.org
Review URL: https://codereview.chromium.org/12770025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Intercept the defaultVideoPoster request and return the poster from AwContents.getDefaultVideoPoster();
BUG=http://b/6294871
Review URL: https://chromiumcodereview.appspot.com/12702015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@190839 0039d316-1c4b-4281-b951-d872f2087c98
|