| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Have the context getter own the factory since it already owns the
context itself.
BUG=
Run through android_fyi_dbg trybot
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11320004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164387 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents the AndroidStreamReaderURLRequestJob from trying to
skip a negative number of bytes.
BUG=None
TEST=AndroidWebViewTest
Review URL: https://chromiumcodereview.appspot.com/11260032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Tests are marked as disabled, because they don't pass without having rendering
working for WebView upstream.
R=johnme@chromium.org
BUG=146009
Review URL: https://codereview.chromium.org/11260014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164308 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some other classes that are added in this patch:
AwBrowserMainParts, AwQuotaPermissionClient,
AwUrlRequestContext[Getter], AwResourceContext.
There is enough implementation for these classes so that
existing instrumentation tests still pass. A lot of TODOs
are added for future work beyond this patch.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11184051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164213 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
add a few trivial default/statics to make build scripts happy.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11264039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164138 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Implement functionality to handle resubmission of forms in Webview.
BUG=None
Review URL: https://chromiumcodereview.appspot.com/11187032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164014 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is important as it has to access two different threads
to get the CookieMonster. Most methods are sync, so waiting
for this to finish can cause a deadlock.
BUG=157683
Review URL: https://chromiumcodereview.appspot.com/11110003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163957 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Added missing destructor.
BUG=
TBR=benm@chromium.org
Review URL: https://codereview.chromium.org/11264007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes it possible to intercept navigations and resource requests
for otherwise unsupported schemes.
BUG=156354,148369
Review URL: https://codereview.chromium.org/11185051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163804 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Using .loadUrl to ensure that the JS-initiated click has finished
processing wasn't a good idea - the .loadUrl would sometimes "overwrite"
the JS-initiated navigation causing the test to fail.
A more reliable approach is to use the test web server to wait for the
page to load.
This change also makes the TestWebServer a part of the fixture.
BUG=None
TEST=AndroidWebViewTest
Java-only change, ran through trybots.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11231051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The magic code that this is currently testing is at the end of
RenderViewImpl::willSendRequest, which sets the UA override (if there is
one). The network stack will only ask UrlRequestContext for a user agent
if it is not already set.
BUG=
Java test change. Ran through android java trybot
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11227059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
No functional change.
BUG=b/7399968
Review URL: https://chromiumcodereview.appspot.com/11227063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebView build has some linker warnings that aren't critical to our
build right now, but Android has turned on --fatal-warnings downstream
in LDFLAGS. Turn this back off for libwebviewchromium until we can fix
the warnings.
BUG=157326
Review URL: https://codereview.chromium.org/11189121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163583 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Upstream Autofill functionality for Android.
BUG=138235
Review URL: https://chromiumcodereview.appspot.com/11187054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163480 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=joth@chromium.org
BUG=88315
Review URL: https://chromiumcodereview.appspot.com/11189110
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to copy the locale paks into the same directory as all the other
paks, not into a locales/ subdirectory, because that's what the android
code expects. Tweak the Android makefile slightly to do this.
BUG=
Review URL: https://codereview.chromium.org/11228030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The libwebview target should be called libwebviewchromium to make it
clear which implementation it is when installed into the system image.
BUG=
Review URL: https://codereview.chromium.org/11189114
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We need to install the Chromium resource paks that webview depends on
into the Android system image. This requires adding them as dependencies
of the WebView All target, and defining custom Android build rules to
copy them to the right place.
BUG=
Review URL: https://codereview.chromium.org/11235002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163266 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NetworkDelegate::OnHeadersReceived const
BUG=149890
TBR=tony@chromium.org,mnaganov@chromium.org,jochen@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10944013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the command line flag file from /data/local/tmp to /data/local
BUG=143146
Review URL: https://chromiumcodereview.appspot.com/11187065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Now that OWNERS supports per-file owners, we can limit the scope of the
top-level wildcard to just DEPS, and make darin and ben owners for
everything else and remove the broad use of "set noparent".
R=ben@chromium.org, darin@chromium.org
BUG=88315
Review URL: https://codereview.chromium.org/11191038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163069 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove workarounds that were depending on https://codereview.chromium.org/11030051/
R=benm@chromium.org
BUG=154271
Review URL: https://codereview.chromium.org/11189087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is needed for Android WebView, so we can display an error page in case when
loading has been blocked due to policy settings.
Currently, cancelling a resource load via ResourceDispatcherHostDelegate doesn't
change the state of the renderer.
R=joth@chromium.org,darin@chromium.org
BUG=154271
Review URL: https://chromiumcodereview.appspot.com/11030051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support for chrome:// URLs will go away once we stop using Profile.
This should also make the tests less flaky as they were
depending on the fact that navigating to the new tab page
would move to the bookmarks sub-page and alter the URL to end with #bookmark.
BUG=147784
Java-only change, ran through android trybots.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11198063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162977 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) The top-level Android.mk mustn't use my-dir after including another
file as it returns the wrong answer.
2) We need "All" to depend on net_errors_java as it's used by the
Android.mk.
3) Fix nits from previous review of android_webview/Android.mk - make it
clearer that only one of the dependencies is temporary.
BUG=
Review URL: https://codereview.chromium.org/11187052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following file:
remoting/host/me2me_preference_pane-Info.plist
got renamed to:
remoting/host/mac/me2me_preference_pane-Info.plist
Causing Android Builder (dbg) on chromium.fyi to go red:
http://build.chromium.org/p/chromium.fyi/builders/Android%20Builder%20%28dbg%29/builds/7880/steps/Check%20licenses%20for%20WebView/logs/stdio
This CL updates the whitelist accordingly.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11189059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=154760
Review URL: https://chromiumcodereview.appspot.com/11183045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently it uses the system default auth-db, and leaves junk in the DB from one run to
the next and was giving me some spurious failures.
Now we use a temporary DB that can be blown away between test runs
BUG=
Review URL: https://chromiumcodereview.appspot.com/11137028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Chrome itself.
Including generated files from within .rc files doesn't work since there's no dependency tracking going on.
BUG=155714
TEST=none
Review URL: https://chromiumcodereview.appspot.com/11147012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162494 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Resource directory may not always be defined for an apk, make it optional.
BUG=156061
Review URL: https://chromiumcodereview.appspot.com/11189010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162477 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The android gyp backend has been updated to introduce an
"android_unmangled_name" target option, which allows the backend to skip
mangling the name of designated targets. Turn this on for libwebview in
order that it's generated as libwebview.so instead of
lib_android_webview_libwebview_gyp.so which was rather confusing.
BUG=
Review URL: https://codereview.chromium.org/11198030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The WebView needs a bunch of Java code from the Chromium tree
(contentview and its dependencies) in order to build. Introduce an
Android build system makefile into android_webview which builds a
suitable static java library.
R=benm@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11185025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162404 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
M D DLS: Dead store to imageUrl in
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testCalledForImage()
At AwContentsClientShouldInterceptRequestTest.java
M D DLS: Dead store to onPageFinishedCallCount in
org.chromium.android_webview.test.AwContentsClientShouldInterceptRequestTest.testOnLoadResourceCalledWithCorrectUrl()
At AwContentsClientShouldInterceptRequestTest.java
M D SF: Switch statement found in
org.chromium.android_webview.AwContents$IoThreadClientHandler.handleMessage(Message)
where default case is missing At AwContents.java
M P SIC: Should
org.chromium.android_webview.test.AwContentsClientShouldIgnoreNavigationTest$TestAwContentsClient$ShouldIgnoreNavigationHelper
be a _static_ inner class? At
AwContentsClientShouldIgnoreNavigationTest.java
Java only change and android bots are happy.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11196016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add AwResource.java, a class that defines a set of resource IDs and
functionality to resolve those IDs to concrete resources.
Initially, we add three resources - two raw resources to represent
error pags and a string resource for default text encoding.
The embedder should set up the IDs before starting to use Chromium.
Review URL: https://codereview.chromium.org/11145026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Ran test 30 times locally, 100% pass rate.
BUG=152033
Review URL: https://chromiumcodereview.appspot.com/11184002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162175 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
FindBugs showed two warnings in this file:
M B RV: exceptional return value of java.io.File.delete() ignored in org.chromium.android_webview.test.LoadDataWithBaseUrlTest.testLoadDataWithBaseUrlAccessingFile() At LoadDataWithBaseUrlTest.java
M X OBL: org.chromium.android_webview.test.LoadDataWithBaseUrlTest.testLoadDataWithBaseUrlAccessingFile() may fail to clean up java.io.OutputStream Obligation to clean up resource created at LoadDataWithBaseUrlTest.java:[line 290] is not discharged
This patch fixes them.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/11166006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This implements the WebViewClient shouldInterceptRequest and onLoadResource callbacks.
BUG=138481
Android-only change - ran through android try.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11110013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11112022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161964 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes undesired destruction of ResourceLoader inside of StartRequestInternal.
R=mkosiba@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11147021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This excludes POST navigations from navigation intercepting.
This also adds a test case which ensures that subframe navigations
are not intercepted.
BUG=155250
android_webview-specific change, ran through trybots.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11017075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The testShouldIgnoreNavigationCanIgnoreLoading method was flaky because we call
onPageFinished for ignored navigations (bug 154292). The fix is to check that
the request for the navigation that is supposed to be ignored doesn't ever hit
the server.
BUG=
Java-only change, ran through trybot.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11108016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Due to the way make rules are generated from gyp files, the
android_webview rule was being invoked even though we already
had a strip and install action.
The simplest fix is to remove the android_webview rule as we don't
use it anymore.
TBR=torne@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11109014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161569 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Allow the top level Android.mk to include GypAndroid.mk if the relevant
environment variable is set, to avoid having to edit this file to build
in the Android tree without breaking other Android builds. Also, provide
a gyp wrapper for webview which passes the correct options.
BUG=
Review URL: https://codereview.chromium.org/11090069
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161566 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This suppresses the shouldIgnoreNavigation callback for navigations
that were requested via the AwContents.loadUrl method.
BUG=154558
Java-only change, successfully passed android trybot.
NOTRY=true
Review URL: https://chromiumcodereview.appspot.com/11093075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, for each such shared library included in an apk, create a link in
the appropriate directory in <(android_product_out) to enable annotating
native stack traces for those apks.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11096038
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161440 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://chromiumcodereview.appspot.com/11096036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebView.loadDataWithBaseURL API[1], which allows access to local file:// resources (depending on AwSettings.getAllowFileAccess) as long as the base URL provided is not "data:".
When AwSettings.getAllowFileAccess returns false, data URIs loaded with a non-data base URL should be able to access file:///android_asset and file:///android_res/, but not the wider filesystem.
We grant the WebView process access to file:// via ChildProcessSecurityPolicy (as WebView is single process we do this on process startup) and add a field to ViewMsg_NavigateParams that indicates if the URL being loaded should have access to local loads. This is bit is checked when the provisional load commits and if set, grants the SecurityOrigin access to local resources. The bit defaults to false and is only set in android_webview when AwContents loads a data URL with a non-data base URL, so there should be no behavior change outside of android_webview.
Once the SecurityOrigin allows local loads, code already present in android_webview controls whether the URL should be able to load either only android_asset and android_res or any file:// URL (see https://codereview.chromium.org/11090003/).
[1]
http://developer.android.com/reference/android/webkit/WebView.html#loadDataWithBaseURL(java.lang.String,
java.lang.String, java.lang.String, java.lang.String, java.lang.String)
BUG=152223
Review URL: https://codereview.chromium.org/10990056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161355 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/10993091
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161214 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Use Integer.valueOf instead of new Integer (fix findbugs downstream).
Moved redirect below null check and add updating count and last request
variables.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11094035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=joth@chromium.org
BUG=155042
Review URL: https://chromiumcodereview.appspot.com/11086051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161158 0039d316-1c4b-4281-b951-d872f2087c98
|