| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=None
R=thestig@chromium.org
Review URL: https://codereview.chromium.org/550503003
Cr-Commit-Position: refs/heads/master@{#293783}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:180001 of https://codereview.chromium.org/479873002/)
Reason for revert:
Broke Android Tests (dbg)
C 427.575s Main [FAIL] org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText:
C 427.575s Main junit.framework.AssertionFailedError
C 427.575s Main at org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:694)
C 427.575s Main at org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:410)
C 427.575s Main at java.lang.reflect.Method.invokeNative(Native Method)
C 427.575s Main at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C 427.575s Main at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C 427.575s Main at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 427.575s Main at org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
C 427.575s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C 427.575s Main at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C 427.575s Main at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C 427.575s Main at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
Original issue's description:
> Removing uses of X11 native key events.
>
> BUG=380349
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822
>
> Committed: https://chromium.googlesource.com/chromium/src/+/13d90b146a400156427243d05159cadd8d72c0b9
TBR=sadrul@chromium.org,sky@chromium.org,erg@chromium.org,jamesr@chromium.org,boliu@chromium.org,kpschoedel@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=380349
Review URL: https://codereview.chromium.org/548303003
Cr-Commit-Position: refs/heads/master@{#293732}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libjpeg and instead link
Chromium's libjpeg_turbo.
This increases binary size by ~120KB.
BUG=409851
Review URL: https://codereview.chromium.org/548513002
Cr-Commit-Position: refs/heads/master@{#293663}
|
|
|
|
|
|
|
|
|
|
|
|
| |
webcontents user data.
Also ensure that if we don't post the callback to the java side to run the js dialog callback in the embedding app that we run the callback.
BUG=411399
Review URL: https://codereview.chromium.org/545963002
Cr-Commit-Position: refs/heads/master@{#293642}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NavigationController functionalities inside ContentViewCore.
I have started to migrate the ownership to respective class for handling specific functionalities.
In this patch I have taken ownership of NavigationController functionalities to drop in NavaigationController classes.
BUG=398263
R=avi@chromium.org, boliu@chromium.org, nasko@chromium.org, yfriedman@chromium.org
Review URL: https://codereview.chromium.org/406023002
Patch from ajith.v <ajith.v@samsung.com>
.
Cr-Commit-Position: refs/heads/master@{#293550}
|
|
|
|
|
|
|
|
|
|
|
|
| |
using TBR because Darin told me he defers to James' judgement. Using NOTRY because there is one presubmit error (dump_file_system.cc was moved and it spews printf).
BUG=338338
TBR=darin@chromium.org
NOTRY=true
Review URL: https://codereview.chromium.org/539143002
Cr-Commit-Position: refs/heads/master@{#293547}
|
|
|
|
|
|
|
|
|
|
| |
BUG=380349
Committed: https://chromium.googlesource.com/chromium/src/+/bbb7ea7c66f18298079eea4a6b24834986f4a822
Review URL: https://codereview.chromium.org/479873002
Cr-Commit-Position: refs/heads/master@{#293520}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of ICU and instead link
Chromium's copy.
This increases binary size by ~7MB.
BUG=409851
Review URL: https://codereview.chromium.org/541753002
Cr-Commit-Position: refs/heads/master@{#293510}
|
|
|
|
|
|
|
|
|
| |
This is required for WebGL conformance tests and cannot be passed
on the cmdline the way WebView overrides this from AwSettings.
Review URL: https://codereview.chromium.org/546643002
Cr-Commit-Position: refs/heads/master@{#293429}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start checking the following names:
- Method names
- Method parameter names
- Local variables
BUG=318404
TRB=qinmin@chromium.org
R=boliu@chromium.org, qinmin@chromium.org, tedchoc@chromium.org
Review URL: https://codereview.chromium.org/543553002
Cr-Commit-Position: refs/heads/master@{#293354}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://codereview.chromium.org/542513002/)
Reason for revert:
This breaks the android tree:
http://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/65137
Original issue's description:
> Remove unused license whitelist entry for a removed file
>
> BUG=None
> TBR=mnaganov@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/4808281fa6b22601ac969b66ea130eb8a5233ffe
TBR=mnaganov@chromium.org,tzik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/537303002
Cr-Commit-Position: refs/heads/master@{#293283}
|
|
|
|
|
|
|
|
|
| |
BUG=None
TBR=mnaganov@chromium.org
Review URL: https://codereview.chromium.org/542513002
Cr-Commit-Position: refs/heads/master@{#293272}
|
|
|
|
|
|
|
|
|
|
|
| |
redirect headers
BUG=338338
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/524983002
Cr-Commit-Position: refs/heads/master@{#293228}
|
|
|
|
|
|
|
|
|
|
|
| |
These were failing on Android Builder (dbg) FYI bot.
BUG=409152
TBR=qinmin@chromium.org
Review URL: https://codereview.chromium.org/522943003
Cr-Commit-Position: refs/heads/master@{#293206}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
requests"
This reverts commit 69538c3b061eb767d25d32edd89626282c030d86.
As described in the bug, the proposed approach is invalid, as Blink's bindings
code isn't ready to deal with terminated scripts properly, resulting in random
crashes. Hence reverting the patch.
BUG=390906
Review URL: https://codereview.chromium.org/534093004
Cr-Commit-Position: refs/heads/master@{#293146}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libexpat and instead link
Chromium's copy, and stop removing the expat sources from the checkout.
This increases binary size by ~64KB.
Also remove an obsolete comment about using the system version of
sqlite; this was never implemented and now will not be.
BUG=409851
Review URL: https://codereview.chromium.org/534603002
Cr-Commit-Position: refs/heads/master@{#293115}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This essentially reverts http://crrev.com/531583002. The super
call is necessary for measuring children, however the super call
should also happen before the call th mAwContents.onMeasure to
make sure the right set of measuredDimensions are used.
BUG=None
TEST=AndroidWebViewTest
TBR=boliu@chromium.org
Review URL: https://codereview.chromium.org/536873002
Cr-Commit-Position: refs/heads/master@{#293111}
|
|
|
|
|
|
|
|
|
|
|
|
| |
It shouldn't matter much but the onMeasure method should be overridden
without calling super.
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/531583002
Cr-Commit-Position: refs/heads/master@{#292953}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This updates the manifest to incorporate newest changes to
the AOSP frameworks/webview project.
BUG=None
TESTS=compile on aosp bot
R=torne@chromium.org
Review URL: https://codereview.chromium.org/527183003
Cr-Commit-Position: refs/heads/master@{#292922}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We check if we have camera or mic access when devices are enumerated to determine if labels should be visible or not. We must ensure all settings are checked when doing this.
* Add interface to ContentBrowserClient for checking media access permission. Add implementation in //chrome.
* Refactor permission checking in MediaStreamDevicesController to be able to use them from elsewhere.
* Add checking policy and app permission to the existing content settings check.
* Remove old interfaces on ResourceContext and its implementations.
* Move the permission check from MediaStreamDispatcherHost to MediaStreamManager.
* Refactor MediaStreamManager to be able to mock the check function and update unit test to mock it.
TBR=jochen@chromium.org (for a few trivial changes)
BUG=406094
Review URL: https://codereview.chromium.org/483523006
Cr-Commit-Position: refs/heads/master@{#292868}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).
Committed previously: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438
Review URL: https://codereview.chromium.org/414503004
Cr-Commit-Position: refs/heads/master@{#292761}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
id:160001 of https://codereview.chromium.org/414503004/)
Reason for revert:
clang
Original issue's description:
> android: Use hw acceleration in android_webview_shell
>
> This creates a (GL)SurfaceView overlay on top of the shell
> container view which runs its own thread for rendering.
> It calls into the native draw functor through a small
> dynamic library (drawgl.so).
>
> NOTRY=True
>
> Committed: https://chromium.googlesource.com/chromium/src/+/09acbf59e7e8f1de574498ee5ba8eae0b0775438
TBR=boliu@chromium.org,mkosiba@chromium.org,hush@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/524933002
Cr-Commit-Position: refs/heads/master@{#292728}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This creates a (GL)SurfaceView overlay on top of the shell
container view which runs its own thread for rendering.
It calls into the native draw functor through a small
dynamic library (drawgl.so).
NOTRY=True
Review URL: https://codereview.chromium.org/414503004
Cr-Commit-Position: refs/heads/master@{#292718}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/337473004
Cr-Commit-Position: refs/heads/master@{#292693}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/519593002
Cr-Commit-Position: refs/heads/master@{#292675}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sort the list of input resource files for the jarjar resource step so
that the contents of generated makefiles in WebView have a stable
ordering.
BUG=
Review URL: https://codereview.chromium.org/516293003
Cr-Commit-Position: refs/heads/master@{#292671}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
deletion.
When the WebView app makes a call to java over the JavaScriptBridge,
we leave the renderer hanging on a synchronous IPC. Once control
is passed into Java, it's possible that the WebView may get destroyed
(and thus the IPC channel back to the renderer closed) which means we
can't unblock the renderer waiting on the IPC response.
Instead we cache the IPC reply message and while waiting on Java to come
back to us, if we detect that the RenderFrame has been deleted, send a
reponse back before the IPC channel is closed.
BUG=408188
Review URL: https://codereview.chromium.org/498633003
Cr-Commit-Position: refs/heads/master@{#292631}
|
|
|
|
|
|
|
|
|
|
|
|
| |
OpenSSL is no longer used by chromium and is not being merged any more.
libaddressinput and boringssl are being merged.
BUG=
NOTRY=true
Review URL: https://codereview.chromium.org/518803002
Cr-Commit-Position: refs/heads/master@{#292630}
|
|
|
|
|
|
|
|
|
|
|
| |
PdfMetafileSkia.
BUG=170859
TBR=sgurun, yzshen
Review URL: https://codereview.chromium.org/516833002
Cr-Commit-Position: refs/heads/master@{#292561}
|
|
|
|
|
|
|
|
| |
NOTRY=true
Review URL: https://codereview.chromium.org/524433003
Cr-Commit-Position: refs/heads/master@{#292549}
|
|
|
|
|
|
|
|
|
|
|
| |
Background color issue should already be fixed by
crbug.com/391462
BUG=384559
Review URL: https://codereview.chromium.org/517153002
Cr-Commit-Position: refs/heads/master@{#292540}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, if |compositor_needs_continuous_invalidate_| is unset before
PostFallbackTick or FallbackTickFired, then the fallback ticks are
cancelled, but we never unset |block_invalidates_|, which will block
invalidates indefinitely.
Fix is simply always unset |block_invalidates_| even if we skip
the fallback tick.
BUG=408779
Review URL: https://codereview.chromium.org/512403002
Cr-Commit-Position: refs/heads/master@{#292511}
|
|
|
|
|
|
|
|
| |
BUG=408525
Review URL: https://codereview.chromium.org/513173002
Cr-Commit-Position: refs/heads/master@{#292380}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
__OBJC__
Currently WebContentsViewDelegate has a mix of ObjectiveC and C++ code
guarded by #ifdef OS_MACOSX. This means, on Mac, it can only be included
in .mm files.
For views on Mac, we want to reuse the toolkit-views WCVD (and tests)
when hosting a WebContents in a views::Widget. So we can't convert
everything to .mm.
This CL changes the guards to use __OBJC__ and ensures the vtable is a
consistent size with the compile flags used on MacViews.
To reduce churn, the WCVD methods are given default implementations.
MacViews needs the other methods, currently guarded by USE_AURA, so
things get really complex without this.
BUG=399191
Review URL: https://codereview.chromium.org/507363002
Cr-Commit-Position: refs/heads/master@{#292349}
|
|
|
|
|
|
|
|
| |
BUG=
Review URL: https://codereview.chromium.org/508233002
Cr-Commit-Position: refs/heads/master@{#292246}
|
|
|
|
|
|
|
|
|
|
| |
TBR=eroman@chromium.org
BUG=none
TEST=green tree
Review URL: https://codereview.chromium.org/492623005
Cr-Commit-Position: refs/heads/master@{#292219}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
exitFullScreen() might be call without a prior call to
enterFullScreen() if a "misbehave" app overrides onShowCustomView
but does not add the custom view to the window. This fixes a
crash by returning early from exitFullScreen in that case.
BUG=408133
Review URL: https://codereview.chromium.org/501093007
Cr-Commit-Position: refs/heads/master@{#292165}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update to a recent version of AOSP master. The primary effect on
Chromium is that the android_aosp bot will now use a recent version of
clang when building chromium targets for host and thus we no longer need
to support using gcc 4.2 or 4.6 to compile host code here.
BUG=377684
NOTRY=true
Review URL: https://codereview.chromium.org/514653002
Cr-Commit-Position: refs/heads/master@{#292149}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HttpServer. (patchset #29 of https://codereview.chromium.org/296053012/)"
This reverts commit 0b2f33f4a88efbd203b0623324ad4114e3bb9d23.
This is relanding CL of https://codereview.chromium.org/296053012/, which broke http server unittests because http server doesn't send response synchronously any more.
This CL fixes unittests by reading responses completely.
Patch set #1 is same to the original CL.
Patch set #2 is the diff.
BUG=371906
TBR=pfeldman@chromium.org,darin@chromium.org,gunsch@chromium.org,mnaganov@chromium.org
Review URL: https://codereview.chromium.org/487013003
Cr-Commit-Position: refs/heads/master@{#291784}
|
|
|
|
|
|
|
|
| |
TBR=boliu@chromium.org,kolla@chromium.org,sadrul@chromium.org
Review URL: https://codereview.chromium.org/495423004
Cr-Commit-Position: refs/heads/master@{#291758}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Part of the refactoring effort to consolidate all fileapi/quota/webkit_database/webkit_blob-related code into a single namespace, directory, and component. Discussed here: https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4
This is itself part of a larger refactoring effort to get rid of the webkit/ directory, as recorded in the following bug:
BUG=338338
TBR=darin@chromium.org
Review URL: https://codereview.chromium.org/498273002
Cr-Commit-Position: refs/heads/master@{#291718}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This one contains the required API changes to include service workers in remote debugging.
For now service workers will show up as "untitled" as they do not have a title to speak of.
Split off https://codereview.chromium.org/349033009/
BUG=389454
TBR= mnaganov@chromium.org (android_webview/native/aw_dev_tools_server.cc)
Review URL: https://codereview.chromium.org/459403002
Cr-Commit-Position: refs/heads/master@{#291676}
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: https://codereview.chromium.org/491223002
Cr-Commit-Position: refs/heads/master@{#291633}
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=406854
Bug: b/17177684
Enabling channel ID causes problems for apps that use multiple network
stacks (such as httpurlconnection and webview) or multiple webviews
and want to share cookies. Disable until we provide some solution.
Review URL: https://codereview.chromium.org/497963002
Cr-Commit-Position: refs/heads/master@{#291610}
|
|
|
|
|
|
|
|
|
|
|
|
| |
Prevent calling postInvalidateOnAnimate inside VSync handler, because
this will cause the invalidation to be one frame delayed.
BUG=394604
Review URL: https://codereview.chromium.org/470523006
Cr-Commit-Position: refs/heads/master@{#291525}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(patchset #29 of https://codereview.chromium.org/296053012/)
Reason for revert:
looks like it caused net_unittests failures: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20(2)/builds/44610/steps/net_unittests/logs/MultipleRequestsOnSameConnection
Original issue's description:
> Replace StreamListenSocket with StreamSocket in HttpServer.
>
> 1) HttpServer gets ServerSocket instead of StreamListenSocket.
> 2) HttpConnection is just a container for socket, websocket, and pending read/write buffers.
> 3) HttpServer handles data buffering and asynchronous read/write.
> 4) HttpConnection has limit in data buffering, up to 1Mbytes by default.
> 5) For devtools, send buffer limit is 100Mbytes.
> 6) Unittests for buffer handling in HttpConnection.
>
> BUG=371906
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291447
NOTREECHECKS=true
NOTRY=true
TBR=rsleevi@chromium.org
Review URL: https://codereview.chromium.org/497223003
Cr-Commit-Position: refs/heads/master@{#291521}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291521 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
namespaces into single storage namespace
As discussed here:
https://groups.google.com/a/chromium.org/forum/#!topic/storage-dev/aQall8GOrS4
BUG=338338
TBR=cevans
NOTRY=true
Review URL: https://codereview.chromium.org/492873002
Cr-Commit-Position: refs/heads/master@{#291485}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291485 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By default, PopupWindows dismiss when the user touches outside the window. The only
way to avert this behavior when using a ListPopupWindow is to rely on a hidden API.
This manifested as the linked bug because each tap dismissed the popup and detached it from the anchor view. C++ didn't realize the popup was dismissed, and tried to update it, but there was no anchor view.
BUG=400601
Review URL: https://codereview.chromium.org/442933002
Cr-Commit-Position: refs/heads/master@{#291463}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
All compositors that use SingleThreadProxy are left calling composite
synchronously and now pass a flag to indicate that this is their
intention. This patch doesn't remove synchronous composite, but now
makes it mutually exclusive with scheduling.
Only cc unittests are exercising this code at this point, although it
also unifies a lot of the code for CompositeImmediately with the
scheduled path.
BUG=329552, 287250
Review URL: https://codereview.chromium.org/134623005
Cr-Commit-Position: refs/heads/master@{#291451}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1) HttpServer gets ServerSocket instead of StreamListenSocket.
2) HttpConnection is just a container for socket, websocket, and pending read/write buffers.
3) HttpServer handles data buffering and asynchronous read/write.
4) HttpConnection has limit in data buffering, up to 1Mbytes by default.
5) For devtools, send buffer limit is 100Mbytes.
6) Unittests for buffer handling in HttpConnection.
BUG=371906
Review URL: https://codereview.chromium.org/296053012
Cr-Commit-Position: refs/heads/master@{#291447}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291447 0039d316-1c4b-4281-b951-d872f2087c98
|