summaryrefslogtreecommitdiffstats
path: root/app/app.gyp
Commit message (Collapse)AuthorAgeFilesLines
* Get rid of app/ directory as it's no longer used (finally).tfarina@chromium.org2011-08-061-44/+0
| | | | | | | | | | | BUG=72317 TEST=None R=tony@chromium.org Review URL: http://codereview.chromium.org/7491072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95711 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/sql/* files to sql/ directory.tfarina@chromium.org2011-07-191-5/+5
| | | | | | | | | | | | | | | | I can't remove app/app.gyp and app/app_base.gypi yet because they are referenced by third_party gyp files :( BUG=72317 TEST=None R=rsesek@chromium.org move app/sql to sql Review URL: http://codereview.chromium.org/7353026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93069 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the comments setting emands and vim tab width and expansion variables.tony@chromium.org2011-07-111-6/+0
| | | | | | | | | | | | | | | | | These were added in r28089 (http://codereview.chromium.org/256059) but are unnecessary bloat for everyone to carry around, even those that don't use emacs or vim. In an earlier change, I added editor config files in src/tools/emacs/ and src/tools/vim/ so users of the appropriate editor can source those instead. BUG=none TEST=none Review URL: http://codereview.chromium.org/7310019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92046 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/resources/* to ui/resources/ directory.tfarina@chromium.org2011-06-291-17/+0
| | | | | | | | | | | BUG=72317 TEST=None R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7253057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91010 0039d316-1c4b-4281-b951-d872f2087c98
* app: Remove the dependency on app_resources from app_unittests.tfarina@chromium.org2011-06-221-1/+0
| | | | | | | | | | | BUG=72317 TEST=app_unittests R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7233020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90081 0039d316-1c4b-4281-b951-d872f2087c98
* app: Get rid of AppTestSuite class.tfarina@chromium.org2011-06-201-4/+0
| | | | | | | | | | | BUG=72317 TEST=app_unittests R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7210017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89706 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move resource_bundle_unittest.cc from app.gyp to ui_unittests.gypi.tfarina@chromium.org2011-06-201-1/+0
| | | | | | | | | | | | | This was the last remaining test to move. BUG=72317 TEST=ui_unittests R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7201011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89665 0039d316-1c4b-4281-b951-d872f2087c98
* app: Trim down the dependency list of app_unittests.tfarina@chromium.org2011-06-201-8/+0
| | | | | | | | | | | BUG=72317 TEST=app_unittests R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7200014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89662 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move more two unittests from app/app.gyp to ui_unittests.gypi.tfarina@chromium.org2011-06-171-8/+0
| | | | | | | | | | | BUG=None TEST=None R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7202003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89515 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move gtk_dnd_util_unittest.cc from app.gyp to ui_unittests.gypi.tfarina@chromium.org2011-06-171-10/+0
| | | | | | | | | | | BUG=None TEST=ui_unittests --gtest_filter=GtkDndUtilTest.* R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7200004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89492 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move data_pack_unittest.cc from app.gyp to ui_unittests.gypi.tfarina@chromium.org2011-06-171-2/+0
| | | | | | | | | | | BUG=None TEST=ui_unittests --gtest_filter=DataPackTest.* R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7189034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89480 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Move more unittests from app/app.gyp to ui_unittests.gypi.tfarina@chromium.org2011-06-161-3/+0
| | | | | | | | | | | BUG=None TEST=ui_unittests R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7167015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89335 0039d316-1c4b-4281-b951-d872f2087c98
* Remove msvs_guids from app, base, breakpad and build.tony@chromium.org2011-06-131-2/+0
| | | | | | | | BUG=28727 Review URL: http://codereview.chromium.org/7108053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88871 0039d316-1c4b-4281-b951-d872f2087c98
* Move tree_node_* unittests to ui_unittests.gypi.tfarina@chromium.org2011-06-101-2/+0
| | | | | | | | | | | BUG=None TEST=None R=rsesek@chromium.org Review URL: http://codereview.chromium.org/7134075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88694 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to have chrome building with net.dllrvargas@google.com2011-06-031-0/+1
| | | | | | | | BUG=76997 TEST=none Review URL: http://codereview.chromium.org/7056049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87873 0039d316-1c4b-4281-b951-d872f2087c98
* Remove files that are compiled in both ui_base and app_base.tony@chromium.org2011-05-201-6/+2
| | | | | | | | | | | | This causes problems when linking because there are duplicate symbols when the same file is compiled into two libs. Previously we were letting the linker collapse these, but that's slow and will start throwing errors once gyp is rolled. Review URL: http://codereview.chromium.org/7040022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86110 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to base/.willchan@chromium.org2011-05-181-1/+0
| | | | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85732 Review URL: http://codereview.chromium.org/7015017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85737 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 85732 (broke build) - Move SystemMonitor to base/.willchan@chromium.org2011-05-181-0/+1
| | | | | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7042003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85734 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to base/.willchan@chromium.org2011-05-181-1/+0
| | | | | | | | | | | | | I plan to use SystemMonitor in net/. Fix up the Mac implementation not to use Cocoa APIs since @interface is not allowed in base. BUG=none TEST=none Review URL: http://codereview.chromium.org/7015017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85732 0039d316-1c4b-4281-b951-d872f2087c98
* The gyp files don't have a way to refer to POSIX-like OS's as a group, so I ↵mark@chromium.org2011-05-121-2/+2
| | | | | | | | | | | | | | | | defined os_posix, toolkit_gtk, and use_x11 in common.gypi to handle them. I used something similar when porting Chromium 10 and 11 to OpenBSD and Solaris, plus a version of this patch has been tested on FreeBSD. Chromium has also been built on other BSDs, so rather than adding each Unix to every gyp file individually every time another port is added, these broad defines can be used instead and modified with specific logic only where necessary. I included a few modified gyp files so the usage can be seen. I also added sunos5 to some grd/html files and set the default host_arch on i86pc solaris to ia32. BUG=0 TEST={} Patch by ruben <chromium@hybridsource.org>. Review URL: http://codereview.chromium.org/6965007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85154 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash that happens if we fail to mmap resources.pak.tony@chromium.org2011-04-191-0/+1
| | | | | | | | | | | | | | | | | The crash happens if mmap_ is null in DataPack so I just added some null checks. Some features still won't work (inspector, bookmark manager, about:net-internals, etc), but we shouldn't crash. I'm going to write a follow up patch that brings up a dialog asking to reinstall and check for quarantined files if resources.pak fails to load (kind of like the dialog that comes up when the history db can't be loaded). BUG=79252 TEST=covered by app_unittests Review URL: http://codereview.chromium.org/6835034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82111 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup SQLite 3.6.18 import.shess@chromium.org2011-04-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | Get things spic-n-span for converting to the amalgamation, then SQLite 3.7.x. sqlite3Preload -> sqlite3_preload because in the amalgamation, sqlite3_ is the key bit to make sure things aren't marked static. AFAICT, SQLite 3.6.18 was not imported correctly last time, throwing up spurious deltas. Re-import and re-apply patches. Remove a bunch of Gears-related stuff. Quite some time ago the Chromium and Gears SQLite imports were brought into line, but they were never fully shared. Nowadays these are completely useless: - remove fts1 patches. - add a Chromium test to make sure fts1 doesn't sneak in. - drop the Symbian stuff. - drop database poisoning. Pull out the WebDatabase patch into a patch file. Move ICU shell changes into a distinct patch file. Pull out testing patches into a separate test.patch. BUG=71731 TEST=automated testing and watching closely. Review URL: http://codereview.chromium.org/6823057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81296 0039d316-1c4b-4281-b951-d872f2087c98
* Standardize grit invokesthomasvl@chromium.org2011-03-281-28/+6
| | | | | | | | | | | | | - Add two gypi files to src/build for the boilerplate added to targets and actions - Update grit_info to also support the -E flag so it can share more of the grit build commandline - switch over all but the webkit and webkit glue grd files to use the common support BUG=22247 TEST=everything still localized correctly Review URL: http://codereview.chromium.org/6705030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79548 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: Move app_strings to ui/base/stringssail@chromium.org2011-03-081-81/+1
| | | | | | | | | | To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings. BUG=72317 TEST=Compiled on Mac, Linux, Windows. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77337 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77068 - Carnitas: Move app_strings to ui/base/stringssail@chromium.org2011-03-071-1/+81
| | | | | | | | | | | | | | To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings. BUG=72317 TEST=Compiled on Mac, Linux, Windows. Review URL: http://codereview.chromium.org/6541035 TBR=sail@chromium.org Review URL: http://codereview.chromium.org/6623055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77142 0039d316-1c4b-4281-b951-d872f2087c98
* Carnitas: Move app_strings to ui/base/stringssail@chromium.org2011-03-061-81/+1
| | | | | | | | | | | To fix circular dependencies between ui/base/ui_base.gyp and app/app.gyp I'm moving app_strings to ui/base/strings. BUG=72317 TEST=Compiled on Mac, Linux, Windows. Review URL: http://codereview.chromium.org/6541035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77068 0039d316-1c4b-4281-b951-d872f2087c98
* More test out-of-lining.erg@google.com2011-02-141-0/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6484043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74879 0039d316-1c4b-4281-b951-d872f2087c98
* Cross-platform CL to remove app/win/win_util.h&cc and related work.msw@chromium.org2011-02-031-2/+0
| | | | | | | | | | | | | | | | | | | | See Issue 70141 for the full move details; see my inline review comments. Changes significantly different from or beyond those prescribed by the bug: *Consolidated a lot of GrabWindowSnapshot code. *Moved EnsureRectIsVisibleInRect to views::internal namespace for test access. *Moved app/win/win_util_unittest.cc to views/window/window_win_unittest.h *Named ui/base/message_box_win.h instead of ui/base/message_box.h *Made WindowWin::GetWindowTitleFont static; needed in static contexts. *Denoted WindowWin::FrameTypeChanged as a Window override, moved code. *Moved TestGrabWindowSnapshot into new file: chrome/browser/ui/window_snapshot/window_snapshot_mac_unittest.mm BUG=70141 TEST=none Review URL: http://codereview.chromium.org/6386009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73589 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to ui/baseben@chromium.org2011-01-211-2/+2
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72227 0039d316-1c4b-4281-b951-d872f2087c98
* Move ResourceBundle, DataPack to ui/baseben@chromium.org2011-01-201-2/+2
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72038 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bustageben@chromium.org2011-01-201-3/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71971 0039d316-1c4b-4281-b951-d872f2087c98
* Move more dnd related files to ui/baseben@chromium.org2011-01-191-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6250014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71828 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor. Move HiResTimerManager to ↵ben@chromium.org2011-01-191-1/+1
| | | | | | | | | | | | | src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71797 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 71487 - Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-1/+1
| | | | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71489 0039d316-1c4b-4281-b951-d872f2087c98
* Move SystemMonitor to src/ui/base/system_monitor.ben@chromium.org2011-01-141-1/+1
| | | | | | | | | | | | Move HiResTimerManager to src/chrome/common. BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6361002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71487 0039d316-1c4b-4281-b951-d872f2087c98
* Move models from app to ui/base/modelsben@chromium.org2011-01-141-2/+2
| | | | | | | | | BUG=none TEST=none TBR=brettw git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71446 0039d316-1c4b-4281-b951-d872f2087c98
* Move OSExchangeData from src/app to src/ui/base/dragdropben@chromium.org2011-01-121-3/+7
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6200005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71205 0039d316-1c4b-4281-b951-d872f2087c98
* Move clipboard from app/ to ui/baseben@chromium.org2011-01-101-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6135006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70938 0039d316-1c4b-4281-b951-d872f2087c98
* Fix grit dependencies for chromeos, touchui, and toolkit_views.tony@chromium.org2011-01-081-1/+2
| | | | | | | | | | | | We weren't passing in the grit defines to grit_info.py, so we weren't getting the dependencies behind <if> blocks included in the Makefile. BUG=68028 Review URL: http://codereview.chromium.org/6109003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70822 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor grit -D flags into a gyp variable so we don'ttony@chromium.org2011-01-071-15/+4
| | | | | | | | | | | | have to repeat the logic for it in a bunch of different places. I had to add another level of variables{} so I could use use_titlecase_in_grd_files in a condition. I also removed some quotes around default values since that seems to be the more common way to express boolean values. BUG=68028 Review URL: http://codereview.chromium.org/6070011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70757 0039d316-1c4b-4281-b951-d872f2087c98
* Move animation code to new ui/base/animation directory.ben@chromium.org2011-01-071-4/+0
| | | | | | | | | | BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6154001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70743 0039d316-1c4b-4281-b951-d872f2087c98
* Move app/win_util to app/win and fix the namespace usage.brettw@google.com2010-12-311-1/+1
| | | | | | | | | | | | | | Split out the two classes: ScopedComInitializer and ScopedCOMem (which I renamed) to separate files. I removed the win_util_path file which had one function in it and moved the function to win_util. Somehow, this was getting picked up by the nacl64 build and the call in sandbox_policy was then not being defined. I just implemented the function in-plcae since it's just a simple wrapper around a Windows API call. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6013009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70343 0039d316-1c4b-4281-b951-d872f2087c98
* Move data pack from base to app (it's just part of the resource bundle system).brettw@chromium.org2010-12-231-0/+1
| | | | | | | | TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/5992006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70038 0039d316-1c4b-4281-b951-d872f2087c98
* Integrates libjpeg-turbo into Chromium (Chromium side)hbono@chromium.org2010-12-071-1/+1
| | | | | | | | | | This change is the Chromium-side change that integrates libjpeg-turbo into Chromium. (We need another change for WebKit.) It adds a GYP option 'libjpeg_turbo' so we can switch from libjpeg to libjpeg-turbo and use libjpeg-turbo when its value is 1. (Unfortunately, its value must be 0 for now to avoid build breaks until we land all changes required for libjpeg-turbo.) BUG=48789 TEST=build Chromium. Review URL: http://codereview.chromium.org/5292007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68453 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2010-11-211-0/+2
| | | | | | | | | | | | | | | Converts usage of SetProp/GetProp to a map. Even after making sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 TEST=none TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/5144005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66920 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ↵sky@chromium.org2010-11-191-2/+0
| | | | | | | | | | | | | | | | | sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/5184009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66786 0039d316-1c4b-4281-b951-d872f2087c98
* Converts usage of SetProp/GetProp to a map. Even after making sure wesky@chromium.org2010-11-191-0/+2
| | | | | | | | | | | | clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66784 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63191 - 2nd try:phajdan.jr@chromium.org2010-10-201-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | Fix regression where high resolution timers could be activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Broke unit_tests on Vista and XP: [ RUN ] GeolocationNetworkProviderTest.GatewayAndWifiScans [2916:2376:1020/030222:2975321329:FATAL:network_location_provider.cc(51)] Check failed: cache_.size() == cache_times_.size(). Review URL: http://codereview.chromium.org/3889004 TBR=mbelshe@chromium.org Review URL: http://codereview.chromium.org/3946003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63200 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd try:mbelshe@chromium.org2010-10-201-0/+1
| | | | | | | | | | | | | | | | Fix regression where high resolution timers could be activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Review URL: http://codereview.chromium.org/3889004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63191 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63176 - Fix regression where high resolution timers could be ↵mbelshe@chromium.org2010-10-201-1/+0
| | | | | | | | | | | | | | | | | | | | activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Review URL: http://codereview.chromium.org/3848002 TBR=mbelshe@chromium.org Review URL: http://codereview.chromium.org/3948001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63177 0039d316-1c4b-4281-b951-d872f2087c98