summaryrefslogtreecommitdiffstats
path: root/app/menus
Commit message (Collapse)AuthorAgeFilesLines
* Add ActivatedAtWithDisposition to MenuModel.estade@chromium.org2010-11-112-0/+9
| | | | | | | | | | | Also, use it in MenuGtk, and implement it in BackForwardMenuModel. BUG=38452 TEST=manual Review URL: http://codereview.chromium.org/4780001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65739 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: The wrench menu should remain open after clicking +/-.erg@google.com2010-09-202-1/+28
| | | | | | | | | | | | | This changes the model so there's a property about whether a button should dismiss the menu, modifies the GtkCustomMenu[Item] implementation to obey it, and modifies the BrowserToolbar to update the menu on zoom change. BUG=48240 TEST=matches windows behaviour Review URL: http://codereview.chromium.org/3391009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59963 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-033-11/+11
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-023-11/+11
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-023-11/+11
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-013-11/+11
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-013-11/+11
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* The "Update Chrome" menu item should appear in addition to the About menu.erg@google.com2010-08-314-1/+26
| | | | | | | | | | | It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation. BUG=46221 TEST=The upgrade item should now appear under instead of replacing the about command. Review URL: http://codereview.chromium.org/3143046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58040 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply menu model cleanups, with WrenchMenuModel being a SimpleMenuModel.erg@google.com2010-08-251-0/+15
| | | | | | | | | BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3184021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57384 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate." ↵erg@google.com2010-08-241-14/+0
| | | | | | | | | | (r57119) TBR=rsesek Review URL: http://codereview.chromium.org/3163035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57128 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate.erg@google.com2010-08-231-0/+14
| | | | | | | | | | | This removes copy-pasted code in each platform implementation. BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3163023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57119 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 5ziadh@chromium.org2010-08-021-0/+3
| | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3080013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54540 0039d316-1c4b-4281-b951-d872f2087c98
* The button menu items on GTK menus honor the enabled state of the command.sanjeevr@chromium.org2010-07-292-1/+8
| | | | | | | | | BUG=None TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise. Review URL: http://codereview.chromium.org/3032038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-271-0/+3
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will ↵sanjeevr@chromium.org2010-07-272-0/+10
| | | | | | | | | | | be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. BUG=None. TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled. Review URL: http://codereview.chromium.org/3026025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-266-0/+6
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementations in menu model stuff from header to implementation.erg@chromium.org2010-07-164-33/+60
| | | | | | | | | | | This breaks a dependency on SkBitmap.h for everything that just uses menus. BUG=none TEST=none Review URL: http://codereview.chromium.org/2854046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52751 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Put buttons into the new unified Wrench menu.rsesek@chromium.org2010-07-151-1/+2
| | | | | | | | | | | | This also makes changes to MenuController to support NIB-based initialization. Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru). BUG=47848 TEST=Click on Wrench menu and see buttons. Buttons perform their function. Review URL: http://codereview.chromium.org/2923009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup: SkBitmap and other unnecessary includes.erg@chromium.org2010-07-122-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52093 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Grouped buttons should be equal sizes in new wrench menu.erg@chromium.org2010-07-092-32/+15
| | | | | | | | | | | | | This completes the linux implementation of the new wrench menu. Turning on by default. Will watch how this goes. BUG=45757 TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons should be equal. Review URL: http://codereview.chromium.org/2961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51974 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanups to the new wrench menu.erg@chromium.org2010-06-302-17/+55
| | | | | | | | | | | | | | | - Make the rendering for multiple buttons pretty by unifying sequnces of buttons. - Add the zoom label control and make the wrench menu model listen for notifications about zoom percentage changing. - Fixes crash that would have gone away once this was taken out from behind a flag BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2799043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r50859 with chromeos fixes.erg@chromium.org2010-06-255-10/+203
| | | | | | | | | | | | | | | | GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. Review URL: http://codereview.chromium.org/2800015 BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50859 - GTK: First draft of the unified cut/copy/paste and ↵rafaelw@google.com2010-06-255-203/+10
| | | | | | | | | | | | | | | | | | +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2836029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.erg@chromium.org2010-06-255-10/+203
| | | | | | | | | | | | | Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50859 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give the Wrench menu keyboard shortcuts.rsesek@chromium.org2010-06-221-0/+58
| | | | | | | | | | | Note that these key equivalents are for display only and do not get fired. Commands are routed through the main menu/CommandUpdater. BUG=45098 TEST=Open Wrench menu, see keyboard shortcuts. Review URL: http://codereview.chromium.org/2800019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50452 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for the merged menu:sky@chromium.org2010-06-171-4/+10
| | | | | | | | | | | | | | | | | | | | | . makes the menu show the same fonts regardless of whether the item has children. . adds text color to MenuConfig. I'm going to use this for the buttons added to the menu. . Changes TextButton to update text_size_ when the font changes. . Changes TextButton to allow you to specify how accelerators are shown. . Nukes TextButton::OnMousePressed as it's not needed (super implementation does the right thing and updates state the TextButton::OnMousePressed wasn't). . Changes accelerator to have constructor taking keycode and modifiers. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2833013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50108 0039d316-1c4b-4281-b951-d872f2087c98
* Only use IDC_ values for command ids in the render view context menu.estade@chromium.org2010-05-132-14/+0
| | | | | | | | | BUG=43816 TEST=none Review URL: http://codereview.chromium.org/1981014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47187 0039d316-1c4b-4281-b951-d872f2087c98
* Re-organize RenderViewContextMenu to the use cross-platform MenuModel class.estade@chromium.org2010-05-112-26/+76
| | | | | | | | | | | | | | | | | | Benefits: - less code - more straightforward code - more shared code unresolved issues: - RenderViewContextMenu{Gtk,Mac,Views} should not be a subclass of RenderViewContextMenu - On Linux, IMEs are added in the wrong place (not near the other editable stuff) BUG=31365 TEST=manual + trybots Review URL: http://codereview.chromium.org/2017001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46987 0039d316-1c4b-4281-b951-d872f2087c98
* Add icons to SimpleMenuModel.estade@chromium.org2010-05-052-14/+33
| | | | | | | | | | | | Also get rid of one of the MenuGtk constructors (now down to 2). Also, stamp out one more use of MenuGtk::Delegate as a controller class. BUG=31365 TEST=manual (in debug mode) + trybots Review URL: http://codereview.chromium.org/1915004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46434 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-171-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* New network menu button UI for ChromeOS.chocobo@chromium.org2010-02-191-0/+10
| | | | | | | | | Added ability to change label font in gtk menu item. TEST=none BUG=none Review URL: http://codereview.chromium.org/650074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39516 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild app menu in ToolbarView::RunAppMenuxiyuan@chromium.org2010-02-061-3/+8
| | | | | | | | | | | | When "enable-udd-profiles" switch is set, update profile submenu and rebuild app menu if necessary. BUG=30417 TEST=Verify that comment 5 in issue 30417 is fixed. Review URL: http://codereview.chromium.org/571015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38281 0039d316-1c4b-4281-b951-d872f2087c98
* Make open tab items check item.oshima@chromium.org2010-02-051-1/+1
| | | | | | | | | | | and fixed comment in simple_menu_model.h BUG=chromium-os:1217 TEST=none Review URL: http://codereview.chromium.org/575012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38263 0039d316-1c4b-4281-b951-d872f2087c98
* Insert methods for SimpleMenuModeloshima@chromium.org2010-01-272-0/+78
| | | | | | | | | | | Don't recreate AppMenuModel in ToolbarView as it now supports updating label dynamically. BUG=none TEST=manual: enabling/disabling bookmark sync will update the bookmark sync label correcty. Review URL: http://codereview.chromium.org/551171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37333 0039d316-1c4b-4281-b951-d872f2087c98
* Make a MenuModel for the popup favicon menu. For now only GTK uses it. ↵estade@chromium.org2010-01-191-7/+19
| | | | | | | | | | | | Consolidate all accelerators for browser commands into one place. BUG=28212,27535 TEST=1. enable custom frame and a popup window and test that the popup contains all the same (non-system) menu items as windows. 2. all context menus still display the correct shortcuts and the shortcuts work Review URL: http://codereview.chromium.org/551032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36527 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make tab context menu use tab_menu_modelestade@chromium.org2010-01-051-0/+46
| | | | | | | | | | | flesh out some more menu model implementation for MenuGtk BUG=28977 TEST=menu still works as before Review URL: http://codereview.chromium.org/523049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35569 0039d316-1c4b-4281-b951-d872f2087c98
* Share the code that builds the page menu in a common model, make Mac and Win ↵pinkerton@chromium.org2009-12-091-0/+2
| | | | | | | | | | use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code. BUG=22646 TEST=page menu should work as before Review URL: http://codereview.chromium.org/465130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-045-0/+447
BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-24 20:49:56 +0000