| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file.
(Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.)
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3452030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
For awhile we had an error where an invalid page_size was being passed in, and SQLite silently ignored it. No more! Fix cache_size logging line. Pull the exclusive locking up to fail more obviously in case someone else has the exclusive lock.
Also, I don't think our code is likely handling the SQLITE_BUSY case correctly. Added some initial code to execute some sql with a timeout.
BUG=56559
TEST=unit tests
Review URL: http://codereview.chromium.org/3413028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60799 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a log line to try to track down an SQLite error happening on the
waterfall. Should only be emitted in case of a bad thing happening,
like file-descriptors closing out from under us, so I can't think of
why this would ever be hit for real.
BUG=56427
TEST=no effect
Attempt to test extended error codes. Fail.
Review URL: http://codereview.chromium.org/3433016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will only apply to app/sql Connection and Statement objects for
now.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3467001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59897 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=good spellers are slightly happier
Review URL: http://codereview.chromium.org/3143037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=evan
BUG=22208
Review URL: http://codereview.chromium.org/3159027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from our patches, READMEs, etc.
Also, add a shim header so we can use it for building
with system sqlite.
TEST=compile
BUG=22208
Review URL: http://codereview.chromium.org/3108030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50273
TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux
TBR: erg
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The database will no longer store the thumbnails - TopSites is storing it's own thumbnails.
BUG=None
TEST=ThumbnailDatabaseTest
Review URL: http://codereview.chromium.org/2842034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
password store migration, since otherwise fragments of password data may be left in it.
BUG=25404
TEST=the "Login Data" file should get deleted and recreated from scratch after migration
Review URL: http://codereview.chromium.org/2866023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
LoginDatabase.
BUG=None
TEST=compiles
Patch from Thiago Farina <thiago.farina@gmail.com>
Review URL: http://codereview.chromium.org/1700017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
fold.
TEST=manual
BUG=none
Review URL: http://codereview.chromium.org/1508016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fix for Crash Report: http://go/crash/reportdetail?reportid=7ea9ff0f4697aa57
The AutoFill sql assertion logic was constructing an std::string from 0 when invalid data was encountered. This caused a c++ exception and then program termination. Correct logic is to return empty string. Note, this fix does not address the underlying database corruption, only the crash.
BUG=38241
TEST=none
Review URL: http://codereview.chromium.org/1016004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/830002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bookmark-only columns. Add getters and setters for BookmarkSpecifics to
syncapi as well as syncable entries. Make the datatype be a required
property when creating a syncapi node. Add a datatype for the 'google
chrome' top level folder. Add database migrations from version 67 to
the new schema. Add infrastructure to support migrations generically.
Add unit tests for the migrations.
Pull a new version of the protobuf library to pick up a fix for a
bug that this change exposed (I upstreamed the fix).
Fix some example code in the sql helpers so that it would actually
compile.
BUG=29899,30041
TEST=New unit tests for migrations: unit tests are based on actual
database dumps. Additionally, I manually tested 2-client sync using
combos of old-protocol servers, new-protocol servers, and initial
database versions v67, v68, and v0 (new client). I manually verified
that add/edit/delete works in these combination cases. Afterwards I
verified (by inspecting the sync databases) that the ModelTypes are
consistent across the various migration/protocol paths.
Review URL: http://codereview.chromium.org/554066
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still nothing is being written to disk with this CL,
in-memory SQLite and DiskCaches are being utilized.
Responses are not yet being removed from the DiskCasche
when the should be. Once that's done (in the next CL), we'll
start saving things on disk.
BUG=none
TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc
Review URL: http://codereview.chromium.org/518020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still nothing is being written to disk with this CL,
inmemory SQLite and DiskCaches are being utilized.
Responses are not yet being removed from the DiskCasche
when the should be. Once that's done (in the next CL), we'll
start saving things on disk.
BUG=none
TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc
Review URL: http://codereview.chromium.org/501033
TBR=michaeln@chromium.org
Review URL: http://codereview.chromium.org/519018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Still nothing is being written to disk with this CL,
in-memory SQLite and DiskCaches are being utilized.
Responses are not yet being removed from the DiskCasche
when the should be. Once that's done (in the next CL), we'll
start saving things on disk.
BUG=none
TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc
Review URL: http://codereview.chromium.org/501033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. If we can't init the web db a dialog is shown to the user.
. If we can't init the web db the default search provider no longer
becomes NULL.
BUG=28374
TEST=none
Review URL: http://codereview.chromium.org/501090
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/400016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/405005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32201 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=26749
Review URL: http://codereview.chromium.org/360042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
reports failure. This meant we were never preloading data.
TEST=covered by perf tests
http://crbug.com/23854
Review URL: http://codereview.chromium.org/265018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
support the needs of history.
BUG=none
TEST=covered by unit tests
Review URL: http://codereview.chromium.org/246053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This part is just the plumbing of the error detection and notification.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/223003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27268 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
wrapper. This also moves and renamed the old cookie_monster_sqlite file to
match the class name.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/201099
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/200113
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26067 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
inclueds.
TEST=run checkdeps (as on buildbot)
BUG=none
Review URL: http://codereview.chromium.org/201098
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
one, combined with the statement cache in a nice way. It is designed to
entirely wrap sqlite so that we can catch corrupt errors in the future and
"do something" when we get them without having to change all the calling code.
There is also a new meta_table file which is almost exactly like the old one
but which uses the new sql interface.
This patch changes Chrome's history TextDatabase to use this new wrapper as a
proof of concept, because this usage is relatively well-confined.
Review URL: http://codereview.chromium.org/199047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26022 0039d316-1c4b-4281-b951-d872f2087c98
|