summaryrefslogtreecommitdiffstats
path: root/app/sql
Commit message (Collapse)AuthorAgeFilesLines
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-1/+1
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Moves code to the headers.erg@google.com2010-09-282-1/+9
| | | | | | | | | | | | | One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file. (Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3452030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
* app/sql/connection hygiene enforcement.shess@chromium.org2010-09-282-9/+67
| | | | | | | | | | | | | For awhile we had an error where an invalid page_size was being passed in, and SQLite silently ignored it. No more! Fix cache_size logging line. Pull the exclusive locking up to fail more obviously in case someone else has the exclusive lock. Also, I don't think our code is likely handling the SQLITE_BUSY case correctly. Added some initial code to execute some sql with a timeout. BUG=56559 TEST=unit tests Review URL: http://codereview.chromium.org/3413028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60799 0039d316-1c4b-4281-b951-d872f2087c98
* Track down errno for SQLITE_IOERR_WRITE is happening.shess@chromium.org2010-09-213-2/+18
| | | | | | | | | | | | | | | | Adds a log line to try to track down an SQLite error happening on the waterfall. Should only be emitted in case of a bad thing happening, like file-descriptors closing out from under us, so I can't think of why this would ever be hit for real. BUG=56427 TEST=no effect Attempt to test extended error codes. Fail. Review URL: http://codereview.chromium.org/3433016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60125 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extended error codes for SQLite.shess@chromium.org2010-09-182-0/+11
| | | | | | | | | | | | This will only apply to app/sql Connection and Statement objects for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/3467001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59897 0039d316-1c4b-4281-b951-d872f2087c98
* Spelling correction: "nonexistant" -> "nonexistent".viettrungluu@chromium.org2010-08-223-8/+8
| | | | | | | | | BUG=none TEST=good spellers are slightly happier Review URL: http://codereview.chromium.org/3143037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DEPS after moving SQLite code.phajdan.jr@chromium.org2010-08-191-1/+1
| | | | | | | | | | TBR=evan BUG=22208 Review URL: http://codereview.chromium.org/3159027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56625 0039d316-1c4b-4281-b951-d872f2087c98
* Move bundled copy of sqlite one level deeper to better separate itphajdan.jr@chromium.org2010-08-185-5/+5
| | | | | | | | | | | | | from our patches, READMEs, etc. Also, add a shim header so we can use it for building with system sqlite. TEST=compile BUG=22208 Review URL: http://codereview.chromium.org/3108030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-266-0/+6
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the Thumbnails database file to Favicons.nshkrob@chromium.org2010-06-301-1/+2
| | | | | | | | | | | The database will no longer store the thumbnails - TopSites is storing it's own thumbnails. BUG=None TEST=ThumbnailDatabaseTest Review URL: http://codereview.chromium.org/2842034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51294 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: delete the unencrypted login database file after a successful ↵mdm@chromium.org2010-06-292-1/+7
| | | | | | | | | | password store migration, since otherwise fragments of password data may be left in it. BUG=25404 TEST=the "Login Data" file should get deleted and recreated from scratch after migration Review URL: http://codereview.chromium.org/2866023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51094 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of MetaTableHelper class and make use of the app/sql API in the ↵stuartmorgan@chromium.org2010-05-112-2/+35
| | | | | | | | | | | | | LoginDatabase. BUG=None TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1700017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46929 0039d316-1c4b-4281-b951-d872f2087c98
* Include the appcache and database tracker databases into the sql diagnostics ↵michaeln@chromium.org2010-04-021-0/+44
| | | | | | | | | | | | fold. TEST=manual BUG=none Review URL: http://codereview.chromium.org/1508016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43534 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to AutoFill sql Crash Reportdhollowa@chromium.org2010-03-161-1/+1
| | | | | | | | | | | | | Fix for Crash Report: http://go/crash/reportdetail?reportid=7ea9ff0f4697aa57 The AutoFill sql assertion logic was constructing an std::string from 0 when invalid data was encountered. This caused a c++ exception and then program termination. Correct logic is to return empty string. Note, this fix does not address the underlying database corruption, only the crash. BUG=38241 TEST=none Review URL: http://codereview.chromium.org/1016004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41757 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* In the sync database, use protobuf-based storage. Drop the oldnick@chromium.org2010-01-272-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | bookmark-only columns. Add getters and setters for BookmarkSpecifics to syncapi as well as syncable entries. Make the datatype be a required property when creating a syncapi node. Add a datatype for the 'google chrome' top level folder. Add database migrations from version 67 to the new schema. Add infrastructure to support migrations generically. Add unit tests for the migrations. Pull a new version of the protobuf library to pick up a fix for a bug that this change exposed (I upstreamed the fix). Fix some example code in the sql helpers so that it would actually compile. BUG=29899,30041 TEST=New unit tests for migrations: unit tests are based on actual database dumps. Additionally, I manually tested 2-client sync using combos of old-protocol servers, new-protocol servers, and initial database versions v67, v68, and v0 (new client). I manually verified that add/edit/delete works in these combination cases. Afterwards I verified (by inspecting the sync databases) that the ModelTypes are consistent across the various migration/protocol paths. Review URL: http://codereview.chromium.org/554066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
* AppCacheDatabase and SQL based AppCacheStorageImpl. michaeln@chromium.org2009-12-294-17/+16
| | | | | | | | | | | | | | | Still nothing is being written to disk with this CL, in-memory SQLite and DiskCaches are being utilized. Responses are not yet being removed from the DiskCasche when the should be. Once that's done (in the next CL), we'll start saving things on disk. BUG=none TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc Review URL: http://codereview.chromium.org/518020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35354 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35328 - AppCacheDatabase and SQL based AppCacheStorageImpl.michaeln@google.com2009-12-294-16/+17
| | | | | | | | | | | | | | | | | | Still nothing is being written to disk with this CL, inmemory SQLite and DiskCaches are being utilized. Responses are not yet being removed from the DiskCasche when the should be. Once that's done (in the next CL), we'll start saving things on disk. BUG=none TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc Review URL: http://codereview.chromium.org/501033 TBR=michaeln@chromium.org Review URL: http://codereview.chromium.org/519018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35329 0039d316-1c4b-4281-b951-d872f2087c98
* AppCacheDatabase and SQL based AppCacheStorageImpl.michaeln@chromium.org2009-12-294-17/+16
| | | | | | | | | | | | | | | Still nothing is being written to disk with this CL, in-memory SQLite and DiskCaches are being utilized. Responses are not yet being removed from the DiskCasche when the should be. Once that's done (in the next CL), we'll start saving things on disk. BUG=none TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc Review URL: http://codereview.chromium.org/501033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35328 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-181-0/+23
| | | | | | | | | | | | | . If we can't init the web db a dialog is shown to the user. . If we can't init the web db the default search provider no longer becomes NULL. BUG=28374 TEST=none Review URL: http://codereview.chromium.org/501090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34901 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lint errors in app/ and turn on presubmit check.erg@google.com2009-11-172-2/+2
| | | | | | Review URL: http://codereview.chromium.org/400016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32222 0039d316-1c4b-4281-b951-d872f2087c98
* Do not open a new connection if one has already been opened.dumi@chromium.org2009-11-171-0/+5
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/405005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32201 0039d316-1c4b-4281-b951-d872f2087c98
* First patch in making destructors of refcounted objects private.jam@chromium.org2009-11-051-2/+9
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SQL preloading. I did Run() with a SELECT which produces data, so itbrettw@chromium.org2009-10-071-1/+1
| | | | | | | | | | reports failure. This meant we were never preloading data. TEST=covered by perf tests http://crbug.com/23854 Review URL: http://codereview.chromium.org/265018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28301 0039d316-1c4b-4281-b951-d872f2087c98
* Convert history to use new sql wrappers. Enhance wrappers in several ways tobrettw@chromium.org2009-10-027-40/+102
| | | | | | | | | | support the needs of history. BUG=none TEST=covered by unit tests Review URL: http://codereview.chromium.org/246053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27832 0039d316-1c4b-4281-b951-d872f2087c98
* Add basic sqlite error handling to the new sqlite handlerscpu@chromium.org2009-09-255-13/+120
| | | | | | | | | | | | This part is just the plumbing of the error detection and notification. BUG=none TEST=none Review URL: http://codereview.chromium.org/223003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27268 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the sqlite cookie database and web database to use the new sqlitebrettw@chromium.org2009-09-154-12/+36
| | | | | | | | | | | wrapper. This also moves and renamed the old cookie_monster_sqlite file to match the class name. BUG=none TEST=none Review URL: http://codereview.chromium.org/201099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing #include <string> in a new file that uses std::string.mark@chromium.org2009-09-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/200113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26067 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DEPS file for app/sql so checkdeps doesn't complain about the sqlitebrettw@chromium.org2009-09-111-0/+3
| | | | | | | | | | inclueds. TEST=run checkdeps (as on buildbot) BUG=none Review URL: http://codereview.chromium.org/201098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26033 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new wrapper for sqlite. This is mostly a large cleanup of the existingbrettw@chromium.org2009-09-1111-0/+1627
one, combined with the statement cache in a nice way. It is designed to entirely wrap sqlite so that we can catch corrupt errors in the future and "do something" when we get them without having to change all the calling code. There is also a new meta_table file which is almost exactly like the old one but which uses the new sql interface. This patch changes Chrome's history TextDatabase to use this new wrapper as a proof of concept, because this usage is relatively well-confined. Review URL: http://codereview.chromium.org/199047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26022 0039d316-1c4b-4281-b951-d872f2087c98