summaryrefslogtreecommitdiffstats
path: root/app/win_util.cc
Commit message (Collapse)AuthorAgeFilesLines
* Add clean-up code to SetAppIdForWindow().hbono@chromium.org2009-07-281-4/+8
| | | | | | | | | | | | | This is a follow-up change for r21596. It seems this change forgot calling pps->Release() and PropVariantClear(&pv). (InitPropVariantFromString() calls SHStrDupW() to create a copy of its input string, so we have to call PropVariantClear() and delete it.) To avoid an object leak and a memory leak, this change uses ScopedComPtr<IPropertyStore> to call Release() in its destructor and call PropVariantClear() to clean-up PROPVARIANT. (My JumpList class uses a class which encapsulates PROPVARIANT. We should move the class to win_util?) BUG=none TEST=none (Run Chromium on purify running on Windows 7.) Review URL: http://codereview.chromium.org/160150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21830 0039d316-1c4b-4281-b951-d872f2087c98
* Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to ↵brg@chromium.com2009-07-251-0/+54
| | | | | | | | | | set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group. Bug=7028 Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly) Review URL: http://codereview.chromium.org/159336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
* Add a command line argument to disable message boxes. This is useful toabarth@chromium.org2009-07-171-0/+5
| | | | | | | | | | | | | extension developers who want to package extensions as part of a build script and aren't there to click the message box. R=aa,jackson BUG=14732 TEST=Pack an extension with the --no-message-box flag and notice that there is no message box. Review URL: http://codereview.chromium.org/149795 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20937 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: call xdg-open on downloaded files to open them.estade@chromium.org2009-05-281-5/+4
| | | | | | | | BUG=12299 TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download. Review URL: http://codereview.chromium.org/112064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new app_strings target that builds strings for the app_base and ↵ben@chromium.org2009-05-191-2/+2
| | | | | | | | | | eventually views targets. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113565 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16361 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFont->gfx::Fontbeng@google.com2009-05-151-2/+2
| | | | | | | | | | Does not rename the files yet. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-081-0/+824
http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98