summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Use GLib to parse environment variables to determine the default locale.jshin@chromium.org2010-10-302-104/+83
| | | | | | | | | | | | | | | | | | | | | | Switch to using GLib, instead of having a Chromium specific implementation, for parsing environment variables for language preferences for all POSIX systems that use GTK+. If we have a non-GTK port in the future, we have to resurrect our custom code. This will guarantee that UI language selection in Chromium works just like for all other GTK+ applications, and simplify the code. While doing this, also do some cleaning-up of the language preferences code and add a test case to verify that the prioritization is done correctly. Original CL by Fredrik Roubert at http://codereview.chromium.org/2901004/show BUG=NONE TEST=app_unittest with "--gtest_filter=L10nUt*.*Loc*" passes. Review URL: http://codereview.chromium.org/4217004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64524 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-291-3/+3
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* Let every "accelerated IO surface swapped" message have an identifier of the ↵thakis@chromium.org2010-10-282-2/+16
| | | | | | | | | | | | | | | surface. Currently, this is only used to DCHECK a currently implicit invariant, but I want to use this to let every surface container only remember its last painted-to surface, and not its last created surface. No behavior change. BUG=53165 TEST=none Review URL: http://codereview.chromium.org/4142004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64317 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Get rid of app/gtk_util.h.jhawkins@chromium.org2010-10-284-158/+1
| | | | | | | | | | | | | * Most functions moved to chrome/browser/gtk/gtk_util.h because they're only used within chrome/browser. * BGRAToRGBA() is used within chrome/ and app/ so moved it to base/gtk_util.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/4170002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64295 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove stale TODOjeremy@chromium.org2010-10-281-5/+0
| | | | | | | | | | | The code in question is no longer needed since Skia has changed to remove the #define in question. BUG=None TEST=Compilation shouldn't break Review URL: http://codereview.chromium.org/4099004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64234 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ElideUrl to return a string16 instead of a wstring.tony@chromium.org2010-10-273-110/+109
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/4115003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64156 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests run with --use-gl=osmesa so they use the OSMesa software renderer ↵apatrick@chromium.org2010-10-272-4/+16
| | | | | | | | | | | | | for GL. This to ensure that ui_tests run consistently regardless of the GPU capabilities, or absense, of the box they run on. TEST=try BUG=none Review URL: http://codereview.chromium.org/4138003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64122 0039d316-1c4b-4281-b951-d872f2087c98
* Specify client version 2 when creating EGL contexts.apatrick@chromium.org2010-10-271-2/+6
| | | | | | | | | | | | | It was doing this already for SecondaryEGLContext but not for NativeViewEGLContext, which made it default to EGL version 1 on non-ANGLE EGL implementations. I also fixed ANGLE upstream in r468 so it fails to create a context unless version 2 is explicitly requested. TEST=try BUG=53823 Review URL: http://codereview.chromium.org/4089006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up SharedMemory implementation so that it is more equivalent on Windows ↵dmaclach@chromium.org2010-10-273-11/+3
| | | | | | | | | | | | | vs Posix and enforces exclusive creates. Clean up some naming to make it clearer what size you are getting by changing max_size to created_size. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/4034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64097 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Directly process key and mouse events.rjkroege@google.com2010-10-263-0/+187
| | | | | | | | | | | | | | | | Capture the keyboard and mouse events directly from X, create a corresponding views::Event out of it, and send it to the associated RootView. Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly modified (called FindRootViewForGdkWindow). BUG=None TEST=Click/Keypress events in a webpage should work correctly. Review URL: http://codereview.chromium.org/3801011 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-2/+4
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Expose bindings for glGetTexLevelParameter[fi]. These functions will be ↵senorblanco@chromium.org2010-10-222-0/+10
| | | | | | | | | | | needed by WebGraphicsContext3DDefaultImpl in WebKit. BUG=60314 TEST=none Review URL: http://codereview.chromium.org/3976003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63528 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/app's dependency on the WebKit api.tony@chromium.org2010-10-213-37/+3
| | | | | | | | | | src/app shouldn't depend on webkit in anyway. DEPS allows this because it allows paths pulled in by deps = {} (stuff pulled in by gclient). Add a new rule to explicitly disallow this. Review URL: http://codereview.chromium.org/3998004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63434 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gfx::ElideText from using wstrings to string16.tony@chromium.org2010-10-213-51/+63
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63433 0039d316-1c4b-4281-b951-d872f2087c98
* Move all ResourceBundle::GetNSImageNamed() calls to GetNativeImageNamed().rsesek@chromium.org2010-10-211-0/+3
| | | | | | | | | | | This is part of the first stage of cleaning up ResourceBundle's interface. BUG=58030 TEST=Compile and unit tests. Review URL: http://codereview.chromium.org/3806007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63367 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more deinlining.erg@google.com2010-10-202-4/+13
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63261 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63232 - On Windows, create a new TransportDIB::Handle struct which ↵kkania@chromium.org2010-10-204-294/+83
| | | | | | | | | | | | | | | | | | | | | | | | | includes the file mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. Also, add a ScopedHandle and fix some handle leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/3834003 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/3943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63246 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, create a new TransportDIB::Handle struct which includes the filekkania@chromium.org2010-10-204-83/+294
| | | | | | | | | | | | | | | | | | | | mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. Also, add a ScopedHandle and fix some handle leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/3834003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63232 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63191 - 2nd try:phajdan.jr@chromium.org2010-10-205-60/+4
| | | | | | | | | | | | | | | | | | | | | | | | Fix regression where high resolution timers could be activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Broke unit_tests on Vista and XP: [ RUN ] GeolocationNetworkProviderTest.GatewayAndWifiScans [2916:2376:1020/030222:2975321329:FATAL:network_location_provider.cc(51)] Check failed: cache_.size() == cache_times_.size(). Review URL: http://codereview.chromium.org/3889004 TBR=mbelshe@chromium.org Review URL: http://codereview.chromium.org/3946003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63200 0039d316-1c4b-4281-b951-d872f2087c98
* 2nd try:mbelshe@chromium.org2010-10-205-4/+60
| | | | | | | | | | | | | | | | Fix regression where high resolution timers could be activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Review URL: http://codereview.chromium.org/3889004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63191 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63176 - Fix regression where high resolution timers could be ↵mbelshe@chromium.org2010-10-204-59/+3
| | | | | | | | | | | | | | | | | | | | activated even under battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Review URL: http://codereview.chromium.org/3848002 TBR=mbelshe@chromium.org Review URL: http://codereview.chromium.org/3948001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63177 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where high resolution timers could be activated even undermbelshe@chromium.org2010-10-204-3/+59
| | | | | | | | | | | | | | | battery power. Add unit test to protect chromium from developers like me in the future. The fix is a one-liner in hi_res_timer_manager_win.cc. The rest of the code change is the mechanics to enable the unit test. BUG=59528 TEST=HiResTimerManagerTest.ToggleOnOff Review URL: http://codereview.chromium.org/3848002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63176 0039d316-1c4b-4281-b951-d872f2087c98
* Report EGL error strings whenever an EGL function fails.apatrick@chromium.org2010-10-191-27/+107
| | | | | | | | | TEST=try, check ANGLE works locally, simulate failure of EGL function and check log output BUG=53823 Review URL: http://codereview.chromium.org/3877001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63101 0039d316-1c4b-4281-b951-d872f2087c98
* Convert LOG(INFO) to VLOG(1) - app/.pkasting@chromium.org2010-10-195-10/+10
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3771009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63000 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Monster ctor patch after changing heuristics in clang plugin.erg@google.com2010-10-182-0/+3
| | | | | | | | | | | (Only 916k this time off Debug Linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3814013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62967 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_nsdisable_screen_update from base to app/macbrettw@chromium.org2010-10-183-2/+40
| | | | | | | | | | | Move scoped_aedesc from base to base/mac Use namespace and proper Google-style class naming. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3828009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62904 0039d316-1c4b-4281-b951-d872f2087c98
* Move BaseDropTarget and BaseDragSource from base to app/win. Remove the ↵brettw@chromium.org2010-10-175-1/+430
| | | | | | | | | | "Base" class name prefix and put in the app::win namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/3822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62900 0039d316-1c4b-4281-b951-d872f2087c98
* Move pe_image and registry from base to base/win and use the namespace. It ↵brettw@chromium.org2010-10-172-3/+3
| | | | | | | | | | | | removes windows_message_list which isn't used. This keeps a stub for registry in the old location until we can update that. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3836005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62888 0039d316-1c4b-4281-b951-d872f2087c98
* Move scoped_cftyperef from base to base/mac, use the new namespace, and name itbrettw@chromium.org2010-10-173-9/+9
| | | | | | | | | | properly (scoped_cftyperef -> ScopedCFTypeRef). TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3855001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62887 0039d316-1c4b-4281-b951-d872f2087c98
* Move xdg_util into base/nix. I originally wanted to use base/linux, but youbrettw@chromium.org2010-10-161-2/+3
| | | | | | | | | | | | | | | | can't have a namespace called "linux" because it's ifdefed by GCC to be a number. Same for "unix". "x11" was discarded because some future stuff in here will not be related to x11. This also renames base_paths_posix to base_paths_linux since this does not apply to mac, and normally posix applies to mac (this confused me when I had to edit it for the XDG stuff). TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3778007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62848 0039d316-1c4b-4281-b951-d872f2087c98
* Move the windows-specific scoped_* stuff from base to base/win and in the ↵brettw@chromium.org2010-10-161-1/+0
| | | | | | | | | | | | | | | | base::win namespace. This keeps old headers that forward to the new versions and have using declarations that allow the existing code to compile. I fixed all the callers in base to use the new ones, and also the other files I happened to touch. This splits out the stuff from scoped_handle into a few separate files. I just deleted ScopedFindFile since it was only used in one place and it wasn't even really helping there. I removed StackBstr which was a #define and used the "regular" ScopedBstr in the 7 places that used it. This is an optimization to avoid an extra allocation, but none of the callers are remotely performance critical. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3781009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62843 0039d316-1c4b-4281-b951-d872f2087c98
* Move windows version-related stuff out of base/win_util and into ↵brettw@chromium.org2010-10-156-16/+16
| | | | | | | | | | | | | | base/win/windows_version. Many files now only need to include this instead of all of win_util. Remove a bunch of unused code from base/win_util. There was a surprising amount. Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98
* Move iat_patch from base to app/win. Remove the functions from the header sincebrettw@chromium.org2010-10-143-0/+357
| | | | | | | | | | | | they aren't used, and just make them local to the .cc file. Rename the .cc file to iat_patch_function to match the class definition. Put it in the app::win namespace to match the directories. Update callers. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62678 0039d316-1c4b-4281-b951-d872f2087c98
* Move constructor and destructor of MockGLInterface out of line.thakis@chromium.org2010-10-142-410/+0
| | | | | | | | | | | | | Speeds up building all of gpu by over one minute / over 10% on my machine (from 9:23 to 8:11). Move the mock to gpu/command_buffer/common to have a more obvious place for the cc file. BUG=None TEST=None Review URL: http://codereview.chromium.org/3811006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62649 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-141-1/+1
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* base: Move SplitString functions into the base namespace and update the callers.tfarina@chromium.org2010-10-142-3/+3
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3750001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62483 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the shared library build issue. This reverts my previous two tries ↵brettw@chromium.org2010-10-101-1/+0
| | | | | | | | | which werer incorrect. perftimer just needed to be added to test_support_base. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62099 0039d316-1c4b-4281-b951-d872f2087c98
* More fixes for the Linux shlib build, probably not everything yet.brettw@chromium.org2010-10-101-0/+1
| | | | | | | TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62098 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the wrong mesa lib name.zmo@google.com2010-10-081-2/+2
| | | | | | Review URL: http://codereview.chromium.org/3596012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61902 0039d316-1c4b-4281-b951-d872f2087c98
* Added switch to disable GPU vsync.apatrick@chromium.org2010-10-0713-7/+164
| | | | | | | | | | | This is useful for GPU performance testing because the vsync caps the frame rate. TEST=try BUG=none Review URL: http://codereview.chromium.org/3380011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61877 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed crash when GetClientRect fails.apatrick@chromium.org2010-10-061-1/+5
| | | | | | | | | | | There is a known race condition with windows being destroyed while the GPU process has a live handle to them. This change treats destroyed windows as having size zero rather than crashing. TEST=try BUG=58065 Review URL: http://codereview.chromium.org/3549018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61702 0039d316-1c4b-4281-b951-d872f2087c98
* Load libGLESv2.dll before libEGL.dll.apatrick@chromium.org2010-10-063-10/+50
| | | | | | | | | | | EGL is dependent on GLESv2 so load the latter first in case there is another version somewhere in the DLL search path. TEST=try BUG=58064 Review URL: http://codereview.chromium.org/3609011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61690 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 61608 - On Windows, create a new TransportDIB::Handle struct which ↵satish@chromium.org2010-10-064-218/+83
| | | | | | | | | | | | | | | | | | | | | | | includes the file mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. BUG=none TEST=none Review URL: http://codereview.chromium.org/3305020 BUG=58128 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/3596008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61624 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, create a new TransportDIB::Handle struct which includes the filekkania@chromium.org2010-10-064-83/+218
| | | | | | | | | | | | | | | | | mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. BUG=none TEST=none Review URL: http://codereview.chromium.org/3305020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61608 0039d316-1c4b-4281-b951-d872f2087c98
* GPU process does one-off EGL initialization on linux.apatrick@chromium.org2010-10-051-11/+23
| | | | | | | | | | | This should get WebGL working on EGL/GLES2 ARM boxes again. TEST=try BUG=53823 Review URL: http://codereview.chromium.org/3466011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61565 0039d316-1c4b-4281-b951-d872f2087c98
* Define gfx::NativeImage and add ResourceBundle::GetNativeImageNamed().rsesek@chromium.org2010-10-052-0/+18
| | | | | | | | | BUG=none TEST=compile Review URL: http://codereview.chromium.org/3597008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61545 0039d316-1c4b-4281-b951-d872f2087c98
* Revert asynchronous backing store changes.derat@chromium.org2010-10-051-4/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts http://codereview.chromium.org/3506007 (r61225 -- the original change) and http://codereview.chromium.org/3616005 (r61446 -- a fix for a double-free in Pepper caused by the original change). Doing asynchronous copying to the backing store in the browser requires some large changes to Pepper that I'm not going to have time to work on anytime soon. A cache of in-flight TransportDIBs would need to be added (similar to what the renderer already does), and we'd also need to do copy-on-write when a plugin wants to draw on top of a previous frame that's currently held by the browser. It seems safer to revert the early part of the asynchronous copying change instead of leaving it partially checked in. BUG=none TEST=ran it Review URL: http://codereview.chromium.org/3583012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61525 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK for misused string resources.estade@chromium.org2010-10-042-40/+76
| | | | | | | | | | | When replacing a placeholder in a localized string, make sure the correct number of placeholders were found (i.e. the same number of strings that the calling code passed). BUG=none TEST=running/testing the browser in debug doesn't cause errors Review URL: http://codereview.chromium.org/3396025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61420 0039d316-1c4b-4281-b951-d872f2087c98
* Add ViewMsg_DoneUsingBitmap message.derat@chromium.org2010-10-011-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | ViewMsg_UpdateRect_ACK messages sent from the browser to the renderer currently tell the renderer both that it can start rendering the next update and that the TransportDIB that it previously sent to the browser is now available for reuse. This change adds a new ViewMsg_DoneUsingBitmap message for communicating the latter piece of information. We currently always send ViewMsg_DoneUsingBitmap immediately before sending ViewMsg_UpdateRect_ACK, so no functional changes are intended from this change. This is preparatory work for an optimization where we defer copying updates to the backing store, instead copying them directly from the TransportDIB to the widget -- if we get repeated updates for the same region, we can avoid copying all but the final update to the backing store entirely. BUG=none TEST=tried it on GTK; sent to trybots. will do some testing on other platforms too Review URL: http://codereview.chromium.org/3506007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61225 0039d316-1c4b-4281-b951-d872f2087c98
* Add offscreen context creation attributes to GGL.enne@chromium.org2010-10-013-6/+26
| | | | | | | | | | | View contexts and more extensive color format picking not handled yet. BUG=39849 TEST=WebGL conformance tests (context*.html) Review URL: http://codereview.chromium.org/3302019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61220 0039d316-1c4b-4281-b951-d872f2087c98