summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Insert methods for SimpleMenuModeloshima@chromium.org2010-01-272-0/+78
| | | | | | | | | | | Don't recreate AppMenuModel in ToolbarView as it now supports updating label dynamically. BUG=none TEST=manual: enabling/disabling bookmark sync will update the bookmark sync label correcty. Review URL: http://codereview.chromium.org/551171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37333 0039d316-1c4b-4281-b951-d872f2087c98
* In the sync database, use protobuf-based storage. Drop the oldnick@chromium.org2010-01-272-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | bookmark-only columns. Add getters and setters for BookmarkSpecifics to syncapi as well as syncable entries. Make the datatype be a required property when creating a syncapi node. Add a datatype for the 'google chrome' top level folder. Add database migrations from version 67 to the new schema. Add infrastructure to support migrations generically. Add unit tests for the migrations. Pull a new version of the protobuf library to pick up a fix for a bug that this change exposed (I upstreamed the fix). Fix some example code in the sql helpers so that it would actually compile. BUG=29899,30041 TEST=New unit tests for migrations: unit tests are based on actual database dumps. Additionally, I manually tested 2-client sync using combos of old-protocol servers, new-protocol servers, and initial database versions v67, v68, and v0 (new client). I manually verified that add/edit/delete works in these combination cases. Afterwards I verified (by inspecting the sync databases) that the ModelTypes are consistent across the various migration/protocol paths. Review URL: http://codereview.chromium.org/554066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37253 0039d316-1c4b-4281-b951-d872f2087c98
* POSIX: Use Shared Mem transport to copy images.jeremy@chromium.org2010-01-276-84/+185
| | | | | | | | | | | | | | | | Prior to this change images where copied inline in IPC messages on non-Windows platforms. Copying an oversized image would cause the IPC system to bork and crash the renderer. Changes in this CL: * All platforms use a unified mechanism to copy images using shared memory. * Introduced a new IPC message so the renderer can allocated a shared memory segment on OS X. * On OS X tried to keep as few copies of the image data in memory as possible. BUG=26822 TEST=1)On all platforms: navigate to a webpage, right click on an image and copy. Then try pasting into an image editor. 2)Repro steps in bug should no longer crash the Renderer on Mac/Linux Review URL: http://codereview.chromium.org/552129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37247 0039d316-1c4b-4281-b951-d872f2087c98
* images for translate infobars.kuan@chromium.org2010-01-2628-0/+29
| | | | | | Review URL: http://codereview.chromium.org/553071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37147 0039d316-1c4b-4281-b951-d872f2087c98
* remove ICU includes from l10n_util.hevan@chromium.org2010-01-258-214/+256
| | | | | | | | | | | | | | | | 95% of users of l10n_util use it for some functions; the other 5% want some complicated templates that pull in a ton of ICU headers as well. Before this change, the average includer of l10n_util.h pulled in an additional 80 subheaders because of it. Additionally, #including ICU headers from a header makes the includee depend on having the ICU include path in the -I header. Review URL: http://codereview.chromium.org/515059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37032 0039d316-1c4b-4281-b951-d872f2087c98
* OpenBSD/FreeBSD ifdefs and GYP changes for app/ directorypvalchev@google.com2010-01-2316-60/+58
| | | | | | | | | | | - Use OS_POSIX && !OS_MACOSX defines to capture Linux/*BSD as they have many similarities, use other defines instead of OS_LINUX where sensible. Based on original work by Sprewell and Ben Laurie on FreeBSD port Review URL: http://codereview.chromium.org/548126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36931 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad tooltip wrapping.davemoore@chromium.org2010-01-221-1/+15
| | | | | | | | | | Bug=32857 Test=Create a document with a long title. Open it. Hover over the tab title. Even if the text is elided it should be only 1 line tall. Review URL: http://codereview.chromium.org/543166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36869 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build.finnur@chromium.org2010-01-211-0/+0
| | | | | | | | | | TBR=dpranke TEST=None BUG=None Review URL: http://codereview.chromium.org/555019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36703 0039d316-1c4b-4281-b951-d872f2087c98
* Adding image for resize gripper in the hopes that the try bots don't fail to ↵finnur@chromium.org2010-01-201-0/+3
| | | | | | | | | | | try my patch. BUG=None TEST=None Review URL: http://codereview.chromium.org/555017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36699 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from the star, bookmarks bar, and bookmark bar menustony@chromium.org2010-01-201-0/+11
| | | | | | | | | | | to the Gnome desktop (nautilus). These should create shortcuts. Other drag operations should be the same as before. BUG=24210 Review URL: http://codereview.chromium.org/548067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36585 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a secondary mini_installer target for Chrome Frame. This will remove ↵robertshield@chromium.org2010-01-191-50/+0
| | | | | | | | | | | | | | the need to have different build scripts to build either Chrome or Chrome Frame. Also remove the now-unneeded gyp variables 'chrome_frame_define' and 'google_update_appid'. BUG=Both Chrome and Chrome Frame products should be buildable from a single solution file - we shouldn't need to run GYP with different settings to get a CF solution. TEST=none Review URL: http://codereview.chromium.org/542078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36546 0039d316-1c4b-4281-b951-d872f2087c98
* Make a MenuModel for the popup favicon menu. For now only GTK uses it. ↵estade@chromium.org2010-01-191-7/+19
| | | | | | | | | | | | Consolidate all accelerators for browser commands into one place. BUG=28212,27535 TEST=1. enable custom frame and a popup window and test that the popup contains all the same (non-system) menu items as windows. 2. all context menus still display the correct shortcuts and the shortcuts work Review URL: http://codereview.chromium.org/551032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36527 0039d316-1c4b-4281-b951-d872f2087c98
* Split win_util.cc - we need ConvertToLongPath in the 64-bit Windows build, ↵gregoryd@google.com2010-01-183-13/+23
| | | | | | | | but would like to avoid the dependencies that would be added by including the whole win_util.cc file Review URL: http://codereview.chromium.org/536028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36494 0039d316-1c4b-4281-b951-d872f2087c98
* Support dragging a virtual file out of the browser.jianli@chromium.org2010-01-156-49/+327
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/351029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36378 0039d316-1c4b-4281-b951-d872f2087c98
* Allow link drags from Chrome to create a shortcut on the desktop.tony@chromium.org2010-01-152-1/+15
| | | | | | | | | | | | | This required adding the netscape link+title format to the drag data (we were already doing this on windows) and adding GDK_ACTION_LINK to the GdkDragAction passed into gtk_drag_begin. BUG=27337 TEST=Drag a link to the desktop, it should create a shortcut (.desktop file). Review URL: http://codereview.chromium.org/542072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36321 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Notify Chrome when it loses the focus.derat@chromium.org2010-01-132-7/+5
| | | | | | | | | | | | | | | I think that this was a regression -- the code was only notifying windows about their active/inactive states when the focus was passed to a new Chrome window. If a different app got the focus instead, they'd retain the old states. BUG=32127 TEST=tried it Review URL: http://codereview.chromium.org/548022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36158 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to way we identify the active window. This deals with XFCE whichdavemoore@chromium.org2010-01-131-2/+5
| | | | | | | | | | | doesn't set the property correctly. Bug=31971 Test=Run Chrome under the XFCE WM and ensure that inactive windows titles are light blue Review URL: http://codereview.chromium.org/550019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36073 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure an evil renderer can't mess up state of the clipboard, later causingcevans@chromium.org2010-01-121-0/+4
| | | | | | | | | | | an untrusted blob to be treated as a GdkPixmap. BUG=32014 TEST=NONE Review URL: http://codereview.chromium.org/547014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35982 0039d316-1c4b-4281-b951-d872f2087c98
* Use string16 instead of wstring in bookmark data model.munjal@chromium.org2010-01-112-3/+22
| | | | | | | | | | | | | Add overloads to bookmark model for string16. Wrap wstring versions in #if !defined since string16 is just a typedef of wstring on windows. TEST=exist BUG=32013 Review URL: http://codereview.chromium.org/536013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35964 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix text not being clipped. This only seems to happen insky@chromium.org2010-01-111-0/+3
| | | | | | | | | | | | certain configurations. I'm guessing the problem is because a width/height <= 0 is not honored and clipping doesn't happen. BUG=26483 TEST=none Review URL: http://codereview.chromium.org/542011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35909 0039d316-1c4b-4281-b951-d872f2087c98
* Translation stringsoritm@google.com2010-01-102-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35882 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix crash in issue 31082xiyuan@chromium.org2010-01-071-0/+4
| | | | | | | | | | | | | Crash in issue 31082 is inside Windows ICM (Image Color Management) code. I suspect it is caused by invalid bV5Intent value in the BITMAPV5HEADER we passed in. BUG=31082 TEST=Crashes in issue 31082 should be gone. Review URL: http://codereview.chromium.org/519081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35734 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make tab context menu use tab_menu_modelestade@chromium.org2010-01-052-0/+47
| | | | | | | | | | | flesh out some more menu model implementation for MenuGtk BUG=28977 TEST=menu still works as before Review URL: http://codereview.chromium.org/523049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35569 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround bug in Pango that was resulted in incorrect wrapping.sky@chromium.org2010-01-041-0/+17
| | | | | | | | | BUG=30361 TEST=see bug Review URL: http://codereview.chromium.org/512002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35490 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] honor the locale passed for loading the pak file.thomasvl@chromium.org2009-12-311-7/+28
| | | | | | | | | | | | chrome_dll_main has SubprocessNeedsResourceBundle(), that is what prompted this. Map the request locale into a Mac on disk localization and ask NSBundle to fetch that specific localization. This lets the language come over via the command line argument and then be honored in the helper processes. TEST=the ui_tests stop logging a message about ignoring locale for the NSBundle one. BUG=none Review URL: http://codereview.chromium.org/503089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35420 0039d316-1c4b-4281-b951-d872f2087c98
* Add a range of sanity checks to the clipboard object handling. In ↵cevans@chromium.org2009-12-301-4/+23
| | | | | | | | | | | particular, fix an integer overflow that might be an issue on Linux. Other changes are to avoid OOB reads and calling front() or [] on an empty or insufficiently sized vector. BUG=31928 TEST=NONE Review URL: http://codereview.chromium.org/522024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35362 0039d316-1c4b-4281-b951-d872f2087c98
* Don't shoehorn a size_t into an int -- especially if the int is used in an ↵cevans@chromium.org2009-12-301-2/+2
| | | | | | | | | | | subsequent allocation. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/518022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35360 0039d316-1c4b-4281-b951-d872f2087c98
* AppCacheDatabase and SQL based AppCacheStorageImpl. michaeln@chromium.org2009-12-294-17/+16
| | | | | | | | | | | | | | | Still nothing is being written to disk with this CL, in-memory SQLite and DiskCaches are being utilized. Responses are not yet being removed from the DiskCasche when the should be. Once that's done (in the next CL), we'll start saving things on disk. BUG=none TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc Review URL: http://codereview.chromium.org/518020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35354 0039d316-1c4b-4281-b951-d872f2087c98
* atl: Remove unused <atlbase.h> header from some source files.jhawkins@chromium.org2009-12-291-1/+0
| | | | | | | | | | BUG=5027 TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/519022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35341 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35328 - AppCacheDatabase and SQL based AppCacheStorageImpl.michaeln@google.com2009-12-294-16/+17
| | | | | | | | | | | | | | | | | | Still nothing is being written to disk with this CL, inmemory SQLite and DiskCaches are being utilized. Responses are not yet being removed from the DiskCasche when the should be. Once that's done (in the next CL), we'll start saving things on disk. BUG=none TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc Review URL: http://codereview.chromium.org/501033 TBR=michaeln@chromium.org Review URL: http://codereview.chromium.org/519018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35329 0039d316-1c4b-4281-b951-d872f2087c98
* AppCacheDatabase and SQL based AppCacheStorageImpl.michaeln@chromium.org2009-12-294-17/+16
| | | | | | | | | | | | | | | Still nothing is being written to disk with this CL, in-memory SQLite and DiskCaches are being utilized. Responses are not yet being removed from the DiskCasche when the should be. Once that's done (in the next CL), we'll start saving things on disk. BUG=none TEST=appcache_database_unittest.cc, appcache_storage_impl_unittest.cc Review URL: http://codereview.chromium.org/501033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35328 0039d316-1c4b-4281-b951-d872f2087c98
* linux: reduce header interdependenciesevan@chromium.org2009-12-293-2/+53
| | | | | | | | | | | | By analyzing gcc -H output, I found some of our worst offenders for headers bringing in other headers. native_web_keyboard_event.h was responsible for just under 60,000 extra includes! This change will in theory make the build faster. Review URL: http://codereview.chromium.org/524004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35326 0039d316-1c4b-4281-b951-d872f2087c98
* Clarify licenses on a bunch of files.evan@chromium.org2009-12-291-0/+4
| | | | | | | | | | | In this process, I also filed bugs on various projects we depend on that also have unclear licenses. BUG=28291 Review URL: http://codereview.chromium.org/521009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35323 0039d316-1c4b-4281-b951-d872f2087c98
* Fix race condition at cros startupdavemoore@chromium.org2009-12-221-15/+42
| | | | | | Review URL: http://codereview.chromium.org/504084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35181 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-221-1/+1
| | | | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35012 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35129 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-182-0/+24
| | | | | | | | | | | | | . If we can't init the web db a dialog is shown to the user. . If we can't init the web db the default search provider no longer becomes NULL. BUG=28374 TEST=none Review URL: http://codereview.chromium.org/501090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34901 0039d316-1c4b-4281-b951-d872f2087c98
* Init allocated SkBitmap pixelsxiyuan@chromium.org2009-12-171-0/+1
| | | | | | | | | | | | Init allocated pixels to ARGB(0,0,0,0) in CreateSkBitmapFromHICON per issue 30584. BUG=30584 TEST=wine-valgrind should no longer complain as in issue 30584. Review URL: http://codereview.chromium.org/504035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34852 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII, so we don't use the deprecated versions.evan@chromium.org2009-12-171-2/+2
| | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/498002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34811 0039d316-1c4b-4281-b951-d872f2087c98
* Changing DCHECKs in ResourceBundle::LoadResources() to CHECK.yusukes@google.com2009-12-171-3/+3
| | | | | | | | | | | | | | | | | | | | Chromium Linux (release build) dies with SIGSEGV on start-up in case when the chrome.pak resource file is missing or broken for some reason: [17247:17247:499277598478:ERROR:base/file_util.cc(302)] Couldn't open /tmp/chrome.pak Segmentation fault. This change changes some DCHECKs to CHECK in order to make the error message readble to user. After this patch, the message would be like this: [17238:17238:499222545654:ERROR:base/file_util.cc(302)] Couldn't open /home/yusukes/tmp/chrome.pak [17238:17238:499222545701:FATAL:app/resource_bundle_posix.cc(88)] Check failed: resources_data_. failed to load chrome.pak Trace/breakpoint trap BUG=none TEST=Run "cp src/out/Release/chrome /tmp && ./tmp/chrome" and verify that it is terminated by CHECK failure (and not SIGSEGV). Review URL: http://codereview.chromium.org/500045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34804 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserThemePack: Move encoding the processed images to the writing thread.erg@google.com2009-12-171-2/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/504032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34786 0039d316-1c4b-4281-b951-d872f2087c98
* Add gfx::Insets::ToString().satorux@chromium.org2009-12-165-1/+92
| | | | | | | | | | | | | This will be useful for debugging views and views applications (I needed this when I was debugging my views application). Along the way, added tests for Insets. TEST=added tests; app_unittests; try BUG=none Review URL: http://codereview.chromium.org/497004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34650 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected destructors instead of ↵jamesr@chromium.org2009-12-164-2/+19
| | | | | | | | | | | | | | | | | | | | | | implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
* Modify LoadPixbuf() so it returns NULL when the |data| parameter is NULL.yusukes@google.com2009-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the latest Chromium build for Chrome OS, r32471, I experienced the following crash during startup possibly due to resource collapse. Since it's not easy to reproduce, I'm still not sure why the resource was collapsed, but anyway this tiny patch prevents SIGSEGV even when image resources are missing for some reason. $ gdb ./out/Debug/chrome ... (gdb) r ... [16434:16434:50993697347:ERROR:base/data_pack.cc(108)] No resource found with id: 25540 Program received signal SIGSEGV, Segmentation fault. 0x0879d315 in LoadPixbuf (data=0x0, rtl_enabled=true) at app/resource_bundle_linux.cc:31 31 reinterpret_cast<const guint8*>(data->front()), data->size(), NULL); (gdb) bt #0 0x0879d315 in LoadPixbuf (data=0x0, rtl_enabled=true) at app/resource_bundle_linux.cc:31 #1 0x0879e0e0 in ResourceBundle::GetPixbufImpl (this=0xb6bf680, resource_id=25540, rtl_enabled=true) at app/resource_bundle_linux.cc:166 #2 0x0879e394 in ResourceBundle::GetRTLEnabledPixbufNamed (this=0xb6bf680, resource_id=25540) at app/resource_bundle_linux.cc:208 #3 0x0814fb78 in CustomDrawButtonBase (this=0xb748ee8, theme_provider=0x0, normal_id=25540, active_id=25540, highlight_id=25540, depressed_id=0, background_id=0) at chrome/browser/gtk/custom_button.cc:47 #4 0x0815050a in CustomDrawButton (this=0xb748ee0, normal_id=25540, active_id=25540, highlight_id=25540, depressed_id=0) at chrome/browser/gtk/custom_button.cc:150 #5 0x08146f6a in BrowserWindowGtk::InitWidgets (this=0xb49062d0) at chrome/browser/gtk/browser_window_gtk.cc:1681 #6 0x081434a5 in BrowserWindowGtk (this=0xb49062d0, browser=0xb4904238) at chrome/browser/gtk/browser_window_gtk.cc:578 #7 0x08439d8a in BrowserWindow::CreateBrowserWindow (browser=0xb4904238) at chrome/browser/gtk/browser_window_factory_gtk.cc:12 #8 0x08382aec in Browser::CreateBrowserWindow (this=0xb4904238) at chrome/browser/browser.cc:230 #9 0x08382938 in Browser::Create (profile=0xb6c5bd8) at chrome/browser/browser.cc:204 ... BUG=none TEST=none Review URL: http://codereview.chromium.org/399110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34535 0039d316-1c4b-4281-b951-d872f2087c98
* Theme download status message, so that it's readable in themes of any color.mirandac@chromium.org2009-12-122-7/+10
| | | | | | | | BUG= 21176 TEST= Download something large in a dark or light theme. Note that status update (notification of how much data is left to download) is legible. Review URL: http://codereview.chromium.org/488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34395 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where some bitmaps were being tinted wrong. It turns outtony@chromium.org2009-12-112-3/+16
| | | | | | | | | | | | | that when converting from RGB to HSL we were comparing doubles and in on some CPUs, a register spill would cause us to do the conversion wrong. BUG=28243 Review URL: http://codereview.chromium.org/491036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34362 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-112-2/+2
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Link the following tests against tcmalloc:glider@chromium.org2009-12-101-0/+9
| | | | | | | | | | | | | | | | | | | | | app_unittests browser_tests startup_tests media_unittests printing_unittests net_unittests googleurl_unittests ipc_tests unit_tests ui_tests This patch was originally reviewed as http://codereview.chromium.org/466089 TBR=willchan Review URL: http://codereview.chromium.org/488004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34247 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserProcess::GetApplicationLocale thread safe and migratetony@chromium.org2009-12-108-21/+28
| | | | | | | | | | | | | | | | | callers of l10n_util::GetApplicationLocale to use this instead. In the browser process, it's wrong to call l10n_util::GetApplicationLocale with an empty string because then it won't consider the user pref value when resolving the locale. On Linux, it's also wrong to call l10n_util::GetApplicationLocale after startup because the call touches disk and on Linux, we assume that all of the program files can be deleted after startup (so updates in place can work). Review URL: http://codereview.chromium.org/476002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34206 0039d316-1c4b-4281-b951-d872f2087c98