summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Revert 35012 - Rearrange build configurations make it clearer and allow ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | | | | better support for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 TBR=gregoryd@google.com Review URL: http://codereview.chromium.org/500149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35016 0039d316-1c4b-4281-b951-d872f2087c98
* Rearrange build configurations - make it clearer and allow better support ↵gregoryd@google.com2009-12-191-1/+1
| | | | | | | | | | | for x64 on Windows TEST=none BUG=29467 Review URL: http://codereview.chromium.org/501127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35012 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two related bugs:sky@chromium.org2009-12-182-0/+24
| | | | | | | | | | | | | . If we can't init the web db a dialog is shown to the user. . If we can't init the web db the default search provider no longer becomes NULL. BUG=28374 TEST=none Review URL: http://codereview.chromium.org/501090 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34901 0039d316-1c4b-4281-b951-d872f2087c98
* Init allocated SkBitmap pixelsxiyuan@chromium.org2009-12-171-0/+1
| | | | | | | | | | | | Init allocated pixels to ARGB(0,0,0,0) in CreateSkBitmapFromHICON per issue 30584. BUG=30584 TEST=wine-valgrind should no longer complain as in issue 30584. Review URL: http://codereview.chromium.org/504035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34852 0039d316-1c4b-4281-b951-d872f2087c98
* Use GetSwitchValueASCII, so we don't use the deprecated versions.evan@chromium.org2009-12-171-2/+2
| | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/498002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34811 0039d316-1c4b-4281-b951-d872f2087c98
* Changing DCHECKs in ResourceBundle::LoadResources() to CHECK.yusukes@google.com2009-12-171-3/+3
| | | | | | | | | | | | | | | | | | | | Chromium Linux (release build) dies with SIGSEGV on start-up in case when the chrome.pak resource file is missing or broken for some reason: [17247:17247:499277598478:ERROR:base/file_util.cc(302)] Couldn't open /tmp/chrome.pak Segmentation fault. This change changes some DCHECKs to CHECK in order to make the error message readble to user. After this patch, the message would be like this: [17238:17238:499222545654:ERROR:base/file_util.cc(302)] Couldn't open /home/yusukes/tmp/chrome.pak [17238:17238:499222545701:FATAL:app/resource_bundle_posix.cc(88)] Check failed: resources_data_. failed to load chrome.pak Trace/breakpoint trap BUG=none TEST=Run "cp src/out/Release/chrome /tmp && ./tmp/chrome" and verify that it is terminated by CHECK failure (and not SIGSEGV). Review URL: http://codereview.chromium.org/500045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34804 0039d316-1c4b-4281-b951-d872f2087c98
* BrowserThemePack: Move encoding the processed images to the writing thread.erg@google.com2009-12-171-2/+3
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/504032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34786 0039d316-1c4b-4281-b951-d872f2087c98
* Add gfx::Insets::ToString().satorux@chromium.org2009-12-165-1/+92
| | | | | | | | | | | | | This will be useful for debugging views and views applications (I needed this when I was debugging my views application). Along the way, added tests for Insets. TEST=added tests; app_unittests; try BUG=none Review URL: http://codereview.chromium.org/497004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34650 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected destructors instead of ↵jamesr@chromium.org2009-12-164-2/+19
| | | | | | | | | | | | | | | | | | | | | | implicit non-virtual public destructors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (Excluding chrome/browser/...) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) Patch by: Jacob Mandelson (jlmjln@gmail.com) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/200106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34633 0039d316-1c4b-4281-b951-d872f2087c98
* Modify LoadPixbuf() so it returns NULL when the |data| parameter is NULL.yusukes@google.com2009-12-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On the latest Chromium build for Chrome OS, r32471, I experienced the following crash during startup possibly due to resource collapse. Since it's not easy to reproduce, I'm still not sure why the resource was collapsed, but anyway this tiny patch prevents SIGSEGV even when image resources are missing for some reason. $ gdb ./out/Debug/chrome ... (gdb) r ... [16434:16434:50993697347:ERROR:base/data_pack.cc(108)] No resource found with id: 25540 Program received signal SIGSEGV, Segmentation fault. 0x0879d315 in LoadPixbuf (data=0x0, rtl_enabled=true) at app/resource_bundle_linux.cc:31 31 reinterpret_cast<const guint8*>(data->front()), data->size(), NULL); (gdb) bt #0 0x0879d315 in LoadPixbuf (data=0x0, rtl_enabled=true) at app/resource_bundle_linux.cc:31 #1 0x0879e0e0 in ResourceBundle::GetPixbufImpl (this=0xb6bf680, resource_id=25540, rtl_enabled=true) at app/resource_bundle_linux.cc:166 #2 0x0879e394 in ResourceBundle::GetRTLEnabledPixbufNamed (this=0xb6bf680, resource_id=25540) at app/resource_bundle_linux.cc:208 #3 0x0814fb78 in CustomDrawButtonBase (this=0xb748ee8, theme_provider=0x0, normal_id=25540, active_id=25540, highlight_id=25540, depressed_id=0, background_id=0) at chrome/browser/gtk/custom_button.cc:47 #4 0x0815050a in CustomDrawButton (this=0xb748ee0, normal_id=25540, active_id=25540, highlight_id=25540, depressed_id=0) at chrome/browser/gtk/custom_button.cc:150 #5 0x08146f6a in BrowserWindowGtk::InitWidgets (this=0xb49062d0) at chrome/browser/gtk/browser_window_gtk.cc:1681 #6 0x081434a5 in BrowserWindowGtk (this=0xb49062d0, browser=0xb4904238) at chrome/browser/gtk/browser_window_gtk.cc:578 #7 0x08439d8a in BrowserWindow::CreateBrowserWindow (browser=0xb4904238) at chrome/browser/gtk/browser_window_factory_gtk.cc:12 #8 0x08382aec in Browser::CreateBrowserWindow (this=0xb4904238) at chrome/browser/browser.cc:230 #9 0x08382938 in Browser::Create (profile=0xb6c5bd8) at chrome/browser/browser.cc:204 ... BUG=none TEST=none Review URL: http://codereview.chromium.org/399110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34535 0039d316-1c4b-4281-b951-d872f2087c98
* Theme download status message, so that it's readable in themes of any color.mirandac@chromium.org2009-12-122-7/+10
| | | | | | | | BUG= 21176 TEST= Download something large in a dark or light theme. Note that status update (notification of how much data is left to download) is legible. Review URL: http://codereview.chromium.org/488002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34395 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bug where some bitmaps were being tinted wrong. It turns outtony@chromium.org2009-12-112-3/+16
| | | | | | | | | | | | | that when converting from RGB to HSL we were comparing doubles and in on some CPUs, a register spill would cause us to do the conversion wrong. BUG=28243 Review URL: http://codereview.chromium.org/491036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34362 0039d316-1c4b-4281-b951-d872f2087c98
* Use utf_string_conversions header in more places.maruel@chromium.org2009-12-112-2/+2
| | | | | | | | | | | Patch contributed by Thiago Farina (thiago.farina@gmail.com) TEST=none BUG=none Review URL: http://codereview.chromium.org/465065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34348 0039d316-1c4b-4281-b951-d872f2087c98
* Link the following tests against tcmalloc:glider@chromium.org2009-12-101-0/+9
| | | | | | | | | | | | | | | | | | | | | app_unittests browser_tests startup_tests media_unittests printing_unittests net_unittests googleurl_unittests ipc_tests unit_tests ui_tests This patch was originally reviewed as http://codereview.chromium.org/466089 TBR=willchan Review URL: http://codereview.chromium.org/488004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34247 0039d316-1c4b-4281-b951-d872f2087c98
* Make BrowserProcess::GetApplicationLocale thread safe and migratetony@chromium.org2009-12-108-21/+28
| | | | | | | | | | | | | | | | | callers of l10n_util::GetApplicationLocale to use this instead. In the browser process, it's wrong to call l10n_util::GetApplicationLocale with an empty string because then it won't consider the user pref value when resolving the locale. On Linux, it's also wrong to call l10n_util::GetApplicationLocale after startup because the call touches disk and on Linux, we assume that all of the program files can be deleted after startup (so updates in place can work). Review URL: http://codereview.chromium.org/476002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34206 0039d316-1c4b-4281-b951-d872f2087c98
* Share the code that builds the page menu in a common model, make Mac and Win ↵pinkerton@chromium.org2009-12-091-0/+2
| | | | | | | | | | use it. Implement a mac menu controller that takes this model and generates an NSMenu. Remove the Page Menu NSMenu from Toolbar.xib since it's now created in code. BUG=22646 TEST=page menu should work as before Review URL: http://codereview.chromium.org/465130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34179 0039d316-1c4b-4281-b951-d872f2087c98
* Change most callers of NativeScrollbar size functions to use a dedicated ↵pkasting@chromium.org2009-12-093-0/+42
| | | | | | | | | | function that matches WebKit instead, since the callers really care about content area scrollbars. BUG=none TEST=none Review URL: http://codereview.chromium.org/463061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34177 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: improve format of text/html copy paste data.estade@chromium.org2009-12-082-7/+26
| | | | | | | | | BUG=28888 TEST=works to paste html into firefox/thunderbird Review URL: http://codereview.chromium.org/465081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34070 0039d316-1c4b-4281-b951-d872f2087c98
* Split app.gyp and add a Win64 version of the app_base target.gregoryd@google.com2009-12-074-209/+377
| | | | | | | | | | | This is required for supporting NaCl on 64-bit Windows TEST=none BUG=28176 Review URL: http://codereview.chromium.org/460083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34009 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Split app.gyp and add a Win64 version of the app_base target."ajwong@chromium.org2009-12-074-368/+209
| | | | | | | | This reverts r33990 due to compile failure on linux ChromeOS. Review URL: http://codereview.chromium.org/466059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33992 0039d316-1c4b-4281-b951-d872f2087c98
* Split app.gyp and add a Win64 version of the app_base target.gregoryd@google.com2009-12-074-209/+368
| | | | | | | | | | | This is required for supporting NaCl on 64-bit Windows TEST=none BUG=28176 Review URL: http://codereview.chromium.org/460083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33990 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in textfield on views/gtk where we weren't properlysky@chromium.org2009-12-041-1/+17
| | | | | | | | | | | | | accounting for border size if not specified by style. Also changes button on views/gtk not to fix the pref height at 29. There is no reason for us to do this. BUG=none TEST=none Review URL: http://codereview.chromium.org/462036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33882 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-046-0/+452
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* Share code between Mac and Linux in ResourceBundle.hayato@chromium.org2009-12-036-162/+141
| | | | | | | | | BUG=25891 TEST=None Review URL: http://codereview.chromium.org/442002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33668 0039d316-1c4b-4281-b951-d872f2087c98
* Setting the ICU default locale is made explicit. This leads to a few morejshin@chromium.org2009-12-032-36/+36
| | | | | | | | | | | | | | | | | | lines of code, but I think it'd be better this way. Setting the ICU default locale 'quitely' as a part of IsLocaleAvailable is partly responsible for bug 26856. With the fix for that bug, Mac Chrome sets the ICU default locale explicitly. Putting Linux/Windows on the same footing is a "good thing" (TM). In addition, I fixed a typo (a spurrious L modifier to a char literal) and resolved one TODO comment (use uloc_getCharacterOrientation to determine the text layout direction). BUG=NONE TEST=Covered by unittests: L10nUtilTest.* Review URL: http://codereview.chromium.org/449077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33646 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: when reading html from clipboard, interpret BOM to meanestade@chromium.org2009-12-021-1/+10
| | | | | | | | | | | | | | | | | | | | | that the encoding is UTF-16. Otherwise, continue assuming it's utf-8. From firefox source: /* * "text/html" can be encoded UCS2. It is recommended that * documents transmitted as UCS2 always begin with a ZERO-WIDTH * NON-BREAKING SPACE character (hexadecimal FEFF, also called * Byte Order Mark (BOM)). Adding BOM can help other app to * detect mozilla use UCS2 encoding when copy-paste. */ BUG=29145 Review URL: http://codereview.chromium.org/455030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33585 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug where Chrome was not rendering fonts at the size it shouldsky@chromium.org2009-12-012-0/+24
| | | | | | | | | | | | have been. This was only apparent at DPIs other than the default, such as is typically seen on netbooks. BUG=none TEST=none Review URL: http://codereview.chromium.org/452031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33487 0039d316-1c4b-4281-b951-d872f2087c98
* Make SystemMonitor not a Singleton and move it out of basephajdan.jr@chromium.org2009-11-269-0/+446
| | | | | | | | | | | | | SystemMonitor makes an assumption that through its lifetime a MessageLoop exists and stays the same. It is difficult and error-prone to satisfy that when it is a Singleton. It has caused problems in the past. Additionally, extract HighResoltionTimerManager out of time_win.cc, eliminating yet another Singleton. TEST=none BUG=none Review URL: http://codereview.chromium.org/431008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33214 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor OS-dependent filename exclusion patternsevan@chromium.org2009-11-261-27/+0
| | | | | | | | | | | | | Rather than duplicate logic in the tree, merge all of the shared rules about patterns in filenames into one common set. The pattern is: "if (OS != x): exclude x's files." This is especially needed for upcoming changes that bring in a few more platform-specific (FreeBSD, OpenBSD, Solaris(?)) files. Review URL: http://codereview.chromium.org/443011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33160 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 7618xiyuan@chromium.org2009-11-252-18/+43
| | | | | | | | | | | | | Issue 7618 is caused by an all transparent favicon. When all pixels in XOR mask has alpha value of zero, Windows will use the AND mask. So create one for this case. BUG=7618 TEST=Verify fix for issue 7618. Review URL: http://codereview.chromium.org/434091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33149 0039d316-1c4b-4281-b951-d872f2087c98
* Load chrome.dll as a resource dll so that resources can be loaded by the ↵tommi@chromium.org2009-11-251-2/+2
| | | | | | | | | | | browser. TEST=fixes net tests for chrome frame BUG=none Review URL: http://codereview.chromium.org/437050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33094 0039d316-1c4b-4281-b951-d872f2087c98
* Move some theme images to being serviced on the IO thread. Fortony@chromium.org2009-11-242-2/+2
| | | | | | | | | | | | | | | | | Linux Release builds on my machine, all the chrome://theme/ image requests block for 300-400ms during browser startup (it's faster after startup). Something is blocking the UI thread so move image requests that aren't themed off the UI thread. This is safe to do because ResourceBundle is thread safe. I still see chrome://theme/theme_ntp_attribution and chrome://theme/theme_ntp_background blocking so I will look into those next (I think with the default theme, they shouldn't be loaded at all). Review URL: http://codereview.chromium.org/440009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ResourceBundle::LoadImageResourceBytes since it appears totony@chromium.org2009-11-233-11/+1
| | | | | | | | | be identical to LoadDataResourceBytes. Migrate callers to LoadDataResourceBytes. Review URL: http://codereview.chromium.org/437019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts font sizes to be readable on Chrome OS.sky@chromium.org2009-11-231-9/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32810 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-201-26/+30
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable TextEliderTest.ElideTextLongStrings.estade@chromium.org2009-11-202-3/+9
| | | | | | | | | | Pango returns 0 for absurdly long strings. Cut the text in half and try again if this occurs. BUG=15435 Review URL: http://codereview.chromium.org/414013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32572 0039d316-1c4b-4281-b951-d872f2087c98
* Mac language/locale cleanupthomasvl@chromium.org2009-11-193-12/+84
| | | | | | | | | | | | | | | - Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale. - For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before) - All other process types will honor the language they got on the command line when starting up. - When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.) - During browser startup, if someone passed a language, bail because Mac can't support that. TEST=The tips on the NTP and the dates on the history page are in the same language at the UI. BUG=26856 BUG=22727 Review URL: http://codereview.chromium.org/399086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32515 0039d316-1c4b-4281-b951-d872f2087c98
* Set prop app id for chromium/application shortcut.xiyuan@chromium.org2009-11-191-12/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up change after andrew's patch for win7 shortcut to properly set app id for chromium/application shortcut. - Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to base/win_util.cc as SetAppIdForPropertyStore to share with file_util shortcut code; - Add an app_id args to file_util's CreateShortcutLink and UpdateShortcutLink; - Update code that calls the above two function in installer and UserDataManager so that the chromium shortcuts are created with proper app id (except the uninstall shortcut which is not tagged with any app id). - Move ComputeApplicationNameFromURL from Browser to web_app namespace and use it as app id for application shortcut. This makes pinned shortcut and browser window use the same app id and Win7 correctly groups them; - Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL per Ben's comments; - Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than 128 chars and contains no space per msdn; - Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName BUG=28104 TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application. Review URL: http://codereview.chromium.org/399045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32508 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify some code that loops over all pixels of a bitmap.pkasting@chromium.org2009-11-191-32/+17
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32444 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanups:pkasting@chromium.org2009-11-181-55/+41
| | | | | | | | | | | | | | * SplitUrlAndTitle() can't fail, so it doesn't need to return a bool. * assign() can do substrings in one shot * Half the code used "*str =" and half "str->assign()", often right next to each other; pick one for consistency * No need to calculate array sizes when we're the ones declaring them * Use early return in a few places BUG=none TEST=none Review URL: http://codereview.chromium.org/405023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32414 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lint errors in app/ and turn on presubmit check.erg@google.com2009-11-1711-16/+41
| | | | | | Review URL: http://codereview.chromium.org/400016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32222 0039d316-1c4b-4281-b951-d872f2087c98
* Do not open a new connection if one has already been opened.dumi@chromium.org2009-11-171-0/+5
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/405005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32201 0039d316-1c4b-4281-b951-d872f2087c98
* Apply the latest translated strings to trunk.mal@chromium.org2009-11-1549-4/+53
| | | | | | | | BUG= None TEST= None Review URL: http://codereview.chromium.org/395014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32020 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Convert Cookies options page from a list into a tree.mattm@chromium.org2009-11-112-0/+8
| | | | | | | | | | | Add gtk_tree::TreeAdapter class. BUG=26713 TEST=compare behavior to windows impl Review URL: http://codereview.chromium.org/371079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31732 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31646.pkasting@chromium.org2009-11-112-17/+1
| | | | | | Review URL: http://codereview.chromium.org/386006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31648 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make widgets clean up after themselves a bit better:pkasting@chromium.org2009-11-112-1/+17
| | | | | | | | | | | * When they get "destroy" window manager messages, clean up internal state so nothing will call into them and in theory someone could re-Init() successfully * When they're deleted, ensure they're also "destroyed" from the window manager point of view BUG=27347 TEST=none Review URL: http://codereview.chromium.org/391010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31646 0039d316-1c4b-4281-b951-d872f2087c98
* Added a flag to the Canvas class which allows forcing an RTL directionalityidana@chromium.org2009-11-112-5/+19
| | | | | | | | | | | | | on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g. Windows XP with no RTL fonts installed). BUG=23425 TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs. Review URL: http://codereview.chromium.org/384018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31619 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 31478 Add UI for turning on/off network devices.mpcomplete@chromium.org2009-11-103-0/+106
| | | | | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 TBR=chocobo@google.com Review URL: http://codereview.chromium.org/384017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31598 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31478 - Add UI for turning on/off network devices.mpcomplete@chromium.org2009-11-103-106/+0
| | | | | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 TBR=chocobo@google.com Review URL: http://codereview.chromium.org/384014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31589 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 20:33:51 +0000