| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Reverts r22593, which was itself a revert of r22555.
Per nsylvain, it looks like the memory_test failures
weren't helped by rolling back this change.
TBR=nsylvain
Review URL: http://codereview.chromium.org/165059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22625 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Per nsylvain, this appears to be causing problems in
memory_test in Release mode.
Review URL: http://codereview.chromium.org/165036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22593 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18038
TESTED=restarted chrome a bunch while mucking around with gnome-appearance-settings
Review URL: http://codereview.chromium.org/164017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22555 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
on decode/encode.
BUG=18427
TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading.
Review URL: http://codereview.chromium.org/159891
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/159885
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15952,18385
Review URL: http://codereview.chromium.org/159859
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=15952
Review URL: http://codereview.chromium.org/159824
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22335 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
references to each other) anywhere in the Chromium code base.
BUG=none
TEST=rebuild
Review URL: http://codereview.chromium.org/159523
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is a follow-up change for r21596.
It seems this change forgot calling pps->Release() and PropVariantClear(&pv). (InitPropVariantFromString() calls SHStrDupW() to create a copy of its input string, so we have to call PropVariantClear() and delete it.)
To avoid an object leak and a memory leak, this change uses ScopedComPtr<IPropertyStore> to call Release() in its destructor and call PropVariantClear() to clean-up PROPVARIANT.
(My JumpList class uses a class which encapsulates PROPVARIANT. We should move the class to win_util?)
BUG=none
TEST=none (Run Chromium on purify running on Windows 7.)
Review URL: http://codereview.chromium.org/160150
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/159357
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group.
Bug=7028
Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly)
Review URL: http://codereview.chromium.org/159336
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jshin
Review URL: http://codereview.chromium.org/155933
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=estade
Review URL: http://codereview.chromium.org/155932
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
don't make sense on Linux/Mac so disable them.
I think we don't want to have a app language option on Linux
since the standard way to do this is to use LANG or LC_ALL.
Update the locale ui test to set LC_ALL on Linux.
BUG=15359
Review URL: http://codereview.chromium.org/155819
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
pango detects strong RTL characters in the layout, it switches the text direction. For our uses of DrawStringInt, we've already handled the layout and don't want the direction switched. This matches the behavior of Windows.
BUG=16970
TEST=Open a browser in a RTL language. Navigate to google.com and notice that the tab title is right-aligned. Open up the history page and notice that the title (in Hebrew) is right-aligned as well.
Review URL: http://codereview.chromium.org/155829
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the UI from ever being completely broken.
It's still possible to get a different Chrome language and GTK+
language, but that seems to be true of any GTK+ app.
BUG=16862
Review URL: http://codereview.chromium.org/155776
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In r21039, BrowserThemeProvider::Init was made non-virtual, which meant
that GtkBrowserThemeProvider::Init was never being called. Make it virtual
again (so the linux UI renders properly), and explicitly add Init() to the
ThemeProvider interface so this doesn't happen again.
Review URL: http://codereview.chromium.org/155754
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21066 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Keep the cairo clipping region in sync with the Skia one.
The PlatformCanvas now tracks this, so we don't need to have the similar code
in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the
cairo_t has a transform and clip but the surface does not.
Review URL: http://codereview.chromium.org/149409
Review URL: http://codereview.chromium.org/155700
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
extension developers who want to package extensions as part of a build script
and aren't there to click the message box.
R=aa,jackson
BUG=14732
TEST=Pack an extension with the --no-message-box flag and notice that there is no message box.
Review URL: http://codereview.chromium.org/149795
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20937 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Since moving from ResourceBundle to ThemeProvider, we needed to
plumb through GetRTLEnabledPixbufNamed in ThemeProvider.
Review URL: http://codereview.chromium.org/149483
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20568 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=http://crbug.com/16484
TEST=ensure no "extensions" folder is created as a sibling of the app binary
Review URL: http://codereview.chromium.org/155425
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20525 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20516 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
The PlatformCanvas now tracks this, so we don't need to have the similar code
in gfx::Canvas. I moved most references of cairo_surface_t to cairo_t since the
cairo_t has a transform and clip but the surface does not.
Review URL: http://codereview.chromium.org/149409
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
platform aspects.
BUG=10809
TEST=none
Review URL: http://codereview.chromium.org/113637
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fix the crazy font on infobars by reducing the "medium" font size.
Make tab dragging not immediately crash by crating a dragged tab container.
Review URL: http://codereview.chromium.org/155253
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/155199
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20161 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
that we can locate sensible shortcut text for them rather than asking Windows.
http://crbug.com/14070
TEST=see bug
Review URL: http://codereview.chromium.org/149302
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
independent of the theme provider. Since the Mac needs it to tint its vector resources it's added to the Mac.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/151153
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also added a stub for an unused method on Canvas in order to link.
TEST=Selecting "Open" from the shelf menu will open a download
BUG=15661
Review URL: http://codereview.chromium.org/150079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkNode*. This helps in making the BookmarkNode class setters public
also without worrying about someone inadvertently changing BookmarkNode
properties directly for bookmark model bookmarks.
Change all the call sites to reflect this.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/149059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19342 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Animate smoothly between decreasing popup heights. Increasing popup heights are instantaneous.
- Don't start a size adjustment until a few ms after the result set is updated to avoid jumping the height of the omnibox popup during typing as results from async providers stream in.
- The result row carries a copy of the match data so it always has something to paint even if the match that corresponded to those results is now gone. These rows aren't actually actionable by the user and only appear during the animation. The result views are retained even if they are not visible (clipped).
BUG=none
TEST=type slowly in the omnibox, note the height of the popup doesn't jump between characters.
Review URL: http://codereview.chromium.org/149030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19317 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
RTL. Use this function for custom buttons and for the Off the Record avatar.
for reference, this will be a bit different than Views, which does it per class rather than per image: http://dev.chromium.org/developers/design-documents/ui-mirroring-infrastructure
Review URL: http://codereview.chromium.org/147157
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19309 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
Fix broken IsLocaleAvailable. test_path should be updated with the result of
ReplaceExtension.
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/147121
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19193 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly.
2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring.
This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places).
Note : this CL will be landed after http://codereview.chromium.org/147038 is landed.
BUG=8647 (http://crbug.com/8647)
TEST=Pass l10n_util_unittest and other unit tests
Review URL: http://codereview.chromium.org/126223
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/14786
TEST=set bookmark bar to show by default. open a new browser window. There should be no weird vertical scrolling at the bottom of the page.
Review URL: http://codereview.chromium.org/145002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18955 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/140007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18925 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Make l10n_util::ToLower string16 friendly.
BUG=13326
Review URL: http://codereview.chromium.org/126260
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18742 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
make it a const method too.
Review URL: http://codereview.chromium.org/126282
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removed fallback to english defaults in the grd file.
BUG=7319 (http://crbug.com/7319)
TEST=Open browser with --lang=ml and confirm fonts in the UI are the
same size as before (and look ok).
Original review: http://codereview.chromium.org/126238
Patch by cira
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18594 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
through prefs.
First we try the path as absolute path. If the file is not found, we try a relative path: [installation path]\extensions
This will make installing extensions easier from pre-installed prefs, since we can drop them into an extensions directory under the program directory.
BUG=14202
TEST=Specify relative path when installing extensions through prefs. Best to test this with an installer that supports deploying extensions (blocked on 14201)
Review URL: http://codereview.chromium.org/125219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
locales more than that).Fixed spelling in font.h.Added windows only unittest for
it.
BUG=2919 (http://crbug.com/2919)
TEST=Pass font_unittest on Windows
Patch by cira
Original Review: http://codereview.chromium.org/125159
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18552 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Remove stub implementation in temp_scaffolding_stubs.h
Use l10n_util collator helper function in TableModel::Compare
Review URL: http://codereview.chromium.org/126184
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/126133
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously we had three classes of PlatformCanvas*, one for each platform. Then
we had a typedef of PlatformContext to PlatformCanvas[Mac|Win|Linux] for the
specific platform.
This means that it was almost impossible to forward-declare PlatformCanvas and
there were a bunch of unnecessary includes of platform_canvas.h in header
files.
This change makes there be only one platform_canvas.h header with ifdefs, which
removes a decent amount of duplicated code. There is a platform-independent
file, and one platform-dependent file of platform_canvas for each platform.
I also renamed PlatformDevice[Mac|Win|Linux] to PlatformDevice, althouth in
this case I kept the separate headers since there was much less overlap.
I also broke out CanvasPaint into separate headers so this template doesn't
need to be included all over the project (only a couple of files actually need
it).
Review URL: http://codereview.chromium.org/125109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18363 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
aesthetic of the bitmap-based UI.
Review URL: http://codereview.chromium.org/119300
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
font size should follow the OS settings.
Add a guard against cases when the resource bundle is not available, which should not happen in the first place.
BUG=http://crbug.com/12309
Review URL: http://codereview.chromium.org/113916
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17875 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Killed (1) the "start download" (big arrow) animation and (2) fade and resize animation on NTP page, when the following conditions is met:
(XP) Chromium is used over RDP.
(Vista) "Turn off all unnecessary animations (when possible)" option in "Control Panel - Ease of Access Center - Make the computer easier to see" is checked. Note that the option automatically becomes checked when a user turns off the "Menu and window animation" option of a remote-desktop client.
Review: http://codereview.chromium.org/115304
BUG=805
TEST=For (1), download a file and verify the arrow doesn't appear over RDP. For (2), set NTP as your homepage, start chromium on RDP session, verify fade animations on thumbnails are killed, then resize browser window, verify resize animations on thumbnails are also killed. Do the same thing with --new-new-tab-page command line flag.
Review URL: http://codereview.chromium.org/118307
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17827 0039d316-1c4b-4281-b951-d872f2087c98
|