summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* The button menu items on GTK menus honor the enabled state of the command.sanjeevr@chromium.org2010-07-292-1/+8
| | | | | | | | | BUG=None TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise. Review URL: http://codereview.chromium.org/3032038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-299-12/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-272-0/+6
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will ↵sanjeevr@chromium.org2010-07-272-0/+10
| | | | | | | | | | | be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. BUG=None. TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled. Review URL: http://codereview.chromium.org/3026025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix some NULL versus 0 issues to appease gcc-4.5.craig.schlenter@chromium.org2010-07-271-2/+2
| | | | | | | | | | | Patch is 99% the same as spotrh's version (thanks spot!) except for the use of gfx::kNullPluginWindow in this version. BUG=49533 Review URL: http://codereview.chromium.org/3014034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53788 0039d316-1c4b-4281-b951-d872f2087c98
* Make the resize gripper invisible.pkasting@chromium.org2010-07-272-1/+0
| | | | | | | | BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2671-0/+71
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity 9291: Uninitialized member in clipboard_linux.ccfinnur@chromium.org2010-07-231-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3008020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53450 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity 9291: Ininitialize member in HighResolutionTimerManager on Posix.finnur@chromium.org2010-07-221-1/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3039019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53357 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve clipboard compatibility with firefox + evolution.estade@chromium.org2010-07-201-12/+11
| | | | | | | | | | BUG=48424 TEST=copying from the chrome bookmark manager into firefox should save the bookmark's title as well as url TEST=copying the address from the omnibox into evolution copies text, and doesn't create an attachment Review URL: http://codereview.chromium.org/3022004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52983 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks the pinned background tab title change animation per Nicholas'ssky@chromium.org2010-07-193-5/+47
| | | | | | | | | | | request. BUG=none TEST=none Review URL: http://codereview.chromium.org/3041006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52949 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the application locale police that allows to enforce the ↵markusheintz@chromium.org2010-07-191-21/+5
| | | | | | | | | | | kApplicationLocale preference. bug=44504 test=none Review URL: http://codereview.chromium.org/2809058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52936 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make TransportDIB::Create() work.thakis@chromium.org2010-07-171-0/+5
| | | | | | | | | | This is never called from "live" code, but chrome/browser/tab_contents/thumbnail_generator.cc uses it. ThumbnailGenerator is currently used only on windows, but I'd like to use it on OS X. TransportDIB::Create() isn't called on OS X because all created by chrome/browser/renderer_host/render_widget_helper.cc, which creates only the shared memory object and stores it away. The actual TransportDIB is created by calls to TransportDIB::Map() in both browser and renderer processes. Review URL: http://codereview.chromium.org/3020008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52835 0039d316-1c4b-4281-b951-d872f2087c98
* Move implementations in menu model stuff from header to implementation.erg@chromium.org2010-07-164-33/+60
| | | | | | | | | | | This breaks a dependency on SkBitmap.h for everything that just uses menus. BUG=none TEST=none Review URL: http://codereview.chromium.org/2854046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52751 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash bug in new SSLClientSocketPool.davidben@chromium.org2010-07-162-2/+30
| | | | | | | | | | | | | We also need to push additional error state out of the SSLClientSocketPool on a ERR_SSL_CLIENT_AUTH_CERT_NEEDED error. BUG=49197 TEST=no crash when visiting https://foafssl.org/srv/idp?authreqissuer=http://foaf.me/index.php Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=52693 Review URL: http://codereview.chromium.org/2827053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52735 0039d316-1c4b-4281-b951-d872f2087c98
* Remove lock.h from resource_bundle.h and histogram.h.erg@chromium.org2010-07-166-11/+18
| | | | | | | | | | | Use a scoped_ptr<Lock> instead of Lock in resource bundle. BUG=none TEST=none Review URL: http://codereview.chromium.org/3038005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52730 0039d316-1c4b-4281-b951-d872f2087c98
* AcceleratedSurface performs one off GL initialization before attempting to ↵apatrick@chromium.org2010-07-151-0/+4
| | | | | | | | | | | create its offscreen GL context. TEST=try, verify that youtube now works, verify that WebGL still works BUG=49158 Review URL: http://codereview.chromium.org/3019003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52532 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt four at landing the "histogram.h removed from message_loop.h" patch.erg@chromium.org2010-07-153-1/+4
| | | | | | | | | | | | | | Previously committed as r52349 and r52336. Related commits: r52367, r52364 and r52343. Rerunning trybots due to previous trybot breakage. TEST=none BUG=none Review URL: http://codereview.chromium.org/2965015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52496 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Put buttons into the new unified Wrench menu.rsesek@chromium.org2010-07-151-1/+2
| | | | | | | | | | | | This also makes changes to MenuController to support NIB-based initialization. Screen shots: http://cl.ly/1cyU (en) and http://cl.ly/1cyE (ru). BUG=47848 TEST=Click on Wrench menu and see buttons. Buttons perform their function. Review URL: http://codereview.chromium.org/2923009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52485 0039d316-1c4b-4281-b951-d872f2087c98
* Supports High DPI mode.hbono@chromium.org2010-07-152-0/+22
| | | | | | | | | | When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later. BUG=1715,36939 TEST=Run chrome.exe on the screen resolution higher than 120 DPI. Review URL: http://codereview.chromium.org/2867031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52446 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix leaking TransportDIB in ↵mattm@chromium.org2010-07-141-1/+2
| | | | | | | | | | | | GpuBackingStore{GLX,Win}::OnPaintToBackingStore CID=8190,9146 TEST=none BUG=none Review URL: http://codereview.chromium.org/2997002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52410 0039d316-1c4b-4281-b951-d872f2087c98
* Remove images on disk that are not referenced by anything.pkasting@chromium.org2010-07-144-0/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2986006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52408 0039d316-1c4b-4281-b951-d872f2087c98
* Added --use-gl command line flag to select GL implementation.apatrick@chromium.org2010-07-1417-333/+717
| | | | | | | | | | | | - Options are desktop, egl and osmesa. - Also added support for bliting an OSMesa bask buffer to a GDK window. TEST=trybots, manual verification that WebGL and Pepper 3D work BUG=45898 Review URL: http://codereview.chromium.org/2825005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52388 0039d316-1c4b-4281-b951-d872f2087c98
* Revert everything related to the relanding.erg@chromium.org2010-07-142-2/+0
| | | | | | Review URL: http://codereview.chromium.org/2982009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52367 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r52336.erg@chromium.org2010-07-142-0/+2
| | | | | | | | | | | | | | (I accidentally committed a previous version of the patch (the fixed version was in codereview since I had switched to my mac to address this exact compile failure.) BUG=none TEST=none TBR=evan Review URL: http://codereview.chromium.org/2937010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52349 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52336 - More header cleanup:erg@chromium.org2010-07-142-2/+0
| | | | | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52343 0039d316-1c4b-4281-b951-d872f2087c98
* More header cleanup:erg@chromium.org2010-07-142-0/+2
| | | | | | | | | | | | | - Some cleanup to url_request.h - Remove task.h from headers that don't need it. - Remove histogram.h from message_loop.h BUG=none TEST=none Review URL: http://codereview.chromium.org/2986002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52336 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up app_resources.grd:pkasting@chromium.org2010-07-1330-41/+13
| | | | | | | | | | | | * Alphabetize a couple entries * Move things to theme_resources.grd where possible; also fixes problems in chrome.gyp and theme_resources.grd that were causing "toolkit_views" to not be properly handled here, so this won't cause problems * Scope things only used by views under an appropriate conditional BUG=none TEST=none Review URL: http://codereview.chromium.org/2987003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52238 0039d316-1c4b-4281-b951-d872f2087c98
* Assign resource ids from a central file.tony@chromium.org2010-07-131-1/+1
| | | | | | | | | | | This allows us to control resource id assignment across all grd files so we can avoid id collisions. BUG=48625 Review URL: http://codereview.chromium.org/2961002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52211 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52144 - Clean up app_resources.grd:pam@chromium.org2010-07-1330-13/+41
| | | | | | | | | | | | | | | | | | | | * Alphabetize a couple entries * Move things to theme_resources.grd where possible * Scope things only used by views under an appropriate conditional Reverting becasue it definitely causes ExtensionBrowserTest.Toolstrip to crash, and apparently causes crashes in the startup_tests too. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/2953005 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2897012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52175 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up app_resources.grd:pkasting@chromium.org2010-07-1230-41/+13
| | | | | | | | | | | | * Alphabetize a couple entries * Move things to theme_resources.grd where possible * Scope things only used by views under an appropriate conditional BUG=none TEST=none Review URL: http://codereview.chromium.org/2953005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52144 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: linux: fix leak in Clipboard::WriteData with disallowed format.mattm@chromium.org2010-07-121-2/+2
| | | | | | | | | | CID=9154 TEST=none BUG=none Review URL: http://codereview.chromium.org/2946006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52134 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup: SkBitmap and other unnecessary includes.erg@chromium.org2010-07-122-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52093 0039d316-1c4b-4281-b951-d872f2087c98
* GTK - don't paste a garbage text/html character.estade@chromium.org2010-07-101-2/+6
| | | | | | | | | | | | | When the clipboard text/html data terminates with NULL, drop it (WebKit used to do this for us before the parsing changed in roll 61629:61653). Some programs such as open office NULL terminate clipboard text/html data, even though it is unnecessary since the clipboard api provides a length for the data buffer. Chrome also NULL terminates text/html data in order to work around a bug in some versions of pidgin. Also, don't NULL terminate text/plain data, because no app I tested (firefox, gedit, midori, konqueror, OO) does this. BUG=48335 TEST=manual (see bug) Review URL: http://codereview.chromium.org/2896006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52034 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Grouped buttons should be equal sizes in new wrench menu.erg@chromium.org2010-07-092-32/+15
| | | | | | | | | | | | | This completes the linux implementation of the new wrench menu. Turning on by default. Will watch how this goes. BUG=45757 TEST=Look at the menu. The size of the "cut," "copy" and "paste" buttons should be equal. Review URL: http://codereview.chromium.org/2961001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51974 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-081-110/+95
| | | | | | | BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51906 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Minimize usage of gtk headers.erg@chromium.org2010-07-085-56/+102
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2891006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51898 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new Chromium IPCs for copying/dragging.dcheng@chromium.org2010-07-071-2/+5
| | | | | | | | | | | A new ClipboardDispatcher interface has been added to handle the IPC calls. The new methods don't really belong on the existing Clipboard class, since that class deals with only copy and paste. On Windows and Mac, ClipboardDispatcher will share logic for copy/paste and drag/drop. GTK will have to use two separate code paths. BUG=31037 TEST=none Review URL: http://codereview.chromium.org/2842016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51790 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 51572 - Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-021-95/+110
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 TBR=pkasting@chromium.org Review URL: http://codereview.chromium.org/2864039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51575 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up .grds, step 1: Alphabetize.pkasting@chromium.org2010-07-021-110/+95
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2838041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51572 0039d316-1c4b-4281-b951-d872f2087c98
* Move WindowImpl to gfx so I can use it there for canvas unit tests.ben@chromium.org2010-07-023-347/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2813042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51554 0039d316-1c4b-4281-b951-d872f2087c98
* Moves gtk accelerator processing functions to base/gtk_util so I cansky@chromium.org2010-07-011-0/+2
| | | | | | | | | | | | | use them from views and gfx. Sorry for the new patch on this and not an update. Not sure what happened. BUG=none TEST=none Review URL: http://codereview.chromium.org/2809047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51409 0039d316-1c4b-4281-b951-d872f2087c98
* Rename the Thumbnails database file to Favicons.nshkrob@chromium.org2010-06-301-1/+2
| | | | | | | | | | | The database will no longer store the thumbnails - TopSites is storing it's own thumbnails. BUG=None TEST=ThumbnailDatabaseTest Review URL: http://codereview.chromium.org/2842034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51294 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Cleanups to the new wrench menu.erg@chromium.org2010-06-302-17/+55
| | | | | | | | | | | | | | | - Make the rendering for multiple buttons pretty by unifying sequnces of buttons. - Add the zoom label control and make the wrench menu model listen for notifications about zoom percentage changing. - Fixes crash that would have gone away once this was taken out from behind a flag BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2799043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51266 0039d316-1c4b-4281-b951-d872f2087c98
* Change chrome from statically enabling high resolution timers on windowsmbelshe@chromium.org2010-06-291-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | to enabling them dynamically - only when the application really needs them. I am working on some test cases for this, and will add them. But wanted to send out the concept for review. In this implementation, I modify the message loop to detect when the application has requested high resolution timers. Note that there are multiple MessageLoops active in a single process. After a period of time, we simply shut it off again. We could have set a timer or kept a count of active timers, or any number of more complex algorithms. But I think this algorithm is very simple and good enough. If an application continues needing high resolution timers for more than 1s, we'll turn the high-resolution timers back on again. One last change - since we've implemented the clamp at 4ms, there isn't a lot of point to our use of 1ms for timeBeginPeriod. I've modified that to 2 (which is half of 4ms, our target minimal interval). BUG=46531 TEST=MessageLoop.HighResolutionTimers Review URL: http://codereview.chromium.org/2822035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51102 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: delete the unencrypted login database file after a successful ↵mdm@chromium.org2010-06-292-1/+7
| | | | | | | | | | password store migration, since otherwise fragments of password data may be left in it. BUG=25404 TEST=the "Login Data" file should get deleted and recreated from scratch after migration Review URL: http://codereview.chromium.org/2866023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51094 0039d316-1c4b-4281-b951-d872f2087c98
* Make all changes to app/ run on all trybot platforms, not just the big three.erg@chromium.org2010-06-281-0/+3
| | | | | | | | | | | Anyone who's changing a header here may break the chromeos build. BUG=none TEST=none Review URL: http://codereview.chromium.org/2838027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51000 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some unncessary dependencies on libxml.mad@google.com2010-06-271-1/+0
| | | | | | | | | | | As working on change committed in rev50132, instead of yet adding another project to the dependency list of libxml, I decided to abstract the dependency in the metrics helper. BUG=0 TEST=None Review URL: http://codereview.chromium.org/2753010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50952 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply r50859 with chromeos fixes.erg@chromium.org2010-06-256-10/+205
| | | | | | | | | | | | | | | | GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. Review URL: http://codereview.chromium.org/2800015 BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50859 - GTK: First draft of the unified cut/copy/paste and ↵rafaelw@google.com2010-06-256-205/+10
| | | | | | | | | | | | | | | | | | +/-/Fullscreen menu items. Adds special menu item types that allow shoving buttons into them, along with tracking which button is selected. We now are halfway to the mocks that the chrome-ui-leads sent out. BUG=45757 TEST=none Review URL: http://codereview.chromium.org/2800015 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2836029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50865 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-17 06:29:26 +0000