summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Get the About panel to align its links correctly,davemoore@chromium.org2009-10-232-9/+2
| | | | | | | | but undo a previous change to the way we measure strings in pango. Review URL: http://codereview.chromium.org/338001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29943 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs on linux throb when the title changes. Isky@chromium.org2009-10-231-0/+4
| | | | | | | | | | | need to resolve with Glen/Nicholas how to handle the windows side. BUG=25308 TEST=none Review URL: http://codereview.chromium.org/314010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the RootView is sized to the correct bounds when the opaque frame ↵ben@chromium.org2009-10-231-0/+3
| | | | | | | | is maximized.It seems that now, when an opaque frame is maximized we also need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know why, it's just is.I reworked the way Widget allows subclasses to handle sizing of the RootView... I delegate responsibility for determining the RootView's bounds to a helper virtual function which BrowserFrameWin overrides. This seems cleaner to me. I make sure this handling only occurs when the window is not maximized.http://crbug.com/25227TEST=use to a theme or switch off glass on vista or use Xp. Maximize the browser window. The tabs should be entirely visible. Review URL: http://codereview.chromium.org/304007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29882 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of file path name handling.brettw@chromium.org2009-10-221-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | This started trying to cleanup DownloadManager::GenerateFilename which asserts if your system locale isn't UTF-8 (I ran into this when mine got messed up). The solution is to have GetSuggestedFilename return a FilePath rather than calling FromWStringHack. The rest of the patch is a result of trying to write GetSuggestedFilename in a reasonable way. I changed ReplaceIllegalCharacters to work on a FilePath::StringType. Some places in the code calling these functions got cleaner, some got messier. I think overall the ones that got messier are the ones doing sketchy things with paths and the ones that got cleaner are the ones doing things more properly. The only code here that gets called a nontrivial number of times is the weburlloader, and I think the new code does about the same number of string conversions overall (though on certain platforms the number will be higher or lower). BUG=none TEST=none Review URL: http://codereview.chromium.org/271056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29832 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium fix for "Copy Image". (WebCore fix is ↵avi@chromium.org2009-10-222-1/+44
| | | | | | | | | | | http://codereview.chromium.org/294023 .) BUG=http://crbug.com/13099 TEST="Copy Image" works; see bug Review URL: http://codereview.chromium.org/308001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29812 0039d316-1c4b-4281-b951-d872f2087c98
* Make PNGCodec::Decode(...) not make an intermediary copy of the decoded data;erg@google.com2009-10-224-73/+160
| | | | | | | | | | | instead have it write directly to the returned SkBitmap. BUG=http://crbug.com/24493 TEST=Perf should get better. On the perf trybot, tab_complex_theme_cold got an average of ~40ms better. Review URL: http://codereview.chromium.org/305001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29780 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dragging icon for dragging bookmarks in views/gtk.skrul@google.com2009-10-214-4/+37
| | | | | | Review URL: http://codereview.chromium.org/270068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29692 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Display explanatory message on sad tab page.estade@chromium.org2009-10-211-4/+3
| | | | | | | | | | | Also fix canvas text drawing bugs for certain vertical alignments. BUG=25267 TEST=about:crash Review URL: http://codereview.chromium.org/307015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29673 0039d316-1c4b-4281-b951-d872f2087c98
* linux: rearrange clipboard codeevan@chromium.org2009-10-203-46/+45
| | | | | | | | | | | | | | | Once I understood what was going on, I attempted to clarify the comment in the header. The code seemed totally wrong on first read and I think a comment like the one I wrote would've helped. Concrete changes: DCHECK() if a key is set twice; don't call WriteText() from WriteBookmark(). BUG=22697 Review URL: http://codereview.chromium.org/307003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29523 0039d316-1c4b-4281-b951-d872f2087c98
* app depends on x11 because of active_window_watcher_x.evan@chromium.org2009-10-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/300017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29514 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing files to app.gyp.mark@chromium.org2009-10-201-3/+6
| | | | | | | | | | Patch by Thiago Farina <thiago.farina@gmail.com> BUG=None TEST=None Review URL: http://codereview.chromium.org/295002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29494 0039d316-1c4b-4281-b951-d872f2087c98
* Plug a font leak.davemoore@chromium.org2009-10-191-1/+3
| | | | | | Review URL: http://codereview.chromium.org/293011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29462 0039d316-1c4b-4281-b951-d872f2087c98
* Do work necessary to make Views About panel work on Chrome OS. This is to be ↵davemoore@chromium.org2009-10-193-24/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | | used for forcing Chrome OS updates. There were many things that needed to be fixed for this to work. Make skia's canvas return height of font for size of strings, instead of the actual height of the characters to bring it in line with Windows. Make average character widths use pango metrics and windows dialog units. Make this lazy, to avoid most calls. Fix bug in About panel that failed to adjust the embedded links to allow for the padding that Link adds so they can be focused. Support gtk about panel in regular build, views in chrome os only. Fix WindowGtk to call WindowClosing() Fix canvas_linux::SetupPangoLayout() to wrap correctly, if passed a width Fix Label::ComputeMultiLineFlags() to turn off eliding. With eliding the pango routines always return 1 line. Enable focus manager in dialogs. Version loader crashed in debug. Review URL: http://codereview.chromium.org/282002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29414 0039d316-1c4b-4281-b951-d872f2087c98
* First fix to minimize copying of image data.erg@google.com2009-10-196-62/+54
| | | | | | | | | | | | | | | | | | | | | | | | | | | This is the first of multiple patches that clean up handling of memory regarding images. Previously, the code did several memcpy()s or equivalents. This change: - Creates an abstract interface RefCountedMemory which provides access to the front() of a memory range and the size() of it. It is a RefCountedThreadSafe. - Adds a RefCountedStaticMemory class which isa RefCountedMemory. - Pushes RefCountedBytes up into base/ from chrome/ and make it conform to RefCountedMemory. - Have ResourceBundle return RefCountedStaticMemory to the mmaped() or DLL loaded resources instead of memcpy()ing them. - General cleanups to minimize copies in constructing RefCountedBytes. - Use the above consistent interface in the BrowserThemeProvider, along with special casing the loading of the new tab page background. This patch is mostly cleanups and there should only be a slight performance gain if any. Most of the real speedups should come in subsequent patches. BUG=http://crbug.com/24493 TEST=Slightly faster on Perf bot; does not introduce crashes. Review URL: http://codereview.chromium.org/288005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29412 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-163-3/+73
| | | | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29258 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29263 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29258.akalin@chromium.org2009-10-163-73/+3
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29259 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-163-3/+73
| | | | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29255 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29258 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29255.akalin@chromium.org2009-10-163-73/+3
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29256 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-163-3/+73
| | | | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29253 Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29255 0039d316-1c4b-4281-b951-d872f2087c98
* Reverted 29253.akalin@chromium.org2009-10-163-73/+3
| | | | | | TBR: nick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29254 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-163-3/+73
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29253 0039d316-1c4b-4281-b951-d872f2087c98
* TBR: nick@chromium.orgakalin@chromium.org2009-10-163-73/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29240 0039d316-1c4b-4281-b951-d872f2087c98
* Made sync code build and pass unit tests on OS X.akalin@chromium.org2009-10-163-3/+73
| | | | | | | | | | | | | | Major changes: - Moved sync_setup_{flow,wizard} to sync directory. - Made browser_with_test_window_test compile on non-Windows platform. - Moved localized contents font util functions to app/. BUG=23073 TEST=trybot Review URL: http://codereview.chromium.org/279004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29239 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the base_gfx project since it no longer has an external dependencies.brettw@chromium.org2009-10-141-1/+1
| | | | | | | | | | Replace it with base_i18n which encapsulates all ICU dependencies. BUG=none TEST=none Review URL: http://codereview.chromium.org/267048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29036 0039d316-1c4b-4281-b951-d872f2087c98
* Make the ThemeProvider methods const.pkasting@chromium.org2009-10-131-11/+12
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/266037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28868 0039d316-1c4b-4281-b951-d872f2087c98
* Turn NULL used as int to 0.phajdan.jr@chromium.org2009-10-132-1/+4
| | | | | | | | | | | | | (Excluding chrome/browser/...) Landing patch for Jacob Mandelson. Original review: http://codereview.chromium.org/195067 BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/267076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28810 0039d316-1c4b-4281-b951-d872f2087c98
* Remove typos for gtk_native_view_id_manager in app.gyp. Make complains: ↵thestig@chromium.org2009-10-131-2/+0
| | | | | | | | | | Circular out/Debug/obj/app/gfx/gtk_native_view_id_manager.o <- out/Debug/obj/app/libapp_base.a dependency dropped. BUG=none TEST=Make no longer complains about circular dependencies in app/gfx. Review URL: http://codereview.chromium.org/267068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28783 0039d316-1c4b-4281-b951-d872f2087c98
* Use ASCII strings for switch names.evan@chromium.org2009-10-132-2/+2
| | | | | | Review URL: http://codereview.chromium.org/270062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28779 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-118-1/+730
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-091-1/+1
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for Swahili and Amharic.mal@chromium.org2009-10-093-0/+24
| | | | | | | | BUG= None TEST= chrome.exe --lang=sw and chrome.exe --lang=am Review URL: http://codereview.chromium.org/272006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28540 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of mac_app_names.h. Replace it with real constants frommark@chromium.org2009-10-081-8/+5
| | | | | | | | | | | | | | | | | chrome_constants.h. As a side effect of this change, tests will use the framework in the build directory as their main bundle override for the purposes of resource loading, instead of looking into the framework inside the application bundle. This should be more than sufficient, and is done for simplicity, because a future change will make it more difficult to locate the correct framework inside the application bundle unless the product version number is known. BUG=24220 TEST=product still works and all tests still pass Review URL: http://codereview.chromium.org/266023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28431 0039d316-1c4b-4281-b951-d872f2087c98
* Separate out some more ICU from base and into base/i18n.brettw@chromium.org2009-10-082-1/+2
| | | | | | | | | | | | | | | | | | | | This moves string_util_icu. I moved the number formatting function into base/i18n/number_formatting and just removed the other function in string_util_icu which was TrimWhitespaceUTF8. It is only used in a few places and isn't actually helpful (and the fact that it round-trips through UTF-16 is better for the caller to see). This takes out the sorting from the FileEnumerator. The comment says the sorting is not guaranteed. I moved it into file_util_icu as a standalone function for callers of FileEnumerator to call manually if they need sorted results. I modified the directory lister to use this sorting instead, and filed a bug on doing more optimal JS-based sorting. TEST=none BUG=none Review URL: http://codereview.chromium.org/267001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28405 0039d316-1c4b-4281-b951-d872f2087c98
* Fix SQL preloading. I did Run() with a SELECT which produces data, so itbrettw@chromium.org2009-10-071-1/+1
| | | | | | | | | | reports failure. This meant we were never preloading data. TEST=covered by perf tests http://crbug.com/23854 Review URL: http://codereview.chromium.org/265018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28301 0039d316-1c4b-4281-b951-d872f2087c98
* Move classes depending on Skia out of base/gfx and into app/gfx. Renamebrettw@chromium.org2009-10-0712-2/+1451
| | | | | | | | | | native_theme to native_theme_win since its Windows-specific. BUG=none TEST=none Review URL: http://codereview.chromium.org/259047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98
* Move all resources into the framework.mark@chromium.org2009-10-071-3/+15
| | | | | | | | | | | | | | BUG=14610 (in support of unbreaking auto-update) TEST=The .app's Contents/Resources folder should not contain the resources that are moving to the .framework's Resources folder; The .app's Contents/Resources folder should still contain app.icns, document.icns, the helper .app, and a whole slew of .lprojs that only contain InfoPlist.strings; Make sure Breakpad still works in the browser, renderer, and other process types. Review URL: http://codereview.chromium.org/256062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28262 0039d316-1c4b-4281-b951-d872f2087c98
* Add comments setting emacs and vim tab width and expansion variables.sgk@google.com2009-10-061-0/+6
| | | | | | | | BUG=none TEST=successful builds Review URL: http://codereview.chromium.org/256059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98
* Move the clipboard stuff out of base and into app/clipboard. I renamedbrettw@chromium.org2009-10-0313-3/+2881
| | | | | | | | | | | clipboard_util to clipboard_util_win since it's Windows-only. This patch makes test_shell depend on app as well. There should be no logic change. TEST=none BUG=none Review URL: http://codereview.chromium.org/260003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27937 0039d316-1c4b-4281-b951-d872f2087c98
* Animations: animate to current time, rather than a set number of frames.estade@chromium.org2009-10-032-27/+22
| | | | | | | | | | | | | | | | This will cut down on the number of total frames shown for slow animations; should have no effect on fast animations. This makes the following animations much snappier (as seen on Linux): - download shelf opening - bookmark bar opening at large browser width - new tab animation BUG=all animation jank bugs TEST=if you put a Sleep(1000) in an AnimationProgressed callback, you will actually get called back fewer times. TEST=looked at all the animations I could think of to make sure they still work right. Review URL: http://codereview.chromium.org/257038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27935 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build by modifying a file I forgotbrettw@chromium.org2009-10-031-5/+5
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/251086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27931 0039d316-1c4b-4281-b951-d872f2087c98
* Move the JPEG and PNG codecs from base/gfx to app/gfx/codec. Move the classesbrettw@chromium.org2009-10-039-7/+1693
| | | | | | | | | | | | | | | into the gfx namespace. Combine the PNGEncoder and PNGDecoder. There were separate when we had different executables for the browser and renderer, and linked the encoder only in one of them (which saved us some space used by libpng). This hasn't been the case for years, so combining them (again) makes sense. TEST=none BUG=none Review URL: http://codereview.chromium.org/243076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27930 0039d316-1c4b-4281-b951-d872f2087c98
* Convert history to use new sql wrappers. Enhance wrappers in several ways tobrettw@chromium.org2009-10-027-40/+102
| | | | | | | | | | support the needs of history. BUG=none TEST=covered by unit tests Review URL: http://codereview.chromium.org/246053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27832 0039d316-1c4b-4281-b951-d872f2087c98
* Check in the binary resources from:aa@chromium.org2009-10-024-0/+5
| | | | | | | | | | http://codereview.chromium.org/259004 separately so that the code changes can be run on the try bot. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27817 0039d316-1c4b-4281-b951-d872f2087c98
* Rollback broken change, again.aa@chromium.org2009-10-024-5/+0
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27815 0039d316-1c4b-4281-b951-d872f2087c98
* Check in http://codereview.chromium.org/259004 again.aa@chromium.org2009-10-024-0/+5
| | | | | | | | First cut at badge implementation. TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27812 0039d316-1c4b-4281-b951-d872f2087c98
* Landing font change again. I don't believe early flakiness was thesky@chromium.org2009-10-012-16/+28
| | | | | | | | | | | | result of my change. test_shell doesn't use font at all. This is exactly the same change as was earlier landed. BUG=22791 TEST=see bug TBR=agl Review URL: http://codereview.chromium.org/242111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27790 0039d316-1c4b-4281-b951-d872f2087c98
* Revert tree bustage.aa@chromium.org2009-10-014-5/+0
| | | | | | TBR=erikkay@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27764 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at badge implementation. Right now it just uses staticaa@chromium.org2009-10-014-0/+5
| | | | | | | | | | | | | data. A subsequent change will hook it up to the extension APIs. See http://dl.getdropbox.com/u/124107/badges.png for a picture of what this looks like. BUG=23268 Review URL: http://codereview.chromium.org/259004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27761 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Remove a check for < 0 on an unsigned int.jhawkins@chromium.org2009-10-011-5/+5
| | | | | | | | | CID=4546 BUG=none TEST=none Review URL: http://codereview.chromium.org/249047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27753 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting recent font change, it seems to be causing problems withsky@chromium.org2009-10-012-28/+16
| | | | | | | | | | | test_shell and valgrind ui. BUG=22791 TEST=none TBR=agl Review URL: http://codereview.chromium.org/251059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27742 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 10:46:08 +0000