summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Clang: Do not ignore result of HANDLE_EINTR.thakis@chromium.org2010-06-231-1/+3
| | | | | | Review URL: http://codereview.chromium.org/2805026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50556 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Give the Wrench menu keyboard shortcuts.rsesek@chromium.org2010-06-222-0/+59
| | | | | | | | | | | Note that these key equivalents are for display only and do not get fired. Commands are routed through the main menu/CommandUpdater. BUG=45098 TEST=Open Wrench menu, see keyboard shortcuts. Review URL: http://codereview.chromium.org/2800019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50452 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals resources from resources.pak.tony@chromium.org2010-06-222-11/+22
| | | | | | | | | | | | | | | This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50433 0039d316-1c4b-4281-b951-d872f2087c98
* gpu: add GLES/EGL support on linuxpiman@chromium.org2010-06-217-32/+204
| | | | | | Review URL: http://codereview.chromium.org/2829007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50397 0039d316-1c4b-4281-b951-d872f2087c98
* Speculatively revert 50374 (miniinstaller breakage) - Load netinternals ↵willchan@chromium.org2010-06-212-22/+11
| | | | | | | | | | | | | | | | | | | | resources from resources.pak. This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2799022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50392 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals resources from resources.pak.erg@chromium.org2010-06-212-11/+22
| | | | | | | | | | | | | | | This is the same as r50257 with 2 fixes: 1) Copy resources.pak to <(PRODUCT_DIR) on mac so it will work for things tests. 2) Add back the check in chrome_paths.cc to see if we're in a mac bundle or not. BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2865010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50374 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50257 - Reland r50057. This is exactly the same except with two lines ↵erg@chromium.org2010-06-182-22/+11
| | | | | | | | | | | | | | | | | | | | | | | | cherrypicked from tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h} files. Load net-internals from the newly created resources.pak file. This patch also forces the loading of the optional DataPack for const correctness reasons Original Review: http://codereview.chromium.org/2855003 BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2800014 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2811016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50260 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r50057. This is exactly the same except with two lines cherrypicked fromerg@chromium.org2010-06-182-11/+22
| | | | | | | | | | | | | | | | | | | tony's CL 2814009 that tell make about the net_internals_resources_map.{cc,h} files. Load net-internals from the newly created resources.pak file. This patch also forces the loading of the optional DataPack for const correctness reasons Original Review: http://codereview.chromium.org/2855003 BUG=35793,42770 TEST=none TBR=tony Review URL: http://codereview.chromium.org/2800014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50257 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks for the merged menu:sky@chromium.org2010-06-171-4/+10
| | | | | | | | | | | | | | | | | | | | | . makes the menu show the same fonts regardless of whether the item has children. . adds text color to MenuConfig. I'm going to use this for the buttons added to the menu. . Changes TextButton to update text_size_ when the font changes. . Changes TextButton to allow you to specify how accelerators are shown. . Nukes TextButton::OnMousePressed as it's not needed (super implementation does the right thing and updates state the TextButton::OnMousePressed wasn't). . Changes accelerator to have constructor taking keycode and modifiers. BUG=45734 TEST=none Review URL: http://codereview.chromium.org/2833013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50108 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 50057 - Load net-internals from the newly created resources.pak file.erg@chromium.org2010-06-172-22/+11
| | | | | | | | | | | | | | This patch also forces the loading of the optional DataPack for const correctness reasons BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2855003 TBR=erg@chromium.org Review URL: http://codereview.chromium.org/2852011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50059 0039d316-1c4b-4281-b951-d872f2087c98
* Load net-internals from the newly created resources.pak file.erg@chromium.org2010-06-172-11/+22
| | | | | | | | | | | This patch also forces the loading of the optional DataPack for const correctness reasons BUG=35793,42770 TEST=none Review URL: http://codereview.chromium.org/2855003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50057 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49984 - patch from issue 2762014thakis@chromium.org2010-06-161-3/+1
| | | | | | | TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/2835007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50000 0039d316-1c4b-4281-b951-d872f2087c98
* patch from issue 2762014thakis@chromium.org2010-06-161-1/+3
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49984 0039d316-1c4b-4281-b951-d872f2087c98
* Committing on behalf of p155off@gmail.com .kbr@google.com2010-06-154-78/+40
| | | | | | | | | | | | | Remove duplicated code in AcceleratedSurface using PbufferGLContext instead. This also fixes a crash caused by the OpenGL bindings not being initialized. BUG=46286 TEST=flash plugin 10.1 works again in both mac 10.5 and 10.6 Review URL: http://codereview.chromium.org/2782006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49836 0039d316-1c4b-4281-b951-d872f2087c98
* Mac/clang: Possibly contentious changes.thakis@chromium.org2010-06-151-2/+2
| | | | | | | | | | | | As discussed on irc, we're getting rid of const NSObjects, and we're making all properties nonatomic. const: All of cocoa takes nonconst NSObjects, and passing a const NSString to a function that takes NSString is a const violation. gcc doesn't complain about this, but clang intentionally does. constness is usually done via immutable base classes and mutable subclasses in cocoa anyway, so getting rid of const isn't that bad. Also, we don't really have a choice. nonatomic: Some of our classes have custom setters that are not @synchronized. If the @property for that is not non-atomic, then the interface claims that the method is synchronized but the implementation actually isn't. That's a bug. gcc happens not to complain about this, but clang does. Since we shouldn't need atomic properties anywhere, the simple rule is now to just make all properties nonatomic. Review URL: http://codereview.chromium.org/2769014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49808 0039d316-1c4b-4281-b951-d872f2087c98
* Load resources.pak, which should be located next to the chrometony@chromium.org2010-06-154-2/+76
| | | | | | | | | | | | | | | binary. resources.pak will contain all the files we currently have in the resources subdirectory (it currently only has net-internals files). On Linux, this is an eager load (before the zygote), but on Mac and Win, this is lazily loaded as needed. This isn't being used yet, just adding the necessary plumbing for now. BUG=42770 Review URL: http://codereview.chromium.org/2755006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49772 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a ResourceBundle::GetDataResource and convert people totony@chromium.org2010-06-152-12/+1
| | | | | | | | | | the StringPiece version. In most cases, I didn't bother trying to make the calling code more efficient since nothing seems to be in time sensitive code. Review URL: http://codereview.chromium.org/2827001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49766 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Catch X errors and force a crash.thestig@chromium.org2010-06-112-0/+21
| | | | | | | | BUG=45020 TEST=See http://crosbug.com/3487 Review URL: http://codereview.chromium.org/2716007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49488 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting checkin in rev 48521 as creating a child window for GL rendering ↵vangelis@chromium.org2010-06-101-63/+5
| | | | | | | | | | | | | creates more problems than it solves. Hopefully either we'll find a more elegant solution or the problem will go away with the introduction of ANGLE. This patch is identical to: http://codereview.chromium.org/2644001/show which was checked in and reverted due to a build failure (which I believe was unrelated) Review URL: http://codereview.chromium.org/2721001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49441 0039d316-1c4b-4281-b951-d872f2087c98
* Added EGL based GLContext.apatrick@chromium.org2010-06-0922-362/+2514
| | | | | | | | | | | | | | Python script to generate code to dynamically bind to GL functions (native GL, OSMesa, EGL or mock GL for unit tests). This replaces GLEW because GLEW doesn't bind to the GLES dialect of GL. Moved the mock GL code into app/gfx/gl. Updated the GPU code and AcceleratedSurface to use the new GL bindings. TEST=trybots BUG=none Review URL: http://codereview.chromium.org/2134006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49332 0039d316-1c4b-4281-b951-d872f2087c98
* Refactored the translate infobars.jcivelli@chromium.org2010-06-092-0/+12
| | | | | | | | | | | | | | Since some work is needed on Linux and Mac to use the new translate infobar delegate, I created a new version of the refactored classes instead of replacing them. Once Linux and Mac use the new classes, we can make the swicth. The TranslateInfoBarDelegate now contains all states, so there is no more logic on the infobar classes. I broke down the single infobar class into multiple ones (there is now an infobar for each state: before translate, translating, after translate, error): it makes the code simpler. I had to fix ReplaceInfoBar on Windows as it was not working properly. BUG=40828 TEST=Test thoroughly the translate feature. Review URL: http://codereview.chromium.org/2602003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49307 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 49066 - Reverting checkin in rev 48521 as creating a child window for ↵erg@chromium.org2010-06-071-5/+63
| | | | | | | | | | | | GL rendering creates more problems than it solves. Hopefully either we'll find a more elegant solution or the problem will go away with the introduction of ANGLE. Review URL: http://codereview.chromium.org/2644001 TBR=vangelis@chromium.org Review URL: http://codereview.chromium.org/2645007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49067 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting checkin in rev 48521 as creating a child window for GL rendering ↵vangelis@chromium.org2010-06-071-63/+5
| | | | | | | | | creates more problems than it solves. Hopefully either we'll find a more elegant solution or the problem will go away with the introduction of ANGLE. Review URL: http://codereview.chromium.org/2644001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49066 0039d316-1c4b-4281-b951-d872f2087c98
* Convert RTF on the pasteboard to HTML and all it to substitute if present ↵pinkerton@chromium.org2010-06-042-3/+14
| | | | | | | | | | and no HTML is on a paste or drop. Safari does not put HTML on the pasteboard, only RTF. BUG=44661 TEST=dropping/pasting html should retain basic structure, but fonts/colors don't seem to propagate. Review URL: http://codereview.chromium.org/2674002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48962 0039d316-1c4b-4281-b951-d872f2087c98
* <wininet.h> related cleanup.wtc@chromium.org2010-06-041-1/+1
| | | | | | | | | | | | | Document why clipboard_util_win.cc needs to include <wininet.h>. test_shell_win.cc does not need to include <wininet.h>. R=eroman BUG=none TEST=none Review URL: http://codereview.chromium.org/2606004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48937 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in app ↵tfarina@chromium.org2010-06-043-3/+3
| | | | | | | | | | | and base directories. BUG=None TEST=None Review URL: http://codereview.chromium.org/2654001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48931 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: implement update notification.estade@chromium.org2010-06-032-1/+5
| | | | | | | | | BUG=45148 TEST=compile chrome with PRODUCT_VERSION manually set to something higher than the current version (e.g. 7.0.0.0), and manually set the upgrade detector time to something short (like 10 seconds). Launch chrome and wait a short time for the update notification to appear. The update notification should pulse every few seconds, and should stop pulsing when the user opens the wrench menu. The about menu item should launch a dialog that allows the user to restart chrome, restoring the current session. Review URL: http://codereview.chromium.org/2365003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48795 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. small cleanups I ran into while working on other changes.pkasting@chromium.org2010-06-021-1/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2486004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48730 0039d316-1c4b-4281-b951-d872f2087c98
* Strip the trailing slash from URLs like "http://google.com/". This ↵pkasting@chromium.org2010-06-021-3/+3
| | | | | | | | | | | | especially helps when the scheme has also been stripped, as it makes the hostname look less unbalanced. We're careful to avoid stripping the slash when doing so would confuse the omnibox. This also moves to more aggressive stripping and/or unescaping in several places. In general, it seems like we should be as aggressive as is feasible. BUG=43587 TEST=Visit google.com. There should be no slash in the address bar. Review URL: http://codereview.chromium.org/2389002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48691 0039d316-1c4b-4281-b951-d872f2087c98
* Implement most of the ridealong fixes/cleanups I suggested during review for ↵pkasting@chromium.org2010-06-011-1/+1
| | | | | | | | | | enabling warn-on-signed-versus-unsigned-equality-comparisions on Windows. BUG=none TEST=none Review URL: http://codereview.chromium.org/2395001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48666 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Add FRIEND_TEST_ALL_PREFIXES, a FRIEND_TEST replacementphajdan.jr@chromium.org2010-06-011-2/+3
| | | | | | | | | | | that works with all test prefixes (DISABLED, FLAKY, FAILS). TEST=none BUG=44549 Review URL: http://codereview.chromium.org/2439001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48634 0039d316-1c4b-4281-b951-d872f2087c98
* Added warning if GLX version is less than 1.3. Pbuffers need GLX 1.3 and the ↵apatrick@chromium.org2010-05-281-0/+10
| | | | | | | | | | | pixmap fallback for 1.2 does not work on all systems. TEST=try BUG=none Review URL: http://codereview.chromium.org/2382002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48538 0039d316-1c4b-4281-b951-d872f2087c98
* Get the GPU process to create an additional window for the GL context in ordervangelis@chromium.org2010-05-281-7/+65
| | | | | | | | | to get window resizing to work. The new content window is a sibling of the hosting window but its position is set such that it renders on top of the host. BUG=44518 Review URL: http://codereview.chromium.org/2102009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48521 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will make mbelshe@chromium.org2010-05-272-8/+7
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48395 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Another dependency the bbot missed!!!"rafaelw@chromium.org2010-05-262-7/+8
| | | | | | | | | | | | | | | | | | This reverts commit 161f7fd3bdd425167af9fe26fdc5373a2ff44c98. Revert "Missed a file as part of checkin for r48186" This reverts commit cff86beba5938209393a6c3bccced62a7f3ff36b. Revert "Enable warning 4389 as an error on windows builds. This will make" This reverts commit c78936bcfc65b98edf288191d927a495b0364621. TBR=mbelshe Review URL: http://codereview.chromium.org/2253001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48238 0039d316-1c4b-4281-b951-d872f2087c98
* Enable warning 4389 as an error on windows builds. This will makembelshe@chromium.org2010-05-252-8/+7
| | | | | | | | | | | | windows builds more similar to linux/mac, which already treat signed/ unsigned equality comparisons as warnings (and hence errors). BUG=44471 TEST=none Review URL: http://codereview.chromium.org/2081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48186 0039d316-1c4b-4281-b951-d872f2087c98
* Changed DLOG to LOG in gl_context_linux.cc to get informative errorkbr@google.com2010-05-241-19/+19
| | | | | | | | | | | messages even in release builds when WebGL initialization fails. BUG=44226 TEST=none Review URL: http://codereview.chromium.org/2110012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48045 0039d316-1c4b-4281-b951-d872f2087c98
* Don't populate WebDropData with file URLs when dragging files.dcheng@chromium.org2010-05-213-48/+59
| | | | | | | | | | | This is the Windows patch. There will be separate patches for Mac and Linux. BUG=42685 TEST=none Review URL: http://codereview.chromium.org/2126010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47870 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-203-51/+96
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* A crasher would sometimes happen when opening a selet file dialogjcivelli@chromium.org2010-05-192-0/+13
| | | | | | | | | | | | | | | | | | | (such as when loading an unpacled extension). This is because we would reinterpret cast the user data of the HWND to a WidgetWin, and in that case the Windows dialog has a user-data that we did not set. This CL checks that the HWND is at least a WindowImpl before attempting to retrieve the WidgetWin, ensuring we won't mess with windows we did not create directly. BUG=44312 TEST=Open the extension page. Move the focus by pressing TAB to the "Load unpacked extension..." button. Press ENTER many times quickly so it opens/closes the "Select dir" dialog. It should not crash. Review URL: http://codereview.chromium.org/2124009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47672 0039d316-1c4b-4281-b951-d872f2087c98
* Pull latest ppapi for initial testing support, implement checks so the tests ↵brettw@chromium.org2010-05-184-5/+18
| | | | | | | | | | | | pass in Chrome. Mostly, this involves better error checking. The most substantial change is that I made TransportDIB able to return NULL on failure to make a PlatformCanvas, which we run into when makeing too large of a canvas from a plugin. I checked all the callers of this function to make sure they all handled the problem (many already did). TEST=pulls Pepper test BUG=-none Review URL: http://codereview.chromium.org/2101004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47526 0039d316-1c4b-4281-b951-d872f2087c98
* linux: fallback to GLX Pixmaps when pbuffers aren't availablepiman@chromium.org2010-05-181-3/+159
| | | | | | Review URL: http://codereview.chromium.org/2129007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47484 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Null terminate text/html data we send to the clipboard. Change ↵thestig@chromium.org2010-05-174-26/+35
| | | | | | | | | | WriteHyperlink to take string16 anchor text. BUG=42624 TEST=none Review URL: http://codereview.chromium.org/2036013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47432 0039d316-1c4b-4281-b951-d872f2087c98
* cleaner grd files: use os.find('bsd') instead of listing all the versionpvalchev@google.com2010-05-141-1/+1
| | | | | | | | of freebsd, openbsd and possibly netbsd in the future via sprewell Review URL: http://codereview.chromium.org/2099003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47313 0039d316-1c4b-4281-b951-d872f2087c98
* Commiting http://codereview.chromium.org/2017007/show on behalf of ↵zelidrag@chromium.org2010-05-141-1/+1
| | | | | | | | | | | | | | | | | | | | rkc@chromium.org. This change hooks issue report dialog with Google Feedback backend for ChromeOS. The dialog is going to be used only for Chrome OS at the moment, the previous mechanism is kept intact for other operating systems. Image and System Info reporting is disabled at the moment; for image, we need feedback to get their changes in production, for reporting, the system scripts need to be added (basic Chrome and OS version info is being sent with the report) BUG=chromium-os:2761 TEST=none, work in progress TBR=zelidrag Review URL: http://codereview.chromium.org/2068004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47244 0039d316-1c4b-4281-b951-d872f2087c98
* Clear IOSurface to transparent, not white, so that transparent CA plugins ↵stuartmorgan@chromium.org2010-05-132-2/+2
| | | | | | | | | | | work correctly BUG=none TEST=Transparent CA plugins shouldn't have an opaque white background. Review URL: http://codereview.chromium.org/1732020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47221 0039d316-1c4b-4281-b951-d872f2087c98
* Move non-linux specific code from base/linux_util to app/gtk_utilpvalchev@google.com2010-05-134-4/+31
| | | | | | | | from sprewell Review URL: http://codereview.chromium.org/2058004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47201 0039d316-1c4b-4281-b951-d872f2087c98
* Only use IDC_ values for command ids in the render view context menu.estade@chromium.org2010-05-132-14/+0
| | | | | | | | | BUG=43816 TEST=none Review URL: http://codereview.chromium.org/1981014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47187 0039d316-1c4b-4281-b951-d872f2087c98
* Re-organize RenderViewContextMenu to the use cross-platform MenuModel class.estade@chromium.org2010-05-112-26/+76
| | | | | | | | | | | | | | | | | | Benefits: - less code - more straightforward code - more shared code unresolved issues: - RenderViewContextMenu{Gtk,Mac,Views} should not be a subclass of RenderViewContextMenu - On Linux, IMEs are added in the wrong place (not near the other editable stuff) BUG=31365 TEST=manual + trybots Review URL: http://codereview.chromium.org/2017001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46987 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of MetaTableHelper class and make use of the app/sql API in the ↵stuartmorgan@chromium.org2010-05-112-2/+35
| | | | | | | | | | | | | LoginDatabase. BUG=None TEST=compiles Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1700017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46929 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 07:13:30 +0000