summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Workaround Skia and Pango measuring font heights differently by asking Pangobrettw@chromium.org2009-09-021-3/+24
| | | | | | | | | | | | | | | | | | for the height that we'll report in the gfx::Font. This seems wrong, but at least things will look reasonable until we find a better solution. This changes the existing height computation code to use ceiling. Even though this is no longer used, it is good to have the correct code for the height computation here so that if we find a better solution, it will be run properly. This also gives more room for the clock in the status area view because the height is now more and we want it to be aligned properly. BUG=none TEST=none Review URL: http://codereview.chromium.org/183044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25131 0039d316-1c4b-4281-b951-d872f2087c98
* The FocusManager stores/restores focus when the top window becomes ↵jcampan@chromium.org2009-09-011-3/+3
| | | | | | | | | | | | inactive/active. BUG=None TEST=Run the focus manager unit-tests. Review URL: http://codereview.chromium.org/164448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
* Parameterize the Google Update appid at build time instead of hard coding it ↵robertshield@chromium.org2009-09-011-1/+46
| | | | | | | | in the source. Review URL: http://codereview.chromium.org/178011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25072 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the toolbar star button a drag source.estade@chromium.org2009-09-012-1/+47
| | | | | | | | | | Also refactor URI list/named url packing code. BUG=19008 Review URL: http://codereview.chromium.org/175036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-014-27/+36
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Drop in new translations.laforge@chromium.org2009-08-3149-4/+54
| | | | | | | TBR=mal@chromium.org Review URL: http://codereview.chromium.org/179050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24951 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of the title-centering code in TabRendererGtk. DrawStringInt ↵jhawkins@chromium.org2009-08-311-8/+1
| | | | | | | | | | centers the text for us already. This change also removes a hack that modified the clipping rect unnecessarily. BUG=20401,20610 TEST=none Review URL: http://codereview.chromium.org/179037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24875 0039d316-1c4b-4281-b951-d872f2087c98
* Some code style cleanup under src/app.maruel@chromium.org2009-08-2911-19/+19
| | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/173260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24859 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for initiating drags from bookmark menus.sky@chromium.org2009-08-283-80/+104
| | | | | | | | | BUG=none TEST=make sure bookmark menus work on Windows. Review URL: http://codereview.chromium.org/176006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24801 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-284-19/+2
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-284-2/+19
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the bounds of the clip region for tab title text.jhawkins@chromium.org2009-08-261-5/+10
| | | | | | | | BUG=19741 TEST=Open many tabs. The ellipses should not be rendered if the tab is not large enough. Review URL: http://codereview.chromium.org/174582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24560 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing bookmark menus.sky@chromium.org2009-08-263-0/+2
| | | | | | | | | | | | | The build breakage was the result of a bad ifdef in MenuController, specifically around the OnKeyDown method. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts menu patch.sky@chromium.org2009-08-263-2/+0
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24509 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids the use of ToWStringHack in a few places.evan@chromium.org2009-08-261-2/+2
| | | | | | | | | | BUG=None TEST=run app_unittests.exe, browser_tests.exe and selenium_tests.exe Review URL: http://codereview.chromium.org/173418 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24504 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark menu working on linux. There are just a handful ofsky@chromium.org2009-08-263-0/+2
| | | | | | | | | | | | NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining issue). I'll tackle the remaining issues separately. BUG=none TEST=make sure bookmark menus work well on windows still. Review URL: http://codereview.chromium.org/173431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24501 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper to resource bundle to get an NSImage back.thomasvl@chromium.org2009-08-262-0/+23
| | | | | | | | | | skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay the framework include path so someone can include the header without errors. BUG=none TEST=none Review URL: http://codereview.chromium.org/173363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24453 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Properly read utf-8 text from drags.estade@chromium.org2009-08-251-1/+1
| | | | | | | | BUG=19365 Review URL: http://codereview.chromium.org/174431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24328 0039d316-1c4b-4281-b951-d872f2087c98
* Fall back to the chrome-themed default favicon if the gtk theme fails to ↵estade@chromium.org2009-08-251-0/+5
| | | | | | | | | | | produce one. BUG=19994 Review URL: http://codereview.chromium.org/174267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24191 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Clip the cairo context to the extents provided to the DrawStringInt ↵jhawkins@chromium.org2009-08-241-0/+7
| | | | | | | | | | function. This fixes an issue when rendering the tab title where the ellipses are rendered no matter how small the tab is sized. This change also fixes an issue where we were using the default font to determine whether to show the tooltip. BUG=19741 TEST=Open many tabs. See that the ellipses should disappear when there's no room left in the tab to display them. Review URL: http://codereview.chromium.org/173300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24149 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk languages options page part 1: accept-languages configuration.mattm@chromium.org2009-08-192-0/+157
| | | | | | | | | | | Move accept_language_list to l10n_util, use it for LanguagesPageGtk. BUG=13524 TEST=You can view, reorder, remove and add accept-languages. Review URL: http://codereview.chromium.org/174043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23695 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Path::CreateGdkRegion return NULL for empty paths. Without thissky@chromium.org2009-08-192-0/+8
| | | | | | | | | | | gdk_region_polygon asserts. And adds the null check in WindowGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/164441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23691 0039d316-1c4b-4281-b951-d872f2087c98
* Moves GtkDndUtil into app.sky@chromium.org2009-08-183-0/+229
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23627 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'icu::' namespace explicitly throughout Chrome tree instead of relying ↵jshin@chromium.org2009-08-188-33/+35
| | | | | | | | | | | | | | | | | | | on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Review URL: http://codereview.chromium.org/171012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include.mattm@chromium.org2009-08-181-0/+2
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/171092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23604 0039d316-1c4b-4281-b951-d872f2087c98
* Factor out views::Combobox::Model so that it can be used cross-platform.mattm@chromium.org2009-08-182-0/+21
| | | | | | | | | | This removes the Combobox* source arg from the Model methods, which wasn't really used by anything. BUG=none TEST=none Review URL: http://codereview.chromium.org/165514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23603 0039d316-1c4b-4281-b951-d872f2087c98
* A canvas_paint for OS X.thakis@chromium.org2009-08-172-3/+1
| | | | | | | | | | | | | | | | | | | Makes it possible to use skia to paint something into a bitmap and then blit that bitmap to screen. I need this so that I can call download_util::PaintDownloadProgress(), which needs an SkCanvas. To be used like this: { gfx::CanvasPaint canvas(myRect); canvas.set_composite_alpha(true); download_util::PaintDownloadprogres(&canvas, ...); } BUG=18902 TEST=none Review URL: http://codereview.chromium.org/172046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23551 0039d316-1c4b-4281-b951-d872f2087c98
* Show favicon in panel title, highlight focused panel, fix breakagedavemoore@chromium.org2009-08-131-50/+39
| | | | | | | recent search box changes Review URL: http://codereview.chromium.org/164425 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23395 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-128-208/+813
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Move the menu bar l10n into the xib file.thomasvl@chromium.org2009-08-122-9/+13
| | | | | | | | | | | | Localize the menu bar titles. Have the browser platform delegate startup the resource bundle system so we can fetch localization data. Make l10n_util::GetApplicationLocale return what cocoa says for the language so we match what the UI is using. TEST=everything still works. BUG=17380 Review URL: http://codereview.chromium.org/164413 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23215 0039d316-1c4b-4281-b951-d872f2087c98
* Allow theming of colors for the Mac.avi@chromium.org2009-08-111-1/+7
| | | | | | | | | BUG=http://crbug.com/18438 TEST=none Review URL: http://codereview.chromium.org/162010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23023 0039d316-1c4b-4281-b951-d872f2087c98
* Use system default favicon in tab strip when using GTK theme.estade@chromium.org2009-08-102-0/+10
| | | | | | Review URL: http://codereview.chromium.org/164266 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22947 0039d316-1c4b-4281-b951-d872f2087c98
* Provides implementation of DragDropTypes for GTK.sky@chromium.org2009-08-094-13/+52
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22882 0039d316-1c4b-4281-b951-d872f2087c98
* Check in translations for app strings.mal@chromium.org2009-08-0850-51/+2253
| | | | | | | | | | | In addition to the xtbs, I've modified app_strings.grd to uncomment the xtb bundles and use the correct path (remove 'resources/'). TEST= None BUG= None Review URL: http://codereview.chromium.org/164222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22859 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Replace window-management buttons with new images.derat@chromium.org2009-08-0715-0/+0
| | | | | | | | | (Attempting to find a halfway point between Chrome's look and Ubuntu's Human theme's.) Review URL: http://codereview.chromium.org/165104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22773 0039d316-1c4b-4281-b951-d872f2087c98
* Move some Mac l10n helpers out into app/l10n so they are closer to the ↵thomasvl@chromium.org2009-08-075-0/+231
| | | | | | | | | | | | | generic ones. Complete the apis points so the ones folks might need are all there already. Switch the code using the old calls over to the new helpers. TEST=no l10n stuff broke BUG=none Review URL: http://codereview.chromium.org/165132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22753 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make gfx::Canvas honor GTK font settings.derat@chromium.org2009-08-061-0/+76
| | | | | | | | | | | | Reverts r22593, which was itself a revert of r22555. Per nsylvain, it looks like the memory_test failures weren't helped by rolling back this change. TBR=nsylvain Review URL: http://codereview.chromium.org/165059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22625 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r22555, "Linux: make gfx::Canvas honor GTK font settings."derat@chromium.org2009-08-061-76/+0
| | | | | | | | | Per nsylvain, this appears to be causing problems in memory_test in Release mode. Review URL: http://codereview.chromium.org/165036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22593 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: make gfx::Canvas honor GTK font settings.derat@chromium.org2009-08-051-0/+76
| | | | | | | | | BUG=18038 TESTED=restarted chrome a bunch while mucking around with gnome-appearance-settings Review URL: http://codereview.chromium.org/164017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22555 0039d316-1c4b-4281-b951-d872f2087c98
* Make the DOMUIThemeSource load and pass through a PNG, rather than relying ↵glen@chromium.org2009-08-051-0/+6
| | | | | | | | | | | on decode/encode. BUG=18427 TEST=Install a giant theme, load the NNTP, verify that you can type in the omnibox without delay while the page is loading. Review URL: http://codereview.chromium.org/159891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22457 0039d316-1c4b-4281-b951-d872f2087c98
* linux: yet more polish for the new toolbar graphicsevan@chromium.org2009-08-041-0/+2
| | | | | | Review URL: http://codereview.chromium.org/159885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22444 0039d316-1c4b-4281-b951-d872f2087c98
* linux: use linux-specific window control graphics from glenevan@chromium.org2009-08-0417-19/+33
| | | | | | | | BUG=15952,18385 Review URL: http://codereview.chromium.org/159859 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22391 0039d316-1c4b-4281-b951-d872f2087c98
* linux: visual refresh of the close boxevan@chromium.org2009-08-032-0/+4
| | | | | | | | BUG=15952 Review URL: http://codereview.chromium.org/159824 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22335 0039d316-1c4b-4281-b951-d872f2087c98
* Remove *.vsprops files that are no longer referenced (or only havesgk@google.com2009-07-281-8/+0
| | | | | | | | | references to each other) anywhere in the Chromium code base. BUG=none TEST=rebuild Review URL: http://codereview.chromium.org/159523 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21873 0039d316-1c4b-4281-b951-d872f2087c98
* Add clean-up code to SetAppIdForWindow().hbono@chromium.org2009-07-281-4/+8
| | | | | | | | | | | | | This is a follow-up change for r21596. It seems this change forgot calling pps->Release() and PropVariantClear(&pv). (InitPropVariantFromString() calls SHStrDupW() to create a copy of its input string, so we have to call PropVariantClear() and delete it.) To avoid an object leak and a memory leak, this change uses ScopedComPtr<IPropertyStore> to call Release() in its destructor and call PropVariantClear() to clean-up PROPVARIANT. (My JumpList class uses a class which encapsulates PROPVARIANT. We should move the class to win_util?) BUG=none TEST=none (Run Chromium on purify running on Windows 7.) Review URL: http://codereview.chromium.org/160150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21830 0039d316-1c4b-4281-b951-d872f2087c98
* Update an inaccurate comment.pkasting@chromium.org2009-07-281-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/159357 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21760 0039d316-1c4b-4281-b951-d872f2087c98
* Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to ↵brg@chromium.com2009-07-252-0/+59
| | | | | | | | | | set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group. Bug=7028 Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly) Review URL: http://codereview.chromium.org/159336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
* Put tests that depend on the application language pref into antc@google.com2009-07-221-21/+26
| | | | | | | | | TBR=jshin Review URL: http://codereview.chromium.org/155933 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21306 0039d316-1c4b-4281-b951-d872f2087c98
* disable L10nUtilTest.GetAppLocale while I debug the linxu failuretc@google.com2009-07-221-1/+1
| | | | | | | | | TBR=estade Review URL: http://codereview.chromium.org/155932 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21301 0039d316-1c4b-4281-b951-d872f2087c98
* Only check --lang and the app language pref on Windows. Theytc@google.com2009-07-221-0/+6
| | | | | | | | | | | | | | | | don't make sense on Linux/Mac so disable them. I think we don't want to have a app language option on Linux since the standard way to do this is to use LANG or LC_ALL. Update the locale ui test to set LC_ALL on Linux. BUG=15359 Review URL: http://codereview.chromium.org/155819 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21295 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 02:03:57 +0000