summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* FBTF: Moves code to the headers.erg@google.com2010-09-288-2/+25
| | | | | | | | | | | | | One of the big things is starting to move/declare ctors/dtors that derive from RefCounted<> to/in the implementation file. (Saves 4 megabytes from libglue.a alone. 1 meg off libbrowser.a. Hundred of kilobyte savings in a large number of .a files; only libmedia.a grew and it's only 100k.) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3452030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60863 0039d316-1c4b-4281-b951-d872f2087c98
* app/sql/connection hygiene enforcement.shess@chromium.org2010-09-282-9/+67
| | | | | | | | | | | | | For awhile we had an error where an invalid page_size was being passed in, and SQLite silently ignored it. No more! Fix cache_size logging line. Pull the exclusive locking up to fail more obviously in case someone else has the exclusive lock. Also, I don't think our code is likely handling the SQLITE_BUSY case correctly. Added some initial code to execute some sql with a timeout. BUG=56559 TEST=unit tests Review URL: http://codereview.chromium.org/3413028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60799 0039d316-1c4b-4281-b951-d872f2087c98
* Made droparrow (currently used at new user pod at login screen) more ↵dilmah@chromium.org2010-09-271-0/+0
| | | | | | | | | | | visually appealing. Made it smaller and color synced with specification #999999 BUG=http://crosbug.com/6568 TEST=Manual git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60637 0039d316-1c4b-4281-b951-d872f2087c98
* Visually polish language selector for new user pod.dilmah@chromium.org2010-09-241-0/+0
| | | | | | | | BUG=http://crosbug.com/5749, http://crosbug.com/6568 TEST=Manual Review URL: http://codereview.chromium.org/3473014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60478 0039d316-1c4b-4281-b951-d872f2087c98
* base: Finish moving the SplitString functions from string_util.h to ↵tfarina@chromium.org2010-09-242-0/+2
| | | | | | | | | | | string_split.h BUG=None TEST=trybos Review URL: http://codereview.chromium.org/3447008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60422 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move virtual methods to implementation files.erg@google.com2010-09-233-17/+28
| | | | | | | | | | | Remove logging.h and other headers where possible. BUG=none TEST=none Review URL: http://codereview.chromium.org/3461019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60369 0039d316-1c4b-4281-b951-d872f2087c98
* Default IDR_MENU_DROPARROW is unsuitable for us because it is too opaque.dilmah@chromium.org2010-09-222-0/+1
| | | | | | | | | | Added IDR_MENU_DROPARROW_SHARP with more transparent background. BUG=http://crosbug.com/6568 TEST=Manual Review URL: http://codereview.chromium.org/3479002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60162 0039d316-1c4b-4281-b951-d872f2087c98
* Track down errno for SQLITE_IOERR_WRITE is happening.shess@chromium.org2010-09-213-2/+18
| | | | | | | | | | | | | | | | Adds a log line to try to track down an SQLite error happening on the waterfall. Should only be emitted in case of a bad thing happening, like file-descriptors closing out from under us, so I can't think of why this would ever be hit for real. BUG=56427 TEST=no effect Attempt to test extended error codes. Fail. Review URL: http://codereview.chromium.org/3433016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60125 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of clang warnings/errors.thakis@chromium.org2010-09-211-0/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60109 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] fix wraparound error in clipboard.estade@chromium.org2010-09-213-1/+22
| | | | | | | | | | | 0U - 1 = pain BUG=56298 TEST=see bug Review URL: http://codereview.chromium.org/3394011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60079 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed the race described in bug 54400 by changing a LOG(FATAL) to a ↵apatrick@chromium.org2010-09-201-10/+37
| | | | | | | | | | | | | LOG(ERROR). Queried the X server to make the error messages in the error handler more descriptive. When a MakeCurrent fails in the GPU process, the associated rendering is informed that the context is lost. TEST=Run "chrome --enable-accelerated-compositing". Open a few tabs with "http://webkit.org/blog-files/3d-transforms/poster-circle.html". Close one of the tabs. Look for X error info logged on the console (from gpu_main.cc). Remaining tab should still be animated (the fix prevents gpu process from being terminated). This is a race condition, so there may not be an error logged the first time. A few trials should trip the error. BUG=54400 Landing on behalf of baker@ git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59980 0039d316-1c4b-4281-b951-d872f2087c98
* Added lots of logging to the GPU code.apatrick@chromium.org2010-09-209-34/+81
| | | | | | | | | | | This should help us diagnose initialization failures. TEST=try BUG=none Review URL: http://codereview.chromium.org/3380010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59970 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: The wrench menu should remain open after clicking +/-.erg@google.com2010-09-202-1/+28
| | | | | | | | | | | | | This changes the model so there's a property about whether a button should dismiss the menu, modifies the GtkCustomMenu[Item] implementation to obey it, and modifies the BrowserToolbar to update the menu on zoom change. BUG=48240 TEST=matches windows behaviour Review URL: http://codereview.chromium.org/3391009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59963 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extended error codes for SQLite.shess@chromium.org2010-09-182-0/+11
| | | | | | | | | | | | This will only apply to app/sql Connection and Statement objects for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/3467001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59897 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Fix paragraph directionality for first run dialog in Hebrew.estade@chromium.org2010-09-161-5/+22
| | | | | | | | | BUG=54898 TEST= Review URL: http://codereview.chromium.org/3368011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59664 0039d316-1c4b-4281-b951-d872f2087c98
* Make our X11 error handler more descriptivejamesr@chromium.org2010-09-162-4/+8
| | | | | | | | | BUG=none TEST=trigger X11 error, look at the error dialog Review URL: http://codereview.chromium.org/3425006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59595 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 52446 - Supports High DPI mode.hbono@google.com2010-09-142-22/+0
| | | | | | | | | | | | | | | This change caused too many layout problems; such as Issue 50100 and 51562. I would like to revert this change now and send another change when I fix them. When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later. BUG=1715,36939 TEST=Run chrome.exe on the screen resolution higher than 120 DPI. Review URL: http://codereview.chromium.org/2867031 TBR=hbono@chromium.org Review URL: http://codereview.chromium.org/3435002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59353 0039d316-1c4b-4281-b951-d872f2087c98
* This is a second attempt of http://codereview.chromium.org/3175038davemoore@chromium.org2010-09-133-88/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | It failed the Vista Perf UI tests. This is because those tests close the browser upon an error. And they always get an error when the session is closed in the middle of the test. The new changes are in chrome/browser/automation/testing_automation_provider.cc BUG=50006 TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. BUG= TEST= Review URL: http://codereview.chromium.org/3364019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59269 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 59147 - Allow overriding of X error functionsdavemoore@chromium.org2010-09-103-120/+88
| | | | | | | | | | | | | | | | | | | | | | | | | | BUG=50006 (and various other reports) TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully. Review URL: http://codereview.chromium.org/3175038 TBR=davemoore@chromium.org Review URL: http://codereview.chromium.org/3332019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59175 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Convert net::StripWWW to string16 and fix up the callsites.jhawkins@chromium.org2010-09-101-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3360023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59159 0039d316-1c4b-4281-b951-d872f2087c98
* Allow overriding of X error functionsdavemoore@chromium.org2010-09-103-88/+120
| | | | | | | | | | | | | | | | | | | | | | | BUG=50006 (and various other reports) TEST=Run chrome under nested window manager using Xephyr (see http://code.google.com/p/chromium/wiki/LayoutTestsLinux) use --enable-logging=stderr --log-level=0 kill xephyr examine log. You should see X IO Error detected followed (not necessarily immediately) by successfully saved /tmp/tx/Default/Preferences successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Local State successfully saved /tmp/tx/Default/Preferences along with no crash. There is a high ranking crash report on both linux and chromeos that happens whenever X sends an error to chrome. This change causes us to log and continue when we get a regular error from X. When we get an IO error, indicating X is gone, we attempt to shut down gracefully. Review URL: http://codereview.chromium.org/3175038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59147 0039d316-1c4b-4281-b951-d872f2087c98
* GPU process reports context lost when SwapBuffers fails.apatrick@chromium.org2010-09-109-34/+43
| | | | | | | | | | | This is to give the renderer or plugin process an opportunity to recover. TEST=try BUG=none Review URL: http://codereview.chromium.org/3305028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59115 0039d316-1c4b-4281-b951-d872f2087c98
* Loads GL shared libraries from module directories rather than exe directory.vangelis@chromium.org2010-09-103-13/+13
| | | | | | | | | | | This is because when chrome is installed, the shared libraries go in a different directory to the exe. TEST=try BUG=none Review URL: http://codereview.chromium.org/3351021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59036 0039d316-1c4b-4281-b951-d872f2087c98
* Add Farsi supportjshin@chromium.org2010-09-093-0/+11
| | | | | | | | | | | | | | | | | | | | | Add 'fa' entry to all the grd files. For *locale_settings*, create new xtb files for Farsi (copied from Arabic). Also, pulls in ICU @r=58904 (with Farsi data). locale_settings_fa.xtb has a lot of UI dimensions that may not work well in Farsi. We need LQA to take a look at them. terms_FOO.html is not yet available for Farsi as well as Amharic and Swahili. Tentatively, use terms_en.html. BUG=45505 TEST='chrome --lang=fa' on Windows should bring up Chrome in Farsi. 'LANGUAGE=fa chrome' should do the same on Linux. (on Ubuntu, 'language-pack-gnome-fa' and 'language-pack-fa' have be installed to get Chrome in Farsi with the UI mirrored). Review URL: http://codereview.chromium.org/3296013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58998 0039d316-1c4b-4281-b951-d872f2087c98
* Change UI font at startup time if necessary, based on the UI locale.satorux@chromium.org2010-09-093-21/+34
| | | | | | | | | | | | | | | | | | | | | | As of writing, ChromeDroidSans is used as the UI font (see /etc/gtk-2.0/gtkrc). This setting does not work well for Japanese users as Chinese glyphs are used for Kanji characters. For Japanese UI, we should use a Japanese font. Introduce IDS_UI_FONT_FAMILY_CROS to control the UI font based on the UI locale. For now, app_locale_settings_ja.xtb only contains a non-default value: IPAPGothic. Just for the record, I originally tried to use "DroidSans Japanese" but for some reason, this caused space characters (0x20) to be garbled in the wrench menu. Hence, IPAPGotchic is chosen for now. TEST=manually on the netbook, and ubuntu BUG=chromium-os:4038 Review URL: http://codereview.chromium.org/3275008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58913 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] change workaround for weird RTL label alignmentestade@chromium.org2010-09-072-0/+24
| | | | | | | | | | | | | | | When a GtkLabel has line wrapping and an integer size request, the text block is left aligned even in RTL locales. It will wrap at the left (which is correct) and be right justified (also correct) but is flush with the left of the widget allocation instead of the right of the widget allocation. seems not to occur when the size is controled via gtk_label_set_width_chars() instead of gtk_widget_set_size_request(). (also goes away when line wrapping is turned off) TODO: file a reduction upstream. BUG=52857 TEST=launch chrome in Hebrew and look at the under the hood tab of options. Checkbox labels should look correct Review URL: http://codereview.chromium.org/3355007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58758 0039d316-1c4b-4281-b951-d872f2087c98
* Added GPU stat for whether a GPU can report context lost.apatrick@chromium.org2010-09-072-1/+8
| | | | | | | | | | | | | | | On Windows it checks to see if the IDirect3D9 object supports Vista and later features (meaning it won't routinely report lost contexts). On Linux and Mac we can just check if its EGL versus some other GL that doesn't report lost contexts. I routed the stats to the renderer process so webkit code can query whether lost contexts are likely. I didn't wire up breakpad yet. TEST=try BUG=52318 Review URL: http://codereview.chromium.org/3149016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58755 0039d316-1c4b-4281-b951-d872f2087c98
* Clean missing files out of .gyp filesdhollowa@chromium.org2010-09-071-1/+2
| | | | | | | | | | | Removes a number of missing files from the .gyp files. BUG=none TEST=gclient runhooks; inspect the projects for missing files; verify with try bots. Review URL: http://codereview.chromium.org/3307006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58705 0039d316-1c4b-4281-b951-d872f2087c98
* Add 'fall_back_to_english' to 'messages' in app_locale_settings.grdjshin@chromium.org2010-09-0351-228/+8
| | | | | | | | | | | | | | | | That way, we can remove default entries in app_locale_settings_*.xtb files. This doesn't make any change in the build output. I realize this 'problem while reviewing http://codereview.chromium.org/3275008 In addition, I increased the minimum font size for Indic locales and Thai to 10 (Hindi and Arabic already have that set to 10. For other Indian languages and Thai, 5 is too small). BUG=NONE TEST=Build works fine on Windows. Review URL: http://codereview.chromium.org/3323003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58508 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-0318-11/+1976
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-0218-1976/+11
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0218-11/+1976
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-0118-1976/+11
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-0118-11/+1976
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* The "Update Chrome" menu item should appear in addition to the About menu.erg@google.com2010-08-314-1/+26
| | | | | | | | | | | It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation. BUG=46221 TEST=The upgrade item should now appear under instead of replacing the about command. Review URL: http://codereview.chromium.org/3143046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58040 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring FormatUrl() functions (and convert remaining users to the ↵viettrungluu@chromium.org2010-08-311-4/+6
| | | | | | | | | | | | | string16 verison). Still to do: Actually convert the code underlying FormatUrl(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3263005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57968 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move some heavy, repeatedly emitted symbols to implementation files.erg@google.com2010-08-302-3/+5
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3162047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57896 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring TreeModelNode::GetTitle() and rename GetTitleAsString16() ↵viettrungluu@chromium.org2010-08-303-18/+3
| | | | | | | | | | | to GetTitle(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
* Add xtb files for Farsi translations. mal@chromium.org2010-08-281-0/+50
| | | | | | | | | | R = jshin BUG = http://crbug.com/45505 TEST= None. These are just data files. Review URL: http://codereview.chromium.org/3104043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57776 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 7)thestig@chromium.org2010-08-273-5/+3
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3176026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57737 0039d316-1c4b-4281-b951-d872f2087c98
* Reapply menu model cleanups, with WrenchMenuModel being a SimpleMenuModel.erg@google.com2010-08-251-0/+15
| | | | | | | | | BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3184021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57384 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 14.viettrungluu@chromium.org2010-08-252-34/+39
| | | | | | | | | | | Convert TreeNodeWithValue's methods to string16. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3198014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57337 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix small leak in iosurface resizing code.thakis@chromium.org2010-08-251-2/+4
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3200011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57279 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate." ↵erg@google.com2010-08-241-14/+0
| | | | | | | | | | (r57119) TBR=rsesek Review URL: http://codereview.chromium.org/3163035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57128 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate.erg@google.com2010-08-231-0/+14
| | | | | | | | | | | This removes copy-pasted code in each platform implementation. BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3163023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57119 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 12.viettrungluu@chromium.org2010-08-221-3/+3
| | | | | | | | | | | | | | - This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16 instead of a wstring. - This entailed changing the base class, ComboboxModel, and shaving a herd of yaks. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3159031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
* Spelling correction: "nonexistant" -> "nonexistent".viettrungluu@chromium.org2010-08-223-8/+8
| | | | | | | | | BUG=none TEST=good spellers are slightly happier Review URL: http://codereview.chromium.org/3143037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 9.viettrungluu@chromium.org2010-08-223-5/+8
| | | | | | | | | | | | This actually converts TreeNodeModel::SetTitle(node, title); this is used by bookmarks. BUG=23581 TEST=builds nad passes tests Review URL: http://codereview.chromium.org/3111024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57007 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 7.viettrungluu@chromium.org2010-08-212-11/+7
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3140022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57000 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obviously unneeded forward declarations from headers under ↵viettrungluu@chromium.org2010-08-213-13/+1
| | | | | | | | | | | src/{app,base,net}. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3136025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 09:19:30 +0000