summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Initialize destinations variables before calling GL functionsgman@chromium.org2010-11-241-1/+2
| | | | | | | | | | | | because if the context is lost those variables will be uninitialized. TEST=ran chrome, conformance tests, unit tests and hand edited gles2_demo to test BUG=none Review URL: http://codereview.chromium.org/5305005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67293 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AdjustStringForLocaleDirection() to modify input parameter in place.jeremy@chromium.org2010-11-241-9/+7
| | | | | | | | | | | As described in the bug, the current behavior is confusing and bug-prone. BUG=47194 TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows. Review URL: http://codereview.chromium.org/5154009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67237 0039d316-1c4b-4281-b951-d872f2087c98
* [cros] Adjust default font sizes for new hand hinted fonts.nkostylev@chromium.org2010-11-221-4/+20
| | | | | | | | | BUG=chromium-os:8658 TEST=Manual. Review URL: http://codereview.chromium.org/5180002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66999 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2010-11-216-0/+232
| | | | | | | | | | | | | | | Converts usage of SetProp/GetProp to a map. Even after making sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 TEST=none TBR=cpu@chromium.org Review URL: http://codereview.chromium.org/5144005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66920 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 9)thestig@chromium.org2010-11-201-2/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5091005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66873 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 66784 - Converts usage of SetProp/GetProp to a map. Even after making ↵sky@chromium.org2010-11-196-235/+0
| | | | | | | | | | | | | | | | | sure we clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/5184009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66786 0039d316-1c4b-4281-b951-d872f2087c98
* Converts usage of SetProp/GetProp to a map. Even after making sure wesky@chromium.org2010-11-196-0/+235
| | | | | | | | | | | | clean up props we still leak in a handful of cases that are causing test grief. By and large our usage of properties is for inside the application, so that a map works fine. BUG=61528 44991 Review URL: http://codereview.chromium.org/5075003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66784 0039d316-1c4b-4281-b951-d872f2087c98
* Renames Chrome only GL extension functions to followgman@chromium.org2010-11-181-1/+1
| | | | | | | | | | | GL naming convention. TEST=none BUG=none Review URL: http://codereview.chromium.org/5210001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66695 0039d316-1c4b-4281-b951-d872f2087c98
* More animation cleanup.sky@chromium.org2010-11-1811-53/+91
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5154006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66683 0039d316-1c4b-4281-b951-d872f2087c98
* startup: rename chrome_dll_main to chrome_mainevan@chromium.org2010-11-181-1/+1
| | | | | | | | | | | | | | | Startup works like this: 1) platform-specific main, which calls 2) ChromeMain(), which calls 3) subprocess-specific main, like RendererMain() On Windows the middle step is kept in a DLL, but it's a framework on Mac and it's part of the original binary on Linux. This no-op change renames the file to match the function it does. Review URL: http://codereview.chromium.org/5183003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66660 0039d316-1c4b-4281-b951-d872f2087c98
* Pulls AnimationDelegate out into its own header.sky@chromium.org2010-11-177-25/+40
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5121004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66541 0039d316-1c4b-4281-b951-d872f2087c98
* Ups copyright to reflect when last changed.sky@chromium.org2010-11-171-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=erg@chromium.org Review URL: http://codereview.chromium.org/5108002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66384 0039d316-1c4b-4281-b951-d872f2087c98
* Ups the copyright of MenuModel.sky@chromium.org2010-11-171-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=erg@chromium.org Review URL: http://codereview.chromium.org/5152001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66383 0039d316-1c4b-4281-b951-d872f2087c98
* X11: Make the default X11 error handler non-fatal.thestig@chromium.org2010-11-171-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5066002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66355 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed stack overflow if wglGetExtensionsStringARB is not available.apatrick@chromium.org2010-11-161-1/+1
| | | | | | | | | TEST=try BUG=none Review URL: http://codereview.chromium.org/5087001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66318 0039d316-1c4b-4281-b951-d872f2087c98
* Added glResizeCHRM to resize the drawable associated with the command buffer.gman@chromium.org2010-11-161-0/+5
| | | | | | | | | | | | | | | | | This new command is used to pipe resize requests to the GPU process. It will allow is to synchronize the resize with the drawing. Specifically, if we resize at the wrong time, we will damage the backbuffer, causing visual artefacts (http://code.google.com/p/chromium/issues/detail?id=54430). The resize request gets sent to the GLContext. Each backend will implement it differently. At this point it's set as a NOP. -I will do an XResizeWindow on Linux. -Nat will do a resize on Windows. -Nico (or me?) will refactor the MacOSX code to use this path. There is one line webkit patch that's necessary to activate this code (removing an #ifdef). BUG=none TEST=none Review URL: http://codereview.chromium.org/4671003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66307 0039d316-1c4b-4281-b951-d872f2087c98
* Review comments for r66277thakis@chromium.org2010-11-161-2/+1
| | | | | | | | BUG=none TEST=none TBR=grt git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66278 0039d316-1c4b-4281-b951-d872f2087c98
* Fix clang buildthakis@chromium.org2010-11-161-0/+3
| | | | | | | | BUG=none TEST=none TBR=grt git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66277 0039d316-1c4b-4281-b951-d872f2087c98
* The UI language rather than the locale is now used to pick Chrome's language ↵grt@chromium.org2010-11-163-5/+67
| | | | | | | | | | | | | | | on Windows. (Also fixed some unrelated lint errors.) With this change, l10n_util::GetApplicationLocale first checks for an override of the "configured locale" (in base::i18n) containing the list of preferred Windows UI languages. The browser triggers an override early in startup before the ApplicationLocale is determined. In effect, the browser no longer uses ICU on Windows for language detection. (This locale override mechanism is borrowed from the OS X port.) Changes in Chrome Frame are largely a refactor, as some Win32 code in there has been moved into base/win. Also cleaned up language selection in installer_util so that the proper language is chosen for the EULA, installer messages, and shortcuts. In so doing, replaced hand-crafted lists of supported languages with either auto-generated lists (static consts) or logic so that the addition of translations in the future doesn't require code motion (that being said, there may be reason to update the alias and/or wildcard tables in language_selector.cc). In so doing, this change unlocks Amharic, Farsi, and Swahili translations for installer messages and shortcuts. BUG=39986,40496,26470 TEST=New MUI/Win32 calls are tested in base/win/i18n_unittest.cc. To test the overall functionality, uninstall Chrome, remove intl.app_locale user pref, switch to a supported display language (via the "Keyboards and Languages" tab of Win7's "Regional and Language" control panel, and install with { "distribution": { "require_eula": true } } in master_preferences (via -installerdata arg to setup.exe). If all goes well, both EULA and outer frame are in the same language as Windows. Also, from gwilson: "Install system-level Chrome in audit mode on a new machine, then go through the out-of-box-experience, select a language, and the in -product EULA (triggered by "require_eula" : true) and Chrome's UI should be in the language that the user selected." Review URL: http://codereview.chromium.org/4139010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66275 0039d316-1c4b-4281-b951-d872f2087c98
* Implement new task manager mocks on windows.atwilson@chromium.org2010-11-152-0/+7
| | | | | | | | | | | | | Added API to differentiate between background resources and normal foreground tabs, and added support for grouping processes containing background resources in a separate section of task manager. BUG=63140 TEST=bring up task manager on windows Review URL: http://codereview.chromium.org/4987001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66132 0039d316-1c4b-4281-b951-d872f2087c98
* Adding style notion to the TextButton.glotov@google.com2010-11-131-0/+0
| | | | | | | | | | | Welcome screen uses different style of buttons. BUG=chromium-os:8468 TEST=none Review URL: http://codereview.chromium.org/4402001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66061 0039d316-1c4b-4281-b951-d872f2087c98
* Prefer native library symbol lookup to the platform GetProcAddress.kbr@google.com2010-11-111-6/+6
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/4791002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65854 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ThumbnailGenerator on Windows.kkania@chromium.org2010-11-116-44/+123
| | | | | | | | | | | | | In the browser, duplicate the file mapping handle before sending to the renderer and map the TransportDIB before accessing the memory. In the renderer, do not map the file twice, which was happening when TransportDIB::Map and GetPlatformCanvas were both being called. BUG=none TEST=none Review URL: http://codereview.chromium.org/4569002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65775 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the instant suggested text autocomplete after 1.3 seconds. Theresky@chromium.org2010-11-113-5/+49
| | | | | | | | | | | | are a number of parts of this patch that need work, but it should be good enough for us to decide if we want to pursue it. BUG=none TEST=none Review URL: http://codereview.chromium.org/4385001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
* Add ActivatedAtWithDisposition to MenuModel.estade@chromium.org2010-11-112-0/+9
| | | | | | | | | | | Also, use it in MenuGtk, and implement it in BackForwardMenuModel. BUG=38452 TEST=manual Review URL: http://codereview.chromium.org/4780001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65739 0039d316-1c4b-4281-b951-d872f2087c98
* Change default xioerror to _exit() instead of crashdavemoore@chromium.org2010-11-101-2/+2
| | | | | | | | | BUG=57924 TEST=Run under Xephyr, bring up plugin, ensure that no crash happens. Review URL: http://codereview.chromium.org/4712004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65673 0039d316-1c4b-4281-b951-d872f2087c98
* Mac/gpu: Don't show uninitialized surfaces while resizing plugins / ↵thakis@chromium.org2010-11-052-0/+33
| | | | | | | | | | | composited tabs. BUG=53165 TEST=Go to http://webkit.org/blog/386/3d-transforms/. Resize window. Watch a youtube video click the "make bigger" button. No garbage should appear. There are still some funky artifacts at the top/right border during resizing caused by clamping the texture instead of filling with white, and sometimes (rarely) the tab flashes black/white but I'd like to tackle that in follow-up CLs. This is already much better than what's in the tree currently. Review URL: http://codereview.chromium.org/4101002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65220 0039d316-1c4b-4281-b951-d872f2087c98
* Add in changes I forgot in last previous CLgman@chromium.org2010-11-042-3/+1
| | | | | | | | | | | These are only comment changes. No code has changed. TEST=none BUG=none TBR=apatrick@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65105 0039d316-1c4b-4281-b951-d872f2087c98
* Add service side GL call logging to the DEBUGgman@chromium.org2010-11-046-35/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | build of Chrome. For now you need to call InitDebugGLBindings. It seems like it would be nice to add a flag or check an environment variable but it also seems strange to add a flag just for debugging. Then again I guess we have --gpu-startup-dialog. Also, to really make this work will require both an special ostream and adding a bunch more type info the generate_bindings.py so it can cast values appropriately. For example it would be nice if it cast GLenum to an object that printed the enum name. It would also be nice if it cast const GLubyte* and void* to appropriate things depending on usage so the stream can write the correct stuff. For now though it does show all the calls which is useful in and of itself. Any idea how to get base/logging.h working on mac? TEST=ran it in the opengl es 2.0 conformance tests. BUG=none Review URL: http://codereview.chromium.org/4464002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65096 0039d316-1c4b-4281-b951-d872f2087c98
* OSMesa SwapBuffers does not fail if the window handle is invalid on windows.apatrick@chromium.org2010-11-041-9/+18
| | | | | | | | | | | This is because the primary application of this class of GLContext is for testing and we do not want every GL related ui browser test to become flaky if there is a race condition between GL context destruction and window destruction. TEST=try BUG=none Review URL: http://codereview.chromium.org/4458001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65011 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed mismatched channel order in OSMesaViewGLContext.apatrick@chromium.org2010-11-031-5/+7
| | | | | | | | | | | Made failing SwapBuffers not an error. We have a race condition whereby a window can be closed while the GPU process is rendering. This could make ui and browser tests flaky. TEST=try, make sure color channels are not reversed BUG=none Review URL: http://codereview.chromium.org/4281003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64858 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt at fixing leaks from SetProp. Apparently there is a finitesky@chromium.org2010-11-013-0/+74
| | | | | | | | | | | | | | | | | | amount of memory reserved for properties and Windows doesn't always automatically free up the memory if the window is deleted without an explicit remove. For the time being I've made it easier to track SetProp leaks, but we may want to move to using something other than SetProp in the future that isn't as fragile. I didn't fix a couple of places that were trickier. I'm going to file separate bugs on them. BUG=44991 TEST=none Review URL: http://codereview.chromium.org/4195003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64619 0039d316-1c4b-4281-b951-d872f2087c98
* Use GLib to parse environment variables to determine the default locale.jshin@chromium.org2010-10-302-104/+83
| | | | | | | | | | | | | | | | | | | | | | Switch to using GLib, instead of having a Chromium specific implementation, for parsing environment variables for language preferences for all POSIX systems that use GTK+. If we have a non-GTK port in the future, we have to resurrect our custom code. This will guarantee that UI language selection in Chromium works just like for all other GTK+ applications, and simplify the code. While doing this, also do some cleaning-up of the language preferences code and add a test case to verify that the prioritization is done correctly. Original CL by Fredrik Roubert at http://codereview.chromium.org/2901004/show BUG=NONE TEST=app_unittest with "--gtest_filter=L10nUt*.*Loc*" passes. Review URL: http://codereview.chromium.org/4217004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64524 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-291-3/+3
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* Let every "accelerated IO surface swapped" message have an identifier of the ↵thakis@chromium.org2010-10-282-2/+16
| | | | | | | | | | | | | | | surface. Currently, this is only used to DCHECK a currently implicit invariant, but I want to use this to let every surface container only remember its last painted-to surface, and not its last created surface. No behavior change. BUG=53165 TEST=none Review URL: http://codereview.chromium.org/4142004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64317 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Get rid of app/gtk_util.h.jhawkins@chromium.org2010-10-284-158/+1
| | | | | | | | | | | | | * Most functions moved to chrome/browser/gtk/gtk_util.h because they're only used within chrome/browser. * BGRAToRGBA() is used within chrome/ and app/ so moved it to base/gtk_util.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/4170002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64295 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove stale TODOjeremy@chromium.org2010-10-281-5/+0
| | | | | | | | | | | The code in question is no longer needed since Skia has changed to remove the #define in question. BUG=None TEST=Compilation shouldn't break Review URL: http://codereview.chromium.org/4099004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64234 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ElideUrl to return a string16 instead of a wstring.tony@chromium.org2010-10-273-110/+109
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/4115003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64156 0039d316-1c4b-4281-b951-d872f2087c98
* ui_tests run with --use-gl=osmesa so they use the OSMesa software renderer ↵apatrick@chromium.org2010-10-272-4/+16
| | | | | | | | | | | | | for GL. This to ensure that ui_tests run consistently regardless of the GPU capabilities, or absense, of the box they run on. TEST=try BUG=none Review URL: http://codereview.chromium.org/4138003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64122 0039d316-1c4b-4281-b951-d872f2087c98
* Specify client version 2 when creating EGL contexts.apatrick@chromium.org2010-10-271-2/+6
| | | | | | | | | | | | | It was doing this already for SecondaryEGLContext but not for NativeViewEGLContext, which made it default to EGL version 1 on non-ANGLE EGL implementations. I also fixed ANGLE upstream in r468 so it fails to create a context unless version 2 is explicitly requested. TEST=try BUG=53823 Review URL: http://codereview.chromium.org/4089006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64119 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up SharedMemory implementation so that it is more equivalent on Windows ↵dmaclach@chromium.org2010-10-273-11/+3
| | | | | | | | | | | | | vs Posix and enforces exclusive creates. Clean up some naming to make it clearer what size you are getting by changing max_size to created_size. BUG=NONE TEST=BUILD Review URL: http://codereview.chromium.org/4034006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64097 0039d316-1c4b-4281-b951-d872f2087c98
* touchui: Directly process key and mouse events.rjkroege@google.com2010-10-263-0/+187
| | | | | | | | | | | | | | | | Capture the keyboard and mouse events directly from X, create a corresponding views::Event out of it, and send it to the associated RootView. Includes Chad's (wyck) function FindRootViewForGdkEvent (from #3704005) slightly modified (called FindRootViewForGdkWindow). BUG=None TEST=Click/Keypress events in a webpage should work correctly. Review URL: http://codereview.chromium.org/3801011 Patch from Sadrul Chowdhury <sadrul@chromium.org>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63916 0039d316-1c4b-4281-b951-d872f2087c98
* Move debug-related stuff from base to the base/debug directory and use thebrettw@chromium.org2010-10-261-2/+4
| | | | | | | | | | | | | | | | base::debug namespace. This splits apart debug_util into base/debugger and base/stack_trace There are still two functions in debug_util that I'm not sure what to do with. Since this uses the base::debug namespace, I removed the functions in debugger.h from the static class and just made them free functions in the namespace. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3945002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63859 0039d316-1c4b-4281-b951-d872f2087c98
* Expose bindings for glGetTexLevelParameter[fi]. These functions will be ↵senorblanco@chromium.org2010-10-222-0/+10
| | | | | | | | | | | needed by WebGraphicsContext3DDefaultImpl in WebKit. BUG=60314 TEST=none Review URL: http://codereview.chromium.org/3976003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63528 0039d316-1c4b-4281-b951-d872f2087c98
* Remove src/app's dependency on the WebKit api.tony@chromium.org2010-10-213-37/+3
| | | | | | | | | | src/app shouldn't depend on webkit in anyway. DEPS allows this because it allows paths pulled in by deps = {} (stuff pulled in by gclient). Add a new rule to explicitly disallow this. Review URL: http://codereview.chromium.org/3998004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63434 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gfx::ElideText from using wstrings to string16.tony@chromium.org2010-10-213-51/+63
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63433 0039d316-1c4b-4281-b951-d872f2087c98
* Move all ResourceBundle::GetNSImageNamed() calls to GetNativeImageNamed().rsesek@chromium.org2010-10-211-0/+3
| | | | | | | | | | | This is part of the first stage of cleaning up ResourceBundle's interface. BUG=58030 TEST=Compile and unit tests. Review URL: http://codereview.chromium.org/3806007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63367 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more deinlining.erg@google.com2010-10-202-4/+13
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63261 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 63232 - On Windows, create a new TransportDIB::Handle struct which ↵kkania@chromium.org2010-10-204-294/+83
| | | | | | | | | | | | | | | | | | | | | | | | | includes the file mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. Also, add a ScopedHandle and fix some handle leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/3834003 TBR=kkania@chromium.org Review URL: http://codereview.chromium.org/3943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63246 0039d316-1c4b-4281-b951-d872f2087c98
* On Windows, create a new TransportDIB::Handle struct which includes the filekkania@chromium.org2010-10-204-83/+294
| | | | | | | | | | | | | | | | | | | | mapping HANDLE and the source process ID. Duplicating the handle for the remote process is done in TransportDIB::Map, instead of in various #ifdefs scattered across the code. Also on windows, remove the struct for the TransportDIB::Id which contained both the sequence number and the HANDLE and replace it with just the sequence number. Fix ThumbnailGenerator by mapping the TransportDIB on Windows and adding a method to duplicate the file mapping handle before sending across the channel. Also, add a ScopedHandle and fix some handle leaks. BUG=none TEST=none Review URL: http://codereview.chromium.org/3834003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63232 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-14 12:28:35 +0000