summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Revert "Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate." ↵erg@google.com2010-08-241-14/+0
| | | | | | | | | | (r57119) TBR=rsesek Review URL: http://codereview.chromium.org/3163035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57128 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up the WrenchMenuModel so that it uses SimpleMenu::Delegate.erg@google.com2010-08-231-0/+14
| | | | | | | | | | | This removes copy-pasted code in each platform implementation. BUG=47320 TEST=compiles Review URL: http://codereview.chromium.org/3163023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57119 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 12.viettrungluu@chromium.org2010-08-221-3/+3
| | | | | | | | | | | | | | - This changes RecentlyUsedFoldersComboModel::GetItemAt() to return a string16 instead of a wstring. - This entailed changing the base class, ComboboxModel, and shaving a herd of yaks. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3159031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57021 0039d316-1c4b-4281-b951-d872f2087c98
* Spelling correction: "nonexistant" -> "nonexistent".viettrungluu@chromium.org2010-08-223-8/+8
| | | | | | | | | BUG=none TEST=good spellers are slightly happier Review URL: http://codereview.chromium.org/3143037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57020 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 9.viettrungluu@chromium.org2010-08-223-5/+8
| | | | | | | | | | | | This actually converts TreeNodeModel::SetTitle(node, title); this is used by bookmarks. BUG=23581 TEST=builds nad passes tests Review URL: http://codereview.chromium.org/3111024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57007 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 7.viettrungluu@chromium.org2010-08-212-11/+7
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3140022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57000 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obviously unneeded forward declarations from headers under ↵viettrungluu@chromium.org2010-08-213-13/+1
| | | | | | | | | | | src/{app,base,net}. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3136025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56995 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 6)thestig@chromium.org2010-08-191-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DEPS after moving SQLite code.phajdan.jr@chromium.org2010-08-191-1/+1
| | | | | | | | | | TBR=evan BUG=22208 Review URL: http://codereview.chromium.org/3159027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56625 0039d316-1c4b-4281-b951-d872f2087c98
* Move bundled copy of sqlite one level deeper to better separate itphajdan.jr@chromium.org2010-08-185-5/+5
| | | | | | | | | | | | | from our patches, READMEs, etc. Also, add a shim header so we can use it for building with system sqlite. TEST=compile BUG=22208 Review URL: http://codereview.chromium.org/3108030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56619 0039d316-1c4b-4281-b951-d872f2087c98
* Convert GetDisplayStringInLTRDirectionality from wstring to string16.tony@chromium.org2010-08-182-8/+15
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3108027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56535 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land part of r55416, minus actually moving the test_suite.h contents to a ↵brettw@chromium.org2010-08-171-1/+1
| | | | | | | | | | | | | | | | | | | | | | | .cc file. Cleanup in base. This moves the implementation (and a bunch of header file dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56399 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land just the project file changes from r55416. This makes projects that usebrettw@chromium.org2010-08-151-0/+1
| | | | | | | | | base test files dependent on test_support_base. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56172 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded #includes of <string> and <vector> from src/app and ↵viettrungluu@chromium.org2010-08-146-11/+3
| | | | | | | | | | | src/base. BUG=none TEST=builds Review URL: http://codereview.chromium.org/3173020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56144 0039d316-1c4b-4281-b951-d872f2087c98
* Rework gfx::Font by moving platform-specific code into inner classes.ben@chromium.org2010-08-135-7/+12
| | | | | | | | | | | | | gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage. gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk). BUG=none TEST=existing unittests Review URL: http://codereview.chromium.org/3083022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
* Removed reference to glew from comment.apatrick@chromium.org2010-08-121-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/3175007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55925 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Get rid of TreeNodeChildrenReordered.tfarina@chromium.org2010-08-112-17/+5
| | | | | | | | | | | | Reason: This function was never implemented by TreeNodeModel and is unlike it will be. Also it proved to not be necessary at all. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3091016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55657 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed build problems on Mac OS X when using GLContext from Chromium'skbr@google.com2010-08-106-7/+10
| | | | | | | | | | | | WebKit code. Added glIsFramebufferEXT and glIsRenderbufferEXT as preferred aliases. BUG=none TEST=WebGL, try bots Review URL: http://codereview.chromium.org/3146002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55584 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Minor gfx/ header cleanup.erg@google.com2010-08-104-3/+5
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3034039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55577 0039d316-1c4b-4281-b951-d872f2087c98
* Added a couple of new GL extension bindings.apatrick@chromium.org2010-08-093-2/+30
| | | | | | | | | | | These are used by the default Chrome WebKit WebGL implementation. TEST=try BUG=none Review URL: http://codereview.chromium.org/3030053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55465 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 55400 - Cleanup in base. This moves the implementation (and a bunch ↵nsylvain@chromium.org2010-08-092-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | of header file dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/3035062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55416 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup in base. This moves the implementation (and a bunch of header filebrettw@chromium.org2010-08-092-1/+2
| | | | | | | | | | | | | | | | | | | dependencies) from the multiprocess test and the test_suite headers to .cc files. Moves multiprocess_test to the test directory, and all of this stuff to the existing base_test_support project. I also used the base namespace. Previously other projects included this functionality just by #include because it was all inline, so I had to add dependencies on base_test_support in a few places. Moves and renames the command line switch this was using to base_switches. Move the base switch for process type to chrome switches. TEST=none BUG=none Review URL: http://codereview.chromium.org/3026055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55400 0039d316-1c4b-4281-b951-d872f2087c98
* Add one more test to TreeNodeModelTest.tfarina@chromium.org2010-08-071-0/+15
| | | | | | | | | | | | This add a SetTitle test, so we can verify if the TreeNodeModelChanged is properly called and the node is properly renamed. BUG=None TEST=out/Debug/app_unittests --gtest_filter=TreeNodeModelTest.SetTitle. Review URL: http://codereview.chromium.org/3015059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55338 0039d316-1c4b-4281-b951-d872f2087c98
* rid of more OS_LINUX defines, to help the BSD port (work by sprewell & I)pvalchev@google.com2010-08-061-4/+2
| | | | | | Review URL: http://codereview.chromium.org/2089010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55289 0039d316-1c4b-4281-b951-d872f2087c98
* app: Add unittests for TreeNodeModel.tfarina@chromium.org2010-08-062-1/+279
| | | | | | | | | | | BUG=None TEST=out/Debug/app_unittests --gtest_filter=TreeNodeModelTest.* Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3017023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55179 0039d316-1c4b-4281-b951-d872f2087c98
* base: rename Environment::SetEnv to Environment::SetVar.tfarina@chromium.org2010-08-061-5/+5
| | | | | | | | | | | | This is the part 3 of this series. One more remaining. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2836088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55168 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 1)thestig@chromium.org2010-08-052-2/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3071012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-042-10/+0
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from l10n_util/ResourceBundle locale functions.evan@chromium.org2010-08-049-50/+48
| | | | | | Review URL: http://codereview.chromium.org/3069026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54917 0039d316-1c4b-4281-b951-d872f2087c98
* base: rename Environment::UnSetEnv to Environment::UnSetVar.tfarina@chromium.org2010-08-041-1/+1
| | | | | | | | | | | | This is the part 1 of this series. More three comming. Splitting this into small parts, so it is more easy to review and reduce the size of the CL. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3058034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54862 0039d316-1c4b-4281-b951-d872f2087c98
* De-wstringify gl_implementation.cc.evan@chromium.org2010-08-031-13/+12
| | | | | | Review URL: http://codereview.chromium.org/3085006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54819 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-033-2/+4
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* base: Rename EnvVarGetter to Environment.tfarina@chromium.org2010-08-032-4/+4
| | | | | | | | | | | | | | | Now EnvVarGetter do much more than getting environment variables. Per suggestion from Pawel in http://codereview.chromium.org/3043018/. BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3052034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54696 0039d316-1c4b-4281-b951-d872f2087c98
* GPU command decoder uses depth24_stencil8_oes extension if available.apatrick@chromium.org2010-08-023-0/+21
| | | | | | | | | | | | | This is now the only depth / stencil format supported by ANGLE. Other GLES2 implementations will only use it if the extension is supported. Also changed all usage of GLES2_GPU_SERVICE_BACKEND_NATIVE_GLES2 to a runtime check since we no longer know at compile time whether the backend will be GL ot GLES2. TEST=try, GPU unit tests locally, WebGL locally, Pepper 3D locally BUG=none Review URL: http://codereview.chromium.org/3046035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54627 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 5ziadh@chromium.org2010-08-023-0/+9
| | | | | | | | | | | | | | | Preventative maintenance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. These files were discovered using the -Wnon-virtual-dtor flag in g++. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3080013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54540 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad license header in app/ and net/ directories.tfarina@chromium.org2010-07-312-6/+6
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3013049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54482 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-311-3/+3
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54418 - base: Add UnSetEnv function to EnvVarGetter API.tfarina@chromium.org2010-07-311-7/+10
| | | | | | | | | | | | | | | | | | This reverts commit 7ed083f6d2b1b0a09c8bf9470386ba3e38f2feed. It was reverted due to crbug.com/50663 started failing when I land this patch, so I'm relanding it now again. BUG=None TEST=trybots TBR=thestig@chromium.org Review URL: http://codereview.chromium.org/3043018 Review URL: http://codereview.chromium.org/3076020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54451 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/ (part 3)thestig@chromium.org2010-07-312-1/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3054029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54436 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54418 - base: Add UnSetEnv function to EnvVarGetter API.tfarina@chromium.org2010-07-311-10/+7
| | | | | | | | | | | | | | BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.UnSetEnvVar Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3043018 TBR=tfarina@chromium.org Review URL: http://codereview.chromium.org/2847092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54422 0039d316-1c4b-4281-b951-d872f2087c98
* base: Add UnSetEnv function to EnvVarGetter API.tfarina@chromium.org2010-07-311-7/+10
| | | | | | | | | | | BUG=None TEST=out/Debug/base_unittests --gtest_filter=EnvVarTest.UnSetEnvVar Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/3043018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54418 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-304-31/+43
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* The button menu items on GTK menus honor the enabled state of the command.sanjeevr@chromium.org2010-07-292-1/+8
| | | | | | | | | BUG=None TEST=Verify that wrench menu zoom controls are disabled when showing PDF using the Chrome PDF plugin anf enabled otherwise. Review URL: http://codereview.chromium.org/3032038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54162 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-299-12/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* Add undeclared virtual destructors part 2ziadh@chromium.org2010-07-272-0/+6
| | | | | | | | | | | | | Preventative maintainance for abstract classes that do not declare virtual destructors. Base classes that do not declare their destructors as virtual could potentially lead to memory leaks. r=jar BUG=47469 Review URL: http://codereview.chromium.org/3032024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53831 0039d316-1c4b-4281-b951-d872f2087c98
* Exposed an IsEnabledAt for ButtonMenuItemModel (this is not used yet, will ↵sanjeevr@chromium.org2010-07-272-0/+10
| | | | | | | | | | | be used in a subsequent checkin). The Mac wrench menu zoom controls honor the global enabled state of the zoom commands. BUG=None. TEST=Open a PDF using the internal PDF viewer on the Mac. The Zoom controls on the Wrench menu should be disabled. Review URL: http://codereview.chromium.org/3026025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53824 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Fix some NULL versus 0 issues to appease gcc-4.5.craig.schlenter@chromium.org2010-07-271-2/+2
| | | | | | | | | | | Patch is 99% the same as spotrh's version (thanks spot!) except for the use of gfx::kNullPluginWindow in this version. BUG=49533 Review URL: http://codereview.chromium.org/3014034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53788 0039d316-1c4b-4281-b951-d872f2087c98
* Make the resize gripper invisible.pkasting@chromium.org2010-07-272-1/+0
| | | | | | | | BUG=50107 TEST=Resize gripper nest to browser actions container should no longer appear Review URL: http://codereview.chromium.org/3052011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53732 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2671-0/+71
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity 9291: Uninitialized member in clipboard_linux.ccfinnur@chromium.org2010-07-231-1/+1
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/3008020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53450 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 05:47:28 +0000