summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* Load chrome.dll as a resource dll so that resources can be loaded by the ↵tommi@chromium.org2009-11-251-2/+2
| | | | | | | | | | | browser. TEST=fixes net tests for chrome frame BUG=none Review URL: http://codereview.chromium.org/437050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33094 0039d316-1c4b-4281-b951-d872f2087c98
* Move some theme images to being serviced on the IO thread. Fortony@chromium.org2009-11-242-2/+2
| | | | | | | | | | | | | | | | | Linux Release builds on my machine, all the chrome://theme/ image requests block for 300-400ms during browser startup (it's faster after startup). Something is blocking the UI thread so move image requests that aren't themed off the UI thread. This is safe to do because ResourceBundle is thread safe. I still see chrome://theme/theme_ntp_attribution and chrome://theme/theme_ntp_background blocking so I will look into those next (I think with the default theme, they shouldn't be loaded at all). Review URL: http://codereview.chromium.org/440009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32985 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ResourceBundle::LoadImageResourceBytes since it appears totony@chromium.org2009-11-233-11/+1
| | | | | | | | | be identical to LoadDataResourceBytes. Migrate callers to LoadDataResourceBytes. Review URL: http://codereview.chromium.org/437019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32885 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts font sizes to be readable on Chrome OS.sky@chromium.org2009-11-231-9/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/434010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32810 0039d316-1c4b-4281-b951-d872f2087c98
* Making grd dependencies more correct for grds in app.bradnelson@google.com2009-11-201-26/+30
| | | | | | | | | BUG=17706 TEST=None Review URL: http://codereview.chromium.org/414006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32602 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable TextEliderTest.ElideTextLongStrings.estade@chromium.org2009-11-202-3/+9
| | | | | | | | | | Pango returns 0 for absurdly long strings. Cut the text in half and try again if this occurs. BUG=15435 Review URL: http://codereview.chromium.org/414013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32572 0039d316-1c4b-4281-b951-d872f2087c98
* Mac language/locale cleanupthomasvl@chromium.org2009-11-193-12/+84
| | | | | | | | | | | | | | | - Effectively revert revision 28193 (http://codereview.chromium.org/258037), this makes Mac match the other platform for what at it's core is used for the chrome concept of locale. - For the ApplicationLanguage, the browser will end up with what Cocoa picks (same as before) - All other process types will honor the language they got on the command line when starting up. - When asked the apps language, have the same side effect as Windows and Linux has of pushing the language through to ICU also (so dates format right, etc.) - During browser startup, if someone passed a language, bail because Mac can't support that. TEST=The tips on the NTP and the dates on the history page are in the same language at the UI. BUG=26856 BUG=22727 Review URL: http://codereview.chromium.org/399086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32515 0039d316-1c4b-4281-b951-d872f2087c98
* Set prop app id for chromium/application shortcut.xiyuan@chromium.org2009-11-191-12/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a follow up change after andrew's patch for win7 shortcut to properly set app id for chromium/application shortcut. - Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to base/win_util.cc as SetAppIdForPropertyStore to share with file_util shortcut code; - Add an app_id args to file_util's CreateShortcutLink and UpdateShortcutLink; - Update code that calls the above two function in installer and UserDataManager so that the chromium shortcuts are created with proper app id (except the uninstall shortcut which is not tagged with any app id). - Move ComputeApplicationNameFromURL from Browser to web_app namespace and use it as app id for application shortcut. This makes pinned shortcut and browser window use the same app id and Win7 correctly groups them; - Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL per Ben's comments; - Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than 128 chars and contains no space per msdn; - Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName BUG=28104 TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application. Review URL: http://codereview.chromium.org/399045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32508 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify some code that loops over all pixels of a bitmap.pkasting@chromium.org2009-11-191-32/+17
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/404033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32444 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanups:pkasting@chromium.org2009-11-181-55/+41
| | | | | | | | | | | | | | * SplitUrlAndTitle() can't fail, so it doesn't need to return a bool. * assign() can do substrings in one shot * Half the code used "*str =" and half "str->assign()", often right next to each other; pick one for consistency * No need to calculate array sizes when we're the ones declaring them * Use early return in a few places BUG=none TEST=none Review URL: http://codereview.chromium.org/405023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32414 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lint errors in app/ and turn on presubmit check.erg@google.com2009-11-1711-16/+41
| | | | | | Review URL: http://codereview.chromium.org/400016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32222 0039d316-1c4b-4281-b951-d872f2087c98
* Do not open a new connection if one has already been opened.dumi@chromium.org2009-11-171-0/+5
| | | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/405005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32201 0039d316-1c4b-4281-b951-d872f2087c98
* Apply the latest translated strings to trunk.mal@chromium.org2009-11-1549-4/+53
| | | | | | | | BUG= None TEST= None Review URL: http://codereview.chromium.org/395014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32020 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Convert Cookies options page from a list into a tree.mattm@chromium.org2009-11-112-0/+8
| | | | | | | | | | | Add gtk_tree::TreeAdapter class. BUG=26713 TEST=compare behavior to windows impl Review URL: http://codereview.chromium.org/371079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31732 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-111-1/+1
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 31646.pkasting@chromium.org2009-11-112-17/+1
| | | | | | Review URL: http://codereview.chromium.org/386006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31648 0039d316-1c4b-4281-b951-d872f2087c98
* Try to make widgets clean up after themselves a bit better:pkasting@chromium.org2009-11-112-1/+17
| | | | | | | | | | | * When they get "destroy" window manager messages, clean up internal state so nothing will call into them and in theory someone could re-Init() successfully * When they're deleted, ensure they're also "destroyed" from the window manager point of view BUG=27347 TEST=none Review URL: http://codereview.chromium.org/391010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31646 0039d316-1c4b-4281-b951-d872f2087c98
* Added a flag to the Canvas class which allows forcing an RTL directionalityidana@chromium.org2009-11-112-5/+19
| | | | | | | | | | | | | on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g. Windows XP with no RTL fonts installed). BUG=23425 TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs. Review URL: http://codereview.chromium.org/384018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31619 0039d316-1c4b-4281-b951-d872f2087c98
* Unrevert 31478 Add UI for turning on/off network devices.mpcomplete@chromium.org2009-11-103-0/+106
| | | | | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 TBR=chocobo@google.com Review URL: http://codereview.chromium.org/384017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31598 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31478 - Add UI for turning on/off network devices.mpcomplete@chromium.org2009-11-103-106/+0
| | | | | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 TBR=chocobo@google.com Review URL: http://codereview.chromium.org/384014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31589 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31358 idana@chromium.org2009-11-101-1/+1
| | | | | | | | | Review URL: http://codereview.chromium.org/372041 TBR=cira@chromium.org Review URL: http://codereview.chromium.org/384009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31575 0039d316-1c4b-4281-b951-d872f2087c98
* Block Amharic on Windows XP for now. Win XP does not come with Amharic ↵jshin@chromium.org2009-11-091-3/+4
| | | | | | | | | | | | fonts. Even if a user install fonts supporting Amharic, Chrome's UI (including Omnibox) will not use it. BUG=NONE TEST=On Win XP, start chrome with '--lang=am' and Chrome's UI language matches your OS locale. Review URL: http://codereview.chromium.org/377020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31496 0039d316-1c4b-4281-b951-d872f2087c98
* Add UI for turning on/off network devices.chocobo@google.com2009-11-093-0/+106
| | | | | | | | BUG=26636 TEST=run skbitmap_operations_unittest Review URL: http://codereview.chromium.org/353028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31478 0039d316-1c4b-4281-b951-d872f2087c98
* We shouldn't use BIDI_DEFAULT_(RTL|LTR) if we know the directionality of the ↵cira@chromium.org2009-11-071-1/+1
| | | | | | | | | | | | | | page, because we won't like the result if string is mixed bidi (it may mark string as RTL instead of LTR if it starts with strong RTL characters, even if the global direction is LTR). TEST=Try entering Hebrew query in omnibox - Google Search text in suggested results should always be after "-" not within a string (visible on items from history, so you need to click on one result first). Try typing "אהרון" in omnibox. Review URL: http://codereview.chromium.org/372041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31358 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with inline autocomplete and URLs that change length ↵pkasting@chromium.org2009-11-071-5/+5
| | | | | | | | | | | | | | | | | | | | during fixup: * URLs with http auth info, which gets stripped * URLs with IDN hosts * URLs with escaped values that get unescaped In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode. The fix is to track how fixup affects the offsets into the URL we care about. Plumbing this required an enormous number of additions :( There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match. Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong). This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it). BUG=4010 TEST=Covered by unittests Review URL: http://codereview.chromium.org/372017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31352 0039d316-1c4b-4281-b951-d872f2087c98
* Converting the Cookies options page from a TableView to a TreeViewian@chromium.org2009-11-061-2/+2
| | | | | | | | | | | | so that we can add in Database, LocalStorage, and Appcache next to the cookies for an origin. BUG=26713 TEST=cookies_tree_model_unittest.cc Review URL: http://codereview.chromium.org/365005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31207 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Clipboard::WriteFile{,s} which is unused on mac and windows and ↵estade@chromium.org2009-11-058-157/+0
| | | | | | | | | | | unimplemented on linux. BUG=18037 TEST=trybots Review URL: http://codereview.chromium.org/292018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31148 0039d316-1c4b-4281-b951-d872f2087c98
* First patch in making destructors of refcounted objects private.jam@chromium.org2009-11-052-3/+13
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31136 0039d316-1c4b-4281-b951-d872f2087c98
* Enable localization of default downloaded filename.tony@chromium.org2009-11-041-2/+3
| | | | | | | | | | | | | | | Instead of localizing "download" string in net_util.cc, make a caller, download_manger, provide a localized string. BUG=25289 TEST=NetUtilTest.GetSuggestedFilename,DownloadManagerTest.TestDownloadFilename Original patch by hayato@google.com at: http://codereview.chromium.org/343014/show Review URL: http://codereview.chromium.org/367003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30971 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at:sky@chromium.org2009-11-047-18/+94
| | | | | | | | | | | | | | | Gets find bar animation/clipping to work on views/gtk. The only difference between this and the first version is fixing an include in extension_host that was triggering mac to build views, as well as an extraneous SetSlideDuration I had used for testing. BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/342116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30942 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30903 - Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-047-94/+18
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30913 0039d316-1c4b-4281-b951-d872f2087c98
* Gets find bar animation/clipping to work on views/gtk.sky@chromium.org2009-11-047-18/+94
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30903 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed font height on OS X. Also added some unittests.akalin@chromium.org2009-11-033-6/+12
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/351024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30891 0039d316-1c4b-4281-b951-d872f2087c98
* Remove themes/default.dll and merge the resources into chrome.dll.tc@google.com2009-11-026-57/+12
| | | | | | | | | | | This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035 Review URL: http://codereview.chromium.org/348033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
* Merge themes/default.pak into chrome.pak for Mac and Linux builds.tony@chromium.org2009-10-302-13/+10
| | | | | | | | | | | | | In theory this should result in a slightly faster app startup. I will do a follow up change to merge it on Windows and get rid of the code related to the extra file. BUG=24035 Review URL: http://codereview.chromium.org/344038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up extension badge text drawing.estade@chromium.org2009-10-306-9/+13
| | | | | | | | | | | | | | | Fall abck to the system default font if the preferred font isn't available. Also, only create the SkPaint struct once, not on every paint. Also, make some more things const. BUG=25693 TEST=badge still looks good, that crash goes away Review URL: http://codereview.chromium.org/341045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30631 0039d316-1c4b-4281-b951-d872f2087c98
* Implemented most of HtmlDialogWindowController, which is a Cocoa portakalin@chromium.org2009-10-301-0/+3
| | | | | | | | | | | | | | | | | | | | of HtmlDialogView. Added TODO to fix inaccurate font height metric for OS X font class (and maybe width). Added the BrowserCommandExecutor protocol so that not just a BrowserWindowController can be the window controller for a ChromeEventProcessingWindow. Added unittests. Also tested manually with the bookmark sync setup wizard dialog. BUG=23073 TEST=added unittests, trybot, and manual testing Review URL: http://codereview.chromium.org/344008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30619 0039d316-1c4b-4281-b951-d872f2087c98
* Problem clipping gtk text.davemoore@chromium.org2009-10-301-1/+1
| | | | | | | | | BUG=26266i TEST=NONE Review URL: http://codereview.chromium.org/342060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30604 0039d316-1c4b-4281-b951-d872f2087c98
* Convert ReplaceStringPlaceholders(std::string...) to take atony@chromium.org2009-10-291-0/+4
| | | | | | | | | | | | | | StringPiece as the format string instead. This allows us to save a string copy in the new tab page. Also clean up some code in the extensions process binding that was doing excess string conversions. BUG=26228 Review URL: http://codereview.chromium.org/347019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30491 0039d316-1c4b-4281-b951-d872f2087c98
* Got the about panel to have its text lined up correctly.davemoore@chromium.org2009-10-273-19/+101
| | | | | | | | Also added underline capability to linux fonts. Review URL: http://codereview.chromium.org/338029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30276 0039d316-1c4b-4281-b951-d872f2087c98
* Modify DataPacks so they can return RefCountedStaticMemory objects.erg@google.com2009-10-272-22/+8
| | | | | | | | | | (This is in preparation for a very large reworking of BrowserThemeProvider). BUG=http://crbug.com/21121 Review URL: http://codereview.chromium.org/338027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30241 0039d316-1c4b-4281-b951-d872f2087c98
* ResourceBundle::GetRawDataResource should fall back to localized resourcesmark@chromium.org2009-10-272-4/+14
| | | | | | | | | | | | on Mac and Linux as it does on Windows. BUG=25869 TEST=about:terms should work. In a branded build, terms should show up. In an unbranded build, the about:terms page is supposed to be blank, but there should be some skeletal HTML visible in "View Source". Review URL: http://codereview.chromium.org/338028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30130 0039d316-1c4b-4281-b951-d872f2087c98
* Add a method to TreeNode to return total number of nodes in a subtree.munjal@chromium.org2009-10-251-0/+11
| | | | | | | | | BUG=25542 TEST=none Review URL: http://codereview.chromium.org/332016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30027 0039d316-1c4b-4281-b951-d872f2087c98
* Get the About panel to align its links correctly,davemoore@chromium.org2009-10-232-9/+2
| | | | | | | | but undo a previous change to the way we measure strings in pango. Review URL: http://codereview.chromium.org/338001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29943 0039d316-1c4b-4281-b951-d872f2087c98
* Makes inactive pinned tabs on linux throb when the title changes. Isky@chromium.org2009-10-231-0/+4
| | | | | | | | | | | need to resolve with Glen/Nicholas how to handle the windows side. BUG=25308 TEST=none Review URL: http://codereview.chromium.org/314010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29903 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the RootView is sized to the correct bounds when the opaque frame ↵ben@chromium.org2009-10-231-0/+3
| | | | | | | | is maximized.It seems that now, when an opaque frame is maximized we also need to add the SM_CXSIZEFRAME to the top of the client rect. I don't know why, it's just is.I reworked the way Widget allows subclasses to handle sizing of the RootView... I delegate responsibility for determining the RootView's bounds to a helper virtual function which BrowserFrameWin overrides. This seems cleaner to me. I make sure this handling only occurs when the window is not maximized.http://crbug.com/25227TEST=use to a theme or switch off glass on vista or use Xp. Maximize the browser window. The tabs should be entirely visible. Review URL: http://codereview.chromium.org/304007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29882 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of file path name handling.brettw@chromium.org2009-10-221-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | This started trying to cleanup DownloadManager::GenerateFilename which asserts if your system locale isn't UTF-8 (I ran into this when mine got messed up). The solution is to have GetSuggestedFilename return a FilePath rather than calling FromWStringHack. The rest of the patch is a result of trying to write GetSuggestedFilename in a reasonable way. I changed ReplaceIllegalCharacters to work on a FilePath::StringType. Some places in the code calling these functions got cleaner, some got messier. I think overall the ones that got messier are the ones doing sketchy things with paths and the ones that got cleaner are the ones doing things more properly. The only code here that gets called a nontrivial number of times is the weburlloader, and I think the new code does about the same number of string conversions overall (though on certain platforms the number will be higher or lower). BUG=none TEST=none Review URL: http://codereview.chromium.org/271056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29832 0039d316-1c4b-4281-b951-d872f2087c98
* Chromium fix for "Copy Image". (WebCore fix is ↵avi@chromium.org2009-10-222-1/+44
| | | | | | | | | | | http://codereview.chromium.org/294023 .) BUG=http://crbug.com/13099 TEST="Copy Image" works; see bug Review URL: http://codereview.chromium.org/308001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29812 0039d316-1c4b-4281-b951-d872f2087c98
* Make PNGCodec::Decode(...) not make an intermediary copy of the decoded data;erg@google.com2009-10-224-73/+160
| | | | | | | | | | | instead have it write directly to the returned SkBitmap. BUG=http://crbug.com/24493 TEST=Perf should get better. On the perf trybot, tab_complex_theme_cold got an average of ~40ms better. Review URL: http://codereview.chromium.org/305001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29780 0039d316-1c4b-4281-b951-d872f2087c98
* Implement dragging icon for dragging bookmarks in views/gtk.skrul@google.com2009-10-214-4/+37
| | | | | | Review URL: http://codereview.chromium.org/270068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29692 0039d316-1c4b-4281-b951-d872f2087c98