summaryrefslogtreecommitdiffstats
path: root/app
Commit message (Collapse)AuthorAgeFilesLines
* This CL fixes issue 10860 - RTL: Hebrew file names should have forced LTRxji@chromium.org2009-09-166-12/+68
| | | | | | | | | | | | | | | | | | | directionality in download shelf. File names in download shelf are forced to be LTR in DownloadItemView and through ElideFileName(). BUG=http://crbug.com/10860 TEST=1. Open chrome with Hebrew UI. 2. Right click a link and chose Save As... (4th item from the top for non-Hebrew speakers) 3. In the save as dialog name the file קובץ.html 4. In the download shelf the filename should display as קובץ.html (not html.קובץ) Review URL: http://codereview.chromium.org/131001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26359 0039d316-1c4b-4281-b951-d872f2087c98
* Force inclusion of build/common.gypi for all chromium gyp files.yaar@chromium.org2009-09-151-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | Why: Simpler build code. If everybody includes it, it should be included automatically. Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi. What was done: 1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi 2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi. 3. lots of gyp files were fixed to not refer to build/common.gypi any more. 4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too. 5. build/common.gypi was left empty, because there are some external projects that still refer to it. Things that are left to do after this patch is in: 1. The following external files (in other repositories) need to stop include common.gypi ./third_party/hunspell/hunspell.gyp ./third_party/icu/icu.gyp ./v8/tools/gyp/v8.gyp 2. Once nobody refers to common.gypi anymore, delete common.gypi -or- Delete gyp_chromium.gypi and move its content back to common.gypi Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify. Review URL: http://codereview.chromium.org/206006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98
* Print a stacktrace when we can't find a string resource (on Windows).phajdan.jr@chromium.org2009-09-151-0/+3
| | | | | | | | | | | This should help debug the linked bug, or at least rule out some possibilities. TEST=none BUG=21925 Review URL: http://codereview.chromium.org/196132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26297 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the sqlite cookie database and web database to use the new sqlitebrettw@chromium.org2009-09-154-12/+36
| | | | | | | | | | | wrapper. This also moves and renamed the old cookie_monster_sqlite file to match the class name. BUG=none TEST=none Review URL: http://codereview.chromium.org/201099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26260 0039d316-1c4b-4281-b951-d872f2087c98
* UI language list fix.jshin@chromium.org2009-09-151-11/+36
| | | | | | | | | | | | | | | 30+ minimally populated locales were added to our ICU data. As a result, GetAvailableLocale() used whenconstructing the UI language menu in Chrome list languages Chrome is not localized to. 1. Add IsPartiallyPopulatedLocale() to l10n_util (anonymous namespace) and skip those locales when constructing the locale list. 2. Add 'Hawaiian', 'Oromo' and 'Hausa' to the Accept-Language list. I'll add other languages to the trunk later. BUG=21119 (http://crbug.com/21119), 19329 ( http://crbug.com/19329 ) TEST=1. Launch Chrome and go to Options | "Advanced" | Languages & Fonts menu | Languages tab | Google Chrome language. The list of languages to choose from should contain only languages Chrome is localized to (40 + 1 + 8) and should not contain languages like Hawaian, Belarusian. 2. Accept-Language list should contain 3 new languages added (Hawaiian, Oromo and Hausa) Review URL: http://codereview.chromium.org/193027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26230 0039d316-1c4b-4281-b951-d872f2087c98
* Provide a save file type for unknown extensions.paul@chromium.org2009-09-142-8/+21
| | | | | | | | | | | | BUG=7246 TEST=Download a file with an unknown extension using the "Save as" option. The Save As dialog will populate the "Save Type" combo box with the unknown type and "All Files", instead of just "All files". Review URL: http://codereview.chromium.org/202032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26160 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts linux font change again. Slow down isn't as bad as before. Butsky@chromium.org2009-09-146-261/+270
| | | | | | | | | | | | still not ideal. BUG=none TEST=none TBR=agl Review URL: http://codereview.chromium.org/194105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26141 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at converting font from Skia to Pango. The slow down appears to be ↵sky@chromium.org2009-09-146-270/+261
| | | | | | | | | | | | entirely attributed to asking for the metrics. To get back the performance I did the following: . Only ask for the metrics when needed. We appear to create 6 or so fonts very early on without needing the metrics. This ensures we only take the metrics load hit when needed. . Keep a cache of the metrics around. This ensures that we only load the metrics once. I didn't dig through the Pango source to see why Pango is slow at getting metrics. I suspect it's the first person to ask for metrics incurs a penalty as Pango accesses the disk. The code we have now is the same as that as Gtk. Review URL: http://codereview.chromium.org/199101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26116 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing #include <string> in a new file that uses std::string.mark@chromium.org2009-09-121-0/+1
| | | | | | Review URL: http://codereview.chromium.org/200113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26067 0039d316-1c4b-4281-b951-d872f2087c98
* Add a DEPS file for app/sql so checkdeps doesn't complain about the sqlitebrettw@chromium.org2009-09-111-0/+3
| | | | | | | | | | inclueds. TEST=run checkdeps (as on buildbot) BUG=none Review URL: http://codereview.chromium.org/201098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26033 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts r26015. It caused a startup regression:(sky@chromium.org2009-09-116-170/+271
| | | | | | | | | | BUG=20823 TEST=none TBR=agl Review URL: http://codereview.chromium.org/203041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26030 0039d316-1c4b-4281-b951-d872f2087c98
* Add a new wrapper for sqlite. This is mostly a large cleanup of the existingbrettw@chromium.org2009-09-1112-1/+1640
| | | | | | | | | | | | | | | one, combined with the statement cache in a nice way. It is designed to entirely wrap sqlite so that we can catch corrupt errors in the future and "do something" when we get them without having to change all the calling code. There is also a new meta_table file which is almost exactly like the old one but which uses the new sql interface. This patch changes Chrome's history TextDatabase to use this new wrapper as a proof of concept, because this usage is relatively well-confined. Review URL: http://codereview.chromium.org/199047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26022 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes font_skia and converts font_gtk to use pango. This wassky@chromium.org2009-09-116-271/+170
| | | | | | | | | | | | | | | | | | | | | | necessitated by Pango and Skia differing on how the fonts are sized, resulting in lots of clipping in views. The only iffy part of this is I've made Font::nativeFont() win/mac only (it isn't used on Linux). I did this to avoid folks accidentally modifying the underlying font out from under Font. That said, I could certainly nuke GetPangoFontDescription in favor of nativeFont() and make it return the PangoFontDescription (not a copy). Let me know if you feel strongly about converting this. Assuming your ok with this, I'll watch the perf tests to make sure this doesn't impact startup. BUG=20823 TEST=none Review URL: http://codereview.chromium.org/195058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26015 0039d316-1c4b-4281-b951-d872f2087c98
* Move StringPiece into the base namespace. It is collidingtony@chromium.org2009-09-104-15/+17
| | | | | | | | | | with the StringPiece class in icu4.2, which is a problem when trying to use the system version of icu. Review URL: http://codereview.chromium.org/193072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25920 0039d316-1c4b-4281-b951-d872f2087c98
* Add a "ToUpper" method.paul@chromium.org2009-09-093-0/+26
| | | | | | | | | BUG=None. TEST=Covered by new unittest. Review URL: http://codereview.chromium.org/194060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25809 0039d316-1c4b-4281-b951-d872f2087c98
* Fix to use FilePath version of PathService::Get.thestig@chromium.org2009-09-091-5/+5
| | | | | | | | | | | BUG=None TEST=None Original Review URL: http://codereview.chromium.org/174189 Patch from Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/193047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25778 0039d316-1c4b-4281-b951-d872f2087c98
* Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the ↵jshin@chromium.org2009-09-091-4/+4
| | | | | | | | | | | | | | | | | | references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). Also updated is the test results for net_util_unittests. This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). BUG=8198 TEST=On all platforms, all the targets are built fine. Review URL: http://codereview.chromium.org/172031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids the use of "namespace using-directives" in a few places.thakis@chromium.org2009-09-071-2/+0
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/183008 Patch from tfarina. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25607 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some gcc 4.4 issues when compiling with toolkit_views.craig.schlenter@chromium.org2009-09-071-5/+5
| | | | | | | | | | | | | | | | | | | | | Most of these squash harmless compiler warnings but the custom_button.cc change fixes a real problem with the accelerator key bitmask calculation (+ preceeds << in terms of operator precedence) The change to tab_strip.cc is ugly but it fixes the following error: chrome/browser/views/tabs/tab_strip.cc: In member function ‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’: chrome/browser/views/tabs/tab_strip.cc:201: error: assuming signed overflow does not occur when assuming that (X - c) > X is always false As an added bonus, this makes the Linux shared build of toolkit_views work too. Review URL: http://codereview.chromium.org/199025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98
* Added USE_GDK, set when either TOOLKIT_GTK or TOOLKIT_VIEWS is set butbenl@chromium.org2009-09-072-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | not OS_WIN. Added USE_X11. Set when OS_LINUX or OS_FREEBSD is set. Added USE_BASE_DATA_PACK for base::DataPack usage, set for OS_MACOSX, OS_LINUX or OS_FREEBSD. Added USE_NSS for ... nss (for crypto). Windows and MacOS use platform-specific libraries. All of the above cause slightly odd formulations like: #if defined(OS_WIN) ... #elif defined(USE_BASE_DATA_PACK) ... #endif Possibly should also define USE_DLL_FOR_DATA, etc? Or something? Wrapped various references to struct stat64 and stat64() to use struct stat and stat() for FreeBSD - but a "man stat64" on Linux suggests that we could do the same thing for at least Linux, too, and perhaps eliminate the wrapper? git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25599 0039d316-1c4b-4281-b951-d872f2087c98
* Adds Font::CreateFont(PangoFontDescription* desc).sky@chromium.org2009-09-042-10/+15
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/200019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25488 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement folder chooser dialog.estade@chromium.org2009-09-041-1/+0
| | | | | | | | | | Also, found another gtk bug: http://bugzilla.gnome.org/show_bug.cgi?id=594089 We can't write a suppression for this bug because the warning message is too generic, but it shouldn't be much of a problem in release builds. BUG=20940 Review URL: http://codereview.chromium.org/196014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25485 0039d316-1c4b-4281-b951-d872f2087c98
* Add functions to alpha-blend two colors and pick the more readable of two ↵pkasting@chromium.org2009-09-032-4/+50
| | | | | | | | | | | | colors. These will be used to make the UI more readable on non-default themes. Also removes a function that no one was calling. BUG=92, 18367 TEST=none Review URL: http://codereview.chromium.org/190001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25340 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Workaround Skia and Pango measuring font heights differently by ↵evan@chromium.org2009-09-031-24/+3
| | | | | | | | | asking Pango" This reverts commit r25131. It seems to have regressed Linux startup; will track perf builder after committing this to be sure. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25325 0039d316-1c4b-4281-b951-d872f2087c98
* Replace usage of MFC wrapper classes with their win32 base types to reduce ↵jhawkins@chromium.org2009-09-031-12/+15
| | | | | | | | | | dependency on ATL/MFC. BUG=5027 TEST=none Review URL: http://codereview.chromium.org/171129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25298 0039d316-1c4b-4281-b951-d872f2087c98
* Workaround Skia and Pango measuring font heights differently by asking Pangobrettw@chromium.org2009-09-021-3/+24
| | | | | | | | | | | | | | | | | | for the height that we'll report in the gfx::Font. This seems wrong, but at least things will look reasonable until we find a better solution. This changes the existing height computation code to use ceiling. Even though this is no longer used, it is good to have the correct code for the height computation here so that if we find a better solution, it will be run properly. This also gives more room for the clock in the status area view because the height is now more and we want it to be aligned properly. BUG=none TEST=none Review URL: http://codereview.chromium.org/183044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25131 0039d316-1c4b-4281-b951-d872f2087c98
* The FocusManager stores/restores focus when the top window becomes ↵jcampan@chromium.org2009-09-011-3/+3
| | | | | | | | | | | | inactive/active. BUG=None TEST=Run the focus manager unit-tests. Review URL: http://codereview.chromium.org/164448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25108 0039d316-1c4b-4281-b951-d872f2087c98
* Parameterize the Google Update appid at build time instead of hard coding it ↵robertshield@chromium.org2009-09-011-1/+46
| | | | | | | | in the source. Review URL: http://codereview.chromium.org/178011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25072 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Make the toolbar star button a drag source.estade@chromium.org2009-09-012-1/+47
| | | | | | | | | | Also refactor URI list/named url packing code. BUG=19008 Review URL: http://codereview.chromium.org/175036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25067 0039d316-1c4b-4281-b951-d872f2087c98
* Porting textfield to toolkit_views Gtk.jcampan@chromium.org2009-09-014-27/+36
| | | | | | | | | | | BUG=None TEST=Run the view unit-tests. See original review: http://codereview.chromium.org/165512/show Review URL: http://codereview.chromium.org/180061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25063 0039d316-1c4b-4281-b951-d872f2087c98
* Drop in new translations.laforge@chromium.org2009-08-3149-4/+54
| | | | | | | TBR=mal@chromium.org Review URL: http://codereview.chromium.org/179050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24951 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Get rid of the title-centering code in TabRendererGtk. DrawStringInt ↵jhawkins@chromium.org2009-08-311-8/+1
| | | | | | | | | | centers the text for us already. This change also removes a hack that modified the clipping rect unnecessarily. BUG=20401,20610 TEST=none Review URL: http://codereview.chromium.org/179037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24875 0039d316-1c4b-4281-b951-d872f2087c98
* Some code style cleanup under src/app.maruel@chromium.org2009-08-2911-19/+19
| | | | | | | | | | BUG=None TEST=None Patch contributed by thiago.farina@gmail.com Review URL: http://codereview.chromium.org/173260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24859 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for initiating drags from bookmark menus.sky@chromium.org2009-08-283-80/+104
| | | | | | | | | BUG=none TEST=make sure bookmark menus work on Windows. Review URL: http://codereview.chromium.org/176006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24801 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-284-19/+2
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-284-2/+19
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Fix the bounds of the clip region for tab title text.jhawkins@chromium.org2009-08-261-5/+10
| | | | | | | | BUG=19741 TEST=Open many tabs. The ellipses should not be rendered if the tab is not large enough. Review URL: http://codereview.chromium.org/174582 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24560 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at landing bookmark menus.sky@chromium.org2009-08-263-0/+2
| | | | | | | | | | | | | The build breakage was the result of a bad ifdef in MenuController, specifically around the OnKeyDown method. BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173517 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24526 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts menu patch.sky@chromium.org2009-08-263-2/+0
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: http://codereview.chromium.org/173508 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24509 0039d316-1c4b-4281-b951-d872f2087c98
* Avoids the use of ToWStringHack in a few places.evan@chromium.org2009-08-261-2/+2
| | | | | | | | | | BUG=None TEST=run app_unittests.exe, browser_tests.exe and selenium_tests.exe Review URL: http://codereview.chromium.org/173418 Patch from Thiago Farina <thiago.farina@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24504 0039d316-1c4b-4281-b951-d872f2087c98
* Gets bookmark menu working on linux. There are just a handful ofsky@chromium.org2009-08-263-0/+2
| | | | | | | | | | | | NOTIMPLEMENTEDs to resolve (initiating drags is the biggest remaining issue). I'll tackle the remaining issues separately. BUG=none TEST=make sure bookmark menus work well on windows still. Review URL: http://codereview.chromium.org/173431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24501 0039d316-1c4b-4281-b951-d872f2087c98
* Add a helper to resource bundle to get an NSImage back.thomasvl@chromium.org2009-08-262-0/+23
| | | | | | | | | | skia/ext/skia_utils_mac.h includes CoreGraphics/CGColor.h so we have to relay the framework include path so someone can include the header without errors. BUG=none TEST=none Review URL: http://codereview.chromium.org/173363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24453 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Properly read utf-8 text from drags.estade@chromium.org2009-08-251-1/+1
| | | | | | | | BUG=19365 Review URL: http://codereview.chromium.org/174431 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24328 0039d316-1c4b-4281-b951-d872f2087c98
* Fall back to the chrome-themed default favicon if the gtk theme fails to ↵estade@chromium.org2009-08-251-0/+5
| | | | | | | | | | | produce one. BUG=19994 Review URL: http://codereview.chromium.org/174267 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24191 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Clip the cairo context to the extents provided to the DrawStringInt ↵jhawkins@chromium.org2009-08-241-0/+7
| | | | | | | | | | function. This fixes an issue when rendering the tab title where the ellipses are rendered no matter how small the tab is sized. This change also fixes an issue where we were using the default font to determine whether to show the tooltip. BUG=19741 TEST=Open many tabs. See that the ellipses should disappear when there's no room left in the tab to display them. Review URL: http://codereview.chromium.org/173300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24149 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk languages options page part 1: accept-languages configuration.mattm@chromium.org2009-08-192-0/+157
| | | | | | | | | | | Move accept_language_list to l10n_util, use it for LanguagesPageGtk. BUG=13524 TEST=You can view, reorder, remove and add accept-languages. Review URL: http://codereview.chromium.org/174043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23695 0039d316-1c4b-4281-b951-d872f2087c98
* Makes Path::CreateGdkRegion return NULL for empty paths. Without thissky@chromium.org2009-08-192-0/+8
| | | | | | | | | | | gdk_region_polygon asserts. And adds the null check in WindowGtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/164441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23691 0039d316-1c4b-4281-b951-d872f2087c98
* Moves GtkDndUtil into app.sky@chromium.org2009-08-183-0/+229
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/165423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23627 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'icu::' namespace explicitly throughout Chrome tree instead of relying ↵jshin@chromium.org2009-08-188-33/+35
| | | | | | | | | | | | | | | | | | | on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Review URL: http://codereview.chromium.org/171012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
* Add missing include.mattm@chromium.org2009-08-181-0/+2
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/171092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23604 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 10:48:10 +0000