| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move extension_set.h/cc and extension_set_unittest to extensions/common/.
Remove unused includes.
Add includes where transitive includes were used.
Update DEPS.
No functional changes.
BUG=162530
TBR=sky@chromium.org (c/b/autocomplete, c/b/ui, c/test)
TBR=jam@chromium.org (c/b/automation)
TBR=atwilson@chromium.org (c/b/background, c/b/sync, c/b/policy)
TBR=bauerb@chromium.org (c/b/browsing_data, c/b/content_settings, c/b/managed_mode)
TBR=satorux@chromium.org (c/b/chromeos)
TBR=yurys@chromium.org (c/b/devtools)
TBR=thestig@chromium.org (c/b/media_galleries)
TBR=stevenjb@chromium.org (c/b/notifications)
TBR=battre@chromium.org (c/b/profile_resetter)
TBR=dmazzoni@chromium.org (c/b/speech)
TBR=kinuko@chromium.org (c/b/sync_file_system)
TBR=pkotwicz@chromium.org (c/b/themes)
Review URL: https://codereview.chromium.org/102103005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move the code that checks whether the command-line flag or
pref to disable extensions is set into
ExtensionsBrowserClient, and make ExtensionPrefFactory work
with a BrowserContext instead of requiring a Profile.
BUG=313284
Review URL: https://codereview.chromium.org/89253002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238243 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=298586
R=cdn@chromium.org, miket@chromium.org, sky@chromium.org
TBR=cdn@chromium.org
Review URL: https://codereview.chromium.org/15239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome/browser/extensions/platform_app_launcher.* -> apps/launcher.*
TBR=yoz@chromium.org, willchan@chromium.ogt, satorux@chromium.org
TBR for simple refactors:
yoz for extensions
willchan for new dependency on net/base
satorux for new dependency on chrome/browser/chromeos/drive
BUG=159366
TEST=Ensure launching apps in Windows 8 while chrome is running in
single window mode still prompts to run chrome in desktop mode.
Review URL: https://chromiumcodereview.appspot.com/22536002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216181 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
TBR=brettw
Review URL: https://codereview.chromium.org/18640003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211261 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This involves creating a new delegate type, ShellWindow::Delegate, which
is implemented in chrome.
BUG=159366
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=208927
Review URL: https://chromiumcodereview.appspot.com/16702003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209371 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
broke build:
../../chrome/browser/ui/apps/chrome_shell_window_delegate.cc:7:31: fatal error: base/stringprintf.h: No such file or directory
(I think it was moved to base/strings/stringprintf.h)
> Move ShellWindow into apps component.
>
> This involves creating a new delegate type, ShellWindow::Delegate, which
> is implemented in chrome.
>
> BUG=159366
>
> Review URL: https://chromiumcodereview.appspot.com/16702003
TBR=benwells@chromium.org
Review URL: https://codereview.chromium.org/18062007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This involves creating a new delegate type, ShellWindow::Delegate, which
is implemented in chrome.
BUG=159366
Review URL: https://chromiumcodereview.appspot.com/16702003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208927 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppLifetimeMonitor listens to extension host notifications and observes
ShellWindowRegistry. It sends out notifications when:
- an app starts
- the first shell window opens
- the last shell window closes
- the app stops
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204487
Review URL: https://chromiumcodereview.appspot.com/16412002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206988 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This upates calls to bound temporary objects to also use get().
While it has the same semantic equivalence to the existing code, this generally
represents a dangerous pattern - indeed, part of the whole motivation for this
change is to make this anti-pattern very visible to authors.
This change simply updates all of the call sites, to allow the "operator T*"
to be removed and preventing new instances. The existing instances will then be
reviewed for "suspicious" changes and updated to use/pass scoped_refptr<T>
rather than T*, as appropriate.
BUG=110610
TBR=darin
Review URL: https://codereview.chromium.org/15984016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The dialog allows the user to revoke access for the app, restarting it
if it's currently running. If the app/extension has not retained access
to any files, the dialog is unchanged.
[Mac] XIB change:
- Enable "Show Vertical Scroller" for the scroll view.
Dialog screenshots: https://code.google.com/p/chromium/issues/detail?id=224684#c6
BUG=224684
TEST=Install an app that uses chrome.fileSystem.retainEntry and open a
file with it. In chrome://extensions/ click the permissions link for
that app. The filename should be listed.
Review URL: https://chromiumcodereview.appspot.com/15943007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Was causing BrowserCommandControllerTest.IncognitoModeOnSigninAllowedPrefChange to crash.
> Factor out AppLifetimeMonitor.
>
> AppLifetimeMonitor listens to extension host notifications and observes
> ShellWindowRegistry. It sends out notifications when:
> - an app starts
> - the first shell window opens
> - the last shell window closes
> - the app stops
>
> BUG=
>
> Review URL: https://chromiumcodereview.appspot.com/16412002
TBR=jackhou@chromium.org
Review URL: https://codereview.chromium.org/16554002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AppLifetimeMonitor listens to extension host notifications and observes
ShellWindowRegistry. It sends out notifications when:
- an app starts
- the first shell window opens
- the last shell window closes
- the app stops
BUG=
Review URL: https://chromiumcodereview.appspot.com/16412002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@204487 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This replaces chrome.fileSystem.getEntry(By)Id with retainEntry,
restoreEntry and isRestorable, which enable restoring file access after
an app is closed for apps with the fileSystem.retainFiles permission.
Retained files are evicted by LRU, with a maximum of 500 retained files.
BUG=224684
Review URL: https://chromiumcodereview.appspot.com/14607023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202276 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only do this if the app had windows opened the last time it was running,
otherwise apps that were running but had no windows may restart by opening
windows, which manifests as apps coming back on a restart after the user
already closed them.
BUG=230667,167740,162057
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199406
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=199409
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199970
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=200016
Review URL: https://chromiumcodereview.appspot.com/14878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200779 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This breaks unit_tests:BrowserCommandControllerTest.IncognitoModeOnSigninAllowedPrefChange
in debug builds.
The waterfall seems to not be running with DCHECKs on so this passed by unnoticed, but
it causes failures in the CQ which is using DCHECKs. See also crbug.com/240718
Here's a failure build: http://build.chromium.org/p/tryserver.chromium/builders/linux_rel/builds/127560
Local bisect found this test breaks after this CL but not before.
> Restart apps that don't listen to onRestarted() by sending them onLaunched().
>
> We only do this if the app had windows opened the last time it was running,
> otherwise apps that were running but had no windows may restart by opening
> windows, which manifests as apps coming back on a restart after the user
> already closed them.
>
> BUG=230667,167740,162057
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199406
> Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=199409
>
> Review URL: https://chromiumcodereview.appspot.com/14878008
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/15031005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200016 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only do this if the app had windows opened the last time it was running,
otherwise apps that were running but had no windows may restart by opening
windows, which manifests as apps coming back on a restart after the user
already closed them.
BUG=230667,167740,162057
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199406
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=199409
Review URL: https://chromiumcodereview.appspot.com/14878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Restart apps that don't listen to onRestarted() by sending them onLaunched().
>
> We only do this if the app had windows opened the last time it was running,
> otherwise apps that were running but had no windows may restart by opening
> windows, which manifests as apps coming back on a restart after the user
> already closed them.
>
> BUG=230667,167740,162057
>
> Review URL: https://chromiumcodereview.appspot.com/14878008
TBR=koz@chromium.org
Review URL: https://codereview.chromium.org/14711009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199409 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We only do this if the app had windows opened the last time it was running,
otherwise apps that were running but had no windows may restart by opening
windows, which manifests as apps coming back on a restart after the user
already closed them.
BUG=230667,167740,162057
Review URL: https://chromiumcodereview.appspot.com/14878008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199406 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=180083
TBR=ben@chromium.org (gypi)
Review URL: https://chromiumcodereview.appspot.com/14735002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198995 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
packaged apps are running.
Introduces ShellWindowRegistry::IsShellWindowRegisteredInAnyProfile to
help determine if packaged apps are currently running. Intercepts the
IDC_WIN8_METRO_RESTART command and shows a modal dialog box if packaged
apps are running to confirm that the user is OK with their packaged
apps closing. Ensures apps with a relaunch handler are not relaunched
when restarting in metro mode.
BUG=222297
TEST=Launch a packaged app in desktop mode and select 'Relaunch Chrome
in Windows 8 mode' from the hotdog menu. A prompt should appear
confirming that your Chrome apps will close if you continue. If no
packaged apps are running, no prompt should appear.
Review URL: https://chromiumcodereview.appspot.com/12566039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192240 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=165832
Review URL: https://chromiumcodereview.appspot.com/12391006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I think this revert, oddly, caused a series of failures on chromeos bots
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20x64/builds/30936
like the top of the failures that it was supposed to have solved.
browser_tests browser_tests failed 3
Flakiness dashboard
( 44 mins, 15 secs )
stdio
FileSystemApiOpenBackgroundTest
FileSystemApiSaveBackgroundTest
FileAccessIsSavedToPrefs
Perhaps it wasn't the root cause after all.
This re-landing is an attempt to investigate what's going on here.
I reverted another change in the original blamelist an attempt to investigate further.
https://codereview.chromium.org/12334129/
I also tried disabling these tests to get more green in the tree. That hasn't kicked in yet, oddly.
https://codereview.chromium.org/12334128/
> Revert "Track and persist what file entries an extension has access to."
>
> This reverts commit 4fe61bc24f343a6a1381a782dec4fb45b2f6c437 (r184878).
>
> This was causing test failures in FileSystemApiOpenBackgroundTest and
> FileSystemApiSaveBackgroundTest on linux (example
> http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29&number=23657 )
>
> TBR=koz@chromium.org
> BUG=
>
> Review URL: https://codereview.chromium.org/12319140
TBR=iannucci@chromium.org
Review URL: https://codereview.chromium.org/12317156
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4fe61bc24f343a6a1381a782dec4fb45b2f6c437 (r184878).
This was causing test failures in FileSystemApiOpenBackgroundTest and
FileSystemApiSaveBackgroundTest on linux (example
http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests%20%28dbg%29%281%29&number=23657 )
TBR=koz@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12319140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184900 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note this change doesn't re-grant permissions to the extensions at any point.
Subsequent patches will cause chrome to restore access to the file entries an
extension had in the case of an unexpected crash (ie: onRestarted()).
BUG=165832
Review URL: https://chromiumcodereview.appspot.com/11857009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
This is a small patch to begin the process of pulling apps code out of chrome and the extensions system.
BUG=159366
Review URL: https://chromiumcodereview.appspot.com/11829055
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177968 0039d316-1c4b-4281-b951-d872f2087c98
|