summaryrefslogtreecommitdiffstats
path: root/ash/BUILD.gn
Commit message (Collapse)AuthorAgeFilesLines
* Creating a "Quirks Client" to download icc files and other display infoglevin2016-03-231-0/+3
| | | | | | | | | | | | | | | | | | | | | | | ("quirks") from a Quirks Server. These provide display-specific tuning (e.g. gamma ramps) on a per-monitor basis. Each Quirks Client handles downloading and writing a single file. The single Quirks Manager handles external requests for file paths, creates clients when downloads are needed, and manages their life cycle. For more info, see go/cros-quirks-client-dd (particularly the "Code Design" section). BUG=549349 TEST=Start up device that has a an icc file on the Quirks Server, check that file is downloaded to /var/cache/display_profiles. At next startup, the gamma correction in the icc file should be applied to the display (this will only be visible to the degree that the gamma correction is large enough to be noticeable; the correct functioning of the Quirks Client is primarily determined by the appearance of the file). Review URL: https://codereview.chromium.org/1528963002 Cr-Commit-Position: refs/heads/master@{#382962}
* Move ENABLE_HIDPI to new build flags systembrettw2016-02-241-0/+1
| | | | | | | | | | This define is only used in one source file. This takes the flag out of the global build configuration in GN and puts it in a new .gni file in //ui/base that interested parties can import. This flag then controls a define set in the new generated header. Review URL: https://codereview.chromium.org/1719343002 Cr-Commit-Position: refs/heads/master@{#377177}
* Fix ash_shell_with_content and mash_shell resource init.msw2016-02-171-0/+6
| | | | | | | | | | | | | | | | | Load ash's string and resource pak files; not Chrome's. TODO: Support other languages; drop 'test' from pak names. Remove unused ash/shell/content/shell_main_parts.* Remove unused chrome_browser_main_extra_parts_aura.cc include. Fix gn deps to support non-use_ash Win/Linux builds. BUG=584038 TEST=ash_shell_with_content and mash_shell --use-ash-sysui work on Win/Linux regardless of use_ash. R=sky@chromium.org Review URL: https://codereview.chromium.org/1694263004 Cr-Commit-Position: refs/heads/master@{#375763}
* Fix ash 'gn check' errors; whitelist target.msw2016-02-111-2/+62
| | | | | | | | | | | BUG=NONE TEST='gn check out/<DIR> ash' passes; ash target builds/runs as expected. R=sky@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/1684933002 Cr-Commit-Position: refs/heads/master@{#374832}
* Support building ash targets with use_ash=0 and use_aura=1.msw2016-02-101-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Support building/running ash_unittests and ash_shell_with_content. Change some build |use_ash| checks to |use_aura| (or remove them). Avoid the unspecified ash dependency on chrome resources! Explicitly load new ash_test_*.pak image/string resources instead. (avoids including ash_resources in chrome paks w/use_aura builds) Reserve more resource IDs for ash_strings to avoid overlap. (uses 244 IDs now; reserve 300 instead of 200 to fit existing) Reserve fewer content shell resource IDs, to avoid exceeding 3100. (uses 4 IDs now; reserve 150 instead of 250 to keep current total) https://code.google.com/p/chromium/codesearch#chromium/src/out/Debug/gen/content/shell/grit/shell_resources.h Use base::i18n::GetConfiguredLocale(), in several ash_unittests. (l10n_util::GetApplicationLocale fails IsLocaleAvailable('en-US')) (because it's not loading the chrome locale data anymore) (seems okay to pair with base::i18n::SetICUDefaultLocale) TODO: Fix ash_unittests failures/crahes (repros on ToT w/use_ash). TODO: Fix ash_shell_with_content crash (repros on ToT w/use_ash). TODO: Load ash resources; not 'common' in ash_shell_with_content. TODO: Exclude ash files from message_center crbug.com/585175. TODO: Support ash_test_resources_300_percent.pak, etc.? BUG=584038,585175 TEST=Building ash_unittests and ash_shell_with_content works with use_ash=0 and use_aura=1. R=oshima@chromium.org,dewittj@chromium.org,sky@chromium.org TBR=jam@chromium.org Review URL: https://codereview.chromium.org/1664013002 Cr-Commit-Position: refs/heads/master@{#374547}
* Introduce a 'host' target to allow loading datapack on 'host'.sdefresne2016-02-081-0/+1
| | | | | | | | | | | | | | | | | | As part of building Chrome on iOS, it is necessary to run a tool on the host to load datapack and generate output in a format defined by the platform (this is to support notifications). Introduce a standalone target that build on both 'host' and 'target' toolset that just build the support to load datapack. This require splitting ui/base/layout.cc in two in order to avoid introducing a dependency on skia. TBR=sky@chromium.org BUG=488296 Review URL: https://codereview.chromium.org/1671913002 Cr-Commit-Position: refs/heads/master@{#374137}
* ash: Unify various implementations of AshWindowTreeHost.sadrul2016-02-051-1/+1
| | | | | | | | | | | | | | | | | . Have a single implementation of AshWindowTreeHost::Create, with #ifdefs for platform-specific implementations. In a subsequent CL, I will introduce a factory that this would use (if set). . Rename AshWindowTreeHostOzone to be AshWindowTreeHostPlatform (since it uses ui::PlatformWindow, which is supported on non-ozone platforms too). . Implement Win and Unified versions of AshWindowTreeHost on top of AshWindowTreeHostPlatform. The Unified version uses ui::StubWindow. BUG=none Review URL: https://codereview.chromium.org/1662733005 Cr-Commit-Position: refs/heads/master@{#373750}
* allocator cleanup: remove dependencies on allocator from all targetsprimiano2016-01-281-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Overview of the cleanup: ------------------------ - In the context of the discussion in https://goo.gl/K2m649 our illustrious base/ owners suggested that having base being the only target depending on allocator (and having the other targets inherit that recursively) would be a more scalable solution, as opposite to having to remember to add an exec -> allocator to each target. - This base -> allocator dep landed in crrev.com/1616793003. - After that CL, until this point, many targets got two paths that lead to allocator: 1. The indirect one via base (content_shell -> base -> allocator) which is what we want to preserve. 2. The direct one (content_shell -> allocator) which is the inconsistent one we want to drop. This CL gets rid of all the instances of 2. The nice property of this sequencing of CLs is that the effect of this large change on the final .ninja files is minimal. See details below. Effect on the produced ninja files: ----------------------------------- GYP, Linux, static build: https://paste.ee/p/RaJLj Just some small reordering of include paths. Dropping --rdynamic (as expected) in keyboard_unittests GN, Linux, static build: https://paste.ee/p/zYtrQ Various targets lose the dependency on allocator.stamp (expected, the order is enforced by depending on base which depends on allocator.stamp) GN, Android (both component and static are similar): https://paste.ee/p/Iq6DD As above. GN, Linux, component build: https://paste.ee/p/jHUmv This is the most juicy change. As expected all the ODR goes away and random targets stop re-linking tcmalloc .o files. GYP, Win, static: https://paste.ee/p/j0IjL Extremely minimal changes: All.ninja stops depending on libcmt.lib. Sounds fine as base (which depends on that) is definitely depending on libcmt. GN, Win, static: https://paste.ee/p/Q6zTo Minimal change, like Linux GN, dropping dependencies on the .stamp files. BUG=564618 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1647453002 Cr-Commit-Position: refs/heads/master@{#372167}
* Introduce DisplayConfigurationControllerstevenjb2016-01-201-2/+0
| | | | | | | | | | | | | | This class provides a consistent interface for UI and extension API display configuration changes. It handles any animation transtions, extracting animation code from DisplayManager and WindowTreeHostManager. This also cleans up some of the code in DisplayOptionsHandler. BUG=576375 Review URL: https://codereview.chromium.org/1594683002 Cr-Commit-Position: refs/heads/master@{#370528}
* Rename DisplayConfiguratorAnimation to DisplayAnimatorstevenjb2016-01-161-2/+2
| | | | | | | | | | Also cleans up the class to new style guide some. BUG=576375 Review URL: https://codereview.chromium.org/1590463004 Cr-Commit-Position: refs/heads/master@{#369893}
* GN: Add assert that ash/BUILD.gn referenced only on supported platformsagrieve2016-01-051-0/+2
| | | | | | | | | | This helps to ensure that targets not supported on a platform are not included in the "all" target. BUG=None Review URL: https://codereview.chromium.org/1542633006 Cr-Commit-Position: refs/heads/master@{#367472}
* Break ash->content DEPS; keep in ash_with_content.msw2015-12-221-4/+0
| | | | | | | | | | | | | | | | | | Removes unnecessary GN/GYP dependency specifications. (these aren't needed to build the ash target, etc.) Keep entries as ash_with_content dependencies. Yields "No non-data paths found between these two targets" for both: $ gn path out/Debug //ash:ash //content $ gn path out/Debug //ash:ash //third_party/mojo/src/mojo/edk/embedder BUG=NONE TEST=Ash (and dependent targets) still build as intended. R=derat@chromium.org Review URL: https://codereview.chromium.org/1540963003 Cr-Commit-Position: refs/heads/master@{#366495}
* system tray ui change for AllowOnlyPolicyNetworksToConnectfqj2015-11-241-0/+1
| | | | | | | | | | | | This commit grays out unmanaged WiFis and button to joining other WiFis when AllowOnlyPolicyNetworksToConnect is true after user logged in, as well as adds the tooltip to tell users why. BUG=208378 Review URL: https://codereview.chromium.org/1469733003 Cr-Commit-Position: refs/heads/master@{#361319}
* ash: enable packed_resources in ash_shell_lib_with_content deps listtfarina2015-11-211-1/+1
| | | | | | | | | | | | Now that we have this target, there is no reason to have it commented out. This patch fixes the TODO(GYP) in there. BUG=None R=sky@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/1465963002 Cr-Commit-Position: refs/heads/master@{#361021}
* Run gn --format over all .gn filesagrieve2015-11-201-11/+10
| | | | | | | | | | | | | | | | The recent formatter alphebetizing change is causing a lot of noise in code reviews. Figured it'd be worth a clean-up CL. Exact command I ran: find . -name "*.gn*" -exec gn format --in-place "{}" \; TBR=ddorwin@chromium.org BUG=554928 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1464873002 Cr-Commit-Position: refs/heads/master@{#360891}
* components: Add Exosphere component.reveman2015-11-191-0/+4
| | | | | | | | | | | | | | | | | | Exosphere is a set of display server classes for Chromium that can be used for building a display server on top of Ash, the Chrome Compositor and the GpuMemoryBuffer framework. The classes and interfaces are inspired by the Wayland protocol and reference implementation of a display server that uses the Wayland protocol and server library is provided in the wayland/ sub-directory. BUG=549781 TEST=components_unittests --gtest_filter=ServerTest.*:SurfaceTest.*:BufferTest.*:DisplayTest.*:ShellSurfaceTest.*:SharedMemoryTest.* Review URL: https://codereview.chromium.org/1412093006 Cr-Commit-Position: refs/heads/master@{#360672}
* Fix ash_shell_with_content linkage in component GN build.dpranke2015-11-071-0/+1
| | | | | | | | | TBR=thakis@chromium.org, alemate@chromium.org, sky@chromium.org BUG=552180 Review URL: https://codereview.chromium.org/1435453004 Cr-Commit-Position: refs/heads/master@{#358514}
* ash: Add unit testing coverage of DisplayColorManagerrobert.bradford2015-11-051-0/+1
| | | | | | | | | | | | | | | As part of the effort to enable more advanced display color management this CL introduces testing of the existing VCGT support. The .icc files included here were copied from ChromeOS: http://crrev.com/48950c9cb35671c59f9f63316683357c8792b79d BUG=495196 TEST=ash_unittests:DisplayColorManagerTest Review URL: https://codereview.chromium.org/1430633003 Cr-Commit-Position: refs/heads/master@{#358061}
* This CL replaces user_manager::UserID with AccountId.alemate2015-11-031-0/+2
| | | | | | | | | | | | | | | | | This CL replaces API of user_manager::UserManager, thus modifying API of all child objects, and all calls to UserManager. This is part of transition to AccountId. BUG=468875 TEST=manual Committed: https://crrev.com/cd06408625de9e0d5cf4c7c1ede412cb5c82542b Cr-Commit-Position: refs/heads/master@{#357119} Review URL: https://codereview.chromium.org/1412813003 Cr-Commit-Position: refs/heads/master@{#357512}
* Revert of This CL replaces user_manager::UserID with AccountId. (patchset ↵rjkroege2015-10-301-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | #12 id:210001 of https://codereview.chromium.org/1412813003/ ) Reason for revert: breaks the GN build on windows: FAILED: E:/b/depot_tools/python276_bin/python.exe gyp-win-tool link-wrapper environment.x86 False link.exe /nologo /OUT:ash_unittests.exe /PDB:ash_unittests.exe.pdb @ash_unittests.exe.rsp test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: __thiscall AccountId::AccountId(class AccountId const &)" (??0AccountId@@QAE@ABV0@@Z) referenced in function "public: virtual class AccountId __thiscall ash::test::MockUserInfo::GetAccountId(void)const " (?GetAccountId@MockUserInfo@test@ash@@UBE?AVAccountId@@XZ) test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: bool __thiscall AccountId::operator==(class AccountId const &)const " (??8AccountId@@QBE_NABV0@@Z) referenced in function "public: virtual void __thiscall ash::test::TestSessionStateDelegate::SwitchActiveUser(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?SwitchActiveUser@TestSessionStateDelegate@test@ash@@UAEXABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const & __thiscall AccountId::GetUserEmail(void)const " (?GetUserEmail@AccountId@@QBEABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ) referenced in function "public: virtual void __thiscall ash::test::TestSessionStateDelegate::SwitchActiveUser(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?SwitchActiveUser@TestSessionStateDelegate@test@ash@@UAEXABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) test_session_state_delegate.obj : error LNK2019: unresolved external symbol "public: static class AccountId __cdecl AccountId::FromUserEmail(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?FromUserEmail@AccountId@@SA?AV1@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) referenced in function "class AccountId __cdecl ash::test::`anonymous namespace'::GetAccountIdFromEmail(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (?GetAccountIdFromEmail@?A0x8b8d8028@test@ash@@YA?AVAccountId@@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z) ash_unittests.exe : fatal error LNK1120: 4 unresolved externals ninja: build stopped: subcommand failed. Original issue's description: > This CL replaces user_manager::UserID with AccountId. > > This CL replaces API of user_manager::UserManager, thus modifying API of all > child objects, and all calls to UserManager. > > This is part of transition to AccountId. > > BUG=468875 > TEST=manual > > Committed: https://crrev.com/cd06408625de9e0d5cf4c7c1ede412cb5c82542b > Cr-Commit-Position: refs/heads/master@{#357119} TBR=jochen@chromium.org,achuith@chromium.org,bshe@chromium.org,rogerta@chromium.org,sky@chromium.org,stevenjb@chromium.org,alemate@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468875 Review URL: https://codereview.chromium.org/1425093004 Cr-Commit-Position: refs/heads/master@{#357219}
* This CL replaces user_manager::UserID with AccountId.alemate2015-10-301-0/+1
| | | | | | | | | | | | | | This CL replaces API of user_manager::UserManager, thus modifying API of all child objects, and all calls to UserManager. This is part of transition to AccountId. BUG=468875 TEST=manual Review URL: https://codereview.chromium.org/1412813003 Cr-Commit-Position: refs/heads/master@{#357119}
* Extract content dependency from keyboard codeben2015-10-101-0/+4
| | | | | | | | | | | | | Move content specific stuff to content subdir. KeyboardControllerProxy -> KeyboardUI Restructure targets. R=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1392713002 Cr-Commit-Position: refs/heads/master@{#353441}
* Prune metro bits from the ash testsrobertshield2015-10-051-12/+1
| | | | | | | | BUG=332504 Review URL: https://codereview.chromium.org/1379683002 Cr-Commit-Position: refs/heads/master@{#352388}
* Introduce ShellContentState.ben2015-10-031-1/+13
| | | | | | | | | R=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1382793002 Cr-Commit-Position: refs/heads/master@{#352262}
* Move some files around in ash in preparation for splitting content stuff ↵ben2015-09-251-15/+17
| | | | | | | | | | | some more. TBR=sky@chromium.org http://crbug.com/332504 Review URL: https://codereview.chromium.org/1363643004 Cr-Commit-Position: refs/heads/master@{#350941}
* Annotate GN executables and shared_libraries with sanitizer deps.brettw2015-08-311-0/+1
| | | | | | | | | | | | | | | | | These are needed to link in asan/lsan/etc. mode. GYP injects these automatically but GN doesn't have automatic dependency injection. All tests and components (which cover the vast majority of such targets in actual use) are templates which add these dependencies already, so most of the time it never comes up. Only a few of these changes are actually necessary to link all tests run on the asan bot (which is also what engineers will typically build, since almost nobody will build all in asan mode). But to reduce confusion from linker errors in asan mode, I annotated all executables and shared libraries I could find with the sanitizer dependency. I moved a config out of a target in yasm, and sorted a fews deps on other targets. TBR=xhwang@chromium.org (widevine) TBR=achuith@chromium.org (tools/perf, tools/telemetry) Review URL: https://codereview.chromium.org/1318343003 Cr-Commit-Position: refs/heads/master@{#346490}
* Enable sticky key unit tests under Ozone.kpschoedel2015-08-121-2/+2
| | | | | | Review URL: https://codereview.chromium.org/1272383005 Cr-Commit-Position: refs/heads/master@{#343023}
* ash: Add a base-class for interactive-ui-tests in ash.sadrul2015-08-101-0/+19
| | | | | | | | | | | Introduce AshInteractiveUITestBase for setting up gl, resources, aura for interactive ui-tests that live in ash. BUG=none Review URL: https://codereview.chromium.org/1282433003 Cr-Commit-Position: refs/heads/master@{#342622}
* ash: Remove ash_shell_unittests target.Sadrul Habib Chowdhury2015-08-041-22/+0
| | | | | | | | | | | | | | ash_shell_unittests target has only a single test, and none of the bots actually run it. The test isn't particularly useful either. So remove the test and the target. BUG=none R=oshima@chromium.org TBR=ben@ for toplevel and build/ changes, thestig@ for tools/valgrind/ change Review URL: https://codereview.chromium.org/1266193004 . Cr-Commit-Position: refs/heads/master@{#341775}
* Annotate large GN targets for precompiled headersbrettw2015-07-281-1/+4
| | | | | | | | | | | | | | | | | | Adds the precompiled header config to most large-ish targets in the build, but keeps the config a no-op (so no precompiled headers will be used but this can bw switched with a one-line change). Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them. I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower). For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static. This is a reland of https://codereview.chromium.org/1250273002/ with the config disabled for easier re-landing and iterating CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=dpranke Review URL: https://codereview.chromium.org/1258273004 Cr-Commit-Position: refs/heads/master@{#340728}
* Revert "Add precompiled headers to GN build for large targets."dpranke2015-07-281-4/+1
| | | | | | | | | | | | | | | | | This reverts commit 8f3218985dde74063ccc362da47803be163f3165. It looks like this may have broken incremental builds on Win. TBR=brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1256223003 Cr-Commit-Position: refs/heads/master@{#340620}
* Add precompiled headers to GN build for large targets.brettw2015-07-271-1/+4
| | | | | | | | | | | | | | | | Turns on precompiled header support in the GN build on Windows, and adds the precompiled header config to most large-ish targets in the build. Removes Windows files from the precompiled header. This does not seem to affect the build speed much because most Chrome files don't depend on Windows any more. And windows.h injects typedefs and defines that conflict with some third party libraries and prevent using precompiled headers for those targets or any target that includes them. I counted ~50 files or bigger as large. The 50 file threshold is based on some previous approximate measurements (since the precompile step is an extra per-target compile, it can actually make small targets compile slower). For borderline cases, I added the precompiled header flag if I thought it was likely to have more files added, and didn't add it if I thought the target was likely to be static. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1250273002 Cr-Commit-Position: refs/heads/master@{#340535}
* Reland "Load and apply a vcgt table from an ICC file to the internal display"robert.bradford2015-05-061-0/+1
| | | | | | | | | | | | | | | | | | | | | When the command line switch --internal-display-color-profile-file is provided load the given ICC file using qcms and extract the VCGT data. Use this VCGT data to apply a gamma ramp to change the output on the internal display using drmModeCrtcSetGammaRamp. Original CL: https://codereview.chromium.org/1028563003/ Reason for reland: Linux ChromiumOS GN (dbg) build broke (missing qcms dep in ash/BUILD.gn) BUG=471749 TEST=On a link_freon device add the command line option to load a sample ICC file (e.g. Bluish.icc to give a blue tint) and observe on startup that the internal display is blue tinted. TBR=sievers@chromium.org Review URL: https://codereview.chromium.org/1119113004 Cr-Commit-Position: refs/heads/master@{#328514}
* Rework GN sessions componentbrettw2015-04-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | The main problem with the sessions build was that the test_support source set depended on the core source set, which had symbols set up to be exported. This caused duplicate symbols when both test_support and sessions_content were linked into the same target (like Chrome unit_tests does). This removes the TODOs about the list of sources being duplicated. This actually confused me and set me back anbout an hour on this patch. The only thing is there are different targets for ios and non-iOS, and these files need to be shared. I don't think this is a problem or weird. The comment implied to me there were multiple static libraries in the same build sharing those sources, which is not the case. I renamed the GN targets and did some cleanup to be consistent. There's no need for separate naming under iOS and non-iOS, for example. Removes the SESSIONS_IMPLEMENTATION define for the test support target. This is not a component and should instead import those symbols from the component. Implements a skeleton versions of sessions_ios. The content/test change is unrelated but the bot threw an error (not sure why this doesn't always happen). But the gpu_blink dependency is definitely used, so adding it should be correct. Adds a missing dependency on the win_window target. This is in the GYP build but missing in GN. I also renamed this target to use the typical naming convention while I was there. This adds an export on the SessionsBackend class. This is depended on by the sessions test support target. I speculate the GYP build doesn't run into this because the sessions test support is a static library and the object file that references this symbol is actually unused, so it is stripped. In GN it's a source set so won't get this stripping. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Review URL: https://codereview.chromium.org/1114543005 Cr-Commit-Position: refs/heads/master@{#327778}
* ash: Add missing xdisplaycheck dependency for testspkotwicz2015-03-101-0/+2
| | | | | | | | | BUG=465344 TEST=linux_chromium_clobber_rel_ng does not block new ash_unittests from landing Review URL: https://codereview.chromium.org/985853004 Cr-Commit-Position: refs/heads/master@{#319786}
* Remove link_chrome_on_windows GN flag.brettw2015-03-021-36/+34
| | | | | | | | This flag was used to disable linking when the bots were too behind. It's not needed any more. Review URL: https://codereview.chromium.org/974543002 Cr-Commit-Position: refs/heads/master@{#318795}
* Move chromeos::device_event_log into components.reillyg2015-02-201-0/+1
| | | | | | | | | | | | | There is device code in Chrome on non-Chrome OS platforms that would benefit from a user-visible log dashboard like chrome://device-log. This change moves the code for managing the device log into a component and enables chrome://device-log on all versions of Chrome. BUG=452609 Review URL: https://codereview.chromium.org/919183002 Cr-Commit-Position: refs/heads/master@{#317406}
* Update existing uses of /wd4267 to use the GN configbrettw2015-02-191-4/+2
| | | | | | | | | | This is the size_t to integer conversion warning. Using the config prevents flag duplication and is clearer to read. Minor updates to Win64 build, including some fixes for size_t to int conversions. Review URL: https://codereview.chromium.org/929793006 Cr-Commit-Position: refs/heads/master@{#317162}
* Sort GYP and GN files under ashsatorux2015-02-171-2/+2
| | | | | | | | | | | | For tools/sort_sources.py to be useful, existing GYP and GN files should be sorted. BUG=456014 TEST=everything should build as before Review URL: https://codereview.chromium.org/929873002 Cr-Commit-Position: refs/heads/master@{#316514}
* Split ui/base/ime into a new component (reland with windows GN fix)spang2015-02-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The IME code in ui/base/ime depends on ui/ozone to support keyboard control (via the InputController interface). This dependency is currently missing from the build. Unfortunately, we cannot simply add this dependency, because ui/ozone depends on code from ui/base/cursor and ui/base/resource (for cursor bitmaps). Break this cycle by componentizing ui/base/ime & add a dependency from the new ui/base/ime component to ui/ozone. This also helps clean things up a bit because iOS builds ui/base but not ui/base/ime. So there is already a fault line here. The handful of IME tests are left as part of ui_base_unittests. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) TBR=jam Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 Cr-Commit-Position: refs/heads/master@{#314815} Review URL: https://codereview.chromium.org/889323003 Cr-Commit-Position: refs/heads/master@{#314860}
* Revert of Split ui/base/ime into a new component (patchset #4 id:60001 of ↵ccameron2015-02-051-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://codereview.chromium.org/889323003/) Reason for revert: Windows builds failing with ERROR at //ui/base/ime/BUILD.gn:170:5: Undefined variable for +=. libs += [ "imm32.lib" ] ^--- I don't have something with this name in scope now. http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/4403/steps/gn/logs/stdio (perhaps missed a .gn update)? Original issue's description: > Split ui/base/ime into a new component > > The IME code in ui/base/ime depends on ui/ozone to support keyboard > control (via the InputController interface). This dependency is > currently missing from the build. > > Unfortunately, we cannot simply add this dependency, because ui/ozone > depends on code from ui/base/cursor and ui/base/resource > (for cursor bitmaps). > > Break this cycle by componentizing ui/base/ime & add a dependency > from the new ui/base/ime component to ui/ozone. > > This also helps clean things up a bit because iOS builds ui/base > but not ui/base/ime. So there is already a fault line here. > > The handful of IME tests are left as part of ui_base_unittests. > > BUG=445627 > TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && > ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) > TBR=jam > > Committed: https://crrev.com/2321ca1b99c1a8e9a90e48a9cd50f6446a7e5e82 > Cr-Commit-Position: refs/heads/master@{#314815} TBR=sky@chromium.org,thakis@chromium.org,jam@chromium.org,yukishiino@chromium.org,spang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=445627 Review URL: https://codereview.chromium.org/895363005 Cr-Commit-Position: refs/heads/master@{#314823}
* Split ui/base/ime into a new componentspang2015-02-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | The IME code in ui/base/ime depends on ui/ozone to support keyboard control (via the InputController interface). This dependency is currently missing from the build. Unfortunately, we cannot simply add this dependency, because ui/ozone depends on code from ui/base/cursor and ui/base/resource (for cursor bitmaps). Break this cycle by componentizing ui/base/ime & add a dependency from the new ui/base/ime component to ui/ozone. This also helps clean things up a bit because iOS builds ui/base but not ui/base/ime. So there is already a fault line here. The handful of IME tests are left as part of ui_base_unittests. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) TBR=jam Review URL: https://codereview.chromium.org/889323003 Cr-Commit-Position: refs/heads/master@{#314815}
* ash: Make gesture_detection dependency unconditionalspang2015-02-041-1/+1
| | | | | | | | | | | | | | | This is needed by long_press_affordance_handler.cc, which is built unconditionally. It's already unconditional in the GYP build. This fixes an unresolved reference in the linux chromiumos ozone build. BUG=445627 TEST=gn gen out_gn_ozone --args='os="chromeos" use_ozone=true is_component_build=true' && ninja -C out_gn_ozone chrome ozone_unittests (along with other needed changes) Review URL: https://codereview.chromium.org/869323005 Cr-Commit-Position: refs/heads/master@{#314485}
* Move AccelerometerType from ui to chromeosjonross2015-02-041-2/+0
| | | | | | | | | | | | | | | Move the accelerometer code from ui/accelerometer to chromeos/accelerometer/. This allows for the last dependency from chromeos/ to ui/ to be removed. Create a new utility class in ui/chromeos for vector based accelerometer work. Update code that uses the accelerometer. TEST=All existing accelerometer tests. MaximizeModeControllerTest, ScreenOrientationTest, DisplayPreferencesTest BUG=431865 Review URL: https://codereview.chromium.org/875403004 Cr-Commit-Position: refs/heads/master@{#314448}
* ash: Add missing dependency on events_ozonespang2015-02-031-1/+4
| | | | | | | | | | | | | | | This is needed by display_controller.cc in ozone builds (to set display rotation & scale to apply to cursor movement). These dependencies are needed to enable strict checking of undefined symbols in the shared_library build. BUG=445627 TEST=build chrome for link_freon via simplechrome Review URL: https://codereview.chromium.org/898543006 Cr-Commit-Position: refs/heads/master@{#314429}
* Remove more targets from GN Windows build.brettw2015-02-021-34/+36
| | | | | | | | | | Targets will be removed until the bot is green. TBR=dpranke Review URL: https://codereview.chromium.org/886323002 Cr-Commit-Position: refs/heads/master@{#314104}
* Move the test template to //testing/test.gni (part 2)qsr2015-01-211-0/+1
| | | | | | | | | | | | This CL move the test target from build/config/BUILDCONFIG.gn to testing/test.gni It also update the test template to automatically build an apk on Android. R=cjhopman@chromium.org,brettw@chromium.org Review URL: https://codereview.chromium.org/824263004 Cr-Commit-Position: refs/heads/master@{#312396}
* GN: Add -Wl,-z defs on linux and fix errorsjamesr2015-01-211-1/+9
| | | | | | | | | | | | This tells the linker to resolve symbols for shared libraries at build time, not run time. This alerts developers much earlier that their dependencies are underspecified. BUG=371125 Review URL: https://codereview.chromium.org/843583006 Cr-Commit-Position: refs/heads/master@{#312317}
* Fix some errors in windows GN build of ash.vchigrin2015-01-201-1/+5
| | | | | | Review URL: https://codereview.chromium.org/826293006 Cr-Commit-Position: refs/heads/master@{#312239}
* Add GN files for src/win8.vchigrin2015-01-171-4/+4
| | | | | | Review URL: https://codereview.chromium.org/796903004 Cr-Commit-Position: refs/heads/master@{#312036}
generated by cgit v1.1 at 2024-09-24 01:23:29 +0000