summaryrefslogtreecommitdiffstats
path: root/ash/accelerators/nested_dispatcher_controller_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* ash: Use base::MessageLoop.xhwang@chromium.org2013-04-301-1/+1
| | | | | | | | | BUG=236029 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/14283019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197444 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194589 "Revert 194578 "Add ash SessionStateDelegate""bartfab@google.com2013-04-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The CL turned out to be innocent, the bots turned green without the revert. > Revert 194578 "Add ash SessionStateDelegate" > > > Add ash SessionStateDelegate > > > > This CL refactors the ShellDelegate by adding a SessionStateDelegate to > > which methods dealing with the session state can be moved. This cleans up > > the huge ShellDelegate interface and paves the way for further Chrome OS > > multiprofile work which will need to add several new methods related to > > the session state. > > > > This CL is only the first step. Several other methods should also move to > > SessionStateDelegate but I do not want to overburden a single CL. > > > > BUG=None > > TEST=Manual and browser/unit tests > > > > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) > > > > Review URL: https://codereview.chromium.org/14295008 > > TBR=bartfab@google.com > > Review URL: https://codereview.chromium.org/14200034 TBR=gavinp@chromium.org Review URL: https://codereview.chromium.org/14200038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194602 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194578 "Add ash SessionStateDelegate"gavinp@chromium.org2013-04-171-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | > Add ash SessionStateDelegate > > This CL refactors the ShellDelegate by adding a SessionStateDelegate to > which methods dealing with the session state can be moved. This cleans up > the huge ShellDelegate interface and paves the way for further Chrome OS > multiprofile work which will need to add several new methods related to > the session state. > > This CL is only the first step. Several other methods should also move to > SessionStateDelegate but I do not want to overburden a single CL. > > BUG=None > TEST=Manual and browser/unit tests > > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) > > Review URL: https://codereview.chromium.org/14295008 TBR=bartfab@google.com Review URL: https://codereview.chromium.org/14200034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194589 0039d316-1c4b-4281-b951-d872f2087c98
* Add ash SessionStateDelegatebartfab@google.com2013-04-171-3/+3
| | | | | | | | | | | | | | | | | | | | This CL refactors the ShellDelegate by adding a SessionStateDelegate to which methods dealing with the session state can be moved. This cleans up the huge ShellDelegate interface and paves the way for further Chrome OS multiprofile work which will need to add several new methods related to the session state. This CL is only the first step. Several other methods should also move to SessionStateDelegate but I do not want to overburden a single CL. BUG=None TEST=Manual and browser/unit tests TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) Review URL: https://codereview.chromium.org/14295008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194578 0039d316-1c4b-4281-b951-d872f2087c98
* Add a message pump for ChromeOS Embedded.rjkroege@chromium.org2013-04-061-2/+2
| | | | | | | | | | | A message pump implementation for embedded ChromeOS. BUG=180666 Review URL: https://chromiumcodereview.appspot.com/12546010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@192703 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop aura: Break aura::Window::SetParent in two.erg@chromium.org2012-11-281-5/+3
| | | | | | | | | | | | | | | | | | | | | | | | | Previously, SetParent will query a global StackingClient object if NULL is passed to it. Since we want different behavior on the desktop and on ash, we need to break that. It has been replaced with two methods: - SetParentTo(), which takes an aura window and does the parenting. - SetDefaultParentByTargetRoot(), which takes a RootWindow as context and asks the StackingClient on said RootWindow where it should parent the window. The problem is that people have relied for a long time on what amounts to a global variable. This is the first of several patches that pass around a context RootWindow. This patch focuses on ash/ unittests mostly. Later patches will focus on threading context through Widget creation. The last patch in this series will pull out the global stacking client interface and add DCHECKs so NULL can't be passed to either of these methods on Window. BUG=161882 Review URL: https://chromiumcodereview.appspot.com/11421006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170049 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Split some bits out of event_constants into event_utils.sadrul@chromium.org2012-11-051-0/+1
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/11367084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165951 0039d316-1c4b-4281-b951-d872f2087c98
* events: Move some files into ui/base/events/sadrul@chromium.org2012-09-041-1/+1
| | | | | | | | | BUG=none TBR=jam@chromium.org Review URL: https://chromiumcodereview.appspot.com/10917075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare a bunch of ash tests for workspace2. With Workspace2 you can'tsky@chromium.org2012-08-161-9/+3
| | | | | | | | | | | | | | add to the default container, instead you need to go through the StackingClient. BUG=137342 TEST=none R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10857021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151848 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetContainer to take a root windowoshima@chromium.org2012-06-111-2/+4
| | | | | | | | | | | Update the use of GetContainer to use the correct root window. BUG=123160 TEST=no functional change. all tests must pass. Review URL: https://chromiumcodereview.appspot.com/10540076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141384 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetRootWindow() -> GetPrimaryRootWindow()oshima@chromium.org2012-05-251-8/+8
| | | | | | | | | BUG=123160 TEST=none Review URL: https://chromiumcodereview.appspot.com/10442017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138950 0039d316-1c4b-4281-b951-d872f2087c98
* accelerators: Remove deprecated Accelerator ctor that takes booleans.tfarina@chromium.org2012-05-181-1/+1
| | | | | | | | | BUG=128242 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10399085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137957 0039d316-1c4b-4281-b951-d872f2087c98
* Process all global shortcuts for Ash after InputMethodEventFilter.yusukes@google.com2012-04-241-1/+0
| | | | | | | | | | | | | This CL is for crbug.com/123856 (Aura shell applies accelerators without giving apps the option of handling key events). Currently, shortcuts for IME/layout switching (Shift+Alt, Ctrl+space, and so on) are processed before InputMethodEventFilter, and other Ash global shortcuts are processed after the filter. This is for ensuring that the IME shortcuts always work even if an IME (or an IME extension - http://dev.chromium.org/developers/design-documents/extensions/proposed-changes/apis-under-development/input-method-editor) tries to consume the shortcuts. However, this strategy is not compatible with crbug.com/123856. In order to fix crbug.com/123856, we sometimes have to process an Ash global shortcut key (including IME ones) after the key is passed to a web page. This CL modifies accelerator_table.cc and shell.cc so that they process IME shortcuts after InputMethodEventFilter, and also simplifies ash/accelerators/ and ui/base/accelerators/accelerator_manager.cc by removing code for processing pre-IME shortcuts. BUG=123856 TEST=ran aura_shell_unittests and ui_unittests Review URL: https://chromiumcodereview.appspot.com/10155015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133642 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate win/x dispatchersoshima@chromium.org2012-04-091-13/+6
| | | | | | | | | | BUG=116282 TEST=no functional change. All tests should pass. Review URL: http://codereview.chromium.org/9958152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131412 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stops_event_propagation from Window, since it's broken.ben@chromium.org2012-03-231-8/+5
| | | | | | | | | | | | Changes it to be implemented by the Aura client, via a new interface EventClient. The client can determine whether or not a given window and its subtree can receive events. I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell. http://crbug.com/119347 TEST=none Review URL: https://chromiumcodereview.appspot.com/9788001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128553 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128503 - Remove stops_event_propagation from Window, since it's broken.jam@chromium.org2012-03-231-5/+8
| | | | | | | | | | | | | | | | Changes it to be implemented by the Aura client, via a new interface EventClient. The client can determine whether or not a given window and its subtree can receive events. I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell. http://crbug.com/119347 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128328 Review URL: https://chromiumcodereview.appspot.com/9788001 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/9808068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128508 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stops_event_propagation from Window, since it's broken.ben@chromium.org2012-03-231-8/+5
| | | | | | | | | | | | | Changes it to be implemented by the Aura client, via a new interface EventClient. The client can determine whether or not a given window and its subtree can receive events. I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell. http://crbug.com/119347 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=128328 Review URL: https://chromiumcodereview.appspot.com/9788001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128503 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 128328 - Remove stops_event_propagation from Window, since it's broken.ben@chromium.org2012-03-221-5/+8
| | | | | | | | | | | | | | | Changes it to be implemented by the Aura client, via a new interface EventClient. The client can determine whether or not a given window and its subtree can receive events. I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell. http://crbug.com/119347 TEST=none Review URL: https://chromiumcodereview.appspot.com/9788001 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/9808044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128338 0039d316-1c4b-4281-b951-d872f2087c98
* Remove stops_event_propagation from Window, since it's broken.ben@chromium.org2012-03-221-8/+5
| | | | | | | | | | | | Changes it to be implemented by the Aura client, via a new interface EventClient. The client can determine whether or not a given window and its subtree can receive events. I also cleaned up the way screen locking is entered/exited via the delegate, and some stuff in ash/shell. http://crbug.com/119347 TEST=none Review URL: https://chromiumcodereview.appspot.com/9788001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128328 0039d316-1c4b-4281-b951-d872f2087c98
* Set correct event type to |accelerator| in AcceleratorDispatcher::Dispatch().yusukes@chromium.org2012-03-061-3/+14
| | | | | | | | | BUG=116907 TEST=manual, ran aura_shell_unittests Review URL: http://codereview.chromium.org/9609017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125133 0039d316-1c4b-4281-b951-d872f2087c98
* Translates events so that accelerators which require ↵pkotwicz@chromium.org2012-03-051-11/+53
| | | | | | | | | | | | | | | ET_TRANSLATED_KEY_RELEASE and ET_TRANSLATED_KEY_PRESS are triggered. Translation is always done, so nested dispatcher should not be used for any widgets which have editable content. BUG=113247 TEST=NestedDispatcherTest.AcceleratorHandled Review URL: http://codereview.chromium.org/9538015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124963 0039d316-1c4b-4281-b951-d872f2087c98
* When locking the screen via Ctrl-Shift-L from wrench menu,pkotwicz@chromium.org2012-02-291-0/+127
| | | | | | | | | | | | login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Review URL: http://codereview.chromium.org/9381008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124127 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 123984 for check_deps failure - When locking the screen via Ctrl-Shift-Lmattm@chromium.org2012-02-281-128/+0
| | | | | | | | | | | | | | | | | | | | from wrench menu, login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123500 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123669 Review URL: https://chromiumcodereview.appspot.com/9381008 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/9507001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123992 0039d316-1c4b-4281-b951-d872f2087c98
* When locking the screen via Ctrl-Shift-L from wrench menu,pkotwicz@chromium.org2012-02-281-0/+128
| | | | | | | | | | | | | | | | login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123500 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123669 Review URL: https://chromiumcodereview.appspot.com/9381008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123984 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 123669 because it broke builds:sadrul@chromium.org2012-02-251-126/+0
| | | | | | | | | | | | | | | | | | | --- When locking the screen via Ctrl-Shift-L from wrench menu, login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123500 Review URL: https://chromiumcodereview.appspot.com/9381008 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/9471001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123670 0039d316-1c4b-4281-b951-d872f2087c98
* When locking the screen via Ctrl-Shift-L from wrench menu,pkotwicz@chromium.org2012-02-251-0/+126
| | | | | | | | | | | | | | login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=123500 Review URL: https://chromiumcodereview.appspot.com/9381008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123669 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 123500 - When locking the screen via Ctrl-Shift-L from wrench menu,pkotwicz@chromium.org2012-02-241-127/+0
| | | | | | | | | | | | | | | login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Review URL: https://chromiumcodereview.appspot.com/9381008 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/9460011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123511 0039d316-1c4b-4281-b951-d872f2087c98
* When locking the screen via Ctrl-Shift-L from wrench menu,pkotwicz@chromium.org2012-02-241-0/+127
login screen menus do not work, because wrench menu is not fully closed. Made Noop events always make it to inner loop in the nested_dispatcher such that the menu can fully close itself via noop event. Bug=113247 Testing=Manual Review URL: https://chromiumcodereview.appspot.com/9381008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123500 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-15 02:36:12 +0000