summaryrefslogtreecommitdiffstats
path: root/ash/accelerators
Commit message (Collapse)AuthorAgeFilesLines
* Add DOM3 'location' attribute support to Chrome for Chrome OS.yusukes@chromium.org2012-06-251-0/+8
| | | | | | | | | | | | | WebInputEventFactory::keyboardEvent() functions in WebKit/chromium/src/android/WebInputEventFactory.cpp, mac/WebInputEventFactory.mm, and gtk/WebInputEventFactory.cpp have recently been fixed and they now use VKEY_[LR]XXX instead of VKEY_XXX when the key pressed is Shift, Control, or Alt (https://bugs.webkit.org/show_bug.cgi?id=86694 ). WebKit/chromium/src/win/WebInputEventFactory.cpp is now being fixed (https://bugs.webkit.org/show_bug.cgi?id=89742). This CL fixes Aura X11 equivalent of WebInputEventFactory.cpp so that Aura X11 could support the DOM3 attribute. BUG=122074 TEST=ran content_unittests and aura_shell_unittests + manual Review URL: https://chromiumcodereview.appspot.com/10627014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143930 0039d316-1c4b-4281-b951-d872f2087c98
* Screen Magnifier: Adds option UI and enables accelerators.yoshiki@chromium.org2012-06-243-21/+23
| | | | | | | | | | | | | Add option UI on chrome://settings to enable & disable screen magnifier, and enable the accelerators of screen magnifier "Ctrl + brightness keys (F6/F7)". Option UI part is almost same as the patch of high contrast mode. https://chromiumcodereview.appspot.com/10408085. BUG=126880 TEST=manual test Review URL: https://chromiumcodereview.appspot.com/10635019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143841 0039d316-1c4b-4281-b951-d872f2087c98
* Make the window minimize/maximize shortcuts restore the window from launcher ↵mazda@chromium.org2012-06-221-2/+10
| | | | | | | | | | | | when thre is no active window. BUG=133337 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10633022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143594 0039d316-1c4b-4281-b951-d872f2087c98
* Changes constant type from double to float.yoshiki@chromium.org2012-06-221-1/+1
| | | | | | | | | | | | | It will fix the build error on win_aura. http://build.chromium.org/p/chromium/buildstatus?builder=Win%20Aura&number=15690 BUG=none TEST=none TBR=yoshiki Review URL: https://chromiumcodereview.appspot.com/10642013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143518 0039d316-1c4b-4281-b951-d872f2087c98
* Full-screen Magnifier: Support warping the cursor on the edgeyoshiki@chromium.org2012-06-223-0/+32
| | | | | | | | | | | | | With this CL, a magnified region will moved when the cursor on the edge. Only on debug build, we can test the this magnifier with "Ctrl + {" and "Ctrl + }" shortcut. These shortcut keys are temporary. These will be removed just after either the shortcuts or setting UI are fixed. BUG=126880 TEST=manual test (even with high-DPI and external display) Review URL: https://chromiumcodereview.appspot.com/10388141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143514 0039d316-1c4b-4281-b951-d872f2087c98
* Disable shortcut key "alt +" for maximizing window under full screen mode.jennyz@google.com2012-06-211-1/+1
| | | | | | | | | BUG=133865 TEST=Alt+ should do nothing under fullscreen mode. Review URL: https://chromiumcodereview.appspot.com/10630016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143480 0039d316-1c4b-4281-b951-d872f2087c98
* Make Alt+Tab accelerator behavior compatible to Windows.yusukes@chromium.org2012-06-207-9/+84
| | | | | | | | | | | | Handle Alt+Tab and Shift+Alt+Tab very early in Ash unless the current target window is in the full screen mode. BUG=132724 TEST=manual + aura_shell_unittests Review URL: https://chromiumcodereview.appspot.com/10562028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143137 0039d316-1c4b-4281-b951-d872f2087c98
* Support normalized form of the Shift+Alt+ET_KEY_RELEASED accelerator.yusukes@google.com2012-06-202-4/+48
| | | | | | | | | | | This fixes the regression (crbug.com/133266) caused by crrev.com/142209. BUG=133266 TEST=aura_shell_unittests + manual Review URL: https://chromiumcodereview.appspot.com/10572012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143116 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add an about:flags entry for debug keyboard shortcuts.thakis@chromium.org2012-06-193-17/+41
| | | | | | | | | | BUG=131734 TEST=Enable "Debugging keyboard shortcuts" on about:flags. ctrl-shift-home now toggles DPIness at runtime even in release builds. Review URL: https://chromiumcodereview.appspot.com/10582021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143054 0039d316-1c4b-4281-b951-d872f2087c98
* Fix typo in accelerator_controller_unittest.cc.yusukes@google.com2012-06-181-1/+1
| | | | | | | | | | | | CycleBackwardLinear is Shift+F5, not Ctrl+F5. BUG=None TEST=ran aura_shell_unittests TBR=derat@chromium.org Review URL: https://chromiumcodereview.appspot.com/10568004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142677 0039d316-1c4b-4281-b951-d872f2087c98
* Do not toggle Applist with Search key press when accessibility is enabled.yusukes@chromium.org2012-06-162-0/+18
| | | | | | | | | | BUG=132296 TEST=manual + aura_shell_unittests Review URL: https://chromiumcodereview.appspot.com/10543158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142590 0039d316-1c4b-4281-b951-d872f2087c98
* Add Extended Desktop mode behind --ash-extended-desktop flag.oshima@chromium.org2012-06-152-3/+2
| | | | | | | | | | | | A lot of stuff still doesn't work but you can create and use a window on 2nd display. MonitorController now owns all root windows. BUG=123160 TEST=see http://codereview.chromium.org/10536187/ Review URL: https://chromiumcodereview.appspot.com/10535149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142350 0039d316-1c4b-4281-b951-d872f2087c98
* Handle Ctrl+F1 and Ctrl+F2 correctly even when no browser window is available.yusukes@chromium.org2012-06-143-0/+24
| | | | | | | | | | | | | - Remove accelerators from ash/focus_cycler.cc and chrome/browser/ui/views/accelerator_table.cc. Instead, handle it in ash/accelerator/accelerator_controller.cc. - Do not try to focus a browser window in ash/focus_cycler.cc when it's not available. Unit tests added. BUG=129307 TEST=ran aura_shell_unittests + manually checked Review URL: https://chromiumcodereview.appspot.com/10545132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142107 0039d316-1c4b-4281-b951-d872f2087c98
* Make the shortcut of opening content browser global.mazda@chromium.org2012-06-134-6/+18
| | | | | | | | | | BUG=124232 TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10535140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142021 0039d316-1c4b-4281-b951-d872f2087c98
* Disable minimize window shortcut key for the full screen window, which will ↵jennyz@chromium.org2012-06-131-1/+4
| | | | | | | | | | | | crash for minimizing a full screen pepper window. BUG=131709 TEST=alt- won't minize window if the window is in full screen mode. Review URL: https://chromiumcodereview.appspot.com/10544144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142020 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r141871.oshima@chromium.org2012-06-131-5/+6
| | | | | | | | | | | | | | | Add RootWindowController that keeps per root window state. Cleanup Shell::Init(). Separated initialization that are specific to shell, root window and primary display. I also did small cleanup in detor. I'll do more cleanups when I have a chance. BUG=123160 TEST=no functional change. all tests should pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141871 Review URL: https://chromiumcodereview.appspot.com/10546024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141881 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r141871 "Add RootWindowController that keeps per root window state."oshima@chromium.org2012-06-131-6/+5
| | | | | | | | | | | | This reverts commit d696be73d92539286ad99338a26ceffe320be7cc. TBR=oshima@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10545154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141875 0039d316-1c4b-4281-b951-d872f2087c98
* Add RootWindowController that keeps per root window state.oshima@chromium.org2012-06-131-5/+6
| | | | | | | | | | | | Cleanup Shell::Init(). Separated initialization that are specific to shell, root window and primary display. I also did small cleanup in detor. I'll do more cleanups when I have a chance. BUG=123160 TEST=no functional change. all tests should pass. Review URL: https://chromiumcodereview.appspot.com/10546024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141871 0039d316-1c4b-4281-b951-d872f2087c98
* Consume Ctrl+Alt+/ in ash/accelerators/accelerator_controller.cc.yusukes@chromium.org2012-06-131-1/+4
| | | | | | | | | | | Currently, the accelerator handler function in accelerator_controller.cc is called twice for a single Ctrl+Alt+/ press. Ctrl+Alt+/ is also sent to a web page. These issues are almost user-invisible, but still better to be fixed. BUG=None TEST=try Review URL: https://chromiumcodereview.appspot.com/10548018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141861 0039d316-1c4b-4281-b951-d872f2087c98
* Fix and re-enable AcceleratorControllerTest.GlobalAccelerator.mazda@chromium.org2012-06-121-10/+13
| | | | | | | | | | BUG=127538 TEST=aura_shell_unittests --gtest_filter="AcceleratorControllerTest.GlobalAccelerator" Review URL: https://chromiumcodereview.appspot.com/10541127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141779 0039d316-1c4b-4281-b951-d872f2087c98
* Use a #fefefe solid color wallpaper background before user login for GAIA ↵bshe@chromium.org2012-06-121-3/+4
| | | | | | | | | | | | | login flow. BUG=130635 TEST= Enable new OOBE login from about:flags and relaunch browser, in the loggin screen, the background color should be white (#FEFEFE). Review URL: https://chromiumcodereview.appspot.com/10492003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141596 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetContainer to take a root windowoshima@chromium.org2012-06-113-32/+36
| | | | | | | | | | | Update the use of GetContainer to use the correct root window. BUG=123160 TEST=no functional change. all tests must pass. Review URL: https://chromiumcodereview.appspot.com/10540076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141384 0039d316-1c4b-4281-b951-d872f2087c98
* ash/chromeos: "Search" key to toggle app list.xiyuan@chromium.org2012-06-083-7/+2
| | | | | | | | | | | | | | - "Search" key to toggle app list; - Remove old "Ctrl+Search" shortcut for app list; - Remove ShellDelegate::Search since it no longer in use; BUG=131703 TEST=Verify "Search" key toggles app list and old "Ctrl+Search" stops working. Review URL: https://chromiumcodereview.appspot.com/10534053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141290 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Allow snapping/minimizing a fullscreen/maximized window using accelerators.sadrul@chromium.org2012-06-073-37/+119
| | | | | | | | | | | | Includes some refactoring to make it simpler to test specific accelerator actions without sending the accelerator keys. BUG=131114 TEST=aura_shell_unittests Review URL: https://chromiumcodereview.appspot.com/10541058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141078 0039d316-1c4b-4281-b951-d872f2087c98
* Allow taking screenshots for all of minitors at the same time.mukai@chromium.org2012-06-071-4/+6
| | | | | | | | | | | | | | | It contains a fix of screenshot filename too. Because multiple screenshot taking happens in a very short time period, the filename could be same for all of the monitors. Thus we need to rename them by specifying some suffix. Here I just added numbers (2), (3), ... BUG=130718 TEST=none Review URL: https://chromiumcodereview.appspot.com/10514002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140939 0039d316-1c4b-4281-b951-d872f2087c98
* Add EnvEventFilter to filter events before root window process eventoshima@chromium.org2012-06-061-1/+0
| | | | | | | | Factor out CursorManager from RootWindowEventFilter Review URL: https://chromiumcodereview.appspot.com/10444107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140714 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: ash: Improved window maximize/restore animationsjamescook@chromium.org2012-06-061-3/+3
| | | | | | | | | | | | | | | | | | | | | | This implements a cross-fade while scaling the window between the new and old size. When a maximize animation is triggered we grab the window's current layer (and those of child windows) and start an animation on those layers to scale them up to full size. Simultaneously, we install a fresh layer for the window, set the bounds to fill the workspace, and tell the window to paint. We scale down that layer to match the window size at the start of the animation, then fade it in while scaling it up to full size. The restore animation essentially does the above in reverse. However, we always keep the higher resolution layer on top (it looks better), and we always keep the lower layer fully opaque (so the desktop doesn't bleed through). The animation is aborted if the window is closed mid-animation or the GPU process crashes mid-animation. The animation does not yet work for app windows, see crbug.com/131293 BUG=116618 TEST=aura_shell_unittests WorkspaceManagerTest and WindowAnimationsTest, trigger slow window animation with shift-click on maximize widget and close window during animation, kill -9 the GPU process during the animation and observe that Chrome recovers Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139494 Review URL: https://chromiumcodereview.appspot.com/10444014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140698 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Shift+space accelerator.yusukes@chromium.org2012-06-052-6/+1
| | | | | | | | | | BUG=129257 TEST=ran aura_shell_unittests and unit_tests Review URL: https://chromiumcodereview.appspot.com/10441067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140473 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Load user custom wallpaper after browser crash"bshe@chromium.org2012-06-041-3/+5
| | | | | | | | | | | | | | | | | | | Reland issue 10459003. It got reverted because of aura shell unittests failing. TBR=nkostylev@chromium.org, sky@chromium.org, jhawkins@chromium.org BUG=129810 TEST= 1. Login 2. Set custom wallpaper for desktop background 3. Trigger a chrome crash (about://inducebrowsercrashforrealz) 4. Observe the desktop wallpaper 5. Go to "Set wallpaper" settings dialog and look for the custom added wallpaper thumbnail Verify that custom wallpaper restored after chrome crash. Review URL: https://chromiumcodereview.appspot.com/10518003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140343 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 140312 - Load user custom wallpaper after browser crash.acolwell@chromium.org2012-06-041-5/+3
| | | | | | | | | | | | | | | | | | | | BUG=129810 TEST= 1. Login 2. Set custom wallpaper for desktop background 3. Trigger a chrome crash (about://inducebrowsercrashforrealz) 4. Observe the desktop wallpaper 5. Go to "Set wallpaper" settings dialog and look for the custom added wallpaper thumbnail Verify that custom wallpaper restored after chrome crash. Review URL: https://chromiumcodereview.appspot.com/10459003 TBR=bshe@chromium.org Review URL: https://chromiumcodereview.appspot.com/10511014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140329 0039d316-1c4b-4281-b951-d872f2087c98
* Load user custom wallpaper after browser crash.bshe@chromium.org2012-06-041-3/+5
| | | | | | | | | | | | | | | | | BUG=129810 TEST= 1. Login 2. Set custom wallpaper for desktop background 3. Trigger a chrome crash (about://inducebrowsercrashforrealz) 4. Observe the desktop wallpaper 5. Go to "Set wallpaper" settings dialog and look for the custom added wallpaper thumbnail Verify that custom wallpaper restored after chrome crash. Review URL: https://chromiumcodereview.appspot.com/10459003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140312 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome version of monitor configuration codedisher@chromium.org2012-06-023-1/+12
| | | | | | | | | | | | | | | | | | | | New MonitorConfigurator class interprets events (ctrl-F4, display add/remove, and brightness-related CRTC state changes). Ctrl-F4 events come in through the AcceleratorController. Display add/remove events are interpretted by MonitorChangeObserverX11. CRTC enable/disable events related to power management come over DBus and are interpretted by the new OutputObserver class. Note the the chromeos/monitor/DEPS change can be removed once the now-unused code is retired from powerd (since that is the only reason for a DBus call-out). Valgrind suppressions.txt was updated because this change re-orders our initial XRR calls such that a different top-level call is blamed for its leak. BUG=chromium:126493 TEST=Manually tested with an additional display and mode switching on Lumpy. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140031 Review URL: https://chromiumcodereview.appspot.com/10384103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140203 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more root window dependenciesoshima@chromium.org2012-06-012-2/+3
| | | | | | | | | | BUG=123160 TEST=no functional change. all tests should pass. Review URL: https://chromiumcodereview.appspot.com/10441146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140053 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 140031 - Chrome version of monitor configuration codewjia@chromium.org2012-06-013-12/+1
| | | | | | | | | | | | | | | | | | | New MonitorConfigurator class interprets events (ctrl-F4, display add/remove, and brightness-related CRTC state changes). Ctrl-F4 events come in through the AcceleratorController. Display add/remove events are interpretted by MonitorChangeObserverX11. CRTC enable/disable events related to power management come over DBus and are interpretted by the new OutputObserver class. BUG=chromium:126493 TEST=Manually tested with an additional display and mode switching on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10384103 TBR=disher@chromium.org Review URL: https://chromiumcodereview.appspot.com/10459076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140035 0039d316-1c4b-4281-b951-d872f2087c98
* Chrome version of monitor configuration codedisher@chromium.org2012-06-013-1/+12
| | | | | | | | | | | | | | | | New MonitorConfigurator class interprets events (ctrl-F4, display add/remove, and brightness-related CRTC state changes). Ctrl-F4 events come in through the AcceleratorController. Display add/remove events are interpretted by MonitorChangeObserverX11. CRTC enable/disable events related to power management come over DBus and are interpretted by the new OutputObserver class. BUG=chromium:126493 TEST=Manually tested with an additional display and mode switching on Lumpy. Review URL: https://chromiumcodereview.appspot.com/10384103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140031 0039d316-1c4b-4281-b951-d872f2087c98
* Support Home, Search, Favorites, Refresh, Stop, Back, and Forward keys on an ↵yusukes@chromium.org2012-06-011-0/+4
| | | | | | | | | | | | | | external keyboard. Supporting these keys would be nice since Stumpy might be used with a keyboard with such keys. BUG=127209 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10449064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139994 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 139494 - ash: Improved window maximize/restore animationsjamescook@chromium.org2012-06-011-3/+3
| | | | | | | | | | | | | | | | | | | | | This implements a cross-fade while scaling the window between the new and old size. When a maximize animation is triggered we grab the window's current layer (and those of child windows) and start an animation on those layers to scale them up to full size. Simultaneously, we install a fresh layer for the window, set the bounds to fill the workspace, and tell the window to paint. We scale down that layer to match the window size at the start of the animation, then fade it in while scaling it up to full size. The restore animation essentially does the above in reverse. However, we always keep the higher resolution layer on top (it looks better), and we always keep the lower layer fully opaque (so the desktop doesn't bleed through). The animation is aborted if the window is closed mid-animation or the GPU process crashes mid-animation. BUG=116618,130688 TEST=aura_shell_unittests WorkspaceManagerTest and WindowAnimationsTest, trigger slow window animation with control-shift-click on maximize widget and close window during animation, kill -9 the GPU process during the animation and observe that Chrome recovers Review URL: https://chromiumcodereview.appspot.com/10444014 TBR=jamescook@chromium.org Review URL: https://chromiumcodereview.appspot.com/10454107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139959 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing french keyboard handlingskuhne@chromium.org2012-05-303-16/+8
| | | | | | | | | | BUG=129017 TEST=none Review URL: https://chromiumcodereview.appspot.com/10452042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139678 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare to support Ash notification tray:stevenjb@google.com2012-05-303-5/+6
| | | | | | | | | | | | | | * Separate status area widget from system tray * Support adding multiple trays to status area widget * Move the background animation into a common base class BUG=124914 TEST=Status area should look and behave the same as before. TBR=ben for ash/ OWNER Review URL: https://chromiumcodereview.appspot.com/10447040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139671 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Improved window maximize/restore animationsjamescook@chromium.org2012-05-301-3/+3
| | | | | | | | | | | | | | | | | | This implements a cross-fade while scaling the window between the new and old size. When a maximize animation is triggered we grab the window's current layer (and those of child windows) and start an animation on those layers to scale them up to full size. Simultaneously, we install a fresh layer for the window, set the bounds to fill the workspace, and tell the window to paint. We scale down that layer to match the window size at the start of the animation, then fade it in while scaling it up to full size. The restore animation essentially does the above in reverse. However, we always keep the higher resolution layer on top (it looks better), and we always keep the lower layer fully opaque (so the desktop doesn't bleed through). The animation is aborted if the window is closed mid-animation or the GPU process crashes mid-animation. BUG=116618 TEST=aura_shell_unittests WorkspaceManagerTest and WindowAnimationsTest, trigger slow window animation with control-shift-click on maximize widget and close window during animation, kill -9 the GPU process during the animation and observe that Chrome recovers Review URL: https://chromiumcodereview.appspot.com/10444014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139494 0039d316-1c4b-4281-b951-d872f2087c98
* Handle more browser commands in ash.mazda@chromium.org2012-05-254-2/+42
| | | | | | | | | | | | | | | This CL modifies the shell accelerator controller to handle the shortcuts for the following browser commands so that they work with no browser window shown. - IDC_NEW_TAB - IDC_RESTORE_TAB - IDC_SHOW_BOOKMARK_MANAGER BUG=124232,120642 TEST=Checked all the shortcuts worked properly with no browser window shown. aura_shell_unittests Review URL: https://chromiumcodereview.appspot.com/10414064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138982 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetRootWindow() -> GetPrimaryRootWindow()oshima@chromium.org2012-05-256-25/+25
| | | | | | | | | BUG=123160 TEST=none Review URL: https://chromiumcodereview.appspot.com/10442017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138950 0039d316-1c4b-4281-b951-d872f2087c98
* Make the keyboard overlay handle close shortcuts in JavaScript code.mazda@chromium.org2012-05-241-1/+1
| | | | | | | | | | | | | The aim of this change is to remove the dependency to chrome/browser/ui/views/accelerator_table.cc as a preparation for moving the keyboard overlay code to src/ash. BUG=124222 TEST=Manually checked that the keyboard overlay is closed with shrotcut keys. Review URL: https://chromiumcodereview.appspot.com/10434012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138903 0039d316-1c4b-4281-b951-d872f2087c98
* Allow Control+Shift+Q on lock screen.yusukes@chromium.org2012-05-235-18/+48
| | | | | | | | | | | | Usually, when the screen is locked and the status area at the bottom right corner of the screen is not focused, Control+Shift+Q is handled by chrome/browser/chromeos/login/webui_login_view.cc. But when the status area is focused, Control+Shift+Q is handled by Ash, accelerator_controller.cc. BUG=120953 TEST=aura_shell_unittests + manual: focus the area and press C+S+Q on both login and lock screens Review URL: https://chromiumcodereview.appspot.com/10388230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138509 0039d316-1c4b-4281-b951-d872f2087c98
* Adding four bezel gesturesskuhne@chromium.org2012-05-192-0/+6
| | | | | | | | | | | | BUG=126061, 126060, 123167 TEST=Unit test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137968 Review URL: https://chromiumcodereview.appspot.com/10383108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138000 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 137968 - Adding four bezel gestureszea@chromium.org2012-05-182-6/+0
| | | | | | | | | | | | | | | Reverted due to compile failure on Linux CrOS BUG=126061, 126060, 123167 TEST=Unit test Review URL: https://chromiumcodereview.appspot.com/10383108 TBR=skuhne@chromium.org Review URL: https://chromiumcodereview.appspot.com/10412012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137970 0039d316-1c4b-4281-b951-d872f2087c98
* Adding four bezel gesturesskuhne@chromium.org2012-05-182-0/+6
| | | | | | | | | | BUG=126061, 126060, 123167 TEST=Unit test Review URL: https://chromiumcodereview.appspot.com/10383108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137968 0039d316-1c4b-4281-b951-d872f2087c98
* accelerators: Remove deprecated Accelerator ctor that takes booleans.tfarina@chromium.org2012-05-182-69/+66
| | | | | | | | | BUG=128242 R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10399085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137957 0039d316-1c4b-4281-b951-d872f2087c98
* Let Chrome app handle Ash accelerators first if the app is launched as a window.yusukes@chromium.org2012-05-177-16/+122
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Currently, Ash accelerators are handled at a very early stage, right after a native key event is received by aura::RootWindowHost. This CL change the way of handling Ash accelerators as follows to make it more App friendly: 1. If no window is focused, handle an Ash accelerator immediately in ash/accelerators/accelerator_filter.cc in the same way as before. 2. Otherwise, do not handle it in ash/accelerators/accelerator_filter.cc but let a custom views::FocusManager handle it (see ash/shell.cc). There are 3 types of scenarios here depending on the type of the focused window: 2-a. If the focused window is a browser, and the browser is not for an app, let the custom focus manager pre-handle Ash accelerators before passing it to the browser (see PreHandleKeyboardEvent() in chrome/browser/ui/views/frame/browser_view.cc). 2-b. If the focused window is a browser, and the browser is for an app, let the app handle Ash accelerators first (see chrome/browser/ui/views/frame/browser_view.cc). If the accelerator is not consumed by the app, let the custom focus manager handle it. 2-c. If the focused window is not a browser, let the window handle Ash accelerators first. If the accelerator is not consumed by the window, then let the custom focus manager handle it. This means a WebView without the chrome/browser/ui/ layer can handle Ash accelerators first whenever needed. Other changes: chrome/browser/ui/views/frame/browser_view.cc: Support ET_KEY_RELEASED accelerators in BrowserView::PreHandleKeyboardEvent(). ui/views/focus/focus_manager.cc: Support ET_KEY_RELEASED accelerators. Also fix code for handing VKEY_MENU so that the Shift+Alt+ET_KEY_RELEASED accelerator for Ash could be handled correctly. This CL depends on http://codereview.chromium.org/10377158/ (by jochen), https://chromiumcodereview.appspot.com/10388023, http://codereview.chromium.org/10389035/, and https://chromiumcodereview.appspot.com/10332051/, and should not be submitted until the 4 CLs are landed. BUG=123856 TEST=ran aura_shell_unittests TEST=manual; launch Chromoting app as a window, connect to a Chromoting server, focus Chrome on the remote machine, press Ctrl-n, confirm a new window is opened on the remote machine. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135791 Review URL: https://chromiumcodereview.appspot.com/10134036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137629 0039d316-1c4b-4281-b951-d872f2087c98
* Use single "modifiers" field rather than boolean fields.mukai@chromium.org2012-05-164-91/+97
| | | | | | | | | | BUG=128199 TEST=aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10382178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137474 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 19:58:25 +0000