summaryrefslogtreecommitdiffstats
path: root/ash/accelerators
Commit message (Collapse)AuthorAgeFilesLines
* Linux/ChromeOS Chromium style checker cleanup, ash/ edition.rsleevi@chromium.org2013-02-071-2/+2
| | | | | | | | | | | Automated clean up of style checker errors that were missed due to the plugin not being executed on implementation files. BUG=115047 Review URL: https://chromiumcodereview.appspot.com/12218027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181180 0039d316-1c4b-4281-b951-d872f2087c98
* Make minimize shortcut not repeative.mtomasz@chromium.org2013-02-061-0/+1
| | | | | | | | | | | This solves the problem with flickering screen while holding the ctrl-m key for a longer time. TEST=Hold ctrl-m for 5 seconds. BUG=174256 Review URL: https://codereview.chromium.org/12213004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180916 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Do not allow minimizing windows in login screen.sadrul@chromium.org2013-02-061-1/+1
| | | | | | | | | | | Minimizing windows (e.g. network proxy window) in a login screen do not make much sense. And it causes unpredictable behaviour. So do not allow minimizing windows in login screen. BUG=167386 Review URL: https://codereview.chromium.org/12220026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180900 0039d316-1c4b-4281-b951-d872f2087c98
* Magnifier: Use Ctrl+BRIGHTNESS_DOWN/UP as debugging shortcut keys instead of ↵yoshiki@chromium.org2013-02-051-2/+3
| | | | | | | | | | | | | Ctrl+F6/F7 Now, even on chromeos_chrome on linux workstation, we get VKEY_BRIGHTNESS_DOWN/UP (not VKEY_F6/F7) key codes when pressing F6/F7 keys. BUG=none TEST=manual Review URL: https://chromiumcodereview.appspot.com/12185013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180642 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add an accelerator to clear the HUD.sadrul@chromium.org2013-01-313-0/+10
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/12093094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180005 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Bind Ctrl-M to minimize windowjamescook@chromium.org2013-01-301-0/+2
| | | | | | | | | | BUG=172629 TEST=manual, it works and appears in the keyboard overlay (Ctrl-Alt-/) TBR=xiyuan for trivial change to chrome/browser/chromeos/resources Review URL: https://chromiumcodereview.appspot.com/12079053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179717 0039d316-1c4b-4281-b951-d872f2087c98
* Fix window rotation animation not ending cleanlyjamescook@chromium.org2013-01-301-3/+1
| | | | | | | | | | | | | | | cros: Sometimes the animation would leave windows partially rotated because it grabbed the current transform (and hence rotation) of the windows rather than the target. If an animation was already playing this could compute an incorrect ending transform. Also cleaned up some includes. BUG=173139 TEST=manual, hit Ctrl-Alt-Shift-F3 repeatedly, windows should always return to original position Review URL: https://chromiumcodereview.appspot.com/12083004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179712 0039d316-1c4b-4281-b951-d872f2087c98
* cros: Fix crash with screen rotation animationjamescook@chromium.org2013-01-271-2/+4
| | | | | | | | | | | | | | | Ensure the interpolated_transform_ member is initialized in the constructor such that OnGetTarget() can be called before OnStart(). I added the animation delegate to the constructor as we need it to initialize the transformation matrix. BUG=172328 TEST=manual, Ctrl-Alt-Shift-F3 should spin the windows and not crash Review URL: https://chromiumcodereview.appspot.com/12087009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@179082 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Use the Pass() idiom of scoped_ptr to pass the ownership of delegates.tfarina@chromium.org2013-01-231-3/+3
| | | | | | | | | | | | | This was requested in this code review: https://chromiumcodereview.appspot.com/11150020, but at that time I just updated the single case. Now this fixes all the other cases. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/12042026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178208 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Make the touch HUD fullscreen.sadrul@chromium.org2013-01-183-0/+10
| | | | | | | | | | | Show the touch HUD fullscreen by default. Allow it to be changed to 10% scale, or invisible, using alt-ctrl-i accelerators. BUG=170758 Review URL: https://codereview.chromium.org/11867018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177710 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes the problem that many shortcuts change the current tab without closing ↵sschmitz@chromium.org2013-01-161-0/+32
| | | | | | | | | | | | | | | | the current context menu. In addition shortcuts execute within the current message loop (created for the context menu). This could conceivably cause nested message loops which is undesirable. Fix: Shortcuts generated by Ctrl/Alt plus either a letter, number of the tab key, will now close the currently open context menu and its message loop *before* they are processed. BUG=168910 TEST=manual 1. Bring up any context menu 2. Press Ctrl t (or 1-9, tab) for tab navigation 3. Observe that the context menu is closed first. Review URL: https://chromiumcodereview.appspot.com/11881034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177038 0039d316-1c4b-4281-b951-d872f2087c98
* add command-line flag to enable brigntness controloshima@chromium.org2013-01-151-1/+4
| | | | | | | | | | | This will be used to enable the brightness control for kiev. BUG=chrome-os-partner:17150 TEST=none Review URL: https://chromiumcodereview.appspot.com/11889028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177000 0039d316-1c4b-4281-b951-d872f2087c98
* Limit how quickly a user can change display configurationoshima@chromium.org2013-01-121-26/+2
| | | | | | | | | | | | | | Add --ash-disable-display-change-limitter to disable throttling This doesn't fix the gpu crash, but we should throttle how quickly a user can change the display settings anyway. BUG=168950 TEST=manually tested on device. See bug for repro step. Review URL: https://chromiumcodereview.appspot.com/11882006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176595 0039d316-1c4b-4281-b951-d872f2087c98
* More work to make ash_unittests pass when we require context.erg@chromium.org2013-01-091-1/+1
| | | | | | | | | | | With the context checking DCHECK, ash_unittests and unit_tests now run on chromeos. BUG=161882 Review URL: https://chromiumcodereview.appspot.com/11801027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175892 0039d316-1c4b-4281-b951-d872f2087c98
* Show more info in print window commmandoshima@chromium.org2012-12-191-5/+10
| | | | | | | | | | | | | | | | - show entire hierarchy rather than just default container - print address to make it easy to find which window you're dealing with in the debugger. - print "" if no name is set - visibility and bounds are added - put [] for active window as it became hard to catch on screen. BUG=none TEST=none Review URL: https://codereview.chromium.org/11565043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173925 0039d316-1c4b-4281-b951-d872f2087c98
* Don't fire Alt-Search binding when Alt-Search is being used for accessing a ↵danakj@chromium.org2012-12-183-3/+16
| | | | | | | | | | modifer key. BUG=165327 Review URL: https://codereview.chromium.org/11580005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173616 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Search-key modifiers for extended key shortcuts.danakj@chromium.org2012-12-183-68/+9
| | | | | | | | | | | | | | | | | | | | | | | | | We use the Search-key as a modifier to disable existing shortcuts that do not use the Search key. So Alt+Backspace still generates a Delete, but Search+Alt+Backspace generates Alt+Backspace. And, Search+Backspace will also generate Delete. Search acts as a modifier for accessing all of the extended keys: Home, End, Delete, Page up, Page down, Insert. This removes the command line flag entirely, making everything work in a way that does not need a flag or a preference option. Tests: unit_tests:EventRewriterTest.TestRewriteExtendedKeys unit_tests:EventRewriterTest.TestRewriteFunctionKeys unit_tests:EventRewriterTest.TestRewriteExtendedKeysWithSearchRemapped BUG=162268 NOTRY=true Review URL: https://codereview.chromium.org/11578044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173607 0039d316-1c4b-4281-b951-d872f2087c98
* events: Update key-event handlers to not return EventResult.sadrul@chromium.org2012-12-143-9/+9
| | | | | | | | BUG=163618 Review URL: https://codereview.chromium.org/11570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173171 0039d316-1c4b-4281-b951-d872f2087c98
* Show an a11y notification only if the feature was enabled by its shortcut keyyoshiki@chromium.org2012-12-132-9/+11
| | | | | | | | | | | | | | | | | | Currently, only spoken feedback has a shortcut key, so this CL supports only it. Major Changes: - Add a |notify| argument to ToggleSpokenFeedback() methods to pass the flag whether the tray should show a notification or not. - (in ash_system_tray_delegate.cc) Use chrome notifications instead of watching pref change to observe the accessibility feature status change. BUG=158288 TEST=manual R=zork@chromium.org,derat@chromium.org TBR=darin@chromium.org,dbeam@chromium.org #TBRing for small changes in chrome/browser/automation and chrome/browser/ui/webui/options Review URL: https://codereview.chromium.org/11510005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172821 0039d316-1c4b-4281-b951-d872f2087c98
* Make Shell::launcher_model() / GetLauncherDelegate privateoshima@chromium.org2012-12-132-42/+9
| | | | | | | | | | | Move SwitchToWindow impl to Launcher BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11558031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172803 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup] rename tray_delegate -> system_tray_delegateoshima@chromium.org2012-12-122-8/+8
| | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11476034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172566 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Ctrl+M for the Chrome OS Files appkaznacheev@chromium.org2012-12-114-11/+3
| | | | | | | | | BUG=152769 Review URL: https://chromiumcodereview.appspot.com/11530009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172353 0039d316-1c4b-4281-b951-d872f2087c98
* - Show app list on 2nd launcheroshima@chromium.org2012-12-111-3/+4
| | | | | | | | | | | | | | | | - Share the launcher mode/delegate in multiple launchers. This CL moves the launcher mode/delegate to Shell - Initialize Display objects before creating RootWindow for 2nd as it'll be used during creation. I'll add tests in next CL, as it crashes without https://codereview.chromium.org/11515004/. BUG=145978 TEST=none Review URL: https://chromiumcodereview.appspot.com/11465037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172310 0039d316-1c4b-4281-b951-d872f2087c98
* [Launcher per display] Removed Shell::status_area_widget(), system_tray()oshima@chromium.org2012-12-101-3/+8
| | | | | | | | | | | | HasPrimaryStatusArea/GetPrimarySystemTray for login screen which will have only one tray/status area on primary BUG=145978 TEST=none Review URL: https://chromiumcodereview.appspot.com/11476033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172169 0039d316-1c4b-4281-b951-d872f2087c98
* Make Shift+Alt+S to show the system tray bubble.mazda@chromium.org2012-12-063-11/+7
| | | | | | | | | BUG=157983 Review URL: https://chromiumcodereview.appspot.com/11443026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171645 0039d316-1c4b-4281-b951-d872f2087c98
* Add the magnifier shortcut keys (Ctrl+F6/F7) for debugging.yoshiki@chromium.org2012-12-051-0/+3
| | | | | | | | | | | | | Original shortcut keys (Ctrl+Alt+F6/F7) are often the keys to switch VTs and cannot be used as the magnifier shortcuts on almost all Linux workstations. This CL adds additional shortcut keys only for debug mode. BUG=none TEST=manual Review URL: https://codereview.chromium.org/11421223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171121 0039d316-1c4b-4281-b951-d872f2087c98
* Don't disable Caps Lock when Shift+<non-modifier-key> is pressed and then ↵yusukes@chromium.org2012-12-042-9/+34
| | | | | | | | | | | Shift is released first. BUG=163804 TEST=ran new tests in accelerator_controller_unittest.cc. tested manually too. Review URL: https://codereview.chromium.org/11419306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170895 0039d316-1c4b-4281-b951-d872f2087c98
* Use rewriting to make ChromeOS keyboard F<number> keys produce extended ↵danakj@chromium.org2012-11-303-170/+92
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | keycodes. This makes the ChromeOS keyboard F<number> keys produce keycodes such as BROWSER_BACK, VOLUME_UP, POWER, etc. We can then remove special-cases for ChromeOS accelerator bindings, and allow the same bindings to work on all platforms including ChromeOS. The ChromeOS keyboard, and external keyboards with these extra keys will also rely on and fire the same bindings for these keys, unifying the code path. The other advantage of this, is that now ChromeOS does not need to bind F<number> keys in a non-standard way. So, an external keyboard plugged into a Chromebook can still use the F<number> keys in the same way as they would when it was plugged into their desktop. This behaviour isn't yet possible, as the event rewritter is not aware if the event came from the ChromeOS keyboard or an external keyboard, but is a 1-line change once this information is known. Lastly, when the Search key acts as Function key option is enabled from https://codereview.chromium.org/11421055/ then Search-1 through Search-0 produce the keycode F1 through F10, and Search-- and Search-= produce F11 and F12. This allows applications to easily rely on these keys and consume them the same way on desktop as on a Chromebook. R=yusukes@chromium.org BUG=162268 TEST=unit_tests:EventRewriter.TestRewriteFunctionKeys Depends on: https://codereview.chromium.org/11421055/ Review URL: https://chromiumcodereview.appspot.com/11417144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170415 0039d316-1c4b-4281-b951-d872f2087c98
* Immersive mode reveals the tabstrip/omnibox on top of web contentjamescook@chromium.org2012-11-301-7/+5
| | | | | | | | | | | | | | | | | ImmersiveModeController reparents the tabstrip and toolbar to a new RevealView during the slide-down reveal of the top views. This allows the view hierarchy in the non-immersive-mode case to remain as it is, reducing the likelihood this change will break Windows. BrowserViewLayout stops caching pointers to tabstrip and toolbar as it can access them directly from BrowserView. BUG=162310 Review URL: https://chromiumcodereview.appspot.com/11411250 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170385 0039d316-1c4b-4281-b951-d872f2087c98
* CrOS: Add hotkey for disabling the GPU watchdog timer.backer@chromium.org2012-11-303-1/+9
| | | | | | | | | | | | This works around the fact that switching to VT1 on CrOS prevents swaps from clearing, which hangs the GPU process, which causes the GPU process to get killed. Sometimes in order to diagnose a problem, we want to switch to VT1. This hotkey allows a developer to do that. TEST=by hand; Ctrl-Shift-Alt-G; then go about://gpuhang; UI should freeze and not unstick after 10 seconds BUG=chromium-os:28253 Review URL: https://chromiumcodereview.appspot.com/11348099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170309 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Remove unnecessary NULL checks for delegates.derat@chromium.org2012-11-291-9/+8
| | | | | | | | | | | | This removes some checks for the ash::ShellDelegate and ash::SystemTrayDelegate, neither which can be NULL now. BUG=none Review URL: https://chromiumcodereview.appspot.com/11421135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170222 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Refactor some code that snaps windows.sadrul@chromium.org2012-11-291-19/+2
| | | | | | | | | | | | Introduce SnapSizer::SnapWindow to allow snapping a window on the left/right edges. Use this API in a few places (e.g. from the accelerator controller, gesture handler etc.) BUG=151267 Review URL: https://codereview.chromium.org/11434004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170113 0039d316-1c4b-4281-b951-d872f2087c98
* Desktop aura: Break aura::Window::SetParent in two.erg@chromium.org2012-11-283-11/+8
| | | | | | | | | | | | | | | | | | | | | | | | | Previously, SetParent will query a global StackingClient object if NULL is passed to it. Since we want different behavior on the desktop and on ash, we need to break that. It has been replaced with two methods: - SetParentTo(), which takes an aura window and does the parenting. - SetDefaultParentByTargetRoot(), which takes a RootWindow as context and asks the StackingClient on said RootWindow where it should parent the window. The problem is that people have relied for a long time on what amounts to a global variable. This is the first of several patches that pass around a context RootWindow. This patch focuses on ash/ unittests mostly. Later patches will focus on threading context through Widget creation. The last patch in this series will pull out the global stacking client interface and add DCHECKs so NULL can't be passed to either of these methods on Window. BUG=161882 Review URL: https://chromiumcodereview.appspot.com/11421006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170049 0039d316-1c4b-4281-b951-d872f2087c98
* Add power-user keyboard mode for ChromeOS with Search key acting as a ↵danakj@chromium.org2012-11-273-21/+111
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | typical Fn key. All new behaviour in this CL is hidden behind the command line flag --enable-chromebook-function-key. Currently the keyboard shortcuts for PageUp, PageDown, Delete, etc are all accessed by holding Alt or Alt+Control. This prevents you from using Alt or Control as a modifier to the desired keyboard shortcut, which prevents access to advanced keyboard shortcuts in applications, and even normal shortcuts such as Control-End to move to the end of the document. This adds a command line flag --enable-chromebook-function-key that adds a checkbox to the Keyboard settings UI. When the checkbox is enabled, the Search key replaces Alt/Control as the modifier used to access advanced keyboard shortcuts such as Home, Delete, etc. The following shortcuts become accessible with the Search key: Search+Up => Page Up Search+Down => Page Down Search+Left => Home Search+Right => End Search+Backspace => Delete R=yusukes@chromium.org BUG=162268 TEST=unit_tests:EventRewriter.TestRewriteBackspaceAndArrowKeys TEST=ash_unittests:AcceleratorControllerTest.GlobalAcceleratorsToggleAppListWithoutSearchAsModifier TEST=ash_unittests:AcceleratorControllerTest.GlobalAcceleratorsToggleAppListWithSearchAsModifier Review URL: https://chromiumcodereview.appspot.com/11421055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169741 0039d316-1c4b-4281-b951-d872f2087c98
* ui: Add default implementations for EventHandler interface.sadrul@chromium.org2012-11-202-20/+0
| | | | | | | | | | | | This allows getting rid of a whole bunch of noop implementations, and makes it easier to add new event types to be dispatched through the EventDispatcher to EventHandlers. BUG=159632 Review URL: https://codereview.chromium.org/11348145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168817 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 168552 - Let shift globally trigger slow animation mode.jamescook@chromium.org2012-11-191-3/+0
| | | | | | | | | | | | | | | | | | | | | | | | | Revert note: This broke win_aura. Also it means we get slow animations when shift-clicking on a link in content to open the page in a new window, which is undesirable. A long time ago, we'd used an accelerator to link shift with slow animation mode, but this affected real key combos so a more piecemeal approach was taken, disabling/enabling slow animation modes for common ui operations. The problem with this approach is that it didn't catch many important UI animations. The fading in and fading out of context menus for example. This CL hooks into the keyboard event stream at a very high level to enable/disable slow animation mode. This has its downsides, too -- mainly that we end up with a specific bit of business littering some very general code. BUG=None Review URL: https://chromiumcodereview.appspot.com/11415050 TBR=vollick@chromium.org Review URL: https://codereview.chromium.org/11413070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168555 0039d316-1c4b-4281-b951-d872f2087c98
* Let shift globally trigger slow animation mode.vollick@chromium.org2012-11-191-0/+3
| | | | | | | | | | | | | | | | | | A long time ago, we'd used an accelerator to link shift with slow animation mode, but this affected real key combos so a more piecemeal approach was taken, disabling/enabling slow animation modes for common ui operations. The problem with this approach is that it didn't catch many important UI animations. The fading in and fading out of context menus for example. This CL hooks into the keyboard event stream at a very high level to enable/disable slow animation mode. This has its downsides, too -- mainly that we end up with a specific bit of business littering some very general code. BUG=None Review URL: https://chromiumcodereview.appspot.com/11415050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168552 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Listen for lock key from within Chrome.derat@chromium.org2012-11-152-21/+9
| | | | | | | | | | | | | | | | We were formerly getting notified via D-Bus signal from the power manager whenever the lock key on external Chrome OS keyboards (F13) was pressed or released. This change makes Chrome instead listen for F13 directly, which will allow apps to override the F13 key when desired. BUG=153951 TEST=lock key still works as before Review URL: https://chromiumcodereview.appspot.com/11420009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168022 0039d316-1c4b-4281-b951-d872f2087c98
* Separates some ash-specific logic from the ActivationController in ↵ben@chromium.org2012-11-151-1/+1
| | | | | | | | | | preparation for moving it to views/corewm. http://crbug.com/158115 R=sky@chromium.org Review URL: https://codereview.chromium.org/11420010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168005 0039d316-1c4b-4281-b951-d872f2087c98
* Add the partial screen magnifier to Chrome OS.zork@chromium.org2012-11-151-12/+20
| | | | | | | | | | BUG=127075 TEST=Set settings->Advanced Settings -> Accessibility -> Screen magnifier to partial. Check that the area around the mouse cursor is magnified Review URL: https://chromiumcodereview.appspot.com/10915140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167878 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Remove aura::EventFilter.sadrul@chromium.org2012-11-141-1/+0
| | | | | | | | | | | | Remove EventFilter. ui::EventHandler should now be used instead of EventFilters. An aura window can still have a single 'filter', which is a pre-target EventHandler owned by the Window. BUG=159632 Review URL: https://codereview.chromium.org/11312230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167711 0039d316-1c4b-4281-b951-d872f2087c98
* - Move DisplayManager and DisplayChangeObserverX11 from auraoshima@chromium.org2012-11-142-11/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | to ash.DisplayManager/DisplayChangeObserverX11 are in aura for historical reason, but they no longer have to be in aura. * Remove SingleDisplayManager as it's no longer necessary. * Rename MultipleDisplayManager and consolidate into DisplayManager. * Remove DisplayManager from desktop environment. Screen information is managed by platform in desktop environment, and should be provided via gfx::Screen implementation. - Move DisplayObserver to ui/gfx. This should be consolicated with other similar features such as WorkAreaWatcherObserver/ DisplaySettingsProvider. It's tracked in crbug.com/122863. - Misc cleanups * Test should use test_support_ash instead of including individual files. * Use TestScreen where appropriate. BUG=159710, 122863 TEST=none Review URL: https://chromiumcodereview.appspot.com/11363124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167639 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Move UserWallpaperDelegate to its own header file.tfarina@chromium.org2012-11-131-0/+1
| | | | | | | | | | BUG=159047 R=derat@chromium.org TBR=dpolukhin@chromium.org Review URL: https://codereview.chromium.org/11363185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167435 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Convert all remaining EventFilters into EventHandlers.sadrul@chromium.org2012-11-131-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | This CL converts the following list of aura::EventFilters into ui::EventHandlers: * MouseCursorEventFilter * DragDropController * LauncherTooltipManager * TooltipController * EventRewriterEventFilter * OverlayEventFilter * PanelWindowEventFilter * SystemModalContainerEventFilter * UserActivityDetector * WindowCycleEventFilter * WindowModalityController * FrameMaximizeButton::EscapeEventFilter * TabScrubber Also remove AddEnvEventFilter/RemoveEnvEventFilter from Shell functions since all the filters for the shell have been converted. BUG=159632 Review URL: https://codereview.chromium.org/11366214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167399 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Convert some aura::EventFilters into ui::EventHandlers.sadrul@chromium.org2012-11-122-29/+24
| | | | | | | | | | | | | | | | | In this CL, the following EventFilters are converted into EventHandlers: * AcceleratorFilter * MagnificationControllerImpl * TrayEventFilter * TouchObserverHUD * AppListController * ShelfLayoutManager::AutoHideEventFilter * SystemGestureEventFilter BUG=159632 Review URL: https://codereview.chromium.org/11362196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167218 0039d316-1c4b-4281-b951-d872f2087c98
* Add a workaround for crbug.com/139556.yusukes@chromium.org2012-11-093-25/+73
| | | | | | | | | | | | | | | * Switch to the next IME when Shift+Alt+Enter (or Space) are pressed and then Enter (or Space) is released. Since most of CJK IMEs use either Enter or Space as a "commit" key, this should work fine for such IME users. * The workaround might not be good enough for Cangjie/Quick IME users since the IME also uses [0-9] keys for committing a string. We might have to add additional workaround for switching from a keyboard layout to an IME, but I believe this CL would be a good enough as an initial trial. BUG=139556 TEST=added some new ash_unittests. also manually checked that the key repeat suppression change by mtomasz is still working fine. Review URL: https://chromiumcodereview.appspot.com/11364168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166868 0039d316-1c4b-4281-b951-d872f2087c98
* Don't check NULL for ShellDelegate.oshima@chromium.org2012-11-081-38/+13
| | | | | | | | | | | This is fixed in r165239 and it's guaranteed not to be NULL now. BUG=159693 TEST=none all tests should pass. Review URL: https://chromiumcodereview.appspot.com/11377063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166789 0039d316-1c4b-4281-b951-d872f2087c98
* Snap resize windows on touch to 50% when the maximize button is close to the ↵skuhne@chromium.org2012-11-071-1/+2
| | | | | | | | | | | | border BUG=151101 TEST=visual & unit test Review URL: https://chromiumcodereview.appspot.com/11366099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166535 0039d316-1c4b-4281-b951-d872f2087c98
* Fixed nonrepeative accelerators.mtomasz@chromium.org2012-11-068-255/+332
| | | | | | | | | | | | This patch fixes broken alt+(shift)+tab accelerator handling. In some situations pressing this accelerator did not invoke switching windows. This patch fixes that issue and significantly simplifies nonrepeative accelerators handling. Moreover, from now adding new nonrepeative accelerators will be very easy. TEST=Open more than two windows, press alt+tab, release alt first then release tab. Press alt+tab again. BUG=158213 Review URL: https://chromiumcodereview.appspot.com/11344008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166139 0039d316-1c4b-4281-b951-d872f2087c98
* Check status_area before accessing system_tray where appropriatestevenjb@chromium.org2012-11-051-3/+8
| | | | | | | | | | | | This needs a bit of a re-factor when we add support for multiple status areas (or decide not to), but will at least be safer for now. BUG=chromium-os:36058 For shell.h: TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11365093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166062 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 23:57:09 +0000