| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gets aura_shell_unittests compiling and passing on Mac. Some
unimplemented tests were disabled. The AuraShell.app is built
to provide the tests with proper resources. Also, references
to the ui::Compositor are now getting released during tear down.
BUG=111279
TEST=aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/9288052
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Introduces VisibilityClient, which aura::Window defers to to update layer visibility, if present. This replaces code which previously undid layer visibility changes after they were set. Layer visibility changes are potentially destructiver (they can drop textures associated with the layer and require a repaint).
- Implements this in ash in VisibilityController, which animates the visibility changes of children in annotated parents.
- Annotates various windows as requiring child window visibility change animations. This replaces animating visibility changes in LayoutManagers.
- Adds a second layer of visibility determination to aura::Window. Some code may check Window->IsVisible which was simply testing layer visibility. We want Window->IsVisible to return false as soon as Window::Hide() is called, so we add a member for this.
- We prevent stacking changes to the window from being propagated to the layer if the layer's delegate has been detached (i.e. the layer is hiding)
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9235016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=103948
TEST=builds, tests pass
Review URL: http://codereview.chromium.org/9288053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119402 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. All normal windows end up in a single workspace.
. Each maximized window ends up in its own workspace.
. There is an additional workspace for split windows, but the
heuristics of this aren't implemented yet.
I've left some bits of the old code, in particular overview but there
isn't really a way to get into it yet and it'll need some reworking if
we decide to keep it.
BUG=111285
TEST=none
R=ben@chromium.org,oshima@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9113045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119282 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Excludes drag and drop tests from aura_shell_unittests on Mac.
Will reenable once drag and drop is functional on Aura/Mac.
BUG=111279
TEST=aura_shell_unittests
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9169034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9141024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118691 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
directory.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9226040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118620 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
like crosbug.com/21842.
This CL depends on https://chromiumcodereview.appspot.com/9241007/.
BUG=None
TEST=ran the unit tests
Review URL: http://codereview.chromium.org/9228013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r118199, which was a revert of r118171.
aura::VideoPropertyWriter (not ash::VideoDetector -- made a
typo in the revert's description) was outliving the
ash::Shell singleton. Now we explicitly destroy the
VideoPropertyWriter before the shell.
The only differences from r118171 are the addition of the
final chunk in chrome_browser_main_chromeos.cc and a change
to reparent a window in VideoDetectorTest.WindowNotVisible
needed in response to r118259.
BUG=110114
TEST=avoided missing DCHECK on shutdown in trybot logs this time
Review URL: http://codereview.chromium.org/9254018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: http://codereview.chromium.org/9167032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118259 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds first cut at "Aura Shell.app" on Mac. The 'ash_shell' is extended
to generate a Cocoa application. This application brings up a single
window containing the Aura desktop. The main view of this window provides
an accelerated surface to Aura in which it can composite and draw its
results.
What works:
- The application launches and renders the Aura desktop and background
- Mouse movement, clicking, double-clicking, and interactions with
Aura windows and widgets
- Text buttons render with Skia text (needs improvement)
- Non-modal transient window button
- Window-modal window button
- System-modal window button
- Example Widgets button (checkboxes, radios, buttons)
- Lock Screen button
- Create Non-Resizable window button
- Create Pointy Bubble button
- Create Widow button
- Switcher and Taskbar
What doesn't work:
- Open Views Examples Window button
- Views menus
- Views scrollbars
- Views accelerators
- Views tooltips
- Drag and drop
- Anything involving MessageLoop dispatcher logic
- Mouse movement doesn't pass through to Aura when mouse button is up
Note: Required .gyp flags are:
'use_aura': 1,
'use_webkit_compositor': 1,
BUG=109946
TEST=Manual tests.
R=sky@chromium.org, thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9232028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r118171. There's an issue in the destruction
order of ash::VideoDetector vs. ash::Shell.
BUG=110114
TEST=built it
TBR=apatrick
Review URL: https://chromiumcodereview.appspot.com/9232037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move the shared code to BaseLayoutManager. Adjust the unit tests. Alice needs this for some compact mode work she's doing right now.
BUG=110648
TEST=Run Aura in both --aura-window-mode=normal and --aura-window-mode=compact, both still start correctly. Also unit test coverage from CompactLayoutManagerTest and ToplevelLayoutManagerTest
Review URL: https://chromiumcodereview.appspot.com/9255024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds an ash::VideoDetector class that watches for layer
updates and attempts to detect the playback of video. A
Chrome OS-specific observer updates a _CHROME_VIDEO_TIME
property on the X root window, which is used by the power
manager to defer screen dimming or other power management
features. This matches the implementation currently in use
on Chrome OS, with Chrome taking the X window manager's role
for detecting video and setting the property.
BUG=110114
TEST=added; also manually checked that the property is updated
Review URL: http://codereview.chromium.org/9249004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118171 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Renames the following as per the bug description by ben@:
kShellWindowId_ModalContainer -> kShellWindowId_SystemModalContainer
kShellWindowId_LockModalContainer -> kShellWindowId_LockSystemModalContainer
ModalContainerLayoutManager->SystemModalContainerLayoutManager
ModalityEventFilter->SystemModalContainerEventFilter
BUG=109460
TEST=All tests and compilation still succeed.
Review URL: https://chromiumcodereview.appspot.com/9249022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. App list and browser shortcut buttons can be moved around.
. Clicking the tabbed button cycles windows (creating a new one if
there isn't one).
BUG=110094
TEST=see bug
R=ben@chromium.org,jamescook@chromium.org
Review URL: http://codereview.chromium.org/9231030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=105198
TEST=built ash and aura_shell_unittests, ran aura_shell_unittests
Review URL: http://codereview.chromium.org/9227003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118063 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: http://codereview.chromium.org/9167032
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9249009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118060 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/110024
TEST=none
Review URL: http://codereview.chromium.org/9167032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118057 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently it's handled in chrome/browser/chromeos/system_key_event_listener.cc by checking the X event loop directly, but for Aura, it'd be better to remove the X dependency by moving the code to ash/accelerators/ since any class except aura::RootWindowHost should not handle an X event directly.
Part 2 of 2: https://chromiumcodereview.appspot.com/9225004/
BUG=110129
TEST=ran aura_shell_unittests
Review URL: http://codereview.chromium.org/9242003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118035 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Splits out Aura shell initialization code out to separate file
to support Mac-specific initialization.
BUG=109946
TEST=Proper initialization of Mac/Aura shell implementation.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9231024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117992 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Monitor root window for size changes and resize maximized windows when it changes. This also ensures windows in compact window mode continue to fill the screen.
* Merged CompactLayoutManager and ToplevelLayoutManager. I expected them to diverge, but they ended up being nearly identical.
* Expanded unit test coverage of ToplevelLayoutManager.
* Put a few window_util functions into a namespace. I didn't do them all because the patch would be too big.
BUG=109952
TEST=Run Aura, maximize an Aura window, change the size of the host window (or plug an external monitor into your ChromeOS device). Window should still fill the screen. Run Aura in compact window mode (default on small screen laptops). Plug in an external monitor. Windows should still fill the screen.
Review URL: https://chromiumcodereview.appspot.com/9214009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117931 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Removes inline methods from ash::LaucherItem that cause trouble
when compiling under clang with Chromium style plugins.
BUG=109946
TEST=Compiles under clang
R=sky@chromium.org
Review URL: http://codereview.chromium.org/9187036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117370 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Provides a default one in Ash that will be used to match kennedy-spec.
Much tweaking is needed, but that can come in future CLs.
http://crbug.com/109138
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117165
Review URL: http://codereview.chromium.org/9166014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117170 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
window widgets.
Provides a default one in Ash that will be used to match kennedy-spec.
Much tweaking is needed, but that can come in future CLs.
http://crbug.com/109138
TEST=none
Review URL: http://codereview.chromium.org/9166014
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/9166035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117168 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Provides a default one in Ash that will be used to match kennedy-spec.
Much tweaking is needed, but that can come in future CLs.
http://crbug.com/109138
TEST=none
Review URL: http://codereview.chromium.org/9166014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Windows should cycle A -> B -> A for repeated Alt-tab presses.
* Holding down Alt allows cycling A -> B -> C -> D...
* Extracted cycling logic into WindowCycleController.
* Added unit tests for new behavior.
BUG=109193
TEST=aura_shell_unittests WindowCycleControllerTest
Review URL: http://codereview.chromium.org/9101010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117112 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/109290
TEST=unittests
Review URL: http://codereview.chromium.org/9123016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116767 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds animated transitions first to the lock screen and
then to shutdown similar to those currently implemented in
the Chrome OS power manager and X window manager. I'll add
support for the lock key in a later change.
BUG=98328
TEST=added tests; also did a lot of manual testing
TBR=evan@chromium.org
Review URL: http://codereview.chromium.org/8976012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=97845
TEST=added new test
Review URL: http://codereview.chromium.org/8994012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in ash.
Part 1: http://codereview.chromium.org/8659033/
Part 2: http://codereview.chromium.org/8687027/
The basic design of the feature is that to use an input method as an event filter for a KeyEvent, and to feed all KeyPress and KeyRelease events that are passed to the filter to the input method. The input method sends IME results (e.g. composition text) to RenderWidgetHostViewAura or NativeWidgetAura as needed.
RenderWidgetHostViewAura:
- Just like RWHVV, implements ui::TextInputClient interface so that RWHVA could receive an event such as 'SetComposition' and 'InsertChar' from an input method object owned by InputMethodEventFilter.
- Sends a notification to the input method object on focus, blur, text input type change, etc.
- OnKeyEvent() handler is now able to handle a non-native key event, e.g. a VKEY_PROCESSKEY event, which is fabricated by the input method editor.
NativeWidgetAura:
- Uses views::InputMethodBridge instead of views::InputMethodIBus.
- InputMethodBridge, which implements ui::TextInputClient interface, just receives IME results (e.g. composition text) from ui::InputMethod and forwards them to Views UI (e.g. a text field).
- InputMethodBridge also receives a request like 'CancelComposition' from the UI and forwards the request to ui::InputMethod.
InputMethodEventFilter:
- Creates and owns a ui::InputMethodIBus object. If IBus-1.4 is not available (e.g. Windows and Goobuntu), creates an instance of ui::MockInputMethod instead.
- In PreHandleKeyEvent(), sends a KeyPress and KeyRelease event to the input method.
- Implements ui::InputMethodDelegate interface so that InputMethodEventFilter could receive a translated key press and key release event (i.e. a key event translated by the IME) which has to be sent back to the root window. Note that the translated key event might be pre-handled by a global short-cut key event filter, otherwise is sent to NWA or RWHVA from the root window. Also note that a Char event is always sent directly from the input method to a TextInputClient. The ui::InputMethodDelegate is not used for that purpose.
Supported platforms:
- Aura + Chrome OS (IME works!)
- Aura + Chrome OS + TOUCH_UI (compiles, but virtual keyboard is not shown since views::TextInputTypeTracker is not ported to Aura yet.)
- Aura + Linux, with and without IBus-1.4
- Aura + Windows (compiles, but IME does not work. views::InputMethodWin is not ported to Aura yet.)
BUG=97261
TEST=ran input_method_event_filter_unittests.cc
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=113224
Review URL: http://codereview.chromium.org/8576005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
http://crbug.com/108457
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9034017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115744 0039d316-1c4b-4281-b951-d872f2087c98
|