summaryrefslogtreecommitdiffstats
path: root/ash/drag_drop
Commit message (Collapse)AuthorAgeFilesLines
* ash: Add a base-class for interactive-ui-tests in ash.sadrul2015-08-101-33/+2
| | | | | | | | | | | Introduce AshInteractiveUITestBase for setting up gl, resources, aura for interactive ui-tests that live in ash. BUG=none Review URL: https://codereview.chromium.org/1282433003 Cr-Commit-Position: refs/heads/master@{#342622}
* aura: Sanitize the lifetime of aura::Env instance.sadrul2015-08-071-0/+7
| | | | | | | | | | | | | | | | | | | | | | | Currently, the aura::Env instance is created and/or destroyed from unexpected places (e.g. WebContentsViewAura), and that makes it difficult to reason about its lifetime. This patch tries to make this better. Notable changes: . Instead of having the ash::Shell instance be responsible for creating the aura::Env instance, make the creator of the Shell instance be responsible for also creating the aura::Env instance. . Individual TestSuite instances are responsible for managing the aura::Env instance for the tests (content::UnitTestTestSuite, ash::AuraShellTestSuite) . For chrome and browser-tests, the browser main-loop is responsible for managing the aura::Env instance. . For interactive-ui-tests that do not use the browser main-loop, each test explicitly manages its aura::Env instance. BUG=515031, 516898 TBR=avi@ for trivial change in content/browser/ Review URL: https://codereview.chromium.org/1270173004 Cr-Commit-Position: refs/heads/master@{#342300}
* gl/test: Move some initialization code used in tests to a separate component.sadrul2015-07-201-2/+2
| | | | | | | | | | | | | Moving test-code to a separete component, so that adding more test-only dependencies does not affect non-test code. BUG=none CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=jam@ for non-ui/gl/ changes, since trivial #include/gyp-gn updates Review URL: https://codereview.chromium.org/1238443004 Cr-Commit-Position: refs/heads/master@{#339539}
* Removes the useless GetFocusedTextInputClient().shuchen2015-07-021-1/+0
| | | | | | | | | | TBR=sadrul@chromium.org,sky@chromium.org BUG=474828 TEST=trybots. Review URL: https://codereview.chromium.org/1213283003 Cr-Commit-Position: refs/heads/master@{#337169}
* Refactor ViewsDelegate singletonmohsen2015-06-102-2/+0
| | | | | | | | | | | | | | | | | Currently, the variable containing ViewsDelegate singleton object can be set by anyone and there are cases (at least in tests) where it is freely replaced without properly deleting the old one which can lead to situations where multiple ViewsDelegate objects are in existence. This patch tries to ensure that there is at most one instance available at each time. Also, cleaned up some ViewsDelegate related includes. BUG=492991 Review URL: https://codereview.chromium.org/1159033008 Cr-Commit-Position: refs/heads/master@{#333692}
* Cleanup: Simplify some checks in tests.thestig2015-05-111-3/+3
| | | | | | Review URL: https://codereview.chromium.org/1123703005 Cr-Commit-Position: refs/heads/master@{#329200}
* Replace drag and drop ownerabodenha2015-04-231-1/+1
| | | | | | | | BUG=0 Review URL: https://codereview.chromium.org/863393003 Cr-Commit-Position: refs/heads/master@{#326568}
* Pass a ui::PaintContext from ui::Layer to layer delegates.danakj2015-04-041-1/+1
| | | | | | | | | | | | | | | | | | | This is a plumbing CL to create a ui::PaintContext that wraps a gfx::Canvas up in ui::Layer. This is passed to every LayerDelegate, and also through to aura::WindowDelegates and views::NativeWidgetDelegates to eventually reach views::View as well. This way ui::PaintContext is created in one place (for compositor paints, there are other places painting to bitmaps we'll address later). And in the future the ui::PaintContext can be backed by a display list instead of a canvas. R=sky BUG=466426 Review URL: https://codereview.chromium.org/1057873004 Cr-Commit-Position: refs/heads/master@{#323855}
* aura: Remove layerless windows.danakj2015-04-031-1/+1
| | | | | | | | | | | | | | | | Layerless windows are only used in unit tests today, and add complexity in that a NativeWidgetAura can not rely on there being a layer present. In practice, having a layer per Window is not unreasonable overhead, and is simpler. The way to render something into the same layer is to use a separate View instead of a separate Window. R=sky BUG=466426 Review URL: https://codereview.chromium.org/1050713002 Cr-Commit-Position: refs/heads/master@{#323610}
* Pass location in screen coordinates to DragDropClient::StartDragAndDrop()pkotwicz2015-02-242-4/+3
| | | | | | | | | | | | | | | | This CL: - Avoids converting from screen coordinates in WebContentsViewAura::StartDragging() and back to screen coordinates in DragDropController::StartDragAndDrop() - Passes the location in the correct coordinates to StartDragAndDrop() in DragDownloadItem() in drag_download_item_views.cc BUG=456619 TEST=Manual, see bug Review URL: https://codereview.chromium.org/901563005 Cr-Commit-Position: refs/heads/master@{#317888}
* Add time_stamp parameter to MouseEvent constructorrobert.bradford2015-02-183-48/+29
| | | | | | | | | | | | | | | | | | In order to allow the use of accurate kernel timestamps in the events from Ozone it is necessary to add a parameter to the constructor for MouseEvent. This CL was partially generated from using a clang tool with some manual changes for files not included in my build and to add header files as necessary. This change fills in all users of the newly added time_stamp parameter with a call into ui::EventTimeForNow() which was the original behaviour used by the constructor. BUG=450341 TEST=Build on all try bots and all unit tests pass. Review URL: https://codereview.chromium.org/934653002 Cr-Commit-Position: refs/heads/master@{#316869}
* text input focus: Supports Window::GetFocusedTextInputClient.yukishiino2015-01-281-0/+1
| | | | | | | | | | | This CL is split off from http://crrev.com/785463002 and Window::GetFocusedTextInputClient is necessary in that CL. BUG=290701 Review URL: https://codereview.chromium.org/860983004 Cr-Commit-Position: refs/heads/master@{#313448}
* Adding UMA stats for ash.dragdrop events for both touch and mouse.caelyn2015-01-231-2/+14
| | | | | | | | BUG=318948 Review URL: https://codereview.chromium.org/800183005 Cr-Commit-Position: refs/heads/master@{#312868}
* Fix references to ui/gfx headers in a*/.Avi Drissman2014-12-223-5/+5
| | | | | | | | | | BUG=444596 TEST=none TBR=ben@chromium.org Review URL: https://codereview.chromium.org/802473003 Cr-Commit-Position: refs/heads/master@{#309448}
* Fixing drag-and-drop for the case when the scroll ends with a fling.mfomitchev2014-11-242-1/+49
| | | | | | | | BUG=414382 Review URL: https://codereview.chromium.org/750703002 Cr-Commit-Position: refs/heads/master@{#305500}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-297-110/+81
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=varunjain@chromium.org Review URL: https://codereview.chromium.org/678123002 Cr-Commit-Position: refs/heads/master@{#301897}
* Prefix CommandLine usage with base namespace (Part 4: ash/)pgal.u-szeged2014-10-291-3/+3
| | | | | | | | | | | Prefix all CommandLine usage in the ash/ directory with the base:: namespace. BUG=422426 Review URL: https://codereview.chromium.org/684783004 Cr-Commit-Position: refs/heads/master@{#301819}
* replace OVERRIDE and FINAL with override and final in ash/mostynb2014-10-037-60/+60
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/621133002 Cr-Commit-Position: refs/heads/master@{#298040}
* Store the result of Pass() in a local variable.danakj2014-09-291-3/+3
| | | | | | | | | | | | This makes the use of Pass() similar to how std::move() would be used to make this code act as it should when using unique_ptr. R=sky@chromium.org BUG=418297 Review URL: https://codereview.chromium.org/609083002 Cr-Commit-Position: refs/heads/master@{#297214}
* Clean up GestureEventDetails constructors and fix unit tests.lanwei2014-09-192-7/+6
| | | | | | | | | | | | | | | Reland the code change for Issue 573963005: Clean up GestureEventDetails constructors and fix unit tests: https://codereview.chromium.org/573963005/. The code does not change, just merge two commits into one. BUG=350942 TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/581963004 Cr-Commit-Position: refs/heads/master@{#295706}
* Remove USE_X11 check in DragDropTracker unittestsdnicoara2014-09-181-17/+8
| | | | | | | | BUG=401307 Review URL: https://codereview.chromium.org/579893002 Cr-Commit-Position: refs/heads/master@{#295494}
* Revert "Clean up GestureEventDetails constructors and fix unit tests."Dirk Pranke2014-09-172-6/+7
| | | | | | | | | | | | | | | | | | | | | | | This reverts commit b44589c531098bbe739ccc7066f41e17fc5b9287. > Clean up GestureEventDetails constructors and fix unit tests. > > A new version of Issue 565583005: Clean up GestureEventDetails > constructors > https://codereview.chromium.org/565583005/ > BUG=350942 > TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org Patch set 9ec877c2d256a538b1c9af2fbed736aad8406e66 was reverted recently, but without that fix, this change doesn't work right (i.e., both patches needed to be reverted). TBR=dbeam@chromium.org, erg@chromium.org, lanwei@chromium.org BUG=350954 Review URL: https://codereview.chromium.org/576373002 Cr-Commit-Position: refs/heads/master@{#295370}
* Remove clipboard argument from ScopedClipboardWriter constructor.dcheng2014-09-171-1/+1
| | | | | | | | | | | | | | Unfortunately, early binding to a clipboard on one thread makes it hard to implement some cleanups in the clipboard IPC handlers for writing data. Since all existing callers simply pass in the clipboard for the current thread, this patch removes the constructor parameter in favor of having ScopedClipboardWriter use it itself internally. BUG=319285 Review URL: https://codereview.chromium.org/558913003 Cr-Commit-Position: refs/heads/master@{#295344}
* Clean up GestureEventDetails constructors and fix unit tests.lanwei2014-09-172-7/+6
| | | | | | | | | | | | | | | | | A new version of Issue 565583005: Clean up GestureEventDetails constructors https://codereview.chromium.org/565583005/ BUG=350942 TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5 Cr-Commit-Position: refs/heads/master@{#295144} Review URL: https://codereview.chromium.org/573963005 Cr-Commit-Position: refs/heads/master@{#295296}
* Revert of Clean up GestureEventDetails constructors and fix unit tests ↵horo2014-09-172-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (patchset #1 id:20001 of https://codereview.chromium.org/573963005/) Reason for revert: This broke TouchEditableImplAuraTest.TouchSelectionOnLongPressTest. [24874:24874:0916/151803:584385367:FATAL:gesture_event_details.cc(54)] Check failed: false. Invalid event type for constructor: 32 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=undefined&tests=TouchEditableImplAuraTest.TouchSelectionOnLongPressTest&testType=content_browsertests Original issue's description: > Clean up GestureEventDetails constructors and fix unit tests. > > A new version of Issue 565583005: Clean up GestureEventDetails > constructors > https://codereview.chromium.org/565583005/ > > BUG=350942 > > TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org > > Committed: https://crrev.com/874611d5ab5b879648682c1ea41062bebc9c95e5 > Cr-Commit-Position: refs/heads/master@{#295144} TBR=sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Review URL: https://codereview.chromium.org/577833003 Cr-Commit-Position: refs/heads/master@{#295223}
* Clean up GestureEventDetails constructors and fix unit tests.lanwei2014-09-162-7/+6
| | | | | | | | | | | | | | A new version of Issue 565583005: Clean up GestureEventDetails constructors https://codereview.chromium.org/565583005/ BUG=350942 TBR=tdresser@chromium.org, jdduke@chromium.org, sadrul@chromium.org Review URL: https://codereview.chromium.org/573963005 Cr-Commit-Position: refs/heads/master@{#295144}
* Revert of Clean up GestureEventDetails constructors (patchset #4 id:100001 ↵nhiroki2014-09-152-6/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | of https://codereview.chromium.org/565583005/) Reason for revert: This seems to fail the following tests in "athena_unittests" on "Linux ChromiumOS Tests (dbg)(3)" - HomeCardGestureManagerTest.Basic - HomeCardGestureManagerTest.StartCentered http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/36778 Original issue's description: > Clean up GestureEventDetails' constructors. > > In one of the GestureEventDetails' constructors, the arguments > delta_x, delta_y sometime are not used, so we should make a new > constructor which only takes one argument EventType. > > BUG=350942 > > Committed: https://crrev.com/b5e408e7bffd3d1e6b60612f65c0538a90329c59 > Cr-Commit-Position: refs/heads/master@{#294760} TBR=tdresser@chromium.org,jdduke@chromium.org,sadrul@chromium.org,sky@chromium.org,lanwei@chromium.org NOTREECHECKS=true NOTRY=true BUG=350942 Review URL: https://codereview.chromium.org/572593002 Cr-Commit-Position: refs/heads/master@{#294776}
* Clean up GestureEventDetails' constructors.lanwei2014-09-142-7/+6
| | | | | | | | | | | | In one of the GestureEventDetails' constructors, the arguments delta_x, delta_y sometime are not used, so we should make a new constructor which only takes one argument EventType. BUG=350942 Review URL: https://codereview.chromium.org/565583005 Cr-Commit-Position: refs/heads/master@{#294760}
* Change type of drag-drop window to popupmohsen@chromium.org2014-08-201-1/+3
| | | | | | | | | | | | | Currently, the window for drag-drop is a normal window. This is not right and cuases a few issues (e.g. see crbug.com/404634). This patch changes the type to popup. BUG=404634 Review URL: https://codereview.chromium.org/472373006 Cr-Commit-Position: refs/heads/master@{#290753} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290753 0039d316-1c4b-4281-b951-d872f2087c98
* Use a qualified path for ui_resources.h grit includes.tfarina@chromium.org2014-08-171-1/+1
| | | | | | | | | | | | BUG=401588 TEST=None R=thestig@chromium.org,thakis@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/480693002 Cr-Commit-Position: refs/heads/master@{#290178} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290178 0039d316-1c4b-4281-b951-d872f2087c98
* Merge ResourceBundle's InitSharedInstanceLocaleOnly with ↵tfarina@chromium.org2014-08-141-1/+2
| | | | | | | | | | | | | | | | | InitSharedInstanceWithLocale(). Both methods do almost the same and just difer on whether or not to load the common resources (aka chrome pak files!). BUG=340082 TEST=None R=tony@chromium.org,lambroslambrou@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/457103003 Cr-Commit-Position: refs/heads/master@{#289435} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289435 0039d316-1c4b-4281-b951-d872f2087c98
* Moving coordinate conversion methods from ash/wm to ui/wm.mfomitchev@chromium.org2014-08-082-8/+8
| | | | | | | | | | | | Re-submit of https://codereview.chromium.org/425363002/ TBR=sky, oshima BUG=NONE Review URL: https://codereview.chromium.org/445173002 Cr-Commit-Position: refs/heads/master@{#288449} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288449 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Moving coordinate conversion methods from ash/wm to ui/wm. ↵robliao@chromium.org2014-08-052-8/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/425363002/) Reason for revert: Build break. ../../ash/display/mouse_cursor_event_filter_ozone.cc:21:7:error: no member named 'ConvertPointToScreen' in namespace 'ash::wm' wm::ConvertPointToScreen(target, &point_in_screen); ~~~~^ ../../ash/display/mouse_cursor_event_filter_ozone.cc:45:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm' wm::ConvertPointFromScreen(root_at_point, &point_in_root); ~~~~^ ../../ash/display/mouse_cursor_event_filter_ozone.cc:86:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm' wm::ConvertPointFromScreen(dst_root, &point_in_dst_screen); ~~~~^ Original issue's description: > Moving coordinate conversion methods from ash/wm to ui/wm. > > Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into > aura::Window. The suggestion to do this was made here: > https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h > > BUG=NONE > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287609 TBR=oshima@chromium.org,ben@chromium.org,sky@chromium.org,mfomitchev@chromium.org NOTREECHECKS=true NOTRY=true BUG=NONE Review URL: https://codereview.chromium.org/445703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287626 0039d316-1c4b-4281-b951-d872f2087c98
* Moving coordinate conversion methods from ash/wm to ui/wm.mfomitchev@chromium.org2014-08-052-8/+8
| | | | | | | | | | | | Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into aura::Window. The suggestion to do this was made here: https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h BUG=NONE Review URL: https://codereview.chromium.org/425363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287609 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-281-25/+25
| | | | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 285209 "Cleanups for aura/test/event_generator.h (resolve..."markusheintz@chromium.org2014-07-241-25/+25
| | | | | | | | | | | | | | | | | | | | | | > Cleanups for aura/test/event_generator.h (resolve TODOs) > > Some purely mechanical changes left over from r283694, now that > aura::test::EventGenerator has moved to ui::test in src/ui/events. > > Moves aura/test/event_generator.* to event_generator_delegate_aura.* > Removes `using ui::test::EventGenerator;` declaration and redirects > includes that don't extend the delegate to include the ui/test > event_generator.h directly > > BUG=378134 > > Review URL: https://codereview.chromium.org/406413004 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/413983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285222 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-241-25/+25
| | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285209 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for re-enabling more MSVC level 4 warnings: misc edition #2pkasting@chromium.org2014-07-181-6/+12
| | | | | | | | | | | | | | | | | | This contains fixes for the following sorts of issues: * Assignment inside conditional * Taking the address of a temporary * Octal escape sequence terminated by decimal number * Signedness mismatch * Possibly-uninitialized local variable This also contains a small number of cleanups to nearby code (e.g. no else after return). BUG=81439 TEST=none Review URL: https://codereview.chromium.org/382673002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
* Replace touch_ids_bitfield_ with first_touch_id_.tdresser@chromium.org2014-07-142-10/+4
| | | | | | | | | | | | touch_ids_bitfield was overcomplicated, and we never used anything except for the lowest touch id. BUG=366707 TEST=GestureRecognizerTest Review URL: https://codereview.chromium.org/344763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283070 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that size passed into drag_utils_win.cc's SetDragImageOnDataObject ↵ananta@chromium.org2014-06-121-2/+1
| | | | | | | | | | | | | | | function is in pixels and is obtained from the SkBitmap instance. This is needed for the drag image to show up without being clipped. Removed the size parameter from the drag_utils::SetDragImageOnDataObject functions as it is not needed. We can get the size from the ImageSkia object as needed. BUG=381611 R=sky Review URL: https://codereview.chromium.org/328993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276725 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Compile ash into chrome.erg@chromium.org2014-05-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | [This is take three. I believe that I've now fixed all the static initializers (including both files named debug_utils.cc that were including <iostream>), the packaging failures, and the black border on the app list as pointed out by mgiuca@.] Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 TBR=sky@chromium.org First Review URL: https://codereview.chromium.org/25108005 Review URL: https://codereview.chromium.org/292443002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271725 0039d316-1c4b-4281-b951-d872f2087c98
* Reland Unified Gesture Recognizer for Auratdresser@chromium.org2014-05-161-2/+7
| | | | | | | | | | | | | | | | | | | | Original patch here: https://codereview.chromium.org/251543003/. Reverted here: https://codereview.chromium.org/278183002/, due to memory management issues in tests. Relanding with a better strategy for cleaning up deleted GestureProviderAura objects. This adds the unified GR for Aura behind the --use-unified-gesture-detector flag. BUG=332418 TEST=GestureRecognizer/GestureRecognizerTest.* MotionEventUITest.* TBR=jochen Review URL: https://codereview.chromium.org/282593002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270874 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce creation of ViewsDelegatesky@chromium.org2014-05-141-3/+0
| | | | | | | | | | | | | | | | | | | By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270290 Review URL: https://codereview.chromium.org/280863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270290 "Reduce creation of ViewsDelegate"raymes@google.com2014-05-141-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | Speculatively reverting as it may have caused the tree to break: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20345/steps/compile/logs/stdio > Reduce creation of ViewsDelegate > > By consolidating override of OnBeforeWidgetInit that finds shell many > of the places that were setting a viewsdelegate no longer need to. > > Also, made AshTestHelper install a ViewsDelegate so that tests don't have. > > Because of removed an include of views_delegate from ash_test_helper I had to update some includes. > > BUG=none > TEST=none > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/280863002 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/286753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270305 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce creation of ViewsDelegatesky@chromium.org2014-05-141-3/+0
| | | | | | | | | | | | | | | | | By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/280863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270290 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270232 "linux_aura: Compile ash into chrome."erg@chromium.org2014-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | Reverted once again because because there are two more static initializers. > linux_aura: Compile ash into chrome. > > [This is a reland now that the static initializers should be fixed.] > > Running chrome with the "--open-ash" parameter will create an ash > desktop window. Ash on Linux has some problems, but at least we're now > compiling the code into the binary. > > TODO: The applist isn't positioned correctly, and some details of the > system tray aren't correct. > > BUG=300084, 303862 > TBR=sky@chromium.org > First Review URL: https://codereview.chromium.org/25108005 > > Review URL: https://codereview.chromium.org/270383007 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/287783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270241 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Compile ash into chrome.erg@chromium.org2014-05-131-1/+1
| | | | | | | | | | | | | | | | | | | [This is a reland now that the static initializers should be fixed.] Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 TBR=sky@chromium.org First Review URL: https://codereview.chromium.org/25108005 Review URL: https://codereview.chromium.org/270383007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270232 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 269892 "linux_aura: Compile ash into chrome."erg@chromium.org2014-05-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Major regression in chrome-si/initializers. Reverting for now to fix. > linux_aura: Compile ash into chrome. > > Running chrome with the "--open-ash" parameter will create an ash > desktop window. Ash on Linux has some problems, but at least we're now > compiling the code into the binary. > > TODO: The applist isn't positioned correctly, and some details of the > system tray aren't correct. > > BUG=300084, 303862 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/25108005 TBR=erg@chromium.org Review URL: https://codereview.chromium.org/276773004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269902 0039d316-1c4b-4281-b951-d872f2087c98
* linux_aura: Compile ash into chrome.erg@chromium.org2014-05-121-1/+1
| | | | | | | | | | | | | | | | Running chrome with the "--open-ash" parameter will create an ash desktop window. Ash on Linux has some problems, but at least we're now compiling the code into the binary. TODO: The applist isn't positioned correctly, and some details of the system tray aren't correct. BUG=300084, 303862 R=sky@chromium.org Review URL: https://codereview.chromium.org/25108005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269892 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Unified Gesture Recognizer ↵hclam@chromium.org2014-05-101-7/+2
| | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/251543003/) Reason for revert: Memory leak detected: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1239/steps/aura_unittests/logs/stdio Original issue's description: > Unified Gesture Recognizer > > This adds the unified GR for Aura behind the --use-unified-gesture-detector flag. > > BUG=332418 > TEST=GestureRecognizer/GestureRecognizerTest.* > MotionEventUITest.* > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269325 Review URL: https://codereview.chromium.org/278183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269628 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 22:27:51 +0000