| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This contains fixes for the following sorts of issues:
* Assignment inside conditional
* Taking the address of a temporary
* Octal escape sequence terminated by decimal number
* Signedness mismatch
* Possibly-uninitialized local variable
This also contains a small number of cleanups to nearby code (e.g. no else after return).
BUG=81439
TEST=none
Review URL: https://codereview.chromium.org/382673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283967 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
touch_ids_bitfield was overcomplicated, and we never used anything
except for the lowest touch id.
BUG=366707
TEST=GestureRecognizerTest
Review URL: https://codereview.chromium.org/344763003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283070 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
function is in pixels and is obtained from the SkBitmap instance.
This is needed for the drag image to show up without being clipped.
Removed the size parameter from the drag_utils::SetDragImageOnDataObject functions as it is not needed. We can get the size from the ImageSkia object as needed.
BUG=381611
R=sky
Review URL: https://codereview.chromium.org/328993002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[This is take three. I believe that I've now fixed all the static
initializers (including both files named debug_utils.cc that were
including <iostream>), the packaging failures, and the black border
on the app list as pointed out by mgiuca@.]
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
TBR=sky@chromium.org
First Review URL: https://codereview.chromium.org/25108005
Review URL: https://codereview.chromium.org/292443002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271725 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original patch here: https://codereview.chromium.org/251543003/.
Reverted here: https://codereview.chromium.org/278183002/,
due to memory management issues in tests.
Relanding with a better strategy for cleaning up deleted
GestureProviderAura objects.
This adds the unified GR for Aura behind the --use-unified-gesture-detector flag.
BUG=332418
TEST=GestureRecognizer/GestureRecognizerTest.*
MotionEventUITest.*
TBR=jochen
Review URL: https://codereview.chromium.org/282593002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By consolidating override of OnBeforeWidgetInit that finds shell many
of the places that were setting a viewsdelegate no longer need to.
Also, made AshTestHelper install a ViewsDelegate so that tests don't have.
Because of removed an include of views_delegate from ash_test_helper I had to update some includes.
BUG=none
TEST=none
R=ben@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270290
Review URL: https://codereview.chromium.org/280863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270399 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Speculatively reverting as it may have caused the tree to break: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20345/steps/compile/logs/stdio
> Reduce creation of ViewsDelegate
>
> By consolidating override of OnBeforeWidgetInit that finds shell many
> of the places that were setting a viewsdelegate no longer need to.
>
> Also, made AshTestHelper install a ViewsDelegate so that tests don't have.
>
> Because of removed an include of views_delegate from ash_test_helper I had to update some includes.
>
> BUG=none
> TEST=none
> R=ben@chromium.org
>
> Review URL: https://codereview.chromium.org/280863002
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/286753002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
By consolidating override of OnBeforeWidgetInit that finds shell many
of the places that were setting a viewsdelegate no longer need to.
Also, made AshTestHelper install a ViewsDelegate so that tests don't have.
Because of removed an include of views_delegate from ash_test_helper I had to update some includes.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/280863002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270290 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Reverted once again because because there are two more static initializers.
> linux_aura: Compile ash into chrome.
>
> [This is a reland now that the static initializers should be fixed.]
>
> Running chrome with the "--open-ash" parameter will create an ash
> desktop window. Ash on Linux has some problems, but at least we're now
> compiling the code into the binary.
>
> TODO: The applist isn't positioned correctly, and some details of the
> system tray aren't correct.
>
> BUG=300084, 303862
> TBR=sky@chromium.org
> First Review URL: https://codereview.chromium.org/25108005
>
> Review URL: https://codereview.chromium.org/270383007
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/287783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270241 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
[This is a reland now that the static initializers should be fixed.]
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
TBR=sky@chromium.org
First Review URL: https://codereview.chromium.org/25108005
Review URL: https://codereview.chromium.org/270383007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major regression in chrome-si/initializers. Reverting for now to fix.
> linux_aura: Compile ash into chrome.
>
> Running chrome with the "--open-ash" parameter will create an ash
> desktop window. Ash on Linux has some problems, but at least we're now
> compiling the code into the binary.
>
> TODO: The applist isn't positioned correctly, and some details of the
> system tray aren't correct.
>
> BUG=300084, 303862
> R=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/25108005
TBR=erg@chromium.org
Review URL: https://codereview.chromium.org/276773004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Running chrome with the "--open-ash" parameter will create an ash
desktop window. Ash on Linux has some problems, but at least we're now
compiling the code into the binary.
TODO: The applist isn't positioned correctly, and some details of the
system tray aren't correct.
BUG=300084, 303862
R=sky@chromium.org
Review URL: https://codereview.chromium.org/25108005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269892 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/251543003/)
Reason for revert:
Memory leak detected: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1239/steps/aura_unittests/logs/stdio
Original issue's description:
> Unified Gesture Recognizer
>
> This adds the unified GR for Aura behind the --use-unified-gesture-detector flag.
>
> BUG=332418
> TEST=GestureRecognizer/GestureRecognizerTest.*
> MotionEventUITest.*
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269325
Review URL: https://codereview.chromium.org/278183002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds the unified GR for Aura behind the --use-unified-gesture-detector flag.
BUG=332418
TEST=GestureRecognizer/GestureRecognizerTest.*
MotionEventUITest.*
Review URL: https://codereview.chromium.org/251543003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plus obvious style nit fixes.
BUG=None
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/224113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface CursorDelegate. (https://codereview.chromium.org/211733003/)
Reason for revert:
http://crbug.com/357015
Original issue's description:
> Move GetCursor() method from WindowDelegate to its own delegate interface CursorDelegate.
>
> R=sky@chromium.org
> http://crbug.com/308845
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259631
TBR=sky@chromium.org
NOTREECHECKS=true
NOTRY=true
Review URL: https://codereview.chromium.org/213383007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259805 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
CursorDelegate.
R=sky@chromium.org
http://crbug.com/308845
Review URL: https://codereview.chromium.org/211733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259631 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This methods is no longer overridden by Window/View. LayerOwner now gets its own delegate interface that is used to notify the RWHVA that the layer was recreated.
Net effect is removal of DidRecreateLayer() from WindowDelegate.
R=sky@chromium.org
http://crbug.com/308845
Review URL: https://codereview.chromium.org/211873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@259615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still building as part of the aura target, will fix that in a future step.
TBR=sky@chromium.org
http://crbug.com/308710
Review URL: https://codereview.chromium.org/206453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Include-What-You-Use for WindowTreeHost.
TBR=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/196383014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
duplication of code in the browser test harness for setting up the browser process, and also ensures that initialization code in ContentMainRunner runs.
Most of the changes are to unit tests which run in browser test executables. These were getting all the setup that these binaries did for browser tests even though they were unit tests. Now they have to explicitly setup objects that they need. This would be done automatically if they were in a unit test binary and therefore using the unit test harness. The goal should be to move these tests to unit test binaries, and make them support launching some tests in separate processes building on the work that Pawel did.
BUG=350550
R=sky@chromium.org
Review URL: https://codereview.chromium.org/190663012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also sets up new targets for wm_core, wm_core_unittests, etc.
R=sky@chromium.org
TBR=sky@chromium.org
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256680
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256839
Review URL: https://codereview.chromium.org/196063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257183 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 521c703f8d62fa698c3e88287c64d8d23f9ac675.
Broke gyp
BUG=
Review URL: https://codereview.chromium.org/199263002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also sets up new targets for wm_core, wm_core_unittests, etc.
R=sky@chromium.org
TBR=sky@chromium.org
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256680
Review URL: https://codereview.chromium.org/196063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 067d7fe616a07011b9e2d2609fc65af8db6a7dfb.
Broke the build:
http://build.chromium.org/p/chromium.mac/builders/Mac%20Builder%20%28dbg%29/builds/63598/steps/compile/logs/stdio
BUG=
TBR=ben
Review URL: https://codereview.chromium.org/198283002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also sets up new targets for wm_core, wm_core_unittests, etc.
R=sky@chromium.org
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/196063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256680 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
TBR=sky@chromium.org
http://crbug.com/308710
Review URL: https://codereview.chromium.org/194843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces Window::GetDispatcher with Window::GetHost().
Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/184903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This aligns this aspect of WindowDelegate with WindowObserver, that I hope to replace this part of WD with in the future. It also allows me to clean up a little bit of the DWTH/DNWA interaction (subsequent CL).
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/183143006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253983 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/308843
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/174803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This prevents the drag capture window from being included in overview mode.
BUG=325221
TEST=WindowSelectorTest.DragDropInProgress, RootWindowTest.CaptureWindow*
TEST=Select some text or an image and drag it to begin a drag and drop action. Then press F5. There should be no extra "blank" window in overview.
Review URL: https://codereview.chromium.org/144363014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249205 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Avoid using aura::Env::GetDispatcher() as the dispatcher for new instances of
base::RunLoop()s, since for both Windows and X11, it's the same as the message-pump.
This patch also removes some non-aura views code, and some unnecessary USE_AURA ifdefs.
R=darin@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/154203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Update the aura::WindowTreeHost implementations to also be ui::EventSource, and
remove the event-dispatch related methods from the WindowTreeHostDelegate
interface. The implementation of the WindowTreeHostDelegate interface related to
event-dispatch in RootWindow uses ui::EventProcessor for dispatching events
anyway, and so it is a good time to remove this redundant code.
BUG=318879
R=ben@chromium.org
Review URL: https://codereview.chromium.org/147203004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248154 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/121773003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243656 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/126513004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
to use the base:: namespace.
BUG=330556
TEST=no change
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/102443009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242444 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch manually generated by:
$ git grep -l aura::client::WINDOW_TYPE | xargs sed -i -e 's/aura::client::WINDOW_TYPE/ui::wm::WINDOW_TYPE/g'
$ git commit -a -m.
$ git clang-format HEAD^ --style=Chromium
$ git commit -a -m.
* Move window_types.h header from ui/aura/client/ to ui/wm/public/
BUG=319638
TEST=ash_unittests, aura_unittests, views_unittests, unit_tests
R=ben@chromium.org
Review URL: https://codereview.chromium.org/115153002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I want this for EventGenerator, but it seems best to make everyone
think about this rather than create another constructor.
BUG=none
TEST=none
R=sadrul@chromium.org
Review URL: https://codereview.chromium.org/101573006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241358 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check if the window observer is empty upon destruction.
* remove the all observers in ~WindowObserver()
* Remove RemoveObserver that are no longer necessary
* Fix shell shutdown order so that observers are removed correctly before deleting all windows.
BUG=324018
R=skuhne@chromium.org, sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239232
Review URL: https://codereview.chromium.org/101013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239246 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Make sure WindowObservers are removed from window before destruction
>
> * Check if the window observer is empty upon destruction.
> * remove the all observers in ~WindowObserver()
> * Remove RemoveObserver that are no longer necessary
> * Fix shell shutdown order so that observers are removed correctly before deleting all windows.
>
> BUG=324018
> R=skuhne@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/101013002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/103863003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239239 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Check if the window observer is empty upon destruction.
* remove the all observers in ~WindowObserver()
* Remove RemoveObserver that are no longer necessary
* Fix shell shutdown order so that observers are removed correctly before deleting all windows.
BUG=324018
R=skuhne@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/101013002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Rename RootWindowHost* to WindowTreeHost*
>
> TBR=sky@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/76583003
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/77203002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236093 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/76583003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236048 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=315884, 78045
TBR=owners
Review URL: https://codereview.chromium.org/67923002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
R=oshima@chromium.org
http://crbug.com/308843
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233787
Review URL: https://codereview.chromium.org/64933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Eliminate Shell::RootWindowList in favor of aura::Window::Windows.
>
> This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
>
> R=oshima@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/64933002
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/59153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
R=oshima@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/64933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type.
Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/37733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
In preparation for hiding/changing RootWindow more...
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/38423002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove SetDefaultParentForRootWindow from Window, and replace with new utility function ParentWindowForContext in window_tree_client.h
This is part of my current campaign to slim down the aura Window types. I will eventually move WindowTreeClient to a new ui/wm component that I plan to create.
R=erg@chromium.org
http://crbug.com/308844
Review URL: https://codereview.chromium.org/36473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230501 0039d316-1c4b-4281-b951-d872f2087c98
|