summaryrefslogtreecommitdiffstats
path: root/ash/extended_desktop_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-271-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=derat@chromium.org Review URL: https://codereview.chromium.org/680153002 Cr-Commit-Position: refs/heads/master@{#301490}
* replace OVERRIDE and FINAL with override and final in ash/mostynb2014-10-031-5/+5
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/621133002 Cr-Commit-Position: refs/heads/master@{#298040}
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-281-11/+11
| | | | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 285209 "Cleanups for aura/test/event_generator.h (resolve..."markusheintz@chromium.org2014-07-241-11/+11
| | | | | | | | | | | | | | | | | | | | | | > Cleanups for aura/test/event_generator.h (resolve TODOs) > > Some purely mechanical changes left over from r283694, now that > aura::test::EventGenerator has moved to ui::test in src/ui/events. > > Moves aura/test/event_generator.* to event_generator_delegate_aura.* > Removes `using ui::test::EventGenerator;` declaration and redirects > includes that don't extend the delegate to include the ui/test > event_generator.h directly > > BUG=378134 > > Review URL: https://codereview.chromium.org/406413004 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/413983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285222 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-241-11/+11
| | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285209 0039d316-1c4b-4281-b951-d872f2087c98
* clean up coding style at ash folder.rucifer1217@gmail.com2014-07-221-2/+2
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/396273004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284594 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Enhance aura's EventGenerator to abstract platform-specific event ↵tapted@chromium.org2014-07-171-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | generation for tests. The focus of this CL is to get widget_unittest.cc compiling on MacViews. To achieve this, aura::test::EventGenerator is moved to ui/events/test and constructed with a delegate class that abstracts away the platform-specific event targeting and coordinate conversions. ui::test::EventGenerator::CreateDefaultPlatformDelegate(..) allows a default platform-specific EventGeneratorDelegate to be provided so that this detail is hidden from tests. On Mac, this delegate wraps a single NSWindow and targets NSEvents at that window. On Aura, the delegate is a thin wrapper to find and target events at an aura::Window, using the aura root window as the initial target. For Mac, NativeWidgetPrivate::IsMouseButtonDown and NSView mouse event handling in BridgedContentView is implemented to put the Mac event generator in context. Adds views_unittest WidgetTest.MouseEventTypesViaGenerator to ensure event generation is consistent across platforms (which currently passes on Mac). Allows an additional 67 tests to compile on Mac (49 pass). After this, widget_unittests.cc compiles on Mac. views_unittests has: Before: 358 tests run 10 tests failed 16 tests crashed. After: 425 tests run 24 tests failed 20 tests crashed. BUG=378134 TEST=views_unittests Review URL: https://codereview.chromium.org/322893005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283694 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Make sure redirected events have the correct location.sadrul@chromium.org2014-07-121-0/+132
| | | | | | | | | | | | | | | If an event is redirected to a different WindowTreeHost because the target window belongs to that, then make sure the event is in the WindowTreeHost's root-window's coordinate space. This is necessary to make sure that the target (and the pre/post-target handlers) see the event in the correct location. BUG=385770 R=sky@chromium.org Review URL: https://codereview.chromium.org/380343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282794 0039d316-1c4b-4281-b951-d872f2087c98
* Re-Reland Linux Window Control Alignmentjonross@chromium.org2014-05-231-3/+3
| | | | | | | | | | | | | | | | | | | | | Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering. This reland addresses changes to custom_frame_view_unittest.cc that landed before the original patch. Causing a build failure. Original code review: https://codereview.chromium.org/281353009/ Revert code review: https://codereview.chromium.org/294473016 Revert "Revert 272352 "Reland Linux Window Control Alignment"" This reverts commit b6f34fbeb011683117b33639ca78d66ff32d5bfd. TBR=oshima, sadrul TEST=CustomFrameViewTest BUG=351917 Review URL: https://codereview.chromium.org/296283003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272576 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 272352 "Reland Linux Window Control Alignment"fgorski@chromium.org2014-05-221-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | > Reland Linux Window Control Alignment > > Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering. > > Update tests that were originally missed. > > Original review: https://codereview.chromium.org/240163006/ > Revert review: https://codereview.chromium.org/276173002/ > Revert "Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)" > > This reverts commit 9031ef57ba679037fc675bf2f081f3880380de3a. > > TEST=CustomFrameViewTest > BUG=351917 > > Review URL: https://codereview.chromium.org/281353009 TBR=jonross@chromium.org Review URL: https://codereview.chromium.org/294473016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272356 0039d316-1c4b-4281-b951-d872f2087c98
* Reland Linux Window Control Alignmentjonross@chromium.org2014-05-221-3/+3
| | | | | | | | | | | | | | | | | | | Modifying CustomFrameView to layout window controls based on user configurations. For linux begin observing the configs and changes. For other systems fall back on a default ordering. Update tests that were originally missed. Original review: https://codereview.chromium.org/240163006/ Revert review: https://codereview.chromium.org/276173002/ Revert "Revert of Linux Aura Task Manager Frame Buttons Misaligned (https://codereview.chromium.org/240163006/)" This reverts commit 9031ef57ba679037fc675bf2f081f3880380de3a. TEST=CustomFrameViewTest BUG=351917 Review URL: https://codereview.chromium.org/281353009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272352 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-031-9/+8
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Move some code from aura/client to wm/publicben@chromium.org2014-03-211-1/+1
| | | | | | | | | | | Still building as part of the aura target, will fix that in a future step. TBR=sky@chromium.org http://crbug.com/308710 Review URL: https://codereview.chromium.org/206453005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258651 0039d316-1c4b-4281-b951-d872f2087c98
* Move UTF16ToASCII, remove WideToASCII.brettw@chromium.org2014-03-141-5/+6
| | | | | | | | | | | | | | | | This removes WideToASCII and changes all callers to use UTF16ToASCII instead. Moves UTF16ToASCII from base/strings/string_util.h to base/strings/utf_string_conversions.h and into the base namespace. Convert a few related string_util functions to take a StringPiece16 instead of a string16. Remove IsStringASCII(std::wstring) which was unused. Updates callers' includes and namespace usage accordingly. TBR=sky Review URL: https://codereview.chromium.org/176843022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257200 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --ash-disable-overview-modeflackr@chromium.org2014-03-121-52/+0
| | | | | | | | BUG=340466 Review URL: https://codereview.chromium.org/181563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256645 0039d316-1c4b-4281-b951-d872f2087c98
* Provide access to the WindowEventDispatcher as a ui::EventProcessor.ben@chromium.org2014-03-101-8/+4
| | | | | | | | | | | | This avoids using WED from a number of places and moves us closer to a world where WED is more of an implementation detail of WTH. R=sky@chromium.org TBR=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/191153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256053 0039d316-1c4b-4281-b951-d872f2087c98
* Window ownership -> WindowTreeHostben@chromium.org2014-03-041-12/+14
| | | | | | | | | | | | | Replaces Window::GetDispatcher with Window::GetHost(). Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect. R=sky@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/184903003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Make sure WindowEventDispatcher only dipatches events to in it.sadrul@chromium.org2014-02-261-12/+24
| | | | | | | | | | | | | | | | | | | | | | If an event arrives at a WindowEventDispatcher targeted to a Window not owned by it, then stop the event-dispatch at this dispatcher, and dispatch the event from the correct dispatcher instead. To explain with an example: * There are two WindowEventDispatchers A and B. * Window W is in A. * An event comes in (from the native platform) to dispatcher B. * The event is targeted at W (because it has capture, or because it has focus etc.) * Instead of dispatching the event to W from B, stop the event-dispatch in B and dispatch the event to W from A instead. BUG=346808 R=oshima@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/180173004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253368 0039d316-1c4b-4281-b951-d872f2087c98
* Move root_window.* to window_event_dispatcher.*ben@chromium.org2014-02-211-1/+1
| | | | | | | | | http://crbug.com/308843 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/174803002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
* Rename RootWindow -> WindowEventDispatcher.ben@chromium.org2014-02-211-4/+4
| | | | | | | | | | http://crbug.com/308843 R=sky@chromium.org Review URL: https://codereview.chromium.org/172743002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252501 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some methods from RootWindow that really belong on the WTH.ben@chromium.org2014-02-161-4/+6
| | | | | | | | | TBR=sky@chromium.org BUG= Review URL: https://codereview.chromium.org/167563004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251606 0039d316-1c4b-4281-b951-d872f2087c98
* Screen cleanup:oshima@chromium.org2014-01-171-5/+5
| | | | | | | | | | | | | * Split ScreenAsh to ScreenUtil (set of utility functions) and the screen implementation. * moved screen_ash from Shell to DisplayManager. Ash specific imp is now hidden in DisplayManager. * Shell now creates a separate screen object which simply keeps the list of displays for shutdown. This allow all screen operation valid during shutdown. BUG=None TBR=hongbo.min@intel.com,sky@chromium.org Review URL: https://codereview.chromium.org/138003007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245562 0039d316-1c4b-4281-b951-d872f2087c98
* GetDisplayNearestPoint returns the nearest display when point is outside of ↵varkha@chromium.org2014-01-071-2/+2
| | | | | | | | | | | any display. BUG=146893 TEST=ash_unittests --gtest_filter=DisplayControllerTest.FindNearestDisplay Review URL: https://codereview.chromium.org/99163006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243273 0039d316-1c4b-4281-b951-d872f2087c98
* Changes MouseEvent constructor to take changed_button_flags.sky@chromium.org2013-12-171-2/+1
| | | | | | | | | | | | | I want this for EventGenerator, but it seems best to make everyone think about this rather than create another constructor. BUG=none TEST=none R=sadrul@chromium.org Review URL: https://codereview.chromium.org/101573006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241358 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes for -Wunused-function on Linux, Android and ChromeOShans@chromium.org2013-11-121-4/+0
| | | | | | | | | BUG=315884, 78045 TBR=owners Review URL: https://codereview.chromium.org/67923002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234373 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Shell::RootWindowList in favor of aura::Window::Windows.ben@chromium.org2013-11-081-26/+28
| | | | | | | | | | | | | This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233787 Review URL: https://codereview.chromium.org/64933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233970 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 233787 "Eliminate Shell::RootWindowList in favor of aura:..."ben@chromium.org2013-11-081-28/+26
| | | | | | | | | | | | | | | | | > Eliminate Shell::RootWindowList in favor of aura::Window::Windows. > > This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. > > R=oshima@chromium.org > http://crbug.com/308843 > > Review URL: https://codereview.chromium.org/64933002 TBR=ben@chromium.org Review URL: https://codereview.chromium.org/59153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233813 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate Shell::RootWindowList in favor of aura::Window::Windows.ben@chromium.org2013-11-081-26/+28
| | | | | | | | | | | This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows. R=oshima@chromium.org http://crbug.com/308843 Review URL: https://codereview.chromium.org/64933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233787 0039d316-1c4b-4281-b951-d872f2087c98
* Move SetLayoutForCurrentDisplays to DisplayManageroshima@chromium.org2013-10-161-1/+1
| | | | | | | | | | BUG=273142 R=mukai@chromium.org TBR=hongbo.min@intel.com, pkotwicz@chromium.org Review URL: https://codereview.chromium.org/27257004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228994 0039d316-1c4b-4281-b951-d872f2087c98
* Moves ui/base/events to ui/eventssky@chromium.org2013-09-181-1/+1
| | | | | | | | | | | BUG=none TEST=none R=ben@chromium.org TBR=brettw@chromium.org, scherkus@chromium.org, ananta@chromium.org, Review URL: https://codereview.chromium.org/23851041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223906 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetActiveRootWindow -> GetTargetRootWindowoshima@chromium.org2013-09-121-4/+4
| | | | | | | | | | Fixed wrong use of GetActiveRootWindow in couple of places. BUG=266378 Review URL: https://chromiumcodereview.appspot.com/23461048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222914 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetRootWindowController to root_window_controller.hoshima@chromium.org2013-09-061-2/+1
| | | | | | | | | | Remove unnecessary includes, forward decls BUG=272460 Review URL: https://chromiumcodereview.appspot.com/24020002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221605 0039d316-1c4b-4281-b951-d872f2087c98
* Use registered info to initialize primary display instead ofoshima@chromium.org2013-08-141-4/+4
| | | | | | | | | | | | | | | | swapping primary display in DisplayController::InitSecondaryDisplays. cleanups: * move GetCurrentDisplayIdPair/GetCurrentDisplayLayout to display manager as the do not depends on primary display/root windows * Remove unnecessary UpdateDisplayBoundsForLayout call in DisplayController::InitSecondaryDisplays. BUG=270117 TEST=no functional change. all tests should pass. Review URL: https://chromiumcodereview.appspot.com/23058006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217523 0039d316-1c4b-4281-b951-d872f2087c98
* [Cleanup]oshima@chromium.org2013-07-121-14/+10
| | | | | | | | | | | | | | | | | | * Remove aura from DisplayManager -Introduced DislayManager::Delegate to decouple DisplayController - Moved methods that requires aura to DisplayController - Changed to use DisplayInfo to get native bounds instead of RootWindow. * Moved mirror_window_controller_ from Shell to DisplayControlller. This should belong to DC rather than Shell. BUG=253991 Review URL: https://chromiumcodereview.appspot.com/19038002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211357 0039d316-1c4b-4281-b951-d872f2087c98
* Keep windows in status/settings bubble in the same root windowoshima@chromium.org2013-07-081-0/+20
| | | | | | | | | BUG=256747 TEST=covered by test Review URL: https://chromiumcodereview.appspot.com/18602002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210402 0039d316-1c4b-4281-b951-d872f2087c98
* Skip mulitple-display tests on win8oshima@chromium.org2013-06-121-0/+54
| | | | | | | | | | Re-enable tests that should pass on win7. BUG=247427 Review URL: https://chromiumcodereview.appspot.com/16539005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205846 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in ash/.avi@chromium.org2013-06-101-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16739005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205277 0039d316-1c4b-4281-b951-d872f2087c98
* Allow no-internal display modeoshima@chromium.org2013-03-301-2/+2
| | | | | | | | | | | | | | | - Remember primary per display pair - remember power state. Restore when restarted, but not boot time. - DefaultLayout is used to construct layout for display pair. It used to be used if the layout wasn't set before, but since layout has other data such as primary/mirror state, it makes more sense to copy it first. Cleanup: remove unnecessary code. BUG=218387 TEST=covered by test. manually tested on device. Review URL: https://chromiumcodereview.appspot.com/12865019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191509 0039d316-1c4b-4281-b951-d872f2087c98
* Move mirror detection to DisplayManageroshima@chromium.org2013-03-141-1/+1
| | | | | | | | | | | | | Remove obsolete code Add tests for mirror & display names TBR=mpcomplete@chromium.org,jamescook@chromium.org BUG=none TEST=covered by test Review URL: https://codereview.chromium.org/12803005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188136 0039d316-1c4b-4281-b951-d872f2087c98
* Add DCHECK to ensure SetContentsView is not called incorrectlly.benwells@chromium.org2013-03-131-1/+1
| | | | | | | | | | | I foolishly did this and it caused a hard to track down crash. BUG=None Review URL: https://chromiumcodereview.appspot.com/12529004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187851 0039d316-1c4b-4281-b951-d872f2087c98
* aura: Do not include test code in production code.tfarina@chromium.org2013-02-011-2/+3
| | | | | | | | | | TEST=aura_unittests R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/12087006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180045 0039d316-1c4b-4281-b951-d872f2087c98
* Support multiple displays in EventGeneratoroshima@chromium.org2013-01-111-40/+110
| | | | | | | | | | | | | | | | - Introduces EventGeneratorDelegates interface that abstracts coordinates - Added AshEventGeneratorDelegates that uses screen coordinates in ash environment. - Updates several ash tests to use new EventGenerator I'll convert other tests in separate CL. BUG=139024 TEST=covered by tests. Review URL: https://chromiumcodereview.appspot.com/11691010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176392 0039d316-1c4b-4281-b951-d872f2087c98
* Continue threading context through unit tests.erg@chromium.org2013-01-071-23/+35
| | | | | | | | | | | - views_unittest now passes with the assert that checks that we have context. - ash_unittest...is making progress towards that and this patch is already big. BUG=161882 Review URL: https://codereview.chromium.org/11795004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@175389 0039d316-1c4b-4281-b951-d872f2087c98
* events: Update mouse-event handlers to not return EventResult.sadrul@chromium.org2012-12-181-2/+1
| | | | | | | | | | This is the last step. Once this is done, we can possibly hide EventResult. BUG=163618 Review URL: https://codereview.chromium.org/11592011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173653 0039d316-1c4b-4281-b951-d872f2087c98
* [Launcher per display] Removed Shell::status_area_widget(), system_tray()oshima@chromium.org2012-12-101-1/+1
| | | | | | | | | | | | HasPrimaryStatusArea/GetPrimarySystemTray for login screen which will have only one tray/status area on primary BUG=145978 TEST=none Review URL: https://chromiumcodereview.appspot.com/11476033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172169 0039d316-1c4b-4281-b951-d872f2087c98
* views cleanup: Merge parent and parent_widget.erg@chromium.org2012-12-061-1/+2
| | | | | | | | | | | | According to Ben, parent_widget is a leftover from when we had NativeViewGtk. It isn't needed now and everything should be handleable by the normal parent. BUG=161882 Review URL: https://chromiumcodereview.appspot.com/11299317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171590 0039d316-1c4b-4281-b951-d872f2087c98
* Use WS_POPUP for ash_unittestsoshima@chromium.org2012-12-011-19/+2
| | | | | | | | | | | | | | | | | | | | | - Layout test windows starting from (1,1) and move mouse to (0,0) so that they don't overlap unless test moves the cursor. - Enabled disabled tests. - RootWindowHostWin::SetBounds should move the window and call OnHostResized when the scale factor has changed. This also seems to fix the desktop size limitation issue (148691) probably because a popup window can be larger than the desktop size. BUG=150986,157817,141577,148691 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170621 Review URL: https://chromiumcodereview.appspot.com/11428066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170673 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use WS_POPUP for ash_unittests"oshima@chromium.org2012-12-011-2/+19
| | | | | | | | | | | | | | | | | | | | | Use WS_POPUP for ash_unittests - Layout test windows starting from (1,1) and move mouse to (0,0) so that they don't overlap unless test moves the cursor. - Enabled disabled tests. - RootWindowHostWin::SetBounds should move the window and call OnHostResized when the scale factor has changed. This also seems to fix the desktop size limitation issue (148691) probably because a popup window can be larger than the desktop size. TBR=oshima@chromium.org BUG=150986, 157817, 141577, 148691 TEST=none Review URL: https://codereview.chromium.org/11419271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170632 0039d316-1c4b-4281-b951-d872f2087c98
* Use WS_POPUP for ash_unittestsoshima@chromium.org2012-12-011-19/+2
| | | | | | | | | | | | | | | | | | | - Layout test windows starting from (1,1) and move mouse to (0,0) so that they don't overlap unless test moves the cursor. - Enabled disabled tests. - RootWindowHostWin::SetBounds should move the window and call OnHostResized when the scale factor has changed. This also seems to fix the desktop size limitation issue (148691) probably because a popup window can be larger than the desktop size. BUG=150986,157817,141577,148691 TEST=none Review URL: https://chromiumcodereview.appspot.com/11428066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170621 0039d316-1c4b-4281-b951-d872f2087c98
* Rework FocusManager as FocusClient.ben@chromium.org2012-11-281-13/+14
| | | | | | | | | | This allows us to have multiple focus system implementations. http://crbug.com/162100 R=sky@chromium.org Review URL: https://codereview.chromium.org/11299219 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169824 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-04 09:44:08 +0000