| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
updated all clients to use one on RootWindowController and/or
Launcher::ForPrimaryDisplay/ForWindow.
BUG=145978
Review URL: https://chromiumcodereview.appspot.com/11017079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162664 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=143015
Review URL: https://codereview.chromium.org/11092034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161391 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
At the end of a drag-gesture, the size of the shelf may be different from
its normal size. For these cases, the shelf will usually animate to the new
size. Make sure the dimmer also resizes itself when that happens.
BUG=151959
Review URL: https://codereview.chromium.org/10958082
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158410 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=146959
Test=Visual
Review URL: https://codereview.chromium.org/10916321
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
have some contrast.
Also fix problem w/ HDPI launcher images.
BUG=123698
TEST=Visual check
Review URL: https://chromiumcodereview.appspot.com/10915149
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155822 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
shouldn't. We need to invoke UpdateShelfVisibility after
BaseLayoutManager::ShowStateChanged since it ShowStateChanged() may
change the visiblity of the window, which effects what
UpdateShelfVisibility returns.
BUG=141391
TEST=covered by unit tests
R=skuhne@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824219
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=131382
TEST=units
Review URL: https://chromiumcodereview.appspot.com/10693003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147500 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Host a LauncherView in bubble to display overflown items;
- Mouse wheel and two-finger scroll to scroll the LauncherView in bubble in case overflow bubble is overflown;
- Fit bubble when items are added/removed;
- Keep launcher bar on screen when the bubble is shown;
BUG=128054
TEST=Verify launcher overflown items are in a bubble instead of menu.
Review URL: https://chromiumcodereview.appspot.com/10659003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146460 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: https://chromiumcodereview.appspot.com/10693135
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous patch has broken win_aura build so reverted. This also fixes the build breaks.
Add ShelfLayoutManager::Observer for two cases:
- AutoHide: catches the auto hiding status to close the tooltip property
- FullScreen: catches the shelf visibility changes to close it too
Check the visibility of Shelf itself in case of tooltip showing. Then the toolip
won't show if the shelf is hidden.
R=derat@chromium.org,davemoore@chromium.org
BUG=133551
TEST=manually done on lumpy, made sure aura_shell_unittests passed
Review URL: https://chromiumcodereview.appspot.com/10701051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145837 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add ShelfLayoutManager::Observer for two cases:
- AutoHide: catches the auto hiding status to close the tooltip property
- FullScreen: catches the shelf visibility changes to close it too
Check the visibility of Shelf itself in case of tooltip showing. Then the toolip
won't show if the shelf is hidden.
R=derat@chromium.org,davemoore@chromium.org
BUG=133551
TEST=manually done on lumpy, made sure aura_shell_unittests passed
Review URL: https://chromiumcodereview.appspot.com/10700030
TBR=mukai@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10701042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144934 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add ShelfLayoutManager::Observer for two cases:
- AutoHide: catches the auto hiding status to close the tooltip property
- FullScreen: catches the shelf visibility changes to close it too
Check the visibility of Shelf itself in case of tooltip showing. Then the toolip
won't show if the shelf is hidden.
R=derat@chromium.org,davemoore@chromium.org
BUG=133551
TEST=manually done on lumpy, made sure aura_shell_unittests passed
Review URL: https://chromiumcodereview.appspot.com/10700030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144930 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
NOTE: This was a TODO for sky@.
R=sky@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10676014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is a ton of rough edges after this patch, but I don't want this patch
to get any bigger.
BUG=121962
TEST=covered by tests.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136312 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Introduce launcher/launcher_navigator files for this code
- Add tests for the logic of launcher_navigator
BUG=119424
TEST=aura_shell_unittests passed
Review URL: https://chromiumcodereview.appspot.com/10377064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add an "enable-applist-v2" command line switch and an about flag to trigger v2;
- Add paging support to AppListModelView;
- Add page switcher buttons for v2 UI;
- Add AppListBubbleBorder to paint bubble for v2 UI;
BUG=125964, 125044
TEST=Issue 125964 is not ready for test yet. For issue 125044, user can now gets overflown apps via keyboard.
Review URL: https://chromiumcodereview.appspot.com/10381018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to listen for changes in the launcher view so that panels can be correctly drawn over the corresponding launcher icon.
BUG=124115
TEST=aura_shell_unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133089
Review URL: https://chromiumcodereview.appspot.com/10116011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to listen for changes in the launcher view so that panels can be correctly drawn over the corresponding launcher icon.
BUG=124115
TEST=aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/10116011
TBR=dcheng@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10142005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133103 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This will be used to listen for changes in the launcher view so that panels can be correctly drawn over the corresponding launcher icon.
BUG=124115
TEST=aura_shell_unittests
Review URL: https://chromiumcodereview.appspot.com/10116011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@133089 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=120706
TEST=see bug, also covered by unit tests
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9890001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129679 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
launcher.
BUG=120301
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9860011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@129059 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
background. I refactored the animation class to allow both launcher
and tray to share it.
BUG=118357
TEST=visual test, see bug.
R=sadrul@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9820002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@128052 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes several issues (blank titles in context menu,
missing icons, pinned apps not getting restored) caused by
launcher-related code that was initialized at startup and
cached the pre-login profile. This change makes us defer
initialization of the launcher until after the user has
logged in when running on Chrome OS devices.
The original version was reverted by r127859. This version
adds a new LOGIN_USER_PROFILE_PREPARED signal so we can
create the launcher before restoring the saved session and
creating browsers (which register themselves with the
launcher).
To test:
- Logged in on a Chrome OS device and checked that
previously-pinned apps appear in the launcher and that
non-component extensions have icons and titles in their
context menus.
- Killed the Chrome process and checked that the launcher is
visible when it restarts.
- Ran Chrome and ash_shell on a Linux workstation and
checked that the launcher is present.
- Ran Chrome OS smoke suite.
BUG=118129,118945
TEST=manual: see above
TBR=ben,stevenjb
Review URL: https://chromiumcodereview.appspot.com/9794014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127980 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=ben@chromium.org
TBR=ben@chromium.org
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9812001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
be a bit icky for a handful of reasons. In particular it means the
work area changes after going maximized so that you can't assume
maximized windows get the work area bounds. This makes for some
ordering dependencies. I've had to expose the bounds for maximized
windows (and non-maximized windows).
The code feels a bit messy in a number of places right now. In
particular there a handful of places (in testing code) mucking with
work area insets. We don't want that as it generally doesn't do the
right thing anymore.
BUG=116070 118671
TEST=covered by tests, but all see bugs.
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9764008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127904 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts r127841, which is causing crashes on session
restore in Chrome OS tests.
BUG=118129,118945
TEST=builds
TBR=ben
Review URL: https://chromiumcodereview.appspot.com/9794011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes several issues (blank titles in context menu,
missing icons, pinned apps not getting restored) caused by
launcher-related code that was initialized at startup and
cached the pre-login profile. This change makes us defer
initialization of the launcher until after the user has
logged in when running on Chrome OS devices.
To test:
- Logged in on a Chrome OS device and checked that
previously-pinned apps appear in the launcher and that
non-component extensions have icons and titles in their
context menus.
- Killed the Chrome process and checked that the launcher is
visible when it restarts.
- Ran Chrome and ash_shell on a Linux workstation and
checked that the launcher is present.
BUG=118129,118945
TEST=manual: see above
Review URL: https://chromiumcodereview.appspot.com/9733024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127841 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
https://chromiumcodereview.appspot.com/9689047/
with fix to allow for special conditions under test
BUG=115650
TEST=LauncherUpdaterTest.*
TBR=sky
Review URL: https://chromiumcodereview.appspot.com/9702072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126917 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=115650
TEST=LauncherUpdaterTest.*, including new tests
Review URL: https://chromiumcodereview.appspot.com/9689047
TBR=davemoore@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9702054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126792 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=115650
TEST=LauncherUpdaterTest.*, including new tests
Review URL: https://chromiumcodereview.appspot.com/9689047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
snapping/minimizing. FrameMaximizeButton handles all the logic for
this. If you move the mouse the drag threshold we'll trigger to
snapping behavior. moving to the left snaps to the left half, moving
to the right the right half, and below minimizes. Uses
PhantomWindowController to render the snap position. Minimizing
highlights the launcher button. To support this I had to plumb through
getting the bounds of the launcher button.
BUG=116213
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9703026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126729 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Refactored aura::Window::set_hit_test_bounds_inset() into SetHitTestBoundsOverride() to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126539
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=126544
Review URL: https://chromiumcodereview.appspot.com/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126554 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Use the aura::Window::set_hit_test_bounds_inset() functionality to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Review URL: http://codereview.chromium.org/9694012
TBR=jamescook@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9705011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126544 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Mocks call for resize handles to function along a single pixel edge inside the window, overlapping the web content. Use the aura::Window::set_hit_test_bounds_inset() functionality to make hover/click events along that border pass through to the non-client area of the window frames. This also allows windows to be resized when they are flush against the top/left/right edges of the screen.
BUG=117542
TEST=aura_shell_unittests ShelfLayoutManager, manually resize window from left/right/bottom/top edges
Review URL: http://codereview.chromium.org/9694012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=114502
TEST=see bug
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9406031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122459 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
class.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: http://codereview.chromium.org/9403002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@122227 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Make Launcher owns its widget;
- Update Shell's dtor since we no longer need to explicitly release launcher;
Also removed explicit tooltip_controller_.reset() and let scoped_ptr handle its release.
BUG=113466,104672
TEST=Verify crash in issue 113466 no longer happens and ASAN failure in 104672 does not regress.
Review URL: http://codereview.chromium.org/9369061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121571 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
and that each item isn't associated with a window. This allows the
chrome side to populate the launcher with items that correspond to app
tabs.
BUG=110827
TEST=none
R=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9271007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes misc clang/style errors for Aura sources. This should be the last
of them.
BUG=109946
TEST=Compiles under mac/clang.
R=sky@chromium.org
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117499
Review URL: http://codereview.chromium.org/9197005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117567 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes misc clang/style errors for Aura sources. This should be the last
of them.
BUG=109946
TEST=Compiles under mac/clang.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/9197005
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/9186049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117502 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes misc clang/style errors for Aura sources. This should be the last
of them.
BUG=109946
TEST=Compiles under mac/clang.
R=sky@chromium.org
Review URL: http://codereview.chromium.org/9197005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
We weren't creating the launcher in compact window mode, but for Alt-Tab to work we need access to its window list and data model. Instead, create the launcher and just hide its widget. This allows us to avoid NULL checks and make compact mode less likely to break in the future.
BUG=109213
TEST=Run Aura in compact window mode. Open several windows. Hit alt-tab to cycle through them.
Review URL: http://codereview.chromium.org/8983032
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116762 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/108457
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9033007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115748 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/108457
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9036011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
http://crbug.com/108457
TEST=none
TBR=sky
Review URL: http://codereview.chromium.org/9030007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115739 0039d316-1c4b-4281-b951-d872f2087c98
|