summaryrefslogtreecommitdiffstats
path: root/ash/launcher
Commit message (Collapse)AuthorAgeFilesLines
* views: Extract Widget observer into its own header file.tfarina@chromium.org2012-08-022-3/+4
| | | | | | | | R=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10834079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149555 0039d316-1c4b-4281-b951-d872f2087c98
* Fixees launcher tooltip animation settings and its finer visibility bugs.mukai@chromium.org2012-07-304-12/+66
| | | | | | | | | BUG=138018 Review URL: https://chromiumcodereview.appspot.com/10824059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148929 0039d316-1c4b-4281-b951-d872f2087c98
* Added hover feedback on touch to launcher buttons.kgr@chromium.org2012-07-252-2/+11
| | | | | | | | | | BUG=131186 TEST= Review URL: https://chromiumcodereview.appspot.com/10702102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148408 0039d316-1c4b-4281-b951-d872f2087c98
* Add EventFilter for LauncherTooltip (2nd try).mukai@chromium.org2012-07-255-41/+205
| | | | | | | | | | | | | | | | | | | Now it monitors mouse/touch/gesture events and hides the tooltip if necessary. Previous CL (crrev.com/148079) was reverted since it causes use-after-free error. It happens when the 'LauncherTooltipBubble' widget exists but LauncherTooltipManager is already released. In that case, the widget's release will cause WindowClosing() which calls host_->OnBubbleClosed(), but host_ is already released. Thus I'd make sure to introduce a method to set host_ to NULL in case that LauncherTooltipManager explicitly clean-up the Bubble. R=derat@chromium.org BUG=137678 TEST=manually checked on linux, aura_shell_unittests passed with asan Review URL: https://chromiumcodereview.appspot.com/10808102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 148079 - Add EventFilter for LauncherTooltip.glider@chromium.org2012-07-245-198/+39
| | | | | | | | | | | | | | | | | This change made ASan report a use-after-free in LauncherTooltipManagerTest.ShowingBasics Now it monitors mouse/touch/gesture events and hides the tooltip if necessary. BUG=137678 TEST=manually verified && aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10810011 TBR=mukai@chromium.org Review URL: https://chromiumcodereview.appspot.com/10809070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148096 0039d316-1c4b-4281-b951-d872f2087c98
* Add EventFilter for LauncherTooltip.mukai@chromium.org2012-07-245-39/+198
| | | | | | | | | | | | Now it monitors mouse/touch/gesture events and hides the tooltip if necessary. BUG=137678 TEST=manually verified && aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10810011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@148079 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Support touch drag in launcher.xiyuan@chromium.org2012-07-217-72/+176
| | | | | | | | | | | This CL uses ET_GESTURE_SCROLL_BEGIN etc on launcher button for touch drag. BUG=113400 TEST=Verify can drag app shortcut around using touch. Review URL: https://chromiumcodereview.appspot.com/10807017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147783 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix laucher button icon clip.xiyuan@chromium.org2012-07-192-9/+27
| | | | | | | | | | | | | - Add more space around icon to accommodate shadows; - Offset icon a bit in layout to compensate the shift caused by shadows; BUG=130949 TEST=Verify app icons (squarish one are easier to check) are no clipped and shaodws could be seen in full. Review URL: https://chromiumcodereview.appspot.com/10803036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147559 0039d316-1c4b-4281-b951-d872f2087c98
* Hide launcher bar until OOBE is completeglotov@chromium.org2012-07-192-1/+6
| | | | | | | | | | BUG=131382 TEST=units Review URL: https://chromiumcodereview.appspot.com/10693003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147500 0039d316-1c4b-4281-b951-d872f2087c98
* Rename bounds accessors to be intuitive and consistentoshima@chromium.org2012-07-192-2/+4
| | | | | | | | | | | | | | | | | | GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen Get/Set ParentBounds -> Get/Set BoundsInParent GetWorkAreaScreenBounds -> GetWorkAreaBoundsInScreen GetClientAreaScreenBounds -> GetClientAreaBoundsInScreen GetWindowScreenBounds -> GetWindowBoundsInScreen GetScreenBounds -> GetBoundsInScreen GetRootWindowBounds -> GetBoundsInRootWindow BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10795013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147499 0039d316-1c4b-4281-b951-d872f2087c98
* (Views only) Enable setting individual marigin values for top, left, bottom ↵markusheintz@chromium.org2012-07-172-2/+5
| | | | | | | | | | | | | | | and right margin in bubbles. Set the left and right margin of the Website Settings popup to 0. BUG=113688 TEST=The left and right margin (distance popup border to popup content) of the Website Settings popup is 0. Review URL: https://chromiumcodereview.appspot.com/10692188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146983 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Fix pixelated icons in app list and launcher (part 1)xiyuan@chromium.org2012-07-173-15/+12
| | | | | | | | | | | | | | | | - Wrap resize and create-shadow operations into ImageSkiaOperations; - Update launcher, app list grid and search to use ImageSkia instead of SkBitmap; This is part 1 of the change. No visual change until ImageLoadingTracker is updated. BUG=131738,131739 TEST=None. No visual change to test until the ImageLoadingTracker change is done. Review URL: https://chromiumcodereview.appspot.com/10699065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146944 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add launcher overflow bubble.xiyuan@chromium.org2012-07-126-69/+458
| | | | | | | | | | | | | | | - Host a LauncherView in bubble to display overflown items; - Mouse wheel and two-finger scroll to scroll the LauncherView in bubble in case overflow bubble is overflown; - Fit bubble when items are added/removed; - Keep launcher bar on screen when the bubble is shown; BUG=128054 TEST=Verify launcher overflown items are in a bubble instead of menu. Review URL: https://chromiumcodereview.appspot.com/10659003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146460 0039d316-1c4b-4281-b951-d872f2087c98
* Remove #pragma once from ashajwong@chromium.org2012-07-1116-16/+0
| | | | | | Review URL: https://chromiumcodereview.appspot.com/10693135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146075 0039d316-1c4b-4281-b951-d872f2087c98
* Polish launcher tooltip visibility (2nd try).mukai@chromium.org2012-07-108-15/+202
| | | | | | | | | | | | | | | | | | | | Previous patch has broken win_aura build so reverted. This also fixes the build breaks. Add ShelfLayoutManager::Observer for two cases: - AutoHide: catches the auto hiding status to close the tooltip property - FullScreen: catches the shelf visibility changes to close it too Check the visibility of Shelf itself in case of tooltip showing. Then the toolip won't show if the shelf is hidden. R=derat@chromium.org,davemoore@chromium.org BUG=133551 TEST=manually done on lumpy, made sure aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10701051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145837 0039d316-1c4b-4281-b951-d872f2087c98
* Add AppListButton which is essentially an ImageButton but calls ↵mukai@chromium.org2012-07-024-5/+129
| | | | | | | | | | | LauncherButtunHost callbacks. BUG=133554 TEST=manually checked by hovering mouse on app-list icon. Review URL: https://chromiumcodereview.appspot.com/10669008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145122 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix app list icon off position.xiyuan@chromium.org2012-06-302-2/+41
| | | | | | | | | | BUG=135198 TEST=Starting with an overflown launcher bar and verify app list button is at the right position. Also covered by a new test. Review URL: https://chromiumcodereview.appspot.com/10704043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145038 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 144930 - Polish launcher tooltip visibility.abodenha@chromium.org2012-06-297-72/+11
| | | | | | | | | | | | | | | | | | | | Add ShelfLayoutManager::Observer for two cases: - AutoHide: catches the auto hiding status to close the tooltip property - FullScreen: catches the shelf visibility changes to close it too Check the visibility of Shelf itself in case of tooltip showing. Then the toolip won't show if the shelf is hidden. R=derat@chromium.org,davemoore@chromium.org BUG=133551 TEST=manually done on lumpy, made sure aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10700030 TBR=mukai@chromium.org Review URL: https://chromiumcodereview.appspot.com/10701042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144934 0039d316-1c4b-4281-b951-d872f2087c98
* Polish launcher tooltip visibility.mukai@chromium.org2012-06-297-11/+72
| | | | | | | | | | | | | | | | | Add ShelfLayoutManager::Observer for two cases: - AutoHide: catches the auto hiding status to close the tooltip property - FullScreen: catches the shelf visibility changes to close it too Check the visibility of Shelf itself in case of tooltip showing. Then the toolip won't show if the shelf is hidden. R=derat@chromium.org,davemoore@chromium.org BUG=133551 TEST=manually done on lumpy, made sure aura_shell_unittests passed Review URL: https://chromiumcodereview.appspot.com/10700030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144930 0039d316-1c4b-4281-b951-d872f2087c98
* Calls parent's OnFocus/OnBlur explicitly in LauncherButton.mukai@chromium.org2012-06-271-0/+2
| | | | | | | | | | | | | | These methods in LauncherButton were introduced by me and forgotten to call methods of parent's class there, but actually they're used for accessibility too. R=zork@chromium.org,davemoore@chromium.org BUG=134393 TEST=manually done on lumpy Review URL: https://chromiumcodereview.appspot.com/10667011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144593 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename shelf_auto_hide_behavior.h to shelf_types.tfarina@chromium.org2012-06-277-7/+7
| | | | | | | | | | | NOTE: This was a TODO for sky@. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10676014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144520 0039d316-1c4b-4281-b951-d872f2087c98
* Wrapping text to multi-line for the launcher tooltip.mukai@chromium.org2012-06-221-6/+20
| | | | | | | | | BUG=133620 TEST=manually checked with crbug.com Review URL: https://chromiumcodereview.appspot.com/10612004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143527 0039d316-1c4b-4281-b951-d872f2087c98
* ash/app_list: Make app list bubble move with launcher app list button.xiyuan@chromium.org2012-06-164-32/+52
| | | | | | | | | | BUG=131693 TEST=Verify that app list bubble moves with launcher app list button when pinning/unpinning from app list grid. Review URL: https://chromiumcodereview.appspot.com/10535170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142548 0039d316-1c4b-4281-b951-d872f2087c98
* Add LauncherTooltip and replace the existing tooltip.mukai@chromium.org2012-06-158-13/+460
| | | | | | | | | | | | | | The tooltip for launcher items behaves quite differently from the normal views tooltip according to the UI mock, so this CL implements the behavior. BUG=118521 TEST=manually done on lumpy R=davemoore@chromium.org Review URL: https://chromiumcodereview.appspot.com/10446070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142338 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for pinning platform appsdavemoore@chromium.org2012-06-142-3/+11
| | | | | | | | | BUG=131878 TEST=Existing and new LauncherPlatformAppBrowserTest Review URL: https://chromiumcodereview.appspot.com/10534142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142086 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure that item status is reflected in viewdavemoore@chromium.org2012-06-132-0/+40
| | | | | | | | | BUG=131878 TEST=New LauncherViewTest.LauncherItemStatusPlatformApp Review URL: https://chromiumcodereview.appspot.com/10537150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142004 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r141871.oshima@chromium.org2012-06-131-7/+8
| | | | | | | | | | | | | | | Add RootWindowController that keeps per root window state. Cleanup Shell::Init(). Separated initialization that are specific to shell, root window and primary display. I also did small cleanup in detor. I'll do more cleanups when I have a chance. BUG=123160 TEST=no functional change. all tests should pass. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141871 Review URL: https://chromiumcodereview.appspot.com/10546024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141881 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r141871 "Add RootWindowController that keeps per root window state."oshima@chromium.org2012-06-131-8/+7
| | | | | | | | | | | | This reverts commit d696be73d92539286ad99338a26ceffe320be7cc. TBR=oshima@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10545154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141875 0039d316-1c4b-4281-b951-d872f2087c98
* Add RootWindowController that keeps per root window state.oshima@chromium.org2012-06-131-7/+8
| | | | | | | | | | | | Cleanup Shell::Init(). Separated initialization that are specific to shell, root window and primary display. I also did small cleanup in detor. I'll do more cleanups when I have a chance. BUG=123160 TEST=no functional change. all tests should pass. Review URL: https://chromiumcodereview.appspot.com/10546024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141871 0039d316-1c4b-4281-b951-d872f2087c98
* Change GetContainer to take a root windowoshima@chromium.org2012-06-111-1/+2
| | | | | | | | | | | Update the use of GetContainer to use the correct root window. BUG=123160 TEST=no functional change. all tests must pass. Review URL: https://chromiumcodereview.appspot.com/10540076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141384 0039d316-1c4b-4281-b951-d872f2087c98
* Set "Hover" status during focus for accessibility.mukai@chromium.org2012-06-082-2/+14
| | | | | | | | | | | | | | Based on the discussion on crbug.com/120499, we'd better to set the "hover" status to the launcher items when focused. This CL keeps the dotted rectangle too. R=zork@chromium.org,davemoore@chromium.org BUG=120499 TEST=manually verified Review URL: https://chromiumcodereview.appspot.com/10449077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141166 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DrawBitmapInt to DrawImageIntpkotwicz@chromium.org2012-06-071-2/+2
| | | | | | | | | | | Bug=None Test=Compiles Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140877 Review URL: https://chromiumcodereview.appspot.com/10512021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141002 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 140877 - Rename DrawBitmapInt to DrawImageIntpkotwicz@chromium.org2012-06-061-2/+2
| | | | | | | | | | | | Bug=None Test=Compiles Review URL: https://chromiumcodereview.appspot.com/10512021 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10546037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140882 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DrawBitmapInt to DrawImageIntpkotwicz@chromium.org2012-06-061-2/+2
| | | | | | | | | Bug=None Test=Compiles Review URL: https://chromiumcodereview.appspot.com/10512021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140877 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Add a pending state to launcher.xiyuan@chromium.org2012-06-055-3/+157
| | | | | | | | | | | | | | | - Add a pending state to LauncherItem and LauncherButton; - When an item is marked as pending, run a pulse animation on its icon until the pending bit is cleared; - Use pending state for pending pinned apps; BUG=125895,129236 TEST=Verify pending pinned apps have a pulsing animation running in their slots and order is preserved after extension update/reload. Review URL: https://chromiumcodereview.appspot.com/10443096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140617 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 140073 - ash: Fix handling of pending pinned apps.mnissler@chromium.org2012-06-024-26/+98
| | | | | | | | | | | BUG=chromium:130012 TEST=Configure pinned apps through policy, with the first entry not being available (non-installed app). Observe that the remaining items show up in the launcher. TBR=sky@chromium.org, xiyuan@chromium.org Review URL: https://chromiumcodereview.appspot.com/10493006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140202 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 140073 - ash: Fix handling of pending pinned apps.asanka@chromium.org2012-06-014-103/+14
| | | | | | | | | | | | | | | | | browser_tests failed on Linux Chromium OS. This changes gets rid of the separate tracking of pending pinned apps and instead incrementally recomputes the launcher model whenever there's a relevant change (i.e. extension loaded, pref change). BUG=chromium:130012 TEST=Configure pinned apps through policy, with the first entry not being available (non-installed app). Observe that the remaining items show up in the launcher. Review URL: https://chromiumcodereview.appspot.com/10459009 TBR=mnissler@chromium.org Review URL: https://chromiumcodereview.appspot.com/10474003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140087 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix handling of pending pinned apps.mnissler@chromium.org2012-06-014-14/+103
| | | | | | | | | | | | This changes gets rid of the separate tracking of pending pinned apps and instead incrementally recomputes the launcher model whenever there's a relevant change (i.e. extension loaded, pref change). BUG=chromium:130012 TEST=Configure pinned apps through policy, with the first entry not being available (non-installed app). Observe that the remaining items show up in the launcher. Review URL: https://chromiumcodereview.appspot.com/10459009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140073 0039d316-1c4b-4281-b951-d872f2087c98
* Support platform apps in launcherdavemoore@chromium.org2012-05-312-0/+7
| | | | | | | | | BUG=125895 TEST=New LauncherPlatformAppBrowserTest.* Review URL: https://chromiumcodereview.appspot.com/10443069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139805 0039d316-1c4b-4281-b951-d872f2087c98
* ash/launcher: No need to tag enum types with ASH_EXPORT in header files.tfarina@chromium.org2012-05-301-3/+3
| | | | | | | | R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10451070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139539 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up SkBitmapOperations.xiyuan@chromium.org2012-05-261-21/+9
| | | | | | | | | | | | | | | | - Remove CreateResizedBitmap since there is a better skia::ImageOperations::Resize; - Update CreateDropShadow to use ShadowValue for shadow definition; BUG=None. TEST=None. All should work as before this change. R=asvitkine@chromium.org Review URL: https://chromiumcodereview.appspot.com/10453035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139162 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Extend launcher first button to include leading inset.xiyuan@chromium.org2012-05-254-24/+57
| | | | | | | | | | | And minor coding style fixes. BUG=120507 TEST=Verify fix for issue 120507. Review URL: https://chromiumcodereview.appspot.com/10409083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138951 0039d316-1c4b-4281-b951-d872f2087c98
* Adjust the launcher buttons for vertical alignment. The images aresky@chromium.org2012-05-242-20/+69
| | | | | | | | | | | | still wrong. I'll update them when I get new ones. BUG=127583 TEST=none R=davemoore@chromium.org Review URL: https://chromiumcodereview.appspot.com/10423011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138871 0039d316-1c4b-4281-b951-d872f2087c98
* Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkiapkotwicz@chromium.org2012-05-212-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138072 0039d316-1c4b-4281-b951-d872f2087c98
* Flash window by pulsing their launcher icon state indicatordavemoore@chromium.org2012-05-191-3/+6
| | | | | | | | | | BUG=119965 TEST=BrowserLauncherItemControllerTest.FlashWindow Review URL: https://chromiumcodereview.appspot.com/10392173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137993 0039d316-1c4b-4281-b951-d872f2087c98
* Add new attention state to launcherdavemoore@chromium.org2012-05-185-18/+95
| | | | | | | | | BUG=119965 TEST=LauncherViewTest.LauncherItemStatus Review URL: https://chromiumcodereview.appspot.com/10386212 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137878 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 136964 - Change SetImage, SetBackground, and SetToggledImage to take ↵vrk@google.com2012-05-142-11/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | in a gfx::ImageSkia The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137005 0039d316-1c4b-4281-b951-d872f2087c98
* Change SetImage, SetBackground, and SetToggledImage to take in a gfx::ImageSkiapkotwicz@chromium.org2012-05-142-9/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The files were changed using the following sed script 1 :top 2 /SetImage/ { 3 s|ToSkBitmap|ToImageSkia|g 4 s|GetBitmapNamed|GetImageSkiaNamed|g 5 n 6 N 7 s|ToSkBitmap|ToImageSkia|g 8 s|GetBitmapNamed|GetImageSkiaNamed|g 9 b top 10 } 11 /SetBackground/ { 12 s|ToSkBitmap|ToImageSkia|g 13 s|GetBitmapNamed|GetImageSkiaNamed|g 14 n 15 N 16 s|ToSkBitmap|ToImageSkia|g 17 s|GetBitmapNamed|GetImageSkiaNamed|g 18 b top 19 } 20 /SetToggledImage/ { 21 s|ToSkBitmap|ToImageSkia|g 22 s|GetBitmapNamed|GetImageSkiaNamed|g 23 n 24 N 25 s|ToSkBitmap|ToImageSkia|g 26 s|GetBitmapNamed|GetImageSkiaNamed|g 27 b top 28 } The following files were modified by hand afterwards: 1 ash/launcher/launcher_button.cc 2 ash/system/audio/tray_volume.cc 3 ash/system/drive/tray_drive.cc 4 ash/system/tray/system_tray_delegate.h 5 ash/system/tray/tray_item_more.cc 6 ash/system/tray/tray_item_more.h 7 chrome/browser/chromeos/login/take_photo_view.cc 8 chrome/browser/chromeos/login/take_photo_view.h 9 chrome/browser/chromeos/options/network_config_view.cc 10 chrome/browser/chromeos/options/network_config_view.h 11 chrome/browser/ui/panels/panel_browser_frame_view.cc 12 chrome/browser/ui/views/autocomplete/autocomplete_result_view.cc 13 chrome/browser/ui/views/autocomplete/autocomplete_result_view.h 14 chrome/browser/ui/views/avatar_menu_bubble_view.cc 15 chrome/browser/ui/views/chrome_to_mobile_bubble_view.cc 16 chrome/browser/ui/views/confirm_bubble_view.cc 17 chrome/browser/ui/views/download/download_shelf_view.cc 18 chrome/browser/ui/views/download/download_started_animation_views.cc 19 chrome/browser/ui/views/dropdown_bar_view.cc 20 chrome/browser/ui/views/dropdown_bar_view.h 21 chrome/browser/ui/views/find_bar_view.cc 22 chrome/browser/ui/views/frame/opaque_browser_frame_view.cc 23 chrome/browser/ui/views/hung_renderer_view.cc 24 chrome/browser/ui/views/location_bar/page_action_image_view.cc 25 chrome/browser/ui/views/tabs/tab_strip.cc 26 chrome/browser/ui/views/tabs/tab_strip.h 27 ui/views/controls/button/image_button.h 28 ui/views/controls/button/image_button_unittest.cc 29 ui/views/controls/scrollbar/bitmap_scroll_bar.cc 30 ui/views/controls/scrollbar/bitmap_scroll_bar.h Whitespace changes were made in the following files manually 1 ash/launcher/launcher_view.cc 2 chrome/browser/chromeos/login/simple_web_view_dialog.cc 3 chrome/browser/ui/views/location_bar/chrome_to_mobile_view.cc 4 chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc 5 chrome/browser/ui/views/toolbar_view.cc Bug=124566 Test=Compiles, try bots pass Review URL: https://chromiumcodereview.appspot.com/10382144 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136964 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Document the ownership of LauncherDelegate.tfarina@chromium.org2012-05-141-2/+3
| | | | | | | | R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10389120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136897 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Don't pass NULL for integer parameter.mnissler@chromium.org2012-05-141-2/+2
| | | | | | | | | | BUG=chromium:126238 TEST=Stuff compiles on picky compilers. TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10388115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136892 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-27 12:26:54 +0000