| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is third CL for adding an item for dialog.
This cl adds new LauncherItemType, TYPE_DIALOG, and
implements a context menu of item created by ShelfWindowWatcher.
R=sky@chromium.org
BUG=121242
TEST=NONE
Review URL: https://codereview.chromium.org/107163005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243965 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I decided to move it there, because enum really defines 'constants'.
I'm considering moving the remaining of launcher_types.h into a new file
called shelf_item.h, since the types there are really related/tied to
ShelfItem.
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
Review URL: https://codereview.chromium.org/123073002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243247 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I decided to split the constants into its own component to make the
transition easier to do and review.
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
TBR=tapted@chromium.org # for c/b/ui/apps
Review URL: https://codereview.chromium.org/97983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move launcher* from launcher to shelf.
- rename to launcher.* to shelf.* and launcher_unittest.cc to
shelf_unittest.cc
- rename LauncherTestAPI to ShelfTestAPI.
- rename to launcher_test_api.* to shelf_test_api.*
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/115113006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move launcher_delegate.h from launcher to shelf.
- rename to shelf_delegate.h
- rename LauncherDelegateImpl to ShelfDelegateImpl.
- rename to shelf_delegate_impl.*
- rename TestLauncherDelegate to TestShelfDelegate.
- rename test_shelf_delegate.* to test_shelf_delegate.*
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
Review URL: https://codereview.chromium.org/103223005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239531 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=267582
TEST=Visual.
Dock a window.
Verify that docked background is same as the launcher background.
Open a second browser window.
Maximize it.
Verify that both docked background and the shelf background become opaque black.
Review URL: https://codereview.chromium.org/98373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is the first CL to add a LauncherItem of TYPE_DIALOG.
ShelfWindowWatcher creates and manages a LauncherItem for aura::Window that has
LauncherItemDetails property.
R=sky@chromium.org
BUG=121242
TEST=ash_unittests --gtest_filter=ShelfWindowWatcherTest.*
Review URL: https://codereview.chromium.org/80933003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239169 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Rename LauncherItemDelegate to ShelfItemDelegate.
* Move launcher_item_delegate.h from launcher/ to shelf/
* Rename to shelf_item_delegate.h
* Rename TestLauncherItemDelegate to TestShelfItemDelegate.
* Move test_launcher_item_delegate.* from launcher/ to shelf/
* Rename to test_shelf_item_delegate.*
* Rename LauncherItemDelegateManager to ShelfItemDelegateManager.
* Move launcher_item_delegate_manager.* from launcher/ to shelf/
* Rename to shelf_item_delegate_manager.*
* Rename LauncherItemDelegateManagerTestAPI to ShelfItemDelegateManagerTestAPI.
* Move launcher_item_delegate_manager_test_api.* from launcher/ to shelf/
* Rename to shelf_item_delegate_manager_test_api.*
* Rename WindowWatcherLauncherItemDelegate to WindowWatcherShelfItemDelegate.
* Move window_watcher_launcher_item_delegate.* from launcher/ to shelf/
* Rename to window_watcher_shelf_item_delegate.*
* Rename LauncherMenuModel to ShelfMenuModel.
* Host it into its own header file named shelf_menu_model.h
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
Review URL: https://codereview.chromium.org/97173003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238696 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move launcher_button.* from launcher/ to shelf/
* Rename to shelf_button.*
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
Review URL: https://codereview.chromium.org/83953003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236982 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently, we need to query all LauncherItemController when we need to get window's id.
This is very inefficient way.
Instead, LauncherID associated with window is set as a window property.
R=sky@chromium.org
BUG=NONE
TEST=browser_tests --gtest_filter=*.MatchingLauncherIDandActiveTab
Review URL: https://codereview.chromium.org/27335006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235496 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move launcher_model.* from launcher/ to shelf/
* Rename to shelf_model.*
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
Review URL: https://codereview.chromium.org/71653003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move launcher_model_observer.h from launcher/ to shelf/
- rename to shelf_model_observer.h
BUG=248353
TEST=None, no functional changes
R=harrym@chromium.org,jamescook@chromium.org
Review URL: https://codereview.chromium.org/68243002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234686 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move launcher_button_host.h from launcher/ to shelf/
- rename to shelf_button_host.h
BUG=248353
TEST=None, no functional changes
R=harrym@chromium.org,jamescook@chromium.org
Review URL: https://codereview.chromium.org/57453002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
user. Furthermore we should not show the menu if an app was created.
BUG=296269
TEST=visual
Review URL: https://codereview.chromium.org/58813002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move launcher_model_util.* from launcher/ to shelf/
- rename to shelf_model_util.*
BUG=248353
TEST=None, no functional changes
R=harrym@chromium.org,jamescook@chromium.org
Review URL: https://codereview.chromium.org/53513003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
And moves from launcher/ to shelf/ directory.
BUG=248353
TEST=None, no behavior changes.
R=harrym@chromium.org,jamescook@chromium.org
Review URL: https://codereview.chromium.org/45973003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type.
Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/37733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Makes GetBrowserItemIndex() more general function to get item index.
Move this function to ./ash/launcher/launcher_item_util.h
R=sky@chromium.org
BUG=NONE
TEST=browser_tests, ash_unittests
Review URL: https://codereview.chromium.org/27369004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230456 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=307668
R=hans@chromium.org
TBR=oshima
Review URL: https://codereview.chromium.org/29263007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229578 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org, xiyuan@chromium.org
TBR=sky@chromium.org # for chrome/browser/ui
Review URL: https://codereview.chromium.org/27628002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
BUG=NONE
Review URL: https://codereview.chromium.org/26971004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228617 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previous CL was reverted (https://codereview.chromium.org/23606016/) because LauncherItemDelegateManager holds destoryed LauncherModel pointer (in win7_aura trybot).
To handle this, destroy LauncherItemDelegateManager and recreates a new one with new LauncherModel.
Original description.
* LauncherItemController subclasses LauncherItemDelegate
* Register/Unregister when LauncherItemDelegate is created/removed
* LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID
* LauncherItemDelegateManager take ownership of all LauncherItemDelegate
R=sky@chromium.org, skuhne@chromium.org
BUG=279105
TEST=unit_tests, browser_tests, ash_unittests, ash_shell
Review URL: https://codereview.chromium.org/25823002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228595 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
visible
When LauncherItem is dragged off from the shelf, it is moved to last position of
LauncherModel and it goes to invisible state when overflow button is shown.
Because of this invisiblity, dragging event of |drag_view_| is not issued anymore.
R=skuhne@chromium.org
BUG=305078
TEST=ash_unittests, browser_tests, visual test
Review URL: https://codereview.chromium.org/26320007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228007 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
allowed. This is only used for touch base drag drop.
BUG=163993
R=jamescook@chromium.org, oshima@chromium.org
Review URL: https://codereview.chromium.org/22988002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Sometimes, we don't need to fetch overflow bounds.
R=jamescook@chromium.org
BUG=NONE
TEST=Compiles
Review URL: https://codereview.chromium.org/26695003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227898 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org,xiyuan@chromium.org
Review URL: https://codereview.chromium.org/26124002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227754 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added method to ash Launcher returning rectangle bounding all visible elements
in launcher.
BUG=269286
TEST=ash_unittests --gtest_filter=*LauncherViewVisibleBoundsTest*
Review URL: https://codereview.chromium.org/26014003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227647 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
off from the shelf
When IconProxy is dragging, it affects panel item position if launcher item is moved
to the last position of LauncherModel.
To handle this, launcher item should be moved to the front of first panel item
during the IconProxy dragging.
R=skuhne@chromium.org
BUG=305120
TEST=visual test
Review URL: https://codereview.chromium.org/26165004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227587 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(This seems to be a side effect / regression because of https://chromiumcodereview.appspot.com/23540013)
BUG=295569
R=jamescook,oshima
TEST=Please follow steps as described in the bug.
Review URL: https://codereview.chromium.org/26091003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@227448 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Refactor LauncherItemController and LauncherItemDelegate
>
> * Remove LauncherItem parameter of LauncherItemDelegate method
> * LauncherItemController subclasses LauncherItemDelegate
> * Register/Unregister when LauncherItemDelegate is created/removed
> * LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID
> * LauncherItemDelegateManager take ownership of all LauncherItemDelegate
>
> R=sky@chromium.org, skuhne@chromium.org
> BUG=279105
> TEST=unit_tests, browser_tests, ash_unittests, ash_shell
>
> Review URL: https://codereview.chromium.org/23606016
TBR=simon.hong81@gmail.com
Review URL: https://codereview.chromium.org/25716004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Remove LauncherItem parameter of LauncherItemDelegate method
* LauncherItemController subclasses LauncherItemDelegate
* Register/Unregister when LauncherItemDelegate is created/removed
* LauncherItemDelegateManager handles LauncherItemDelegate by LauncherID
* LauncherItemDelegateManager take ownership of all LauncherItemDelegate
R=sky@chromium.org, skuhne@chromium.org
BUG=279105
TEST=unit_tests, browser_tests, ash_unittests, ash_shell
Review URL: https://codereview.chromium.org/23606016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226547 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org,xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24265009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225125 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=297038
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/24323007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@225037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=297043
Review URL: https://chromiumcodereview.appspot.com/23714012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224905 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224473
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224876 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I know how much you wanted this jamescook - so I have spent over 12 hours today (saturday) to get this CL done (you owe me a beer ;) !).
Please have a close look at the CL and lets hurry and cross our fingers that we can land it on Monday!
What this does:
It allows the user to change the app list (there were a few things missing, like the wight and so) + it stores the location in the pinned prefs list. Note that this is backwards compatible since all prefs get correctly stored. The placeholder for the app list will be ignored by pre M31 builds.
One problem could arise though if you have an M30 and a M31 session at the same time running and you constantly change the layout on both systems. In that case the M31 system's app list would fall back to the first location, but I think that this is a rather rare case.
BUG=295998
TEST=unittests (and also checked visually)
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/23441079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Remove dependency on ui::ScaleFactor from ui/gfx
>
> As part of the work to removed dependencies on ui/base from ui/gfx I have
> changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
> to take float scale values instead of ui::ScaleFactor.
>
> The notion of supported scale factors has been broken into 2 parts.
> ui::SetSupportedScaleFactors remains and calls the
> new ImageSkia::SetSupportedScales().
>
> The initialization of the supported scale factors has been moved from layout.h
> into ResourceBundle, and is done explicitly in tests that don't use
> ResourceBundle.
>
> BUG=103304
> R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
>
> Review URL: https://codereview.chromium.org/24175004
TBR=davemoore@chromium.org
Review URL: https://codereview.chromium.org/24262008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224499 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
As part of the work to removed dependencies on ui/base from ui/gfx I have
changed the public api to Canvas, ImageSkia, ImageSkiaRep and ImagePNGRep
to take float scale values instead of ui::ScaleFactor.
The notion of supported scale factors has been broken into 2 parts.
ui::SetSupportedScaleFactors remains and calls the
new ImageSkia::SetSupportedScales().
The initialization of the supported scale factors has been moved from layout.h
into ResourceBundle, and is done explicitly in tests that don't use
ResourceBundle.
BUG=103304
R=ben@chromium.org, oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/24175004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=288395
Review URL: https://chromiumcodereview.appspot.com/24252002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224471 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/24108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Just cleanup, boring, trivial work.
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org,xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23537044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224217 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
TBR=brettw@chromium.org, scherkus@chromium.org, ananta@chromium.org,
Review URL: https://codereview.chromium.org/23851041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=275898
Review URL: https://chromiumcodereview.appspot.com/23483041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223839 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm leaving usb_keycodes_map in ui/base for now.
BUG=none
TEST=none
R=ben@chromium.org, benm@chromium.org, scherkus@chromium.org
TBR=benm@chromium.org, brettw@chromium.org, scherkus@chromium.org
Review URL: https://codereview.chromium.org/23480084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223739 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Ensure tooltips are closed when their anchor views go away. Also, close the
tooltip when shelf alignment changes.
BUG=288838
TEST=added to ash_unittests LauncherViewTest
Review URL: https://chromiumcodereview.appspot.com/24141003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223393 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also made GFX_EXPORT real, which is ok since it's the same as
UI_EXPORT. It'll only matter when we separate out at gyp level.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/23531053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
To export LauncherView, ash::test::LauncherTestAPI class is created.
R=sky@chromium.org
BUG=NONE
TEST=ash_unittests, browser_tests, interactive_ui_tests
Review URL: https://chromiumcodereview.appspot.com/23449033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223215 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=skuhne@chromium.org
BUG=NONE
TEST=unit_tests, ash_unittests
Review URL: https://chromiumcodereview.appspot.com/23506035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222508 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
animation should not happen and instead it should get re-inserted at its previous location.
At the same time I have also noticed a bug where dragging existing items into the shelf, keeping the slot, but moving it slightly and pulling it back out again kept the item in a wrong location. Fixed that as well.
BUG=285416, 288248
TEST=visual
Review URL: https://chromiumcodereview.appspot.com/24019004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222375 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
directory.
Minor cleanup, the renames started.
BUG=248353
R=jamescook@chromium.org,xiyuan@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23983013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222298 0039d316-1c4b-4281-b951-d872f2087c98
|