| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some purely mechanical changes left over from r283694, now that
aura::test::EventGenerator has moved to ui::test in src/ui/events.
Moves aura/test/event_generator.* to event_generator_delegate_aura.*
Removes `using ui::test::EventGenerator;` declaration and redirects
includes that don't extend the delegate to include the ui/test
event_generator.h directly
BUG=378134
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209
Review URL: https://codereview.chromium.org/406413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Cleanups for aura/test/event_generator.h (resolve TODOs)
>
> Some purely mechanical changes left over from r283694, now that
> aura::test::EventGenerator has moved to ui::test in src/ui/events.
>
> Moves aura/test/event_generator.* to event_generator_delegate_aura.*
> Removes `using ui::test::EventGenerator;` declaration and redirects
> includes that don't extend the delegate to include the ui/test
> event_generator.h directly
>
> BUG=378134
>
> Review URL: https://codereview.chromium.org/406413004
TBR=tapted@chromium.org
Review URL: https://codereview.chromium.org/413983006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Some purely mechanical changes left over from r283694, now that
aura::test::EventGenerator has moved to ui::test in src/ui/events.
Moves aura/test/event_generator.* to event_generator_delegate_aura.*
Removes `using ui::test::EventGenerator;` declaration and redirects
includes that don't extend the delegate to include the ui/test
event_generator.h directly
BUG=378134
Review URL: https://codereview.chromium.org/406413004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285209 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The revert broke Windows interactive_ui_tests. The world has probably
changed since this was first committed.
WidgetTestInteractive.CanActivateFlagIsHonored
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/29193/steps/interactive_ui_tests/logs/stdio
> Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/)
>
> Reason for revert:
> This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095
>
> I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable
>
> Original issue's description:
> > [Refactor] Consolidate the logic for whether a widget can be activated.
> >
> > This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
> >
> > BUG=353533
> > TEST=None
> >
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597
>
> Review URL: https://codereview.chromium.org/297503003
TBR=pkotwicz@chromium.org
Review URL: https://codereview.chromium.org/291013003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
activated. (https://codereview.chromium.org/286733002/)
Reason for revert:
This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095
I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable
Original issue's description:
> [Refactor] Consolidate the logic for whether a widget can be activated.
>
> This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
>
> BUG=353533
> TEST=None
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597
Review URL: https://codereview.chromium.org/297503003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is a first step towards giving tooltips their own WindowTreeHosts on Linux.
BUG=353533
TEST=None
Review URL: https://codereview.chromium.org/286733002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270597 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The primary use-case for QueryMouseLocation() is for X11 interactive
tests. The only other use was in WindowEventDispatcher, but that code
is no longer necessary.
BUG=none
R=sky@chromium.org
Review URL: https://codereview.chromium.org/251743004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266565 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Other notable changes:
* Removed WindowTreeHostFactory as this is no longer necessary.
* Moved RootWindowTransformer to ash/host
* Removed Set/GetInsets which are no longer necessary (a code in SetInsets is now a part of
SetRootWindowTransformer)
* Added TransformerHelper that implements common behavior to transform root window for AshWindowTreeHost
* Added DEPS files
* Updated metro_viewer code to make sure it creates ash::AshRemoteWindowHostTree
A few more simplifications to come:
* Simplify RootWindowTransformer
* Eliminate EnvObserver in AshWindowTreeHostX11
I'll also work on DEPS reorg to make it more explicit under ash/
BUG=355771
TEST=No functional change. ui/aura/window_tree_host_x11_unittests has been moved to ash/host/ash_window_tree_host_x11_unittests
Review URL: https://codereview.chromium.org/201573015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263192 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plus obvious style nit fixes.
BUG=None
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/224113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Include-What-You-Use for WindowTreeHost.
TBR=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/196383014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=sky@chromium.org
TBR=sky@chromium.org
http://crbug.com/308710
Review URL: https://codereview.chromium.org/194843004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256329 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Replaces Window::GetDispatcher with Window::GetHost().
Had to clear ScreenPositionClient property prior to window teardown as tests on desktop delete it prior to destroying the window hierarchy. Unhooking the property appears to have no ill-effect.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/184903003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254642 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/308843
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/174803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/308843
R=sky@chromium.org
Review URL: https://codereview.chromium.org/172743002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252501 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=sky@chromium.org
BUG=
Review URL: https://codereview.chromium.org/167563004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251606 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Factor out KeyHoldDetector.
BUG=343277
TEST=SpokenFeedbackTogglerTest
Review URL: https://codereview.chromium.org/164823005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251490 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationControllerImpl::OnMouseEvent() should not update
point of interest for mouse events of type ET_MOUSE_CAPTURE_CHANGED
because they do not contain valid coordinates.
BUG=312496
TEST=verified cursor no longer jumps
R=oshima@chromium.org
Review URL: https://codereview.chromium.org/160953002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250832 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add MagnifierKeyScroller event handler that interprets
click and hold action.
* kAshEnableMagnifierKeyScroller to test on desktop.
* Modified EventGenerator to generate native event for key press/release.
BUG=340729
TEST=MagnifierKeyScrollerTest
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249996
Review URL: https://codereview.chromium.org/155493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Suspecting breaking "Win7 Tests (dbg)(4)" and "Win7 Tests (dbg)(5)" due to failed OutOfProcessPPAPITest.Fullscreen tests. The level of confidence in this revert is low but the blame list is short. This is
the CL that touches UI and the bot was consistently green before.
Sorry for reverting, please try to land later when the waterfall is green.
> Add key based scrolling on magnified screen for kiosk mode.
>
> * Add MagnifierKeyScroller event handler that interprets
> click and hold action.
> * kAshEnableMagnifierKeyScroller to test on desktop.
> * Modified EventGenerator to generate native event for key press/release.
>
> BUG=340729
> TEST=MagnifierKeyScrollerTest
>
> Review URL: https://codereview.chromium.org/155493002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/135213004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250009 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Add MagnifierKeyScroller event handler that interprets
click and hold action.
* kAshEnableMagnifierKeyScroller to test on desktop.
* Modified EventGenerator to generate native event for key press/release.
BUG=340729
TEST=MagnifierKeyScrollerTest
Review URL: https://codereview.chromium.org/155493002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@249996 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Transform logic
- Compositor
R=sky@chromium.org
http://crbug.com/308843
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236017
Review URL: https://codereview.chromium.org/70103020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241929 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Move some non-event related functionality from RootWindow onto RootWindowHost.
>
> - Transform logic
> - Compositor
>
> R=sky@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/70103020
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/77233002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Transform logic
- Compositor
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/70103020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236017 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
RootWindowHost again.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/72503002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
R=oshima@chromium.org
http://crbug.com/308843
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233787
Review URL: https://codereview.chromium.org/64933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233970 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Eliminate Shell::RootWindowList in favor of aura::Window::Windows.
>
> This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
>
> R=oshima@chromium.org
> http://crbug.com/308843
>
> Review URL: https://codereview.chromium.org/64933002
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/59153004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233813 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is necessary as part of my plan to rework RootWindow, specifically making it not be a subclass of Window. (It will eventually be renamed WindowEventDispatcher). Code that expected to get the RootWindow interface from this type can still call GetDispatcher() on members of the returned vector of Windows.
R=oshima@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/64933002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233787 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type.
Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher.
R=sky@chromium.org
http://crbug.com/308843
Review URL: https://codereview.chromium.org/37733003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
I'll incorporate changes in https://codereview.chromium.org/27238008 when it's landed.
BUG=none
Review URL: https://codereview.chromium.org/37663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@230619 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=269817
Review URL: https://codereview.chromium.org/23477072
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@226592 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
TBR=brettw@chromium.org, scherkus@chromium.org, ananta@chromium.org,
Review URL: https://codereview.chromium.org/23851041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also made GFX_EXPORT real, which is ok since it's the same as
UI_EXPORT. It'll only matter when we separate out at gyp level.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/23531053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Fixed wrong use of GetActiveRootWindow in couple of places.
BUG=266378
Review URL: https://chromiumcodereview.appspot.com/23461048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222914 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
These methods now take pointers instead of non-const references, this was
previously a violation of the style guide.
R=vollick@chromium.org
BUG=160417
Review URL: https://chromiumcodereview.appspot.com/23724024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222864 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary includes
BUG=253991
R=jamescook@chromium.org
Review URL: https://codereview.chromium.org/18080004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209143 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
r190446 accidentally made Chrome Frame windows transparent and invisible (except when viewed via RDP). This change brings them back.
BUG=223560,237579
Review URL: https://chromiumcodereview.appspot.com/14263020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208886 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16739005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205277 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
so that we can copy texture as is.
- store gfx::Display object for mirrored display instead of
just id because we need one for mirror root window.
- use host window's coordinate for mirror cursor window.
BUG=239776
TEST=covered by unit tests
Review URL: https://chromiumcodereview.appspot.com/15730006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202985 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Magnifier have to use RootWindow::GetRootTransform() instead of getting the transform matrix from the layer because the transform from the layer isn't DPI-unaware.
BUG=235928
TEST=manual
R=oshima@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/14466005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199249 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add RootWindow::MoveCursorToInHost() to move the cursor to the specified location in the host.
- Use it in MagnificationController to move the cursor instead of MoveCursorTo().
BUG=223983, 230979
TEST=ash_unittests passes.
Review URL: https://chromiumcodereview.appspot.com/13947045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196683 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
create transform matrix.
This patch enables us to use simultaneously these features.
BUG=223983, 230979
TEST=ash_unittests and aura_unittests passes.
R=oshima@chromium.org
NOTRY=True
# NOTRYing for trybots are already passed.
Review URL: https://chromiumcodereview.appspot.com/13634002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196077 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
use of StringPrintf now requires prefixing with base:: or a per-scope using directive
TBR'd:
abodenha: chrome/service
brettw: content, third_party, webkit
darin: base, chrome/browser, chrome/renderer
dgarret: courgette
enne: cc
fischmann: media
gbillock: sql
joi: google_apis,components
rsleevi: net, crypto
sky: chrome/test
thestig: printing, chrome/common,
tsepez: ipc
wez: remoting
yfriedman: testing/android
NOTRY=true
R=brettw@chromium.org
TBR=joi@chromium.org, rsleevi@chromium.org, enne@chromium.org, thestig@chromium.org, darin@chromium.org, abodenha@chromium.org, sky@chromium.org, dgarret@chromium.org, tsepez@chromium.org, fishman@chromium.org, wez@chromium.org, gbillock@chromium.org, yfriedman@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12767006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@188857 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of passing a rect based on the size of the layer into the filter
operation, just pass the zoom amount, and compute the rect when applying
the filter, since the size of the texture being filtered is known there.
This deactivates the zoom filter entirely (and sets values to 0's in the
IPC code) until https://bugs.webkit.org/show_bug.cgi?id=112221 rolls into
chromium.
R=piman,jamesr
BUG=161936
TBR=sky
Review URL: https://codereview.chromium.org/12816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
below, so I'm taking over.
I removed a few NULL checks that aren't necessary.
Changes:
- Switch root window if the root window it is currently working on has been destroyed.
- Fixes a bug in OnMouseEvent(), changing the order of assigning to |point_of_interest_|.
- Do not redraw the root window if that root window is being destroyed.
BUG=176335
TEST=interactive_ui_tests doesn't crash with https://codereview.chromium.org/12218045/
Review URL: https://chromiumcodereview.appspot.com/12314163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should keep to watch the mouse location and root window changing even when the magnifier is disabled, in order to do the initial zoom from the disabled state.
BUG=173968
TEST=manual
R=zork@chromium.org
TBR=derat@chromium.org
# TBRIng for simple changes just around magnifier.
Review URL: https://chromiumcodereview.appspot.com/12177014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a WidgetObserver event that is guaranteed to be invoked synchronously
when a Widget is requested to close. Rename the existing event, which
is invoked at Widget destruction time, typically via a task on the event
loop, to OnWidgetDestroying.
The new event will be used in Views-specific WebContentsModalDialogManager
functionality to get close events for Widgets, so that we don't risk
adverse interleaving of Widget close events with other relevant events
(e.g. IPC). This will allow us to avoids test flakiness observed
in https://codereview.chromium.org/12045037 due to event races in
PrintPreviewTest.PrintCommands
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/12089061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164650
TEST=maual
Review URL: https://chromiumcodereview.appspot.com/12043007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ash_unittests passes
R=zork@chromium.org
TBR=derat@chromium.org
# TBRing for modifying only magnifier related code.
Review URL: https://chromiumcodereview.appspot.com/11886043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, on panning, the view-port moves by the fixed amount but this way is not good from the view point of UX.
With this patch, the view-port moves same amount as the cursor moves, and the user can move the view-port toward the arbitrary demanded place.
BUG=161222
TEST=manual
R=zork@chromium.org
TBR=derat@chromium.org
# TBRing for only magnifier changes.
Review URL: https://chromiumcodereview.appspot.com/11783083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The revert didn't fix the ChromeOS failures so I'm restoring the change.
> Revert 176087
>
> Appears to break ChromeOS browser_tests.
>
> > Re-introduce the partial magnifier
> >
> > Major Changes:
> > - Adding a selectbox at the right of screen magnifier setting on the setting page.
> > - Adding 'screen_magnifier_type2' pref.
> > - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> > - Add IsMagnifierEnabled() to shell delegate.
> >
> > BUG=166832
> > TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
> >
> > R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> > TBR=jhawkins@chromium.org
> > # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
> >
> > Review URL: https://chromiumcodereview.appspot.com/11642014
>
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/11821053
TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/11783097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176111 0039d316-1c4b-4281-b951-d872f2087c98
|