| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Instead of passing a rect based on the size of the layer into the filter
operation, just pass the zoom amount, and compute the rect when applying
the filter, since the size of the texture being filtered is known there.
This deactivates the zoom filter entirely (and sets values to 0's in the
IPC code) until https://bugs.webkit.org/show_bug.cgi?id=112221 rolls into
chromium.
R=piman,jamesr
BUG=161936
TBR=sky
Review URL: https://codereview.chromium.org/12816002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@187901 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
below, so I'm taking over.
I removed a few NULL checks that aren't necessary.
Changes:
- Switch root window if the root window it is currently working on has been destroyed.
- Fixes a bug in OnMouseEvent(), changing the order of assigning to |point_of_interest_|.
- Do not redraw the root window if that root window is being destroyed.
BUG=176335
TEST=interactive_ui_tests doesn't crash with https://codereview.chromium.org/12218045/
Review URL: https://chromiumcodereview.appspot.com/12314163
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should keep to watch the mouse location and root window changing even when the magnifier is disabled, in order to do the initial zoom from the disabled state.
BUG=173968
TEST=manual
R=zork@chromium.org
TBR=derat@chromium.org
# TBRIng for simple changes just around magnifier.
Review URL: https://chromiumcodereview.appspot.com/12177014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a WidgetObserver event that is guaranteed to be invoked synchronously
when a Widget is requested to close. Rename the existing event, which
is invoked at Widget destruction time, typically via a task on the event
loop, to OnWidgetDestroying.
The new event will be used in Views-specific WebContentsModalDialogManager
functionality to get close events for Widgets, so that we don't risk
adverse interleaving of Widget close events with other relevant events
(e.g. IPC). This will allow us to avoids test flakiness observed
in https://codereview.chromium.org/12045037 due to event races in
PrintPreviewTest.PrintCommands
BUG=157161
Review URL: https://chromiumcodereview.appspot.com/12089061
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180796 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=164650
TEST=maual
Review URL: https://chromiumcodereview.appspot.com/12043007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177935 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=ash_unittests passes
R=zork@chromium.org
TBR=derat@chromium.org
# TBRing for modifying only magnifier related code.
Review URL: https://chromiumcodereview.appspot.com/11886043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@177145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, on panning, the view-port moves by the fixed amount but this way is not good from the view point of UX.
With this patch, the view-port moves same amount as the cursor moves, and the user can move the view-port toward the arbitrary demanded place.
BUG=161222
TEST=manual
R=zork@chromium.org
TBR=derat@chromium.org
# TBRing for only magnifier changes.
Review URL: https://chromiumcodereview.appspot.com/11783083
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The revert didn't fix the ChromeOS failures so I'm restoring the change.
> Revert 176087
>
> Appears to break ChromeOS browser_tests.
>
> > Re-introduce the partial magnifier
> >
> > Major Changes:
> > - Adding a selectbox at the right of screen magnifier setting on the setting page.
> > - Adding 'screen_magnifier_type2' pref.
> > - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> > - Add IsMagnifierEnabled() to shell delegate.
> >
> > BUG=166832
> > TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
> >
> > R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> > TBR=jhawkins@chromium.org
> > # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
> >
> > Review URL: https://chromiumcodereview.appspot.com/11642014
>
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/11821053
TBR=acolwell@chromium.org
Review URL: https://codereview.chromium.org/11783097
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176111 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Appears to break ChromeOS browser_tests.
> Re-introduce the partial magnifier
>
> Major Changes:
> - Adding a selectbox at the right of screen magnifier setting on the setting page.
> - Adding 'screen_magnifier_type2' pref.
> - Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
> - Add IsMagnifierEnabled() to shell delegate.
>
> BUG=166832
> TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
>
> R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
> TBR=jhawkins@chromium.org
> # TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
>
> Review URL: https://chromiumcodereview.appspot.com/11642014
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11821053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major Changes:
- Adding a selectbox at the right of screen magnifier setting on the setting page.
- Adding 'screen_magnifier_type2' pref.
- Separating the enable/disable state of magnifier from MagnifierType. MagnifierType does no longer indicate the current enable/disable status.
- Add IsMagnifierEnabled() to shell delegate.
BUG=166832
TEST=confirm that magnifier can be enabled/disabled via the tray and the settings page. browser_test passes.
R=zork@chromium.org, derat@chromium.org, nkostylev@chromium.org
TBR=jhawkins@chromium.org
# TBRing for small changed in C/B/ui/webui/options/ and C/B/resources/options/
Review URL: https://chromiumcodereview.appspot.com/11642014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL adds the following APIs.
* CursorClient::DisableMouseEvents: Makes mouse events stop being sent
and hides the cursor if it is visible.
(For now, DisableMouseEvents just clears the hover state and doesn't
prevent mouse events from being generated, though).
* CursorClient::EnableMouseEvents: Makes mouse events start being sent
and shows the cursor if it was hidden with DisableMouseEvents.
* CursorClient::HideCursor: Makes the cursor invisible. This changes
only the cursor visibility and mouse events keep being sent even when
the cursor is invisible.
* CursorClient::ShowCursor: Makes the cursor visible. This does not take
effect When mouse events are disabled.
This CL just replaces the old usages of CursorClient::ShowCursor with
the new APIs to retain existing behavior.
I'll make another CL that uses these APIs in appropriate places.
BUG=153703
TEST=CursorManagerTest.EnableDisableMouseEvents, CursorManagerTest.ShowAndEnable
Review URL: https://chromiumcodereview.appspot.com/11412315
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173933 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This is the last step. Once this is done, we can possibly hide EventResult.
BUG=163618
Review URL: https://codereview.chromium.org/11592011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=163618
Review URL: https://codereview.chromium.org/11568006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The default scale level has been 1.0x only on login screen (2.0x on other screens). This changes it into 2.0x, which is consistent with other screens (lock screen and user screen after login).
BUG=163147, 163170
Review URL: https://chromiumcodereview.appspot.com/11442036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171609 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
- Use the center of window, if magnifier cannot get the mouse location. This will fix the problem not to restore the magnifier scale when the cursor has not been moved.
- Re-magnify the screen when the magnifier is requested to magnify. This will fix the problem when both the login screen and the user desktop are magnified.
BUG=151891
TEST=manual, browser_test:MagnificationManagerTest.* passes
R=zork@chromium.org
TBR=derat@chromiumn.org
# TBRing for simple changes.
Review URL: https://codereview.chromium.org/11451029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On login, although the magnifier is disabled, the manager/controller try to disable it again. This CL prevents this useless operation.
Changes:
- In MagnificationManager::SetMagnifier(), if the given type is same as the current type, do nothing.
- In MagnificationControllerImpl::SetEnabled(), if the given |enabled| is same as current, do nothing.
- Use Initialize/Shutdown pattern instead of scoped_ptr in ChromeBrowserMainPartsChromeos.
- Initialize in PreProfileInit() instead of PostProfileInit().
- Add MagnificationObserver, and use it instead of watching pref changes.
- GetMagnifierType() returns the cached value.
BUG=163941
TEST=manual, browser_tests passes
Review URL: https://codereview.chromium.org/11280287
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171401 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
is invisible.
BUG=157918
TEST=Manually on device
Review URL: https://chromiumcodereview.appspot.com/11316214
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170489 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch add a sub-menu to set accessibility feature (spoken feedback, high-contrast and screen magnifier) under accessibility menu.
The design is at http://crbug.com/158281.
BUG=160689, 158307
TEST=manual
TBR=nkostylev@chromium.org, jhawkins@chromium.org
# TBRing for just rename changes.
Review URL: https://codereview.chromium.org/11415025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170180 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Major changes:
- Rename: |is_on_zoopming_|-> |is_on_animation_|
- Set |is_on_animation_| in Redraw() instead of the callees.
BUG=none
TEST=manual
TBR=sky@chromium.org
# TBRing for simple changes inside magnifier.
Review URL: https://chromiumcodereview.appspot.com/11428018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169616 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We have too many ways to do the same thing in gfx::Transform, and their names
can lead to confusion. We have the notion of Concat-ing and Preconcat-ing.
We've borrowed this verbage from skia. a.preConcat(b) means a = a * b. This may
seem counter-intuitive, but is the correct definition if we are multiplying our
points/vectors on the right.
That said, we almost always want to pre-concat. This what is done throughout
WebKit. To simplify matters, rather than having ConcatFoo and PreconcatFoo, we
will now only have Foo which does what PreconcatFoo used to.
Furthermore, we also have SetFoo which is almost always used immediately after
a transform is created, so Foo would do fine (with the optimization mentioned
below).
Another bit of redundant code eliminated by this CL is
InterpolatedTransform::FactorTRS. This function was brittle and naive, and now
that gfx::Transform::Blend exists, it needs to go away.
Other minor changes rolled into this cleanup:
- RotateAbout now takes the newly minted Vector3dF
- The Foo functions mentioned above also check for identity to avoid
needless matrix multiplications.
BUG=159972
Review URL: https://chromiumcodereview.appspot.com/11418040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162080
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162142
Review URL: https://chromiumcodereview.appspot.com/11065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169457 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the unintentional zoom origin drift described at http://crbug.com/160472.
Major changes:
- Update the formula of calculate new position in RedrawKeepingMousePosition()
- Use the float instead of integer in calculation of the position.
- Add the float version of ConvertPointToDIP() in dip_util.cc
BUG=160472
TEST=manual
Review URL: https://chromiumcodereview.appspot.com/11348059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@169454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Cursor was shown by MagnificationController when it's enabled in chrome::OpenAsh.
This CL makes MagnificationController not to show cursor if unnecessary.
Also makes cursor initially hidden when the host window is not using full screen
for testing ChromeOS build on desktop.
BUG=157918
TEST=Manually on device and desktop
Review URL: https://chromiumcodereview.appspot.com/11364003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168830 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This allows getting rid of a whole bunch of noop implementations, and makes
it easier to add new event types to be dispatched through the EventDispatcher
to EventHandlers.
BUG=159632
Review URL: https://codereview.chromium.org/11348145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=159632
Review URL: https://codereview.chromium.org/11365272
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167958 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=127075
TEST=Set settings->Advanced Settings -> Accessibility -> Screen magnifier to partial. Check that the area around the mouse cursor is magnified
Review URL: https://chromiumcodereview.appspot.com/10915140
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167878 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove EventFilter. ui::EventHandler should now be used instead of EventFilters.
An aura window can still have a single 'filter', which is a pre-target
EventHandler owned by the Window.
BUG=159632
Review URL: https://codereview.chromium.org/11312230
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167711 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/158115
TBR=sky@chromium.org,jam@chromium.org
Review URL: https://codereview.chromium.org/11275139
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this CL, the following EventFilters are converted into EventHandlers:
* AcceleratorFilter
* MagnificationControllerImpl
* TrayEventFilter
* TouchObserverHUD
* AppListController
* ShelfLayoutManager::AutoHideEventFilter
* SystemGestureEventFilter
BUG=159632
Review URL: https://codereview.chromium.org/11362196
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@167218 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://codereview.chromium.org/11364062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165877 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
When the screen magnifier is enabled, Ctrl-Alt-Scroll is used for changing zoom scale. But sometimes quick *flick* makes scrolling instead of zooming. This CL ignores fling scroll events and fix the problem.
BUG=157490
Review URL: https://chromiumcodereview.appspot.com/11301029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165115 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The Point3F::AsPoint() method converts from float to integer by doing an
implicit floor() on the values. Instead, we should have AsPointF() return
floating point values, and use the ToFlooredPoint() conversion method to
explicitly floor the values at the call-site if desired.
Also, move the point3.h header to point3_f.h so that it is consistent with
other geometry header file namings.
BUG=147395
R=sky
Review URL: https://chromiumcodereview.appspot.com/11301043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@165102 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 162142 - Full Screen Magnifier: Add MagnificationManager
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162080
Review URL: https://chromiumcodereview.appspot.com/11065008
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11194011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162080
Review URL: https://chromiumcodereview.appspot.com/11065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=151891
TEST=manual
R=zork@chromium.org
TBR=sky@chromium.org
# TRBing for simple change only of magnification_controller
Review URL: https://chromiumcodereview.appspot.com/11172002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Review URL: https://chromiumcodereview.appspot.com/11065008
TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/11169002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
MagnificationManager controls the full screen magnifier from chrome-browser side (not ash side. Note that MagnificationController is on ash side).
MagnificationManager does:
- Watch logged-in. Change the behavior between the login screen and user desktop.
- Watch change of the pref. When the pref changes, the setting of the magnifier will interlock with it.
In addition, this patch make the magnifier settings per-user instead of per-device.
BUG=151891
TEST=manual, browser_test passes.
Review URL: https://chromiumcodereview.appspot.com/11065008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@162080 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
It is more appropriate for Transform class to belong with its fellow
geometry classes in the gfx namespace.
Review URL: https://chromiumcodereview.appspot.com/11145005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161809 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes mainly three parts:
- Add LockCursor and UnlockCursor to CursorClient.
- Move the code to change cursor visibility from aura::RootWindow and
aura::RootWindowHostLinux to ash::CursorManager.
- Remove CursorDelegate, which was too much simple delegation and unnecessary.
BUG=153702
TEST=CursorManagerTest.ShowCursor
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=161454
Review URL: https://chromiumcodereview.appspot.com/11035050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161629 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes mainly three parts:
- Add LockCursor and UnlockCursor to CursorClient.
- Move the code to change cursor visibility from aura::RootWindow and
aura::RootWindowHostLinux to ash::CursorManager.
- Remove CursorDelegate, which was too much simple delegation and unnecessary.
BUG=153702
TEST=CursorManagerTest.ShowCursor
Review URL: https://chromiumcodereview.appspot.com/11035050
TBR=mazda@chromium.org
Review URL: https://codereview.chromium.org/11114007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161466 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL changes mainly three parts:
- Add LockCursor and UnlockCursor to CursorClient.
- Move the code to change cursor visibility from aura::RootWindow and
aura::RootWindowHostLinux to ash::CursorManager.
- Remove CursorDelegate, which was too much simple delegation and unnecessary.
BUG=153702
TEST=CursorManagerTest.ShowCursor
Review URL: https://chromiumcodereview.appspot.com/11035050
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ALT + Scroll]
BUG=153961
TEST=manual
TBR=sky@chromium.org
# TRBing for a simple change.
Review URL: https://chromiumcodereview.appspot.com/11026062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160353 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We should not set |scale_| in MagnificationControllerImpl::SetEnabled(), because it will be set in RedrawKeepingMousePosition() later.
BUG=none
TEST=none
TBR=sky@chromium.org
# TRBing for a simple change.
Review URL: https://chromiumcodereview.appspot.com/11029011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160345 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch adds the support of remembering the zoom level. Chrome will save the
value whenever it changes and restore it
on launch.
BUG=150751
Review URL: https://chromiumcodereview.appspot.com/10960008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159084 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* CompoundEventFilter should show cursor only if the cursor was hidden by this event filter.
* CompoundEventFilter shouldn't try to hide if it's already hidden by someone else.
* It no longer needs set_update_cursor_visibility.
* There is one edge case where it leaves cursor visible. Cursor is hidden by the CompoundEventFilter, then again hidden by mouse lock. I changed RWHVA to hide the cursor if it's visible when mouse is moved.
BUG=152319
TEST=updated test case. also tested manually: see bug for repro step.
Review URL: https://chromiumcodereview.appspot.com/10982040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158845 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TBR=jam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10917075
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154817 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/10912063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154721 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This also includes some changes in RenderWidgetHostViewWin to change the way it creates gesture events.
BUG=125937
Review URL: https://chromiumcodereview.appspot.com/10824247
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151044 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=125937
Review URL: https://chromiumcodereview.appspot.com/10831240
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150918 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/125937
TEST=existing
Review URL: https://chromiumcodereview.appspot.com/10827145
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150587 0039d316-1c4b-4281-b951-d872f2087c98
|