summaryrefslogtreecommitdiffstats
path: root/ash/root_window_controller.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rename GetActiveRootWindow -> GetTargetRootWindowoshima@chromium.org2013-09-121-6/+6
| | | | | | | | | | Fixed wrong use of GetActiveRootWindow in couple of places. BUG=266378 Review URL: https://chromiumcodereview.appspot.com/23461048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222914 0039d316-1c4b-4281-b951-d872f2087c98
* Move the content-dependent RecreateLayer logic from aura::Window to RWHVApiman@chromium.org2013-09-121-4/+2
| | | | | | | | | | | | aura::Window is the wrong place to reason about all the different types of external data that can go into layer, its delegate (RWHVA) is better suited. So move that logic there. BUG=263068 Review URL: https://chromiumcodereview.appspot.com/23444051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222735 0039d316-1c4b-4281-b951-d872f2087c98
* Move GetRootWindowController to root_window_controller.hoshima@chromium.org2013-09-061-4/+8
| | | | | | | | | | Remove unnecessary includes, forward decls BUG=272460 Review URL: https://chromiumcodereview.appspot.com/24020002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221605 0039d316-1c4b-4281-b951-d872f2087c98
* RootWindowController::GetFullscreenWindow() should return the active one.mukai@chromium.org2013-09-061-6/+7
| | | | | | | | | | | | | | | | | | It returned the fullscreen window (if any) in the active workspace, and a workspace could contain only one fullscreen window at most. However, now there's only one desktop workspace which can contain multiple fullscreen windows. To follow the past state, it would be better to return the active fullscreen window first. TEST=covered by ash_unittests R=oshima@chromium.org, sky@chromium.org BUG=None Review URL: https://chromiumcodereview.appspot.com/23534049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221602 0039d316-1c4b-4281-b951-d872f2087c98
* Change active root window before closing old root windows' children.flackr@chromium.org2013-09-051-1/+6
| | | | | | | | BUG=282582 Review URL: https://chromiumcodereview.appspot.com/23494022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221497 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce RootWindowProperty for RootWindow's propertiesoshima@chromium.org2013-08-301-1/+4
| | | | | | | | BUG=272460 Review URL: https://chromiumcodereview.appspot.com/23496024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@220667 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors CaptureController so that both views and ash can use it.sky@chromium.org2013-08-221-0/+5
| | | | | | | | | | | | | | | | | | | | | | CaptureController and DesktopCaptureClient differed only slightly, and the latter wasn't always cleaning things up leading to the possibility of a use after free. Specifically DesktopCaptureClient::SetCapture() invokes OnOtherCaptureClientTookCapture() *after* updating the capture_window_. SetCapture in term invokes SetCapture(NULL) on the other DesktopCaptureClient, which call GetCaptureWindow(), which returns the first non-null capture_client_, which can be the new one when it wants the old one. This change also means when both ash and aura-windows are running at the same time capture is correctly updated between the two. BUG=268648 TEST=covered by tests. R=erg@chromium.org, oshima@chromium.org Review URL: https://codereview.chromium.org/22929007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@219019 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the order of deleting child windows at shutdown.mukai@chromium.org2013-08-201-3/+24
| | | | | | | | | | | | | | | | | | Instead of simply deleting depth-first, it deletes all toplevel windows first and then remove the containers. This would be safer since all of the containers exist during deleting the child windows. This change would enable to eliminate other NULL checks in ash, but it will be done in further CLs. BUG=273310 R=derat@chromium.org, oshima@chromium.org TEST=covered by the new test case Review URL: https://chromiumcodereview.appspot.com/23219004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@218488 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Fix CopyAreaToCanvas() scaling issues.derat@chromium.org2013-08-141-1/+10
| | | | | | | | | | | | | This moves aura's RootWindow::CopyAreaToSkCanvas() to CopyAreaToCanvas() in x11_util and fixes some physical vs. display-independent pixel confusion that resulted in it always failing on non-1x systems. BUG=152309 Review URL: https://chromiumcodereview.appspot.com/22910003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217669 0039d316-1c4b-4281-b951-d872f2087c98
* Whitelist virtual keyboard container to process events at login screenbshe@chromium.org2013-08-131-0/+1
| | | | | | | | | | | | | | | When user session is blocked (login screen, lock etc.), virtual keyboard container window should still be able to process events to function properly. BUG=263599 TEST= 1. Enable virtual keyboard 2. go to login screen verify if you can use virtual keyboard to type you password and login Review URL: https://chromiumcodereview.appspot.com/22465007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217159 0039d316-1c4b-4281-b951-d872f2087c98
* Delete EmptyWindowDelegate when window is destroyedoshima@chromium.org2013-08-071-1/+3
| | | | | | | | | | | This should fix leaks reported on memory bots. TBR=jyasskin@chromium.org BUG=none Review URL: https://codereview.chromium.org/22299006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216200 0039d316-1c4b-4281-b951-d872f2087c98
* Create an invisible window during login so thatoshima@chromium.org2013-08-071-0/+75
| | | | | | | | | | | | | | | mouse can move between displays. Added NoSessionAshTestBase for tests that should run before a user logs in. BUG=266987 TEST=covered by test TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/21519002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216184 0039d316-1c4b-4281-b951-d872f2087c98
* Retires WorkspaceContainer.mukai@chromium.org2013-08-051-29/+6
| | | | | | | | | | | | Now DefaultContainer holds the normal windows. BUG=264396 R=sky@chromium.org TEST=ash_unittests still passes Review URL: https://chromiumcodereview.appspot.com/21806009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@215664 0039d316-1c4b-4281-b951-d872f2087c98
* Retires Workspace and WorkspaceManager.mukai@chromium.org2013-07-311-7/+1
| | | | | | | | | | | | | | | | | | Now only a single workspace is provided to a user, so there's nothing to 'manage' multiple workspaces. Several property settings and code in the deleted code has been moved to WorkspaceController and WorkspaceLayoutManager. The test is also moved to WorkspaceControllerTest. BUG=264396 R=sky@chromium.org TEST=ash_unittests still passes Review URL: https://chromiumcodereview.appspot.com/21148003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@214869 0039d316-1c4b-4281-b951-d872f2087c98
* Modal window in user session not blocks user adding screen.dzhioev@chromium.org2013-07-241-7/+3
| | | | | | | | | | | | | | | | Added IsUserSessionBlocked method indicating whether user session blocked by some overlying UI (it can be lock/login/user adding UI). Replaced IsScreenLocked() [|| IsActiveUserSessionStarted()] with IsUserSessionBlocked() in several places in order to keep focus and user input in locked container. BUG=none TEST=ash_unittests R=sky Review URL: https://chromiumcodereview.appspot.com/19945004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213524 0039d316-1c4b-4281-b951-d872f2087c98
* Dock with non-zero widthvarkha@chromium.org2013-07-191-1/+11
| | | | | | | | | | | | | BUG=233337 BUG=247085 This CL builds on https://codereview.chromium.org/13896026/ and adds a non-zero width dock. It is possible to add windows to the dock and it will update its width (insetting the workspace). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212306 Review URL: https://chromiumcodereview.appspot.com/15719012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212535 0039d316-1c4b-4281-b951-d872f2087c98
* broke compilation on win_aura: exported class using non-exported interfacejochen@chromium.org2013-07-181-11/+1
| | | | | | | | | | | | | | | | | | | Revert 212306 "Dock with non-zero width" > Dock with non-zero width > > BUG=233337 > BUG=247085 > > This CL builds on https://codereview.chromium.org/13896026/ and adds a non-zero width dock. It is possible to add windows to the dock and it will update its width (insetting the workspace). > > Review URL: https://chromiumcodereview.appspot.com/15719012 TBR=varkha@chromium.org Review URL: https://codereview.chromium.org/19592007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212352 0039d316-1c4b-4281-b951-d872f2087c98
* Dock with non-zero widthvarkha@chromium.org2013-07-181-1/+11
| | | | | | | | | | | BUG=233337 BUG=247085 This CL builds on https://codereview.chromium.org/13896026/ and adds a non-zero width dock. It is possible to add windows to the dock and it will update its width (insetting the workspace). Review URL: https://chromiumcodereview.appspot.com/15719012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@212306 0039d316-1c4b-4281-b951-d872f2087c98
* * Remove unnecessary SetProperty(kStayInSameRootWindowKey)oshima@chromium.org2013-07-121-3/+4
| | | | | | | | | | | | | | | | This is set in container now, so no need to set individual window underneath. * Set kStayInSameRootWindowKey to ShelfContainer, to be consistent with other containers. * Rename launcher_container to shelf_container in RWC.cc. BUG=256747 Review URL: https://chromiumcodereview.appspot.com/18688003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211331 0039d316-1c4b-4281-b951-d872f2087c98
* Sets the background color of shelf is opaque black when maximized (2nd)mukai@chromium.org2013-07-111-1/+1
| | | | | | | | | | | | | | | Previously the black color was achieved by hiding the desktop background. Now shelf's background color is opaque black instead. The first patch (r210763) was reverted due to test failure in win8. BUG=252422 TEST=covered by the new tests TBR=jamescook@chromium.org Review URL: https://chromiumcodereview.appspot.com/18637004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@211053 0039d316-1c4b-4281-b951-d872f2087c98
* Breaks ShelfLayoutManagerTest.ShelfBackgroundColor on Win8 Aurajochen@chromium.org2013-07-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | Revert 210763 "Sets the background color of shelf is opaque blac..." > Sets the background color of shelf is opaque black when maximized. > > Previously the black color was achieved by hiding the desktop background. > Now shelf's background color is opaque black instead. > > Note that right now BaseLayoutManagerTest fails, but it'll be fixed by > crrev.com/18326024 > > BUG=252422 > R=jamescook@chromium.org > TEST=covered by the new tests > > Review URL: https://chromiumcodereview.appspot.com/18339008 TBR=mukai@chromium.org Review URL: https://codereview.chromium.org/18980003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210772 0039d316-1c4b-4281-b951-d872f2087c98
* Sets the background color of shelf is opaque black when maximized.mukai@chromium.org2013-07-101-1/+1
| | | | | | | | | | | | | | | | Previously the black color was achieved by hiding the desktop background. Now shelf's background color is opaque black instead. Note that right now BaseLayoutManagerTest fails, but it'll be fixed by crrev.com/18326024 BUG=252422 R=jamescook@chromium.org TEST=covered by the new tests Review URL: https://chromiumcodereview.appspot.com/18339008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210763 0039d316-1c4b-4281-b951-d872f2087c98
* Add persisted preference for projection touch HUDmohsen@chromium.org2013-07-091-16/+27
| | | | | | | | | | | | | A new preference is created showing if the projection touch HUD is enabled or not. This preference is per-user and unsyncable. It is not exposed anywhere in the UI, but can be toggled using the Ctrl+Alt+9 accelerator combination. BUG=233567 Review URL: https://chromiumcodereview.appspot.com/18163006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210516 0039d316-1c4b-4281-b951-d872f2087c98
* Keep windows in status/settings bubble in the same root windowoshima@chromium.org2013-07-081-0/+8
| | | | | | | | | BUG=256747 TEST=covered by test Review URL: https://chromiumcodereview.appspot.com/18602002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@210402 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify RootWindowController init processoshima@chromium.org2013-07-031-97/+104
| | | | | | | | | | Fixed the order of method body to match the order in header. BUG=253991 Review URL: https://chromiumcodereview.appspot.com/18266004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209915 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary CreateLaucnher.oshima@chromium.org2013-07-021-7/+0
| | | | | | | | | | | This is part of https://codereview.chromium.org/16305009/ but lost due to merge error. TBR=stevenjb@chromium.org BUG=none Review URL: https://chromiumcodereview.appspot.com/18420004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209755 0039d316-1c4b-4281-b951-d872f2087c98
* Wallpaper refactoring.oshima@chromium.org2013-07-021-14/+45
| | | | | | | | | | | - Move the ownership of controllers to RootWindowController Start wallpaper animation after animating controller is set. BUG=157159 Review URL: https://chromiumcodereview.appspot.com/17910007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209613 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: move AlwaysOnTopController to RootWindowControlleroshima@chromium.org2013-07-021-11/+13
| | | | | | | | | | remove if (shelf_) as it should always be there. BUG=253991 Review URL: https://chromiumcodereview.appspot.com/18323011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209575 0039d316-1c4b-4281-b951-d872f2087c98
* Separate projection mode from rest of touch HUDmohsen@chromium.org2013-07-011-8/+24
| | | | | | | | | | | | | Projection mode is separated from the rest of the touch HUD. It now can be toggled on/off using Ctrl+Alt+9 key combination and no command line flag is needed. The rest of the touch HUD is still behind the --ash-touch-log flag. BUG=233567 Review URL: https://chromiumcodereview.appspot.com/17063013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209523 0039d316-1c4b-4281-b951-d872f2087c98
* Move DisplayLayout out from display_controller.hoshima@chromium.org2013-06-281-2/+0
| | | | | | | | | | | Remove unnecessary includes BUG=253991 R=jamescook@chromium.org Review URL: https://codereview.chromium.org/18080004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209143 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of time headers in android_webview/, apps/, ash/.avi@chromium.org2013-06-271-1/+1
| | | | | | | | | | BUG=254986 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/18050008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209025 0039d316-1c4b-4281-b951-d872f2087c98
* Add double click and tap handler to minimize attached panels.flackr@chromium.org2013-06-211-1/+2
| | | | | | | | | BUG=246603 TEST=Open a panel (i.e. hangouts) and double click and tap on header. Panel should minimize. Review URL: https://chromiumcodereview.appspot.com/17175019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207949 0039d316-1c4b-4281-b951-d872f2087c98
* Add ContextMenuSourceType to ↵varunjain@chromium.org2013-06-181-3/+4
| | | | | | | | | | | | | views::ContextMenuController::ShowContextMenuForView. This will help bring context menu positioning logic to one place and unify the positioning logic for all views. BUG=239110 Review URL: https://chromiumcodereview.appspot.com/16979002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207019 0039d316-1c4b-4281-b951-d872f2087c98
* Stick windows to side of workspacesvarkha@chromium.org2013-06-181-0/+20
| | | | | | | | BUG=233331 Review URL: https://chromiumcodereview.appspot.com/13896026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207002 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite scoped_ptr<T>(NULL) to use the default ctor in ash/.dcheng@chromium.org2013-06-131-1/+0
| | | | | | | | | | | This is the result of running the rewrite_scoped_ptr_ctor_null tool across all files built on CrOS in the ash/ directory. BUG=173286 Review URL: https://chromiumcodereview.appspot.com/16968003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@206125 0039d316-1c4b-4281-b951-d872f2087c98
* Call OpenAsh before Profile Init and CreateLauncher() afterstevenjb@chromium.org2013-05-311-0/+4
| | | | | | | | | | | | | | | This partially undoes the changes from https://chromiumcodereview.appspot.com/15702004 Rather than initializing Ash after Profile Init, initialize Ash first and postpone CreateLauncher() and any other calls that may depend on GetDefaultProfile() until after profiles have been initialized. BUG=245055 Review URL: https://chromiumcodereview.appspot.com/16229008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203454 0039d316-1c4b-4281-b951-d872f2087c98
* Ensures calling OnMouseExited for window close with mouse hovers.mukai@chromium.org2013-05-201-2/+2
| | | | | | | | | | | | | This is introduced to keep the consitent behavior of non-aura Windows and aura. BUG=241253 R=sky@chromium.org TEST=covered by aura_unittests Review URL: https://chromiumcodereview.appspot.com/15235002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201170 0039d316-1c4b-4281-b951-d872f2087c98
* Adding new user menu section to the SystemTrayMenu & refactoring of user accessskuhne@chromium.org2013-05-181-1/+1
| | | | | | | | | | | | | | | | | | | It is still not fully finished - but it is functional and might be useful for what you are doing (and already quite big as it is). Note that the functionality is controlled by the flag. What is missing? - There are no unit tests yet - The visual Drop down box to add a new user is missing. - The error message box which shows the error if there are already 3 users signed in is missing. - At the moment I have ~7 lines of test code in there which I will remove before I check in. (I need them since the multi login still does not work for me) I am not sure if you want to wait until I finish the issue - or if you'd rather want to have this to be able to rather merge early then later. I leave this up to you. If you are for the latter one, you can have at least a look at my changes and if they conflict with yours. BUG=239201 TEST=visual Review URL: https://chromiumcodereview.appspot.com/14756019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200978 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ash-disable-launcher-per-display flagoshima@chromium.org2013-05-101-18/+11
| | | | | | | | | BUG=239681 TEST=none Review URL: https://chromiumcodereview.appspot.com/14584004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199368 0039d316-1c4b-4281-b951-d872f2087c98
* Hide the tab indicators and the shelf when in immersive + tab fullscreen. pkotwicz@chromium.org2013-04-301-4/+5
| | | | | | | | | | BUG=234447, 233271 Test=ImmersiveModeControllerAshTest.TabAndBrowserFullscreen, RootWindowController.GetFullscreenWindow Review URL: https://chromiumcodereview.appspot.com/14340007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197400 0039d316-1c4b-4281-b951-d872f2087c98
* Partial fix for keyboard occlusion.bryeung@chromium.org2013-04-291-0/+4
| | | | | | | | | | | | | | | | | This fixes three aspects of keyboard occlusion. When the keyboard is showing: - full-screen windows are resized to still be 100% visible - panels are moved above the keyboard - the shelf is hidden This CL does not address: - moving focused text fields into view in web pages BUG=235157 Review URL: https://chromiumcodereview.appspot.com/14477010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@197129 0039d316-1c4b-4281-b951-d872f2087c98
* Reland "Swap touch HUD when switching primary display"mohsen@chromium.org2013-04-251-18/+4
| | | | | | | | | | | | | | | | | When a display is set as the primary display, its root window (and all its children, including the widget showing the touch HUD) is replaced with the old one's. But, the touch HUD widget is bound to display and should not be swapped between the two displays. So, after swapping the root windows, touch HUDs are swapped back to their own display. Original Review URL: https://codereview.chromium.org/13460017/ BUG=172237 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/14079010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196312 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 196235 "Swap touch HUD when switching primary display"brianderson@chromium.org2013-04-241-4/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | Causes clang compile errors: ash/touch/touch_observer_hud_unittest.cc:226:54:error: format specifies type 'long' but the argument has type 'int64' (aka 'long long') [-Werror,-Wformat] DisplayInfo info(id, base::StringPrintf("x-%ld", id), false); ~~~ ^~ %lld > Swap touch HUD when switching primary display > > When a display is set as the primary display, its root window (and all > its children, including the widget showing the touch HUD) is replaced > with the old one's. But, the touch HUD widget is bound to display and > should not be swapped between the two displays. So, after swapping the > root windows, touch HUDs are swapped back to their own display. > > BUG=172237 > > Review URL: https://chromiumcodereview.appspot.com/13460017 TBR=mohsen@chromium.org Review URL: https://codereview.chromium.org/14481002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196237 0039d316-1c4b-4281-b951-d872f2087c98
* Swap touch HUD when switching primary displaymohsen@chromium.org2013-04-241-18/+4
| | | | | | | | | | | | | | When a display is set as the primary display, its root window (and all its children, including the widget showing the touch HUD) is replaced with the old one's. But, the touch HUD widget is bound to display and should not be swapped between the two displays. So, after swapping the root windows, touch HUDs are swapped back to their own display. BUG=172237 Review URL: https://chromiumcodereview.appspot.com/13460017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@196235 0039d316-1c4b-4281-b951-d872f2087c98
* Restore focus/activation after the root window has been completely deleted.oshima@chromium.org2013-04-221-32/+0
| | | | | | | | | | Otherwise restoring focused/active window may try to use stale display. BUG=229158 Review URL: https://chromiumcodereview.appspot.com/14188054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195552 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unnecessary ".get()" from scoped_ptrs<>.erg@chromium.org2013-04-171-5/+5
| | | | | | | | | | | In r174057, ajwong@ added support for implicit testing to scoped_ptr<>. Removes these in ash/. BUG=232084 Review URL: https://codereview.chromium.org/14297013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194609 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194589 "Revert 194578 "Add ash SessionStateDelegate""bartfab@google.com2013-04-171-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The CL turned out to be innocent, the bots turned green without the revert. > Revert 194578 "Add ash SessionStateDelegate" > > > Add ash SessionStateDelegate > > > > This CL refactors the ShellDelegate by adding a SessionStateDelegate to > > which methods dealing with the session state can be moved. This cleans up > > the huge ShellDelegate interface and paves the way for further Chrome OS > > multiprofile work which will need to add several new methods related to > > the session state. > > > > This CL is only the first step. Several other methods should also move to > > SessionStateDelegate but I do not want to overburden a single CL. > > > > BUG=None > > TEST=Manual and browser/unit tests > > > > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) > > > > Review URL: https://codereview.chromium.org/14295008 > > TBR=bartfab@google.com > > Review URL: https://codereview.chromium.org/14200034 TBR=gavinp@chromium.org Review URL: https://codereview.chromium.org/14200038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194602 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 194578 "Add ash SessionStateDelegate"gavinp@chromium.org2013-04-171-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | > Add ash SessionStateDelegate > > This CL refactors the ShellDelegate by adding a SessionStateDelegate to > which methods dealing with the session state can be moved. This cleans up > the huge ShellDelegate interface and paves the way for further Chrome OS > multiprofile work which will need to add several new methods related to > the session state. > > This CL is only the first step. Several other methods should also move to > SessionStateDelegate but I do not want to overburden a single CL. > > BUG=None > TEST=Manual and browser/unit tests > > TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) > > Review URL: https://codereview.chromium.org/14295008 TBR=bartfab@google.com Review URL: https://codereview.chromium.org/14200034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194589 0039d316-1c4b-4281-b951-d872f2087c98
* Delayed loading of the virtual keyboard.bryeung@chromium.org2013-04-171-0/+1
| | | | | | | | | | | | | | | Don't create the virtual keyboard until it is first shown. This helps prevent some start-up races. Also clean-up some of the object ownership between KeyboardController and KeyboardLayoutManager. Each pointer exists in only one or the other object now. BUG=none Review URL: https://codereview.chromium.org/13932030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194580 0039d316-1c4b-4281-b951-d872f2087c98
* Add ash SessionStateDelegatebartfab@google.com2013-04-171-1/+2
| | | | | | | | | | | | | | | | | | | | This CL refactors the ShellDelegate by adding a SessionStateDelegate to which methods dealing with the session state can be moved. This cleans up the huge ShellDelegate interface and paves the way for further Chrome OS multiprofile work which will need to add several new methods related to the session state. This CL is only the first step. Several other methods should also move to SessionStateDelegate but I do not want to overburden a single CL. BUG=None TEST=Manual and browser/unit tests TBR=sky (for c/b/idle_chromeos.cc and c/chrome_browser_ui.gypi) Review URL: https://codereview.chromium.org/14295008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194578 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 12:59:49 +0000