summaryrefslogtreecommitdiffstats
path: root/ash/screensaver/screensaver_view_unittest.cc
Commit message (Collapse)AuthorAgeFilesLines
* Remove retail mode.rkc2014-12-181-78/+0
| | | | | | | | | | | | | | | | | | | Now that we are using public accounts for our retail experience, we should get rid of all the retail mode code which is no longer used. Owner reviews requested, nkostylev@ - login pneubeck@ - enterprise derat@ - ash asargent@ - extensions sky@ - c/b/browser_resources.grd and c/b/ui/startup R=bartfab@chromium.org, derat@chromium.org, nkostylev@chromium.org BUG=254840 Review URL: https://codereview.chromium.org/608283003 Cr-Commit-Position: refs/heads/master@{#309022}
* Standardize usage of virtual/override/final specifiers.dcheng2014-10-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=derat@chromium.org Review URL: https://codereview.chromium.org/680153002 Cr-Commit-Position: refs/heads/master@{#301490}
* replace OVERRIDE and FINAL with override and final in ash/mostynb2014-10-031-1/+1
| | | | | | | | BUG=417463 Review URL: https://codereview.chromium.org/621133002 Cr-Commit-Position: refs/heads/master@{#298040}
* Reduce creation of ViewsDelegatesky@chromium.org2014-05-141-2/+0
| | | | | | | | | | | | | | | | | | | By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270290 Review URL: https://codereview.chromium.org/280863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270399 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 270290 "Reduce creation of ViewsDelegate"raymes@google.com2014-05-141-0/+2
| | | | | | | | | | | | | | | | | | | | | | | | | Speculatively reverting as it may have caused the tree to break: http://build.chromium.org/p/chromium.win/builders/Win%20Builder/builds/20345/steps/compile/logs/stdio > Reduce creation of ViewsDelegate > > By consolidating override of OnBeforeWidgetInit that finds shell many > of the places that were setting a viewsdelegate no longer need to. > > Also, made AshTestHelper install a ViewsDelegate so that tests don't have. > > Because of removed an include of views_delegate from ash_test_helper I had to update some includes. > > BUG=none > TEST=none > R=ben@chromium.org > > Review URL: https://codereview.chromium.org/280863002 TBR=sky@chromium.org Review URL: https://codereview.chromium.org/286753002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270305 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce creation of ViewsDelegatesky@chromium.org2014-05-141-2/+0
| | | | | | | | | | | | | | | | | By consolidating override of OnBeforeWidgetInit that finds shell many of the places that were setting a viewsdelegate no longer need to. Also, made AshTestHelper install a ViewsDelegate so that tests don't have. Because of removed an include of views_delegate from ash_test_helper I had to update some includes. BUG=none TEST=none R=ben@chromium.org Review URL: https://codereview.chromium.org/280863002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270290 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate ash::internal namespaceoshima@chromium.org2014-04-031-3/+2
| | | | | | | | | | | Plus obvious style nit fixes. BUG=None TBR=sky@chromium.org Review URL: https://codereview.chromium.org/224113005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly integrate StoragePartition into TestingProfile.ajwong@chromium.org2013-07-231-2/+2
| | | | | | | | | | | | | | | | | | | | | | | Until this CL, TestingProfile had 3 distinct URLRequestContexts it would return to the user: one via profile->GetDefaultStoragePartition()->GetRequestContext(), one via profile->GetRequestContext(), and one via profile->GetResourceContext->GetRequestContext(). All of these had different cookie stores. This CL unified them so they all return the one from profile->GetDefaultStoragePartition()->GetRequestContext(). This correctly mimics how production code works. Doing this had a bunch of implications: (1) Removes TestingProfile::CreateRequestContext()/ResetRequestContext() (2) Changes MockRequestContext to share the URLRequestContext with TestingProfile. (3) TestingProfile now requires all BrowserThreads. Point (3) effectively adds TestBrowserThreadBundle into a bunch more spots. Because of that, we also have the following changes: (a) AshTestBase now has a TestBrowserThreadBundle (b) Removed a bunch of real threads from tests. (c) TemplateUrlService has reworked synchronization semantics. (d) Removed MultiThreadTestHelper. (e) Added TestingIOThread class + testing API in IOThread to mock out various IO thread tasks which enervated with the new TestBrowserThreadBundle. TBR=bauerb,brettw,isherman,joth,jyasskin,mattm,mmenke,mnissler,pkasting,rkc,rlp,satorux,tim,xians,joth BUG=159193 Review URL: https://chromiumcodereview.appspot.com/17127002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213272 0039d316-1c4b-4281-b951-d872f2087c98
* Screensaver implementation for ChromeOS.rkc@chromium.org2013-02-011-9/+1
| | | | | | | | | | | | | | | This is the initial implementation for screensaver extensions. The feature is currently behind a flag and installing an extension with a screensaver permission without the flag enabled will do nothing. This currently allows one Screensaver extension to be installed at a time, and brings up the screensaver after a fixed 2 minutes. Further work to be done is to add different timeouts for power manager if the screensaver is active, add more tests and add security features for the screensaver permission (if needed, this needs to be discussed still). TBR'ed jhawkins for chrome_browser_chromeos.gypi R=mpcomplete@chromium.org,stevenjb@chromium.org BUG=163681 TBR=jhawkins@chromium.org Review URL: https://codereview.chromium.org/12093058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180189 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup of removing unnecessary web_contents.h include from webview.h. This ↵jam@chromium.org2012-12-061-0/+1
| | | | | | | | is split off from https://codereview.chromium.org/11444013/ Review URL: https://codereview.chromium.org/11474002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171535 0039d316-1c4b-4281-b951-d872f2087c98
* Fix leaks in ash_unittestsoshima@chromium.org2012-09-101-5/+0
| | | | | | | | | | | | also suppressed leaks in non chrome component plus a couple of cleanups (eliminated unused code/variables) BUG=144990,146947 TEST=valgrind reports no leak on ash_unittests Review URL: https://chromiumcodereview.appspot.com/10907101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155819 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the mouse event's location that is captured by aura correctlyoshima@chromium.org2012-09-071-0/+1
| | | | | | | | | BUG=145173 TEST=manual. see bug for repro step. Review URL: https://chromiumcodereview.appspot.com/10916121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155382 0039d316-1c4b-4281-b951-d872f2087c98
* Fix view view in views examples.rkc@chromium.org2012-05-311-3/+2
| | | | | | | | | | | | | | The views delegate used in Views Examples derives from TestViewsDelegate, which returns a TestWebContents when WebView tries to create it's webcontents. Since this functionality is intended only for unit tests, moved the test webcontents creation to a subclass of TestViewsDelegate in ash_test_base. This leaves TestViewsDelegate and it's subclasses unaffected. R=ben@chromium.org BUG=None. TEST=Ran aura_test_unittests and verified that the webview example in views examples through ash_shell works correctly. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139690 Review URL: https://chromiumcodereview.appspot.com/10447096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139704 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 139690 - Fix view view in views examples.rkc@chromium.org2012-05-301-2/+3
| | | | | | | | | | | | | | | The views delegate used in Views Examples derives from TestViewsDelegate, which returns a TestWebContents when WebView tries to create it's webcontents. Since this functionality is intended only for unit tests, moved the test webcontents creation to a subclass of TestViewsDelegate in ash_test_base. This leaves TestViewsDelegate and it's subclasses unaffected. R=ben@chromium.org BUG=None. TEST=Ran aura_test_unittests and verified that the webview example in views examples through ash_shell works correctly. Review URL: https://chromiumcodereview.appspot.com/10447096 TBR=rkc@chromium.org Review URL: https://chromiumcodereview.appspot.com/10459041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139694 0039d316-1c4b-4281-b951-d872f2087c98
* Fix view view in views examples.rkc@chromium.org2012-05-301-3/+2
| | | | | | | | | | | | The views delegate used in Views Examples derives from TestViewsDelegate, which returns a TestWebContents when WebView tries to create it's webcontents. Since this functionality is intended only for unit tests, moved the test webcontents creation to a subclass of TestViewsDelegate in ash_test_base. This leaves TestViewsDelegate and it's subclasses unaffected. R=ben@chromium.org BUG=None. TEST=Ran aura_test_unittests and verified that the webview example in views examples through ash_shell works correctly. Review URL: https://chromiumcodereview.appspot.com/10447096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139690 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-041-0/+93
| | | | | | | | | | | | | Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135392 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135369 - Re-implement the screensaver to use WebView instead of ↵rkc@chromium.org2012-05-041-93/+0
| | | | | | | | | | | | | | | | | ExtensionDialogHost. Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 TBR=rkc@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135372 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-041-0/+93
| | | | | | | | | | | | | Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135369 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 135000 - Re-implement the screensaver to use WebView instead of ↵rkc@chromium.org2012-05-021-93/+0
| | | | | | | | | | | | | | | | | | ExtensionDialogHost. Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 TBR=rkc@chromium.org Review URL: https://chromiumcodereview.appspot.com/10335010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135004 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-021-0/+93
| | | | | | | | | | | | | Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@135000 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r134889, "Re-implement the screensaver to use WebView instead of ↵caseq@google.com2012-05-021-93/+0
| | | | | | | | | | | | | | ExtensionDialogHost." The original change broke Win Aura and 3 Linux CrOs builders. TBR=rkc@chromium.org,finnur@chromium.org BUG=chromium-os:28211 TEST=tree goes green Review URL: https://chromiumcodereview.appspot.com/10314008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134893 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-021-0/+93
| | | | | | | | | | | | | | Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: http://codereview.chromium.org/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134889 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 134878 - Re-implement the screensaver to use WebView instead of ↵rkc@chromium.org2012-05-021-93/+0
| | | | | | | | | | | | | | | | | | ExtensionDialogHost. Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 TBR=rkc@chromium.org Review URL: https://chromiumcodereview.appspot.com/10316004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134881 0039d316-1c4b-4281-b951-d872f2087c98
* Re-implement the screensaver to use WebView instead of ExtensionDialogHost.rkc@chromium.org2012-05-021-0/+93
Use WebView to render the screensaver extension instead of ExtensionDialogHost. Using the RenderViewGone override to detect termination of the renderer process to restart it. Added browser tests. R=ben@chromium.org,sky@chromium.org BUG=chromium-os:28211 TEST=Tested that the screensaver comes up; tested the reload via crashing the extension renderer with SIG_ABRT; also ran browser tests. Review URL: https://chromiumcodereview.appspot.com/10191010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134878 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 16:07:00 +0000