| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
Update ShelfLayoutManager to no longer change its state upon entering MaximizeMode.
Update tests to reflect this new behaviour.
TEST=Hide the shelf, open device past 180, shelf should still be hidden.
BUG=385702
Review URL: https://codereview.chromium.org/400663004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286083 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Introduced SnapToPixelLayoutManager and used where it makes sense.
WorkspaceLayoutManager uses WindowState, so it's the property is manually set there.
This depends on the following CL:
https://codereview.chromium.org/375693006/
BUG=391822
Review URL: https://codereview.chromium.org/357063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284119 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Re-enable the shelf auto-hide feature, and the supporting gestures, while in touchview mode.
This effectively reverts the portions of the following reviews which impact the shelf and the launcher context menu.
https://codereview.chromium.org/205603003/
https://codereview.chromium.org/247363005/
TEST=ShelfLayoutManagerTest, LauncherContextMenuTest
BUG=370985
Review URL: https://codereview.chromium.org/305003002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275236 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330746
Review URL: https://codereview.chromium.org/286623004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=351553
TEST=existing unit tests
Review URL: https://codereview.chromium.org/280383009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270293 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=nkostylev@chromium.org
TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267158
Review URL: https://codereview.chromium.org/253063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267337 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> CleanUp: Introduce UserInfo. Move session_state stuff to ash/session.
>
> BUG=None
> R=nkostylev@chromium.org
> TBR=sky@chromium.org
>
> Review URL: https://codereview.chromium.org/253063002
TBR=oshima@chromium.org
Review URL: https://codereview.chromium.org/260783002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
R=nkostylev@chromium.org
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/253063002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267158 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
windows to prevent occlusion by the virtual keyboard, the inner viewport is resized to extend the vertical scroll range.
BUG=242933
Review URL: https://codereview.chromium.org/195793004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
hidden and an edge swipe brings the shelf back.
Allowing immersive / full screen mode in maximize mode
BUG=359606
TEST=ash tests and visual
Review URL: https://codereview.chromium.org/247363005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@266350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rest of the code seem to suggest that we always check validity of status_area_widget() pointer before calling method on it.
Also a specific comment in the code "status_area_widget() may be NULL during the shutdown." seems to suggest status_area_widget being NULL is expected.
shelf_ could have been a possible culprit here, but before we reach this particular statment, we have already called methods on it, so possibility of status_area_widget() being culprit is more. This bug doesn't repro on my machine so have to go with guess work.
BUG=365631
R=skuhne@chromium.org
Review URL: https://codereview.chromium.org/251343003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@265790 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes sure that multi-profile user adding UI gets 100% of working area and
also works fine with onscreen keyboard.
BUG=361157
Review URL: https://codereview.chromium.org/231123002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263611 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
R=skuhne@chromium.org
TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org
BUG=338429
re-landing of https://codereview.chromium.org/176883022/ with fix for the inset of app panel as discussed offline /w jennyz@
Review URL: https://codereview.chromium.org/229453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263451 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Enabled TouchView mode test accelerator on login screen,
changed to Ctrl+Alt+Shift+T (to avoid conflicts).
* Added ash::VirtualKeyboardStateObserver to ShellDelegate.
LoginDisplayHost subscribes to virtual keyboard activations and
hides/shows login WebUI control bar.
* Login WebUI window is no longer fullscreen window so when
virtual keyboard is shown, login window is resized accordingly.
This means a special case for ShelfLayoutManager i.e. status tray (and shelf)
should overflow on top of login window and not resize it
(as with maximized windows in session)
* Added support for scroll in OOBE/login container.
When login window resizes new [scroll-container] it has overflow enabled
but without scrollbars being shown.
* Since all login / oobe WebUI screens are stacked on top of each other
and are hidden just with visibility: hidden, added hidden (display: none)
attribute to all screens which is removed right before new screen
is activated via toggleStep(). Hidden attribute is added after
old screen transition finishes.
* Adding hidden attribute to all screens breaks two things
which are also addressed in this CL:
1. OOBE screens network/eula/update form a screen group so that
their size is adjusted to be the same. This is fixed by
removing hidden attribute for OOBE screen group during init.
2. Same OOBE screens have sliding animation defined and
adding/removing hidden attributed breaks that. Fix (temporary):
don't add hidden attribute to old screen after transition ends.
BUG=354413
Review URL: https://codereview.chromium.org/211433002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Plus obvious style nit fixes.
BUG=None
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/224113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@261522 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Still building as part of the aura target, will fix that in a future step.
TBR=sky@chromium.org
http://crbug.com/308710
Review URL: https://codereview.chromium.org/206453005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
running
BUG=353145
TEST=unittest, ash tests and visual
Review URL: https://codereview.chromium.org/205603003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@258612 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On ChromeOS a reveal occurs on a swipe down from the top
edge, and hides on a swipe up from the top edge.
On Windows we can only detect one piece of information: A
swipe up occurred from the bottom edge, or a swipe down
occured from the top edge. These two events are
indistinguishable on Windows, and they do not come with any
location information.
As a result, the CrOS behavior of these two distinct
operations are merged into one operation here. On Windows
an "edge swipe" displays the shelf AND does the immersive
reveal, whereas on CrOS these are separate operations
triggered by a swipe on the respective edges.
Hiding should still behave the same as CrOS.
BUG=227247
Review URL: https://codereview.chromium.org/198413003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@257909 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/176883022/)
Reason for revert:
This cl is breaking the app list launch bubble. see crbug.com/351776.
Original issue's description:
> Shelf Cleanup (- binary files)
>
> R=skuhne@chromium.org
> TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org
> BUG=338429
>
> re-landing of
> https://codereview.chromium.org/140323010/ hopefully this time with less breaking everything.
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=256319
TBR=jamescook@chromium.org,skuhne@chromium.org,harrym@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338429
Review URL: https://codereview.chromium.org/198063003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
R=skuhne@chromium.org
TBR=jamescook@chromium.org, miket@chromium.org, skuhne@chromium.org
BUG=338429
re-landing of
https://codereview.chromium.org/140323010/ hopefully this time with less breaking everything.
Review URL: https://codereview.chromium.org/176883022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@256319 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(https://codereview.chromium.org/140323010/)
Reason for revert:
Broke Linux ChromiumOS Builder (dbg):
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Builder%20%28dbg%29/builds/45933/steps/compile/logs/stdio
FAILED: /b/build/goma/gomacc c++ -MMD -MF obj/ash/system/web_notification/ash.web_notification_tray.o.d ....
../../ash/system/web_notification/web_notification_tray.cc: In constructor 'ash::WebNotificationTray::WebNotificationTray(ash::internal::StatusAreaWidget*)':
../../ash/system/web_notification/web_notification_tray.cc:322:7:error: 'UseAlternateShelfLayout' is not a member of 'ash::switches'
../../ui/message_center/message_center_style.h: At global scope:
../../ui/message_center/message_center_style.h:103:15:error: 'message_center::kButtonSeparatorColor' defined but not used [-Werror=unused-variable]
../../ui/message_center/message_center_style.h:104:15:error: 'message_center::kHoveredButtonBackgroundColor' defined but not used [-Werror=unused-variable]
../../ui/message_center/message_center_style.h:111:15:error: 'message_center::kProgressBarBackgroundColor' defined but not used [-Werror=unused-variable]
../../ui/message_center/message_center_style.h:112:15:error: 'message_center::kProgressBarSliceColor' defined but not used [-Werror=unused-variable]
../../ui/message_center/message_center_style.h:43:15:error: 'message_center::settings::kEntrySeparatorColor' defined but not used [-Werror=unused-variable]
Original issue's description:
> Part 1) of cleaning up the code related to the shelf layout, specifically removing all instances of branching related to the 'alternate shelf layout' as this is now the only option.
> Removed the about:flags entry relating to alternate shelf layout.
>
> A patch will follow to simplify the remaining layout code as it is still a bit of a spaghetti like mess.
>
> R=jamescook@chromium.org, skuhne@chromium.org
> TBR=miket@chromium.org
> BUG=338429
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254301
TBR=jamescook@chromium.org,skuhne@chromium.org,harrym@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=338429
Review URL: https://codereview.chromium.org/185143002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removing all instances of branching related to the 'alternate shelf layout' as this is now the only option.
Removed the about:flags entry relating to alternate shelf layout.
A patch will follow to simplify the remaining layout code as it is still a bit of a spaghetti like mess.
R=jamescook@chromium.org, skuhne@chromium.org
TBR=miket@chromium.org
BUG=338429
Review URL: https://codereview.chromium.org/140323010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254301 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ShelfLayoutManager::GetInsetsForAlignment() is no longer used.
BUG=318879
R=skuhne@chromium.org
Review URL: https://codereview.chromium.org/167373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@253050 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Switches updating of state_.is_screen_locked to push rather than pull.
is_screen_locked is set when the lock animation starts and unset when
OnLockStateChanged is called with locked unset.
If is_screen_locked is set avoid generating notifications about inset
changes.
BUG=338377
Review URL: https://codereview.chromium.org/175473003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252785 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://crbug.com/308843
TBR=sky@chromium.org
Review URL: https://codereview.chromium.org/174803002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This change does the following:
1) Adds a new gesture referred to as an EdgeSwipe gesture.
This is Win8 / Metro specific, and refers to a swipe up from
the bottom edge, or swipe down from the top edge. The
semantics of this gesture are slightly different than those
of a bezel gesture, which can occur on any edge, and for
which you can determine specifically which edge it was (not
possible with Win8 edge swipe).
2) edge swipe no longer enters / exits full screen mode.
Instead it makes the shelf visible (if it was hidden, and
auto-hide was checked), disables auto-hide, and exits full
screen.
BUG=340772
R=asvitkine@chromium.org, cpu@chromium.org, harrym@chromium.org, jschuh@chromium.org, sadrul@chromium.org, sky@chromium.org
Review URL: https://codereview.chromium.org/143023003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@250738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=330746
Review URL: https://codereview.chromium.org/146023005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@248462 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Event-targeters (e.g. wm::EasyResizeWindowTargeter) now do the necessary work
for allowing a window to receive events outside of its bounds. So these methods
on aura::Window are no longer necessary.
BUG=318879
R=ben@chromium.org
Review URL: https://codereview.chromium.org/133873004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows.
This CL is adding window animations for the following multi profile related actions:
- switching the user
- teleporting of windows
- window ownership changes
The user switch animation is as follows:
Time: ----->
Screen: A X B
- The desktop cross dissolves between A -> B
- User A's windows fade out between A -> X
- User B's windows get faded in between X -> B
- User A's shelf gets hidden between A -> X
- The user icon in the system tray as well as the shelf configuration changes at 'X'.
- User B's shelf gets faded on between X -> B
So at time X the user would see a half way cross dissolved desktop and shared windows (if there are any).
Since there is no guarantee that there is an animation going from A -> X an additional timer was used to kick off the second animation portion.
Further gotchas:
- Animations of the individual shelf items were in the past incorrectly performed with another animator which produced a lag for some components (e.g. the activation bar lagged and / or there was a gap between icons in the tray and the screen border when playing the animation fast.
- Wallpaper loading was so delayed that the animations started after all other animations were done.
BUG=336639, 307279
Review URL: https://codereview.chromium.org/130983007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
ShelfLayoutManager clears |workspace_controller_| in its PrepareForShutdown
during shutdown and the case needs to be handled in UpdateVisibilityState.
BUG=334321
Review URL: https://codereview.chromium.org/146703003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@247031 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Split ScreenAsh to ScreenUtil (set of utility functions) and the screen implementation.
* moved screen_ash from Shell to DisplayManager. Ash specific imp is now hidden in DisplayManager.
* Shell now creates a separate screen object which simply keeps the list of displays for shutdown. This allow all screen operation valid during shutdown.
BUG=None
TBR=hongbo.min@intel.com,sky@chromium.org
Review URL: https://codereview.chromium.org/138003007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@245562 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I decided to split the constants into its own component to make the
transition easier to do and review.
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
TBR=tapted@chromium.org # for c/b/ui/apps
Review URL: https://codereview.chromium.org/97983003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- move launcher* from launcher to shelf.
- rename to launcher.* to shelf.* and launcher_unittest.cc to
shelf_unittest.cc
- rename LauncherTestAPI to ShelfTestAPI.
- rename to launcher_test_api.* to shelf_test_api.*
BUG=248353
TEST=None, no functional changes
R=jamescook@chromium.org,harrym@chromium.org
TBR=sky
Review URL: https://codereview.chromium.org/115113006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241794 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=321704
TEST=ash_unittests --gtest_filter=*WorkspaceControllerTestDragging.DragWindowOverlapShelf*
Review URL: https://codereview.chromium.org/102493004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=319889
TEST=ShelfLayoutManagerTest.FullscreenWindowInFrontHidesShelf, ShelfLayoutManagerTest.FullscreenWindowOnSecondDisplay,WorkspaceLayoutManagerTest.NotifyFullscreenChanges
TEST=Navigate to a site using HTML5 fullscreen API, alt tab away to another window and back. Window remains fullscreen but shelf shows while another window is in front.
Review URL: https://codereview.chromium.org/100903002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239859 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=267582
TEST=Visual.
Dock a window.
Verify that docked background is same as the launcher background.
Open a second browser window.
Maximize it.
Verify that both docked background and the shelf background become opaque black.
Review URL: https://codereview.chromium.org/98373006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239284 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ash::wm::WindowState::hide_shelf_when_fullscreen()
BUG=None
TEST=None
R=jamescook
TBR=sky (For trivial change in chrome/browser/notifications/fullscreen_notification_blocker.cc)
Review URL: https://codereview.chromium.org/32943006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@231398 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=234271
TEST=visual, using arabic language, made sure that status menu, launcher, notifications and chat window icons were at the right place
Review URL: https://codereview.chromium.org/27711005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=248353
TEST=none, no functional changes.
R=jamescook@chromium.org, xiyuan@chromium.org
TBR=sky@chromium.org # for chrome/browser/ui
Review URL: https://codereview.chromium.org/27628002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@229274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=298210
TEST=ash_unittests --gtest_filter=*AttachOneAutoHideShelf*
Review URL: https://codereview.chromium.org/26662002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@228858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/24108003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Unit tests added for above.
Position of status area and launcher items (App list/Overflow) updated to spec.
Removed duplicate variable for positioning (App list, Overflow Button and status area now share an inset constant).
BUG=288294, 288296, 288399
Review URL: https://chromiumcodereview.appspot.com/23928004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
R=ben@chromium.org
TBR=brettw@chromium.org, scherkus@chromium.org, ananta@chromium.org,
Review URL: https://codereview.chromium.org/23851041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223906 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I also made GFX_EXPORT real, which is ok since it's the same as
UI_EXPORT. It'll only matter when we separate out at gyp level.
BUG=none
TEST=none
R=ben@chromium.org
Review URL: https://codereview.chromium.org/23531053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223289 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Add animation to the status area widget for lock screen, forcing shelf (specifically status area widget) to be in the bottom alignment state while the screen is locked.
BUG=223776
Review URL: https://chromiumcodereview.appspot.com/23702026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@222271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Remove unnecessary includes, forward decls
BUG=272460
Review URL: https://chromiumcodereview.appspot.com/24020002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221605 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It returned the fullscreen window (if any) in the active workspace,
and a workspace could contain only one fullscreen window at most.
However, now there's only one desktop workspace which can contain
multiple fullscreen windows.
To follow the past state, it would be better to return the active
fullscreen window first.
TEST=covered by ash_unittests
R=oshima@chromium.org, sky@chromium.org
BUG=None
Review URL: https://chromiumcodereview.appspot.com/23534049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Updated and/or duplicated (updated with copy renamed *ForLegacyShelfLayout) unit tests as required.
BUG=246279
TBR=jamescook@chromium.org, skuhne@chromium.org
Review URL: https://codereview.chromium.org/22793011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@221325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
windows part 2
- This CL combines the common parts of ShelfLayoutManager::LayoutShelf() and ShelfLayoutManager::SetState() into
ShelfLayoutManager::UpdateBoundsAndOpacity().
- This CL animates the shelf when a gesture drag is completed / canceled
BUG=268209
TEST=ShelfLayoutManagerTest.ShelfAnimatesWhenGestureComplete
Review URL: https://chromiumcodereview.appspot.com/22638013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217700 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
visible windows
- Ignore the mouse position if mouse events are disabled (this is the case when the user is interacting with the device via touch)
BUG=268209
TEST=ShelfLayoutManagerTest.GestureDrag
Review URL: https://chromiumcodereview.appspot.com/22121002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@216879 0039d316-1c4b-4281-b951-d872f2087c98
|