summaryrefslogtreecommitdiffstats
path: root/ash/shelf
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Remove misc unneeded grit includes.thestig2014-08-283-7/+4
| | | | | | Review URL: https://codereview.chromium.org/512663002 Cr-Commit-Position: refs/heads/master@{#292448}
* Set the shelf icon title explicitly for settings and task managerstevenjb2014-08-262-5/+8
| | | | | | | | | | | This allows us to set the icon title (used for hovertext) independently of the window title (which is empty for Settings windows). BUG=406954 Review URL: https://codereview.chromium.org/507003002 Cr-Commit-Position: refs/heads/master@{#292029}
* Ash: Double-clicking on a shelf item now opens the itemjamescook2014-08-252-11/+63
| | | | | | | | | | | | | Previously it would open the item then immediately minimize it. This caused user confusion because they tried a double-click and didn't see anything open on the screen. BUG=404060 TEST=ash_unittests ShelfViewTest.ClickingTwiceActivatesOnce Review URL: https://codereview.chromium.org/492963008 Cr-Commit-Position: refs/heads/master@{#291695}
* Ash: Fix browser icon menu model lifetimejamescook2014-08-232-5/+4
| | | | | | | | | | | | The menu model needs to be cleaned up if the menu is suppressed for being too short. BUG=406609 TEST=manual, see bug Review URL: https://codereview.chromium.org/486193004 Cr-Commit-Position: refs/heads/master@{#291600}
* Split Shell::ToggleAppList() into ShowAppList and DismissAppList.calamity@chromium.org2014-08-152-13/+13
| | | | | | | | | | | | | This CL is in preparation for passing a reason for showing the app list. This split is necessary to pass a reason only when showing and not when dismissing. BUG=None Review URL: https://codereview.chromium.org/460933002 Cr-Commit-Position: refs/heads/master@{#289889} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289889 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Remove a few unused includes.thakis@chromium.org2014-08-142-2/+0
| | | | | | | | | | | See https://codereview.chromium.org/467193003/ for how. BUG=none Review URL: https://codereview.chromium.org/470663002 Cr-Commit-Position: refs/heads/master@{#289472} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289472 0039d316-1c4b-4281-b951-d872f2087c98
* Moving coordinate conversion methods from ash/wm to ui/wm.mfomitchev@chromium.org2014-08-083-12/+11
| | | | | | | | | | | | Re-submit of https://codereview.chromium.org/425363002/ TBR=sky, oshima BUG=NONE Review URL: https://codereview.chromium.org/445173002 Cr-Commit-Position: refs/heads/master@{#288449} git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288449 0039d316-1c4b-4281-b951-d872f2087c98
* Avoiding double resize of maximized windows upon user switch due to showing ↵skuhne@chromium.org2014-08-062-0/+39
| | | | | | | | | | | and hiding of the shelf BUG=385992 TEST=MultiUserWindowManagerChromeOSTest.TestBlackBarCover & visual inspection Review URL: https://codereview.chromium.org/448493002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287880 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Moving coordinate conversion methods from ash/wm to ui/wm. ↵robliao@chromium.org2014-08-053-11/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/425363002/) Reason for revert: Build break. ../../ash/display/mouse_cursor_event_filter_ozone.cc:21:7:error: no member named 'ConvertPointToScreen' in namespace 'ash::wm' wm::ConvertPointToScreen(target, &point_in_screen); ~~~~^ ../../ash/display/mouse_cursor_event_filter_ozone.cc:45:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm' wm::ConvertPointFromScreen(root_at_point, &point_in_root); ~~~~^ ../../ash/display/mouse_cursor_event_filter_ozone.cc:86:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm' wm::ConvertPointFromScreen(dst_root, &point_in_dst_screen); ~~~~^ Original issue's description: > Moving coordinate conversion methods from ash/wm to ui/wm. > > Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into > aura::Window. The suggestion to do this was made here: > https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h > > BUG=NONE > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287609 TBR=oshima@chromium.org,ben@chromium.org,sky@chromium.org,mfomitchev@chromium.org NOTREECHECKS=true NOTRY=true BUG=NONE Review URL: https://codereview.chromium.org/445703005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287626 0039d316-1c4b-4281-b951-d872f2087c98
* Moving coordinate conversion methods from ash/wm to ui/wm.mfomitchev@chromium.org2014-08-053-12/+11
| | | | | | | | | | | | Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into aura::Window. The suggestion to do this was made here: https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h BUG=NONE Review URL: https://codereview.chromium.org/425363002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@287609 0039d316-1c4b-4281-b951-d872f2087c98
* Reland: Introduce NON_ZERO_DURATION for animation unit testsjamescook@chromium.org2014-07-301-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Animations are usually disabled in unit tests for performance. However, to test the animation system itself some tests request "normal" durations. Under some conditions (remote desktop, animation disabled for accessibility) the "normal" duration could still be zero. This was causing test failures and use-after-frees in ash_unittests on the drmemory bots and for developers using remote desktop. Introduce NON_ZERO_DURATION to signal that animation must be enabled and the duration must be non-zero, but other than that can be as short as possible. (Original patch https://codereview.chromium.org/420013002/ was correlated with app_list_unittests failures in AppListMainViewTest.DragLastItemFromFolderAndDropAtLastSlot AppListViewTestAura.ReshowWithOpenFolder but testing locally and on the try bots can't repro it, so calling it flake.) BUG=397478, 396969 TEST=ash_unittests on drmemory, Windows and Chrome OS bots TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/426973002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286517 0039d316-1c4b-4281-b951-d872f2087c98
* views: Avoid unnecessary overrides of CanProcessEventsWithinSubtree().sadrul@chromium.org2014-07-302-13/+5
| | | | | | | | | | | | | | views::ImageView overrides CanProcessEventsWithinSubtree() to make sure non-interactive image-views do not process any events. Use this override where possible by making the ImageViews non-interactive, rather than overriding the interface method. BUG=none R=sky@chromium.org Review URL: https://codereview.chromium.org/429643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286411 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Introduce NON_ZERO_DURATION for animation unit tests ↵jamescook@chromium.org2014-07-291-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/420013002/) Reason for revert: I suspect this is causing Linux Tests dbg (2) failures in app_list_unittests: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/47929 Strangely I had green try runs for linux_chromium_rel for app_list_unittests. Original issue's description: > Introduce NON_ZERO_DURATION for animation unit tests > > Animations are usually disabled in unit tests for performance. However, to > test the animation system itself some tests request "normal" durations. > Under some conditions (remote desktop, animation disabled for accessibility) > the "normal" duration could still be zero. > > This was causing test failures and use-after-frees in ash_unittests on the > drmemory bots and for developers using remote desktop. > > Introduce NON_ZERO_DURATION to signal that animation must be enabled and the > duration must be non-zero, but other than that can be as short as possible. > > BUG=397478,396969 > TEST=ash_unittests on drmemory, Windows and Chrome OS bots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286089 TBR=oshima@chromium.org,ajuma@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=397478,396969 Review URL: https://codereview.chromium.org/413403011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286102 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce NON_ZERO_DURATION for animation unit testsjamescook@chromium.org2014-07-291-2/+2
| | | | | | | | | | | | | | | | | | | | Animations are usually disabled in unit tests for performance. However, to test the animation system itself some tests request "normal" durations. Under some conditions (remote desktop, animation disabled for accessibility) the "normal" duration could still be zero. This was causing test failures and use-after-frees in ash_unittests on the drmemory bots and for developers using remote desktop. Introduce NON_ZERO_DURATION to signal that animation must be enabled and the duration must be non-zero, but other than that can be as short as possible. BUG=397478,396969 TEST=ash_unittests on drmemory, Windows and Chrome OS bots Review URL: https://codereview.chromium.org/420013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286089 0039d316-1c4b-4281-b951-d872f2087c98
* Make Shelf Consistent in MaximizeModejonross@chromium.org2014-07-293-61/+0
| | | | | | | | | | | | Update ShelfLayoutManager to no longer change its state upon entering MaximizeMode. Update tests to reflect this new behaviour. TEST=Hide the shelf, open device past 180, shelf should still be hidden. BUG=385702 Review URL: https://codereview.chromium.org/400663004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@286083 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-282-28/+28
| | | | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285857 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BubbleDelegateView::use_focuseless().vasilii@chromium.org2014-07-252-2/+2
| | | | | | | | | | | | | It's confusing because it prevents the bubble activation. As a side effect on Windows the bubble doesn't get LBUTTON_DOWN messages. The reason for that is in HWNDMessageHandler::OnMouseActivate(). It asks the bubble if it can be activated. It answers "no" due to implementation in BubbleDelegateView::CanActivate(). Windows gets MA_NOACTIVATEANDEAT and MouseDown event isn't dispatched. This is definitely unexpected. The bubbles which indeed always inactive should use set_can_activate(false) at construction time. The bubbles which can be active but created without focus by default should use ShowInactive() instead. BUG=392734 Review URL: https://codereview.chromium.org/413433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285682 0039d316-1c4b-4281-b951-d872f2087c98
* Distinguish between keystroke and character events.kpschoedel@chromium.org2014-07-252-3/+2
| | | | | | | | | | | | | | | | | | | | As described in its class comment, a ui::KeyEvent can be either of two distinct kinds. When constructing a ui::KeyEvent from a native event, the distinction is made by a new IsCharFromNative() call, in the same way that other ui::Event properties are determined, instead of having the caller inspect the native event itself. Removing the redundant |is_char| parameter from constructors also prevent accidental synthetic `mixed' events that consuming code does not handle. Incidentally, while KeyEvent constructor calls are being touched, use EF_NONE instead of 0 to make that argument's purpose clear. BUG=380349 TEST=unit_tests,ash_unittests,events_unittests,ui_unittests,interactive_ui_tests Review URL: https://codereview.chromium.org/404203003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285605 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 285209 "Cleanups for aura/test/event_generator.h (resolve..."markusheintz@chromium.org2014-07-242-28/+28
| | | | | | | | | | | | | | | | | | | | | | > Cleanups for aura/test/event_generator.h (resolve TODOs) > > Some purely mechanical changes left over from r283694, now that > aura::test::EventGenerator has moved to ui::test in src/ui/events. > > Moves aura/test/event_generator.* to event_generator_delegate_aura.* > Removes `using ui::test::EventGenerator;` declaration and redirects > includes that don't extend the delegate to include the ui/test > event_generator.h directly > > BUG=378134 > > Review URL: https://codereview.chromium.org/406413004 TBR=tapted@chromium.org Review URL: https://codereview.chromium.org/413983006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285222 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanups for aura/test/event_generator.h (resolve TODOs)tapted@chromium.org2014-07-242-28/+28
| | | | | | | | | | | | | | | | Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Review URL: https://codereview.chromium.org/406413004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285209 0039d316-1c4b-4281-b951-d872f2087c98
* Snap widgets to pixel boundary on ashoshima@chromium.org2014-07-183-31/+15
| | | | | | | | | | | | | | | Introduced SnapToPixelLayoutManager and used where it makes sense. WorkspaceLayoutManager uses WindowState, so it's the property is manually set there. This depends on the following CL: https://codereview.chromium.org/375693006/ BUG=391822 Review URL: https://codereview.chromium.org/357063002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284119 0039d316-1c4b-4281-b951-d872f2087c98
* Rename "managed (mode|user)" to "supervised user" (part 7)treib@chromium.org2014-07-181-1/+1
| | | | | | | | | | | | | | | | | | | | | | | Followup to https://codereview.chromium.org/384023002/ This CL renames ChromeOS-specific code. Still missing: - ChromeOS-specific resource IDs (strings and images) - JavaScript, HTML, CSS - The global ENABLE_MANAGED_USERS define TBR=atwilson@chromium.org (c/b/signin) TBR=nkostylev@chromium.org (c/b/chromeos) TBR=noms@chromium.org (c/b/profiles) TBR=oshima@chromium.org (ash and c/b/ui/ash) All TBRs are simple renamings. BUG=385113 Review URL: https://codereview.chromium.org/393343002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284078 0039d316-1c4b-4281-b951-d872f2087c98
* Clear velocity tracker upon delayed ACTION_UPjdduke@chromium.org2014-07-151-1/+2
| | | | | | | | | | | | | | | | | | | | | The velocity tracker currently ignores ACTION_{UP,POINTER_UP} events. While these events don't convey additional motion information, they do convey timing and lack of motion. This is particularly relevent if the final ACTION_UP event is delayed, e.g., the user's finger moves and then is perfectly stationary for a time before being lifted. In that case, the tracker would report the non-zero velocity of the movement, when it really ought to have been cleared because of the delayed release. Add an additional check for such delayed pointer release events, using a value larger than the 40ms |kAssumePointerMoveStoppedTimeMs| to allow for slightly delayed ACTION_UP detection. Also remove the smooth scroll synthetic gesture workaround that was previously required to prevent fling detection. BUG=392652 Review URL: https://codereview.chromium.org/381233002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283218 0039d316-1c4b-4281-b951-d872f2087c98
* MacViews: Move menu run types parameter to constructor.andresantoso@chromium.org2014-07-151-8/+7
| | | | | | | | | | | | | | This is in preparation for supporting running native Cocoa context menus to support Services (https://codereview.chromium.org/331993009/). The parameter is moved to the constructor so that we can know which kind of MenuRunnerImpl to create at construction time. TBR=sky@chromium.org BUG=388455 Review URL: https://codereview.chromium.org/390183002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283114 0039d316-1c4b-4281-b951-d872f2087c98
* Replace touch_ids_bitfield_ with first_touch_id_.tdresser@chromium.org2014-07-141-2/+2
| | | | | | | | | | | | touch_ids_bitfield was overcomplicated, and we never used anything except for the lowest touch id. BUG=366707 TEST=GestureRecognizerTest Review URL: https://codereview.chromium.org/344763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283070 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the logic of popup alignment and workarea handling as delegate.mukai@chromium.org2014-07-101-0/+2
| | | | | | | | | | | | | | | | | | | | | | | MessagePopupCollection contains plenty size of conditions and ifdefs to work properly with each type of the desktop we have, and some logic makes side effects on another desktop. This design is unhealty and adding more conditions sounds incorrect. Considering this, it would be better to extract platform dependent parts as a delegate class (PopupAlignmentDelegate) and allow subclasses to provide platform-specific features. This design is also beneficial for win-ash, because we had OS_CHROMEOS layout data and logic which actually means Ash. BUG=389656 R=stevenjb@chromium.org, dimich@chromium.org TBR=jamescook@chromium.org, harrym@chromium.org TEST=message_center_unittests, ash_unittests, some manual checks Review URL: https://codereview.chromium.org/369573004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282269 0039d316-1c4b-4281-b951-d872f2087c98
* Status Area disappears during Multi-User Sign-injonross@chromium.org2014-06-241-0/+20
| | | | | | | | | | | Update StatusAreaLayoutManager to acccount for animations when it is updating its bounds. TEST=ShelfLayoutManagerTest.ShelfAutoHideToggleDuringAnimationUpdatesBounds BUG=386069 Review URL: https://codereview.chromium.org/343193007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@279504 0039d316-1c4b-4281-b951-d872f2087c98
* Manage settings window icon for multi profilestevenjb@chromium.org2014-06-202-1/+17
| | | | | | | | | | | | Includes some minor refactoring: merges launcher_item_util.cc into ash:shelf_util.cc BUG=385161 R=ben@chromium.org, skuhne@chromium.org Review URL: https://codereview.chromium.org/332163006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278629 0039d316-1c4b-4281-b951-d872f2087c98
* Require the cursor to move a minimum distance after the mouse press before ↵pkotwicz@chromium.org2014-06-183-10/+84
| | | | | | | | | | | | | initiating a mouse drag. The CL also makes ShelfViewTest send ui::MouseEvents in the coordinates of |ShelfView::drag_view_|. BUG=377522 TEST=ShelfViewTest.ClickAndMoveSlightly Review URL: https://codereview.chromium.org/338833008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278129 0039d316-1c4b-4281-b951-d872f2087c98
* Make BoundsAnimator always own its animation delegate.pkasting@chromium.org2014-06-171-11/+13
| | | | | | | | | | | All non-unittest code wanted this behavior. BUG=none TEST=none Review URL: https://codereview.chromium.org/331323005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277707 0039d316-1c4b-4281-b951-d872f2087c98
* Add const to PanelLayoutManagerTest::IsPanelAboveLauncherIcon 'panel' parameterbruthig@chromium.org2014-06-164-4/+5
| | | | | | | | BUG=none Review URL: https://codereview.chromium.org/331843003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@277511 0039d316-1c4b-4281-b951-d872f2087c98
* Enable Shelf Auto-Hide in TouchViewjonross@chromium.org2014-06-053-135/+25
| | | | | | | | | | | | | | | Re-enable the shelf auto-hide feature, and the supporting gestures, while in touchview mode. This effectively reverts the portions of the following reviews which impact the shelf and the launcher context menu. https://codereview.chromium.org/205603003/ https://codereview.chromium.org/247363005/ TEST=ShelfLayoutManagerTest, LauncherContextMenuTest BUG=370985 Review URL: https://codereview.chromium.org/305003002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275236 0039d316-1c4b-4281-b951-d872f2087c98
* compositor: Tick the UI animations from cc, instead of from timer callbacks.sadrul@chromium.org2014-06-051-5/+2
| | | | | | | | | | | | | Update the animations in the UI in response to the animation step in the compositor, instead of from a timer callback. This should make it more difficult for rogue UI animations to negatively impact the system too much. BUG=371071 R=ajuma@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/291843012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274988 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r274404 and r274409:tzik@chromium.org2014-06-031-2/+5
| | | | | | | | | | | | | | | | | "compositor: Tick the UI animations from cc, instead of from timer callbacks." "asan: Fix asan leak from r274404." These CLs seem to break ash_unittests on win8 aura bot: http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20Aura&number=19390 BUG=371071 TBR=sadrul@chromium.org NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/311783002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274423 0039d316-1c4b-4281-b951-d872f2087c98
* compositor: Tick the UI animations from cc, instead of from timer callbacks.sadrul@chromium.org2014-06-031-5/+2
| | | | | | | | | | | | | Update the animations in the UI in response to the animation step in the compositor, instead of from a timer callback. This should make it more difficult for rogue UI animations to negatively impact the system too much. BUG=371071 R=ajuma@chromium.org, piman@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/291843012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274404 0039d316-1c4b-4281-b951-d872f2087c98
* Remove overrides of HitTestRect() which just return falsetdanderson@chromium.org2014-06-022-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | Some overrides of View::HitTestRect() just return false in order to force event-targeting to fail for that view type and its descendants. Because this logic is unrelated to hit-testing against a rectangular region, remove these overrides and instead override View::CanProcessEventsWithinSubtree() to just return false. The relevant classes are: ProfileImageView ShelfButton::BarView ShelfButton::IconView PasswordRow BoundedLabel Label (and Link as a result) BUG=374303 TEST=none Review URL: https://codereview.chromium.org/287193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274366 0039d316-1c4b-4281-b951-d872f2087c98
* Update Status Area Paint Schedulingjonross@chromium.org2014-06-021-1/+1
| | | | | | | | | | | | | With each TrayBackgroundView now backed by its own layer, calling SchedulePaint on StatusAreaWidgetDelegate no longer notifies them of the need to paint. When the shelf changes its dimming state it triggers painting. Add support for StatusAreaWidget to notify each of the layer backed trays that painting is needed TEST=Launch a non-maximized browser. The system tray will be a dark grey. Maximize the browser. The tray should be a lighter grey. This will mimic the colour changes of the application launcher on the shelf. BUG=378115 Review URL: https://codereview.chromium.org/302153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274318 0039d316-1c4b-4281-b951-d872f2087c98
* Prepare for Unified Gesture Recognizer landing in Auratdresser@chromium.org2014-06-021-34/+67
| | | | | | | | | | | | | This is the final cleanup before the unified gesture recognizer is turned on. Tests are passing with the unified GR flag on and with the flag off. BUG=332418 Test=GestureRecognizerTest.*, GestureProviderTest.* Review URL: https://codereview.chromium.org/306483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@274277 0039d316-1c4b-4281-b951-d872f2087c98
* Moving default minimize location to the app launcher item.skuhne@chromium.org2014-05-303-4/+39
| | | | | | | | | BUG=374833 TEST=visual & unit test Review URL: https://codereview.chromium.org/302653008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273699 0039d316-1c4b-4281-b951-d872f2087c98
* Removes --ash_disable-docked-windows flagvarkha@chromium.org2014-05-291-4/+1
| | | | | | | | | | | | | | The feature launched in Chrome OS in M-34 so no need to keep the flag anymore. BUG=227223 TEST=Visual 1. in chrome://flags verify that ash-disable-docked-windows is absent. 2. When running chrome it should be possible to dock a window at a screen edge. TEST=ash_unittests --gtest_filter=*Dock* Review URL: https://codereview.chromium.org/305813002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@273609 0039d316-1c4b-4281-b951-d872f2087c98
* Add OnDisplayMetricsChanged in DisplayObserver.mlamouri@chromium.org2014-05-222-4/+6
| | | | | | | | | | | | | | This replaces OnDisplayBoundsChanged and add a MetricsType parameter so consumers can now which metrics has changed. The current set of MetricsType include bounds, workarea and rotation. BUG=162827 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271768 Review URL: https://codereview.chromium.org/259253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@272040 0039d316-1c4b-4281-b951-d872f2087c98
* Retain the menu models in the class along with the menu runner.dmazzoni@chromium.org2014-05-212-16/+18
| | | | | | | | | | | | | | The issue was that we were posting an asynchronous accessibility event on the menu item view, and the menu item view was still around after the menu closed (just hidden, and owned by the menu runner), but the menu item view's delegate (the menu model adapter) had gone out of scope. BUG=327510 NOTRY=true Review URL: https://codereview.chromium.org/295903006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271961 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of Add OnDisplayMetricsChanged in DisplayObserver. ↵zea@chromium.org2014-05-202-6/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | (https://codereview.chromium.org/259253002/) Reason for revert: Breaks DesktopScreenX11Test.RemoveMonitorOnRight and AddMonitorToTheRight on Linux Tests TBR=mlamouri@chromium.org NOTRY=true NOTREECHECKS=true http://build.chromium.org/p/chromium.linux/buildstatus?builder=Linux%20Tests&number=11092 Original issue's description: > Add OnDisplayMetricsChanged in DisplayObserver. > > This replaces OnDisplayBoundsChanged and add a MetricsType > parameter so consumers can now which metrics has changed. The > current set of MetricsType include bounds, workarea and rotation. > > BUG=162827 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271768 Review URL: https://codereview.chromium.org/294963004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271782 0039d316-1c4b-4281-b951-d872f2087c98
* Add OnDisplayMetricsChanged in DisplayObserver.mlamouri@chromium.org2014-05-202-4/+6
| | | | | | | | | | | | This replaces OnDisplayBoundsChanged and add a MetricsType parameter so consumers can now which metrics has changed. The current set of MetricsType include bounds, workarea and rotation. BUG=162827 Review URL: https://codereview.chromium.org/259253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271768 0039d316-1c4b-4281-b951-d872f2087c98
* clang: Turn on -Wabsolute-value.thakis@chromium.org2014-05-202-8/+8
| | | | | | | | | | BUG=351479 TBR=hans@chromium.org NOTRY=true Review URL: https://codereview.chromium.org/274533004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271732 0039d316-1c4b-4281-b951-d872f2087c98
* views: Make view::Views::GetPreferredSize() const.erg@chromium.org2014-05-205-15/+15
| | | | | | | | | | | | | | | | | | | Due to button refactoring patches, we now need to ask views for their preferred sizes in const methods. Across the entire codebase, the overwhelming majority of GetPreferredSize() implementations could be const. There are only a few places where we can't, and they are usually combining the sizing and layout code. BookmarksBarView was simple enough to perform this separation. Most of the other places were solved by adding "mutable" to value caches. BUG=155363 R=jam@chromium.org, pkasting@chromium.org, scheib@chromium.org, sky@chromium.org, pkasting, sky TBR=jam, scheib Review URL: https://codereview.chromium.org/273223002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271682 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 271468 "Revert of [Refactor] Consolidate the logic for wh..."erg@chromium.org2014-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The revert broke Windows interactive_ui_tests. The world has probably changed since this was first committed. WidgetTestInteractive.CanActivateFlagIsHonored http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/29193/steps/interactive_ui_tests/logs/stdio > Revert of [Refactor] Consolidate the logic for whether a widget can be activated. (https://codereview.chromium.org/286733002/) > > Reason for revert: > This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095 > > I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable > > Original issue's description: > > [Refactor] Consolidate the logic for whether a widget can be activated. > > > > This is a first step towards giving tooltips their own WindowTreeHosts on Linux. > > > > BUG=353533 > > TEST=None > > > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597 > > Review URL: https://codereview.chromium.org/297503003 TBR=pkotwicz@chromium.org Review URL: https://codereview.chromium.org/291013003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271511 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of [Refactor] Consolidate the logic for whether a widget can be ↵pkotwicz@chromium.org2014-05-191-1/+1
| | | | | | | | | | | | | | | | | | | | | | | activated. (https://codereview.chromium.org/286733002/) Reason for revert: This CL was causing problems when the value of views::Widget::CanActivate() changes crbug.com/374095 I also need to audit the code to find out whether there are any 'non-activatable' widgets which were intended to be activatable Original issue's description: > [Refactor] Consolidate the logic for whether a widget can be activated. > > This is a first step towards giving tooltips their own WindowTreeHosts on Linux. > > BUG=353533 > TEST=None > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270597 Review URL: https://codereview.chromium.org/297503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271468 0039d316-1c4b-4281-b951-d872f2087c98
* ash: Rename some IDS_AURA entries to IDS_ASH_SHELF.tfarina@chromium.org2014-05-173-4/+4
| | | | | | | | | | | This is because the directory was aura before it was renamed to ash. BUG=248353 R=jamescook@chromium.org Review URL: https://codereview.chromium.org/282163004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271221 0039d316-1c4b-4281-b951-d872f2087c98
* Sliding animation unified.merkulova@chromium.org2014-05-151-9/+1
| | | | | | | | BUG=330746 Review URL: https://codereview.chromium.org/286623004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270687 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-19 12:37:13 +0000